claudeup 6.2.0 → 6.3.0

package/src/__tests__/scope-action.test.ts

@@ -1,7 +1,7 @@
 import { describe, expect, test } from "bun:test";
 import {
-  isInstalledInScope,
-  resolveScopeAction,
+	isInstalledInScope,
+	resolveScopeAction,
 } from "../services/plugin-manager.js";
 
 /**
@@ -19,64 +19,66 @@ import {
  */
 
 describe("isInstalledInScope", () => {
-  test("enabled with a registry version is installed", () => {
-    expect(isInstalledInScope({ enabled: true, version: "3.0.2" })).toBe(true);
-  });
+	test("enabled with a registry version is installed", () => {
+		expect(isInstalledInScope({ enabled: true, version: "3.0.2" })).toBe(true);
+	});
 
-  test("enabled with NO version is not installed — the broken state", () => {
-    // dev@magus, measured: `.claude/settings.json` had "dev@magus": true while
-    // installed_plugins.json had no entry resolving for the project path.
-    expect(isInstalledInScope({ enabled: true })).toBe(false);
-  });
+	test("enabled with NO version is not installed — the broken state", () => {
+		// dev@magus, measured: `.claude/settings.json` had "dev@magus": true while
+		// installed_plugins.json had no entry resolving for the project path.
+		expect(isInstalledInScope({ enabled: true })).toBe(false);
+	});
 
-  test("a version with the flag off is not installed either", () => {
-    expect(isInstalledInScope({ enabled: false, version: "3.0.2" })).toBe(false);
-  });
+	test("a version with the flag off is not installed either", () => {
+		expect(isInstalledInScope({ enabled: false, version: "3.0.2" })).toBe(
+			false,
+		);
+	});
 
-  test("an absent scope is not installed", () => {
-    expect(isInstalledInScope(undefined)).toBe(false);
-  });
+	test("an absent scope is not installed", () => {
+		expect(isInstalledInScope(undefined)).toBe(false);
+	});
 
-  test('"0.0.0" counts as installed — Anthropic official plugins record it', () => {
-    expect(isInstalledInScope({ enabled: true, version: "0.0.0" })).toBe(true);
-  });
+	test('"0.0.0" counts as installed — Anthropic official plugins record it', () => {
+		expect(isInstalledInScope({ enabled: true, version: "0.0.0" })).toBe(true);
+	});
 });
 
 describe("resolveScopeAction", () => {
-  test("REGRESSION: enabled but not installed resolves to install, never uninstall", () => {
-    // This is the reported bug. Before the fix this returned "uninstall".
-    expect(resolveScopeAction({ enabled: true }, "3.0.2")).toBe("install");
-  });
+	test("REGRESSION: enabled but not installed resolves to install, never uninstall", () => {
+		// This is the reported bug. Before the fix this returned "uninstall".
+		expect(resolveScopeAction({ enabled: true }, "3.0.2")).toBe("install");
+	});
 
-  test("a scope that was never enabled resolves to install", () => {
-    expect(resolveScopeAction(undefined, "3.0.2")).toBe("install");
-    expect(resolveScopeAction({ enabled: false }, "3.0.2")).toBe("install");
-  });
+	test("a scope that was never enabled resolves to install", () => {
+		expect(resolveScopeAction(undefined, "3.0.2")).toBe("install");
+		expect(resolveScopeAction({ enabled: false }, "3.0.2")).toBe("install");
+	});
 
-  test("a healthy install at the latest version resolves to uninstall (toggle off)", () => {
-    expect(resolveScopeAction({ enabled: true, version: "3.0.2" }, "3.0.2")).toBe(
-      "uninstall",
-    );
-  });
+	test("a healthy install at the latest version resolves to uninstall (toggle off)", () => {
+		expect(
+			resolveScopeAction({ enabled: true, version: "3.0.2" }, "3.0.2"),
+		).toBe("uninstall");
+	});
 
-  test("a healthy install behind the catalog resolves to update", () => {
-    expect(resolveScopeAction({ enabled: true, version: "2.9.0" }, "3.0.2")).toBe(
-      "update",
-    );
-  });
+	test("a healthy install behind the catalog resolves to update", () => {
+		expect(
+			resolveScopeAction({ enabled: true, version: "2.9.0" }, "3.0.2"),
+		).toBe("update");
+	});
 
-  test('an unknown catalog version ("0.0.0") never fabricates an update', () => {
-    // There is nothing to update *to*, so toggling must still mean uninstall.
-    expect(resolveScopeAction({ enabled: true, version: "3.0.2" }, "0.0.0")).toBe(
-      "uninstall",
-    );
-  });
+	test('an unknown catalog version ("0.0.0") never fabricates an update', () => {
+		// There is nothing to update *to*, so toggling must still mean uninstall.
+		expect(
+			resolveScopeAction({ enabled: true, version: "3.0.2" }, "0.0.0"),
+		).toBe("uninstall");
+	});
 
-  test("installed with unknown version resolves to update when a real version is published", () => {
-    // "0.0.0" installed against a real catalog version is a genuine upgrade
-    // path, not the broken state — it must not be treated as uninstall.
-    expect(resolveScopeAction({ enabled: true, version: "0.0.0" }, "3.0.2")).toBe(
-      "update",
-    );
-  });
+	test("installed with unknown version resolves to update when a real version is published", () => {
+		// "0.0.0" installed against a real catalog version is a genuine upgrade
+		// path, not the broken state — it must not be treated as uninstall.
+		expect(
+			resolveScopeAction({ enabled: true, version: "0.0.0" }, "3.0.2"),
+		).toBe("update");
+	});
 });

package/src/__tests__/scope-squares.test.tsx

@@ -2,7 +2,6 @@ import { afterEach, describe, expect, test } from "bun:test";
 import type React from "react";
 import { ScopeSquares } from "../ui/components/primitives/ScopeSquares.js";
 import {
-	SCOPE_OFF_FALLBACK,
 	SCOPE_OFF_FILL,
 	resetThemeMode,
 	setThemeMode,
@@ -19,8 +18,8 @@ import { CONTRAST_REFERENCE, theme } from "../ui/theme.js";
  *
  * An unlit segment has to recede toward the page, which is exactly what a fixed
  * colour cannot do — a pale fill that sits quietly on cream is a bright block on
- * near-black. So the fill follows the detected terminal, and these tests pin both
- * that behaviour and its fallback.
+ * near-black. So the fill follows the resolved mode, and these tests pin both
+ * that behaviour and the dark default that applies before resolution.
  */
 
 interface SpanLike {
@@ -94,10 +93,10 @@ describe("fill distinguishes lit from unlit", () => {
 		]);
 	});
 
-	test("an undetected terminal still gets a visible fill, never nothing", () => {
+	test("before resolution the fill is the dark pair", () => {
 		resetThemeMode();
 		const el = ScopeSquares({ user: false, project: false, local: false });
-		expect(new Set(fills(el))).toEqual(new Set([SCOPE_OFF_FALLBACK]));
+		expect(new Set(fills(el))).toEqual(new Set([SCOPE_OFF_FILL.dark]));
 	});
 });
 

package/src/__tests__/skill-install-files.test.ts

@@ -1,8 +1,8 @@
 import { describe, expect, test } from "bun:test";
 import path from "node:path";
 import {
-  resolveSkillFilePath,
-  selectSkillFiles,
+	resolveSkillFilePath,
+	selectSkillFiles,
 } from "../services/skills-manager.js";
 
 /**
@@ -21,108 +21,116 @@ const blob = (p: string) => ({ path: p, type: "blob" });
 const tree = (p: string) => ({ path: p, type: "tree" });
 
 describe("selectSkillFiles", () => {
-  test("returns paths relative to the skill directory", () => {
-    expect(
-      selectSkillFiles(
-        [
-          blob("skills/audit-website/SKILL.md"),
-          blob("skills/audit-website/references/OUTPUT-FORMAT.md"),
-          blob("skills/audit-website/assets/icon-small.svg"),
-        ],
-        "skills/audit-website",
-      ),
-    ).toEqual(["SKILL.md", "references/OUTPUT-FORMAT.md", "assets/icon-small.svg"]);
-  });
-
-  test("REGRESSION: a sibling with a shared name prefix is excluded", () => {
-    // Without the trailing slash on the prefix, "skills/audit" also matches
-    // "skills/audit-website/..." and dumps a second skill's files into the
-    // first one's directory.
-    expect(
-      selectSkillFiles(
-        [
-          blob("skills/audit/SKILL.md"),
-          blob("skills/audit-website/SKILL.md"),
-          blob("skills/audit-website/references/OUTPUT-FORMAT.md"),
-        ],
-        "skills/audit",
-      ),
-    ).toEqual(["SKILL.md"]);
-  });
-
-  test("tree entries are skipped — only blobs are downloadable", () => {
-    expect(
-      selectSkillFiles(
-        [
-          tree("skills/x/references"),
-          blob("skills/x/SKILL.md"),
-          blob("skills/x/references/a.md"),
-        ],
-        "skills/x",
-      ),
-    ).toEqual(["SKILL.md", "references/a.md"]);
-  });
-
-  test("files outside the skill directory are excluded", () => {
-    expect(
-      selectSkillFiles(
-        [blob("README.md"), blob("other/SKILL.md"), blob("skills/x/SKILL.md")],
-        "skills/x",
-      ),
-    ).toEqual(["SKILL.md"]);
-  });
-
-  test("a trailing slash on the skill path does not break matching", () => {
-    expect(
-      selectSkillFiles([blob("skills/x/SKILL.md")], "skills/x/"),
-    ).toEqual(["SKILL.md"]);
-  });
-
-  test("a skill directory with no files yields nothing", () => {
-    expect(selectSkillFiles([blob("skills/other/SKILL.md")], "skills/x")).toEqual([]);
-  });
+	test("returns paths relative to the skill directory", () => {
+		expect(
+			selectSkillFiles(
+				[
+					blob("skills/audit-website/SKILL.md"),
+					blob("skills/audit-website/references/OUTPUT-FORMAT.md"),
+					blob("skills/audit-website/assets/icon-small.svg"),
+				],
+				"skills/audit-website",
+			),
+		).toEqual([
+			"SKILL.md",
+			"references/OUTPUT-FORMAT.md",
+			"assets/icon-small.svg",
+		]);
+	});
+
+	test("REGRESSION: a sibling with a shared name prefix is excluded", () => {
+		// Without the trailing slash on the prefix, "skills/audit" also matches
+		// "skills/audit-website/..." and dumps a second skill's files into the
+		// first one's directory.
+		expect(
+			selectSkillFiles(
+				[
+					blob("skills/audit/SKILL.md"),
+					blob("skills/audit-website/SKILL.md"),
+					blob("skills/audit-website/references/OUTPUT-FORMAT.md"),
+				],
+				"skills/audit",
+			),
+		).toEqual(["SKILL.md"]);
+	});
+
+	test("tree entries are skipped — only blobs are downloadable", () => {
+		expect(
+			selectSkillFiles(
+				[
+					tree("skills/x/references"),
+					blob("skills/x/SKILL.md"),
+					blob("skills/x/references/a.md"),
+				],
+				"skills/x",
+			),
+		).toEqual(["SKILL.md", "references/a.md"]);
+	});
+
+	test("files outside the skill directory are excluded", () => {
+		expect(
+			selectSkillFiles(
+				[blob("README.md"), blob("other/SKILL.md"), blob("skills/x/SKILL.md")],
+				"skills/x",
+			),
+		).toEqual(["SKILL.md"]);
+	});
+
+	test("a trailing slash on the skill path does not break matching", () => {
+		expect(selectSkillFiles([blob("skills/x/SKILL.md")], "skills/x/")).toEqual([
+			"SKILL.md",
+		]);
+	});
+
+	test("a skill directory with no files yields nothing", () => {
+		expect(
+			selectSkillFiles([blob("skills/other/SKILL.md")], "skills/x"),
+		).toEqual([]);
+	});
 });
 
 describe("resolveSkillFilePath", () => {
-  const dir = path.join(path.sep, "tmp", "skills", "demo");
-
-  test("resolves a plain relative path inside the install directory", () => {
-    expect(resolveSkillFilePath(dir, "SKILL.md")).toBe(
-      path.join(dir, "SKILL.md"),
-    );
-  });
-
-  test("resolves a nested path", () => {
-    expect(resolveSkillFilePath(dir, "references/OUTPUT-FORMAT.md")).toBe(
-      path.join(dir, "references", "OUTPUT-FORMAT.md"),
-    );
-  });
-
-  test("SECURITY: rejects paths escaping via ..", () => {
-    // These paths come from a remote repository and are untrusted input to a
-    // filesystem write.
-    expect(resolveSkillFilePath(dir, "../evil.md")).toBeNull();
-    expect(resolveSkillFilePath(dir, "../../.bashrc")).toBeNull();
-    expect(resolveSkillFilePath(dir, "refs/../../../evil.md")).toBeNull();
-  });
-
-  test("SECURITY: rejects absolute paths", () => {
-    expect(resolveSkillFilePath(dir, path.join(path.sep, "etc", "passwd"))).toBeNull();
-  });
-
-  test("rejects an empty path", () => {
-    expect(resolveSkillFilePath(dir, "")).toBeNull();
-  });
-
-  test("a .. that stays inside the directory is allowed", () => {
-    expect(resolveSkillFilePath(dir, "refs/../SKILL.md")).toBe(
-      path.join(dir, "SKILL.md"),
-    );
-  });
-
-  test("REGRESSION: a sibling directory sharing the name prefix is rejected", () => {
-    // path.startsWith without a separator would accept /tmp/skills/demo-evil
-    // as being inside /tmp/skills/demo.
-    expect(resolveSkillFilePath(dir, "../demo-evil/x.md")).toBeNull();
-  });
+	const dir = path.join(path.sep, "tmp", "skills", "demo");
+
+	test("resolves a plain relative path inside the install directory", () => {
+		expect(resolveSkillFilePath(dir, "SKILL.md")).toBe(
+			path.join(dir, "SKILL.md"),
+		);
+	});
+
+	test("resolves a nested path", () => {
+		expect(resolveSkillFilePath(dir, "references/OUTPUT-FORMAT.md")).toBe(
+			path.join(dir, "references", "OUTPUT-FORMAT.md"),
+		);
+	});
+
+	test("SECURITY: rejects paths escaping via ..", () => {
+		// These paths come from a remote repository and are untrusted input to a
+		// filesystem write.
+		expect(resolveSkillFilePath(dir, "../evil.md")).toBeNull();
+		expect(resolveSkillFilePath(dir, "../../.bashrc")).toBeNull();
+		expect(resolveSkillFilePath(dir, "refs/../../../evil.md")).toBeNull();
+	});
+
+	test("SECURITY: rejects absolute paths", () => {
+		expect(
+			resolveSkillFilePath(dir, path.join(path.sep, "etc", "passwd")),
+		).toBeNull();
+	});
+
+	test("rejects an empty path", () => {
+		expect(resolveSkillFilePath(dir, "")).toBeNull();
+	});
+
+	test("a .. that stays inside the directory is allowed", () => {
+		expect(resolveSkillFilePath(dir, "refs/../SKILL.md")).toBe(
+			path.join(dir, "SKILL.md"),
+		);
+	});
+
+	test("REGRESSION: a sibling directory sharing the name prefix is rejected", () => {
+		// path.startsWith without a separator would accept /tmp/skills/demo-evil
+		// as being inside /tmp/skills/demo.
+		expect(resolveSkillFilePath(dir, "../demo-evil/x.md")).toBeNull();
+	});
 });

package/src/__tests__/symlink-manager.test.ts

@@ -1,5 +1,5 @@
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
-import { mkdtemp, rm, lstat, readlink } from "node:fs/promises";
+import { lstat, mkdtemp, readlink, rm } from "node:fs/promises";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import fs from "fs-extra";
@@ -17,7 +17,8 @@ async function materialize(
 ) {
 	const dir = profileDir(name, project);
 	await fs.ensureDir(dir);
-	if (files.settings) await fs.writeJson(join(dir, "settings.json"), files.settings);
+	if (files.settings)
+		await fs.writeJson(join(dir, "settings.json"), files.settings);
 	if (files.mcp) await fs.writeJson(join(dir, "mcp.json"), files.mcp);
 	if (files.skills) await fs.ensureDir(join(dir, "skills"));
 }
@@ -40,12 +41,20 @@ describe("symlink-manager", () => {
 		await activateProfile("frontend", project);
 
 		// settings.json is a symlink into the profile dir
-		expect((await lstat(join(project, ".claude", "settings.json"))).isSymbolicLink()).toBe(true);
-		expect((await lstat(join(project, ".mcp.json"))).isSymbolicLink()).toBe(true);
-		expect((await lstat(join(project, ".claude", "skills"))).isSymbolicLink()).toBe(true);
+		expect(
+			(await lstat(join(project, ".claude", "settings.json"))).isSymbolicLink(),
+		).toBe(true);
+		expect((await lstat(join(project, ".mcp.json"))).isSymbolicLink()).toBe(
+			true,
+		);
+		expect(
+			(await lstat(join(project, ".claude", "skills"))).isSymbolicLink(),
+		).toBe(true);
 
 		// reading through the link returns the profile's content
-		const settings = await fs.readJson(join(project, ".claude", "settings.json"));
+		const settings = await fs.readJson(
+			join(project, ".claude", "settings.json"),
+		);
 		expect(settings.enabledPlugins["dev@magus"]).toBe(true);
 	});
 
@@ -54,8 +63,12 @@ describe("symlink-manager", () => {
 		await activateProfile("frontend", project);
 		await fs.writeJson(join(project, ".claude", "settings.json"), { a: 2 });
 		// The real file inside the profile dir was updated (symlink preserved).
-		expect((await lstat(join(project, ".claude", "settings.json"))).isSymbolicLink()).toBe(true);
-		expect((await fs.readJson(profileDir("frontend", project) + "/settings.json")).a).toBe(2);
+		expect(
+			(await lstat(join(project, ".claude", "settings.json"))).isSymbolicLink(),
+		).toBe(true);
+		expect(
+			(await fs.readJson(`${profileDir("frontend", project)}/settings.json`)).a,
+		).toBe(2);
 	});
 
 	test("switching repoints links and activeProfile tracks it", async () => {
@@ -64,11 +77,15 @@ describe("symlink-manager", () => {
 
 		await activateProfile("frontend", project);
 		expect(await activeProfile(project)).toBe("frontend");
-		expect((await fs.readJson(join(project, ".claude", "settings.json"))).which).toBe("frontend");
+		expect(
+			(await fs.readJson(join(project, ".claude", "settings.json"))).which,
+		).toBe("frontend");
 
 		await activateProfile("backend", project);
 		expect(await activeProfile(project)).toBe("backend");
-		expect((await fs.readJson(join(project, ".claude", "settings.json"))).which).toBe("backend");
+		expect(
+			(await fs.readJson(join(project, ".claude", "settings.json"))).which,
+		).toBe("backend");
 	});
 
 	test("uses relative (not absolute) symlinks", async () => {