claudeup 4.35.1 → 4.36.0

package/src/ui/adapters/settingsAdapter.ts

@@ -1,29 +1,30 @@
 import {
-  SETTINGS_CATALOG,
-  type SettingCategory,
-  type SettingDefinition,
+	SETTINGS_CATALOG,
+	type SettingCategory,
+	type SettingDefinition,
 } from "../../data/settings-catalog.js";
 import type { ScopedSettingValues } from "../../services/settings-manager.js";
+import { theme, type UiColor } from "../theme.js";
 
 // ─── Item types ────────────────────────────────────────────────────────────────
 
 export interface SettingsCategoryItem {
-  id: string;
-  kind: "category";
-  label: string;
-  category: SettingCategory;
-  isDefault: true;
+	id: string;
+	kind: "category";
+	label: string;
+	category: SettingCategory;
+	isDefault: true;
 }
 
 export interface SettingsSettingItem {
-  id: string;
-  kind: "setting";
-  label: string;
-  category: SettingCategory;
-  setting: SettingDefinition;
-  scopedValues: ScopedSettingValues;
-  effectiveValue: string | undefined;
-  isDefault: boolean;
+	id: string;
+	kind: "setting";
+	label: string;
+	category: SettingCategory;
+	setting: SettingDefinition;
+	scopedValues: ScopedSettingValues;
+	effectiveValue: string | undefined;
+	isDefault: boolean;
 }
 
 export type SettingsBrowserItem = SettingsCategoryItem | SettingsSettingItem;
@@ -31,92 +32,94 @@ export type SettingsBrowserItem = SettingsCategoryItem | SettingsSettingItem;
 // ─── Constants ─────────────────────────────────────────────────────────────────
 
 export const CATEGORY_LABELS: Record<SettingCategory, string> = {
-  recommended: "Recommended",
-  agents: "Agents & Teams",
-  models: "Models & Thinking",
-  workflow: "Workflow",
-  terminal: "Terminal & UI",
-  performance: "Performance",
-  advanced: "Advanced",
+	recommended: "Recommended",
+	agents: "Agents & Teams",
+	models: "Models & Thinking",
+	workflow: "Workflow",
+	terminal: "Terminal & UI",
+	performance: "Performance",
+	advanced: "Advanced",
 };
 
 export const CATEGORY_ORDER: SettingCategory[] = [
-  "recommended",
-  "agents",
-  "models",
-  "workflow",
-  "terminal",
-  "performance",
-  "advanced",
+	"recommended",
+	"agents",
+	"models",
+	"workflow",
+	"terminal",
+	"performance",
+	"advanced",
 ];
 
-export const CATEGORY_BG: Record<SettingCategory, string> = {
-  recommended: "#2e7d32",
-  agents: "#00838f",
-  models: "#4527a0",
-  workflow: "#1565c0",
-  terminal: "#4e342e",
-  performance: "#6a1b9a",
-  advanced: "#e65100",
+export const CATEGORY_BG: Record<SettingCategory, UiColor> = {
+	recommended: theme.colors.success,
+	agents: theme.colors.info,
+	models: theme.colors.accent,
+	workflow: theme.colors.link,
+	terminal: theme.colors.warning,
+	performance: theme.colors.accent,
+	advanced: theme.colors.warning,
 };
 
-export const CATEGORY_COLOR: Record<SettingCategory, string> = {
-  recommended: "green",
-  agents: "cyan",
-  models: "cyan",
-  workflow: "blue",
-  terminal: "blue",
-  performance: "magentaBright",
-  advanced: "yellow",
+export const CATEGORY_COLOR: Record<SettingCategory, UiColor> = {
+	recommended: theme.colors.success,
+	agents: theme.colors.info,
+	models: theme.colors.info,
+	workflow: theme.colors.link,
+	terminal: theme.colors.link,
+	performance: "magentaBright",
+	advanced: theme.colors.warning,
 };
 
 export const CATEGORY_DESCRIPTIONS: Record<SettingCategory, string> = {
-  recommended: "Most impactful settings every user should know.",
-  agents: "Agent teams, task lists, and subagent configuration.",
-  models: "Model selection, extended thinking, and effort.",
-  workflow: "Git, plans, permissions, output style, and languages.",
-  terminal: "Shell, spinners, progress bars, voice, and UI behavior.",
-  performance: "Compaction, token limits, timeouts, and caching.",
-  advanced: "Telemetry, updates, debugging, and internal controls.",
+	recommended: "Most impactful settings every user should know.",
+	agents: "Agent teams, task lists, and subagent configuration.",
+	models: "Model selection, extended thinking, and effort.",
+	workflow: "Git, plans, permissions, output style, and languages.",
+	terminal: "Shell, spinners, progress bars, voice, and UI behavior.",
+	performance: "Compaction, token limits, timeouts, and caching.",
+	advanced: "Telemetry, updates, debugging, and internal controls.",
 };
 
 // ─── Helpers ───────────────────────────────────────────────────────────────────
 
 /** Get the effective value (project overrides user) */
 export function getEffectiveValue(
-  scoped: ScopedSettingValues,
+	scoped: ScopedSettingValues,
 ): string | undefined {
-  return scoped.project !== undefined ? scoped.project : scoped.user;
+	return scoped.project !== undefined ? scoped.project : scoped.user;
 }
 
 export function formatValue(
-  setting: SettingDefinition,
-  value: string | undefined,
+	setting: SettingDefinition,
+	value: string | undefined,
 ): string {
-  if (value === undefined || value === "") {
-    if (setting.type === "boolean" && setting.defaultValue !== undefined) {
-      return setting.defaultValue === "true" ? "on" : "off";
-    }
-    if (setting.type === "select" && setting.defaultValue !== undefined) {
-      const opt = setting.options?.find((o) => o.value === setting.defaultValue);
-      return opt ? opt.label : setting.defaultValue;
-    }
-    return "—";
-  }
-
-  if (setting.type === "boolean") {
-    return value === "true" || value === "1" ? "on" : "off";
-  }
-
-  if (setting.type === "select" && setting.options) {
-    const opt = setting.options.find((o) => o.value === value);
-    return opt ? opt.label : value;
-  }
-
-  if (value.length > 12) {
-    return value.slice(0, 12) + "…";
-  }
-  return value;
+	if (value === undefined || value === "") {
+		if (setting.type === "boolean" && setting.defaultValue !== undefined) {
+			return setting.defaultValue === "true" ? "on" : "off";
+		}
+		if (setting.type === "select" && setting.defaultValue !== undefined) {
+			const opt = setting.options?.find(
+				(o) => o.value === setting.defaultValue,
+			);
+			return opt ? opt.label : setting.defaultValue;
+		}
+		return "—";
+	}
+
+	if (setting.type === "boolean") {
+		return value === "true" || value === "1" ? "on" : "off";
+	}
+
+	if (setting.type === "select" && setting.options) {
+		const opt = setting.options.find((o) => o.value === value);
+		return opt ? opt.label : value;
+	}
+
+	if (value.length > 12) {
+		return value.slice(0, 12) + "…";
+	}
+	return value;
 }
 
 // ─── Adapter ───────────────────────────────────────────────────────────────────
@@ -126,40 +129,40 @@ export function formatValue(
  * Extracted from SettingsScreen so it can be tested independently.
  */
 export function buildSettingsBrowserItems(
-  values: Map<string, ScopedSettingValues>,
+	values: Map<string, ScopedSettingValues>,
 ): SettingsBrowserItem[] {
-  const items: SettingsBrowserItem[] = [];
-
-  for (const category of CATEGORY_ORDER) {
-    items.push({
-      id: `cat:${category}`,
-      kind: "category",
-      label: CATEGORY_LABELS[category],
-      category,
-      isDefault: true,
-    });
-
-    const categorySettings = SETTINGS_CATALOG.filter(
-      (s) => s.category === category,
-    );
-    for (const setting of categorySettings) {
-      const scoped = values.get(setting.id) || {
-        user: undefined,
-        project: undefined,
-      };
-      const effective = getEffectiveValue(scoped);
-      items.push({
-        id: `setting:${setting.id}`,
-        kind: "setting",
-        label: setting.name,
-        category,
-        setting,
-        scopedValues: scoped,
-        effectiveValue: effective,
-        isDefault: effective === undefined || effective === "",
-      });
-    }
-  }
-
-  return items;
+	const items: SettingsBrowserItem[] = [];
+
+	for (const category of CATEGORY_ORDER) {
+		items.push({
+			id: `cat:${category}`,
+			kind: "category",
+			label: CATEGORY_LABELS[category],
+			category,
+			isDefault: true,
+		});
+
+		const categorySettings = SETTINGS_CATALOG.filter(
+			(s) => s.category === category,
+		);
+		for (const setting of categorySettings) {
+			const scoped = values.get(setting.id) || {
+				user: undefined,
+				project: undefined,
+			};
+			const effective = getEffectiveValue(scoped);
+			items.push({
+				id: `setting:${setting.id}`,
+				kind: "setting",
+				label: setting.name,
+				category,
+				setting,
+				scopedValues: scoped,
+				effectiveValue: effective,
+				isDefault: effective === undefined || effective === "",
+			});
+		}
+	}
+
+	return items;
 }