claudeup 4.30.0 → 4.32.0

package/src/ui/screens/PluginsScreen.tsx

@@ -7,6 +7,7 @@ import { ScrollableList } from "../components/ScrollableList.js";
 import { EmptyFilterState } from "../components/EmptyFilterState.js";
 import { fuzzyFilter } from "../../utils/fuzzy-search.js";
 import { getAllMarketplaces } from "../../data/marketplaces.js";
+import { clearContentDriftCache } from "../../services/content-drift.js";
 import {
 	diffVersions,
 	loadSeenVersions,
@@ -30,6 +31,7 @@ import {
 import { saveProfile } from "../../services/profiles.js";
 import {
 	installPlugin as cliInstallPlugin,
+	repairPlugin as cliRepairPlugin,
 	uninstallPlugin as cliUninstallPlugin,
 	updatePlugin as cliUpdatePlugin,
 	type PluginScope,
@@ -87,7 +89,8 @@ export function PluginsScreen() {
 			for (const p of pluginData) {
 				if (p.installedVersion) current[p.id] = p.installedVersion;
 			}
-			const previous = await loadSeenVersions();
+			const projectPath = state.projectPath || process.cwd();
+			const previous = await loadSeenVersions(projectPath);
 			for (const change of diffVersions(previous, current)) {
 				const target = pluginData.find((p) => p.id === change.pluginId);
 				if (!target) continue;
@@ -97,8 +100,10 @@ export function PluginsScreen() {
 					target.recentlyInstalled = true;
 				}
 			}
-			// Record now so the same change is not reported on the next launch.
-			void saveSeenVersions(current);
+			// Await the write. Fire-and-forget raced the next fetchData() — a
+			// refresh or a post-action refetch could load the baseline before the
+			// previous save landed and re-report the same change.
+			await saveSeenVersions(projectPath, current);
 
 			dispatch({
 				type: "PLUGINS_DATA_SUCCESS",
@@ -352,6 +357,9 @@ export function PluginsScreen() {
 				progress.show(`${p.name}`, p.current, p.total);
 			});
 			clearMarketplaceCache();
+			// Drift is answered by diffing against the clone's HEAD, so a refresh
+			// that moves HEAD invalidates every cached answer.
+			clearContentDriftCache();
 			progress.hide();
 
 			let message =
@@ -705,17 +713,29 @@ export function PluginsScreen() {
 
 	const handleUpdate = async () => {
 		const item = selectableItems[pluginsState.selectedIndex];
-		if (!item || item.kind !== "plugin" || !item.plugin.hasUpdate) return;
+		if (!item || item.kind !== "plugin") return;
+		if (!item.plugin.hasUpdate && !item.plugin.contentStale) return;
 
 		const plugin = item.plugin;
 		const scope: PluginScope =
 			pluginsState.scope === "global" ? "user" : "project";
 
+		// No version bump to install over — the files changed underneath an
+		// unchanged version, and `plugin install` no-ops on "already installed".
+		// Only uninstall+install re-copies. See claude-cli.ts repairPlugin.
+		const repairing = !plugin.hasUpdate && plugin.contentStale;
+
 		modal.loading(
-			`Updating ${plugin.name}…\nclaude plugin install ${plugin.id} --scope ${scope}`,
+			repairing
+				? `Repairing ${plugin.name}…\nclaude plugin uninstall ${plugin.id} --scope ${scope} && claude plugin install ${plugin.id} --scope ${scope}`
+				: `Updating ${plugin.name}…\nclaude plugin install ${plugin.id} --scope ${scope}`,
 		);
 		try {
-			await cliUpdatePlugin(plugin.id, scope);
+			if (repairing) {
+				await cliRepairPlugin(plugin.id, scope, state.projectPath);
+			} else {
+				await cliUpdatePlugin(plugin.id, scope);
+			}
 			if (plugin.version) {
 				await saveVersionForScope(plugin.id, plugin.version, scope);
 			}
@@ -731,7 +751,11 @@ export function PluginsScreen() {
 	const handleUpdateAll = async () => {
 		if (pluginsState.plugins.status !== "success") return;
 
-		const updatable = pluginsState.plugins.data.filter((p) => p.hasUpdate);
+		// Content-stale plugins are included: they need repairing, and excluding
+		// them meant "update all" left the machine with silently outdated files.
+		const updatable = pluginsState.plugins.data.filter(
+			(p) => p.hasUpdate || p.contentStale,
+		);
 		if (updatable.length === 0) return;
 
 		const scope: PluginScope =
@@ -741,10 +765,15 @@ export function PluginsScreen() {
 		try {
 			for (let i = 0; i < updatable.length; i++) {
 				const plugin = updatable[i];
+				const repairing = !plugin.hasUpdate && plugin.contentStale;
 				modal.loading(
-					`Updating ${plugin.name} (${i + 1}/${updatable.length})…\nclaude plugin install ${plugin.id} --scope ${scope}`,
+					`${repairing ? "Repairing" : "Updating"} ${plugin.name} (${i + 1}/${updatable.length})…\nclaude plugin install ${plugin.id} --scope ${scope}`,
 				);
-				await cliUpdatePlugin(plugin.id, scope);
+				if (repairing) {
+					await cliRepairPlugin(plugin.id, scope, state.projectPath);
+				} else {
+					await cliUpdatePlugin(plugin.id, scope);
+				}
 				if (plugin.version) {
 					await saveVersionForScope(plugin.id, plugin.version, scope);
 				}
@@ -872,19 +901,62 @@ export function PluginsScreen() {
 		if (!item || item.kind !== "plugin" || !item.plugin.isOrphaned) return;
 
 		const plugin = item.plugin;
+
+		// A plugin that moved marketplace is not deprecated — it is still
+		// published under a new namespace. Offering only "remove" silently drops
+		// something the user still wants (the magus → magus-marketing split left
+		// seo, instantly, video-editing and image-generate in this state).
+		let migrateTo: string | undefined;
+		if (plugin.movedTo) {
+			const choice = await modal.select(
+				"Plugin moved",
+				`${plugin.name} is no longer published by "${plugin.marketplace}", but "${plugin.movedTo}" still publishes it.`,
+				[
+					{
+						label: `Migrate to ${plugin.name}@${plugin.movedTo}`,
+						value: "migrate",
+					},
+					{ label: "Remove it entirely", value: "remove" },
+				],
+			);
+			if (choice === null) return;
+			if (choice === "migrate") migrateTo = plugin.movedTo;
+		}
+
 		try {
 			// Remove from all scopes — try all to clean up stale references
 			const scopes: PluginScope[] = ["user", "project", "local"];
+			const removedFrom: PluginScope[] = [];
 			for (const scope of scopes) {
 				try {
 					modal.loading(
 						`Removing ${plugin.name} from ${scope}…\nclaude plugin uninstall ${plugin.id} --scope ${scope}`,
 					);
+					const wasInstalled =
+						scope === "user"
+							? plugin.userScope?.enabled
+							: scope === "project"
+								? plugin.projectScope?.enabled
+								: plugin.localScope?.enabled;
 					await cliUninstallPlugin(plugin.id, scope, state.projectPath);
+					if (wasInstalled) removedFrom.push(scope);
 				} catch {
 					// Ignore errors for scopes where it doesn't exist
 				}
 			}
+
+			if (migrateTo) {
+				// Reinstall under the new namespace in every scope it occupied, so
+				// the migration does not quietly change where the plugin is enabled.
+				const newId = `${plugin.name}@${migrateTo}`;
+				for (const scope of removedFrom.length > 0 ? removedFrom : ["project" as PluginScope]) {
+					modal.loading(
+						`Installing ${newId} (${scope})…\nclaude plugin install ${newId} --scope ${scope}`,
+					);
+					await cliInstallPlugin(newId, scope);
+				}
+			}
+
 			modal.hideModal();
 			fetchData();
 		} catch (error) {
@@ -986,7 +1058,7 @@ export function PluginsScreen() {
 	const installedCount = plugins.filter((p) => p.enabled).length;
 	const updateCount = plugins.filter(
 		(p) =>
-			p.hasUpdate &&
+			(p.hasUpdate || p.contentStale) &&
 			(p.userScope?.enabled ||
 				p.projectScope?.enabled ||
 				p.localScope?.enabled),