claudeup 4.18.0 → 4.19.0

package/src/services/plugin-setup.ts

@@ -295,6 +295,65 @@ export function extractGoBinaryName(pkg: string): string {
 	return withoutVersion.split("/").pop() || pkg;
 }
 
+/**
+ * Extract the pinned version from a Go module path, or null when unpinned.
+ * e.g., "github.com/MadAppGang/tmux-mcp@v1.6.2" → "v1.6.2"
+ *       "github.com/MadAppGang/tmux-mcp@latest" → null (a moving target)
+ *       "github.com/user/tool"                  → null
+ */
+export function extractGoVersion(pkg: string): string | null {
+	const at = pkg.lastIndexOf("@");
+	if (at === -1) return null;
+	const version = pkg.slice(at + 1);
+	if (version === "" || version === "latest") return null;
+	return version;
+}
+
+/** Normalize a semver-ish string for comparison: trim and drop a leading "v". */
+function normalizeVersion(v: string): string {
+	return v.trim().replace(/^v/, "");
+}
+
+/**
+ * Read an installed binary's version via `<binary> --version`, normalized, or
+ * null if it produced no usable version string. Used to tell whether a pinned Go
+ * dependency is already at the right version.
+ */
+async function getInstalledBinaryVersion(
+	binaryName: string,
+): Promise<string | null> {
+	const { ok, stdout } = await run(binaryName, ["--version"], 10000);
+	if (!ok || !stdout) return null;
+	const match = stdout.split("\n")[0].match(/v?\d+\.\d+\.\d+[^\s]*/);
+	return match ? normalizeVersion(match[0]) : null;
+}
+
+/**
+ * Decide whether a Go dependency needs (re)installing. This is what makes a
+ * plugin *update* actually update its binary: without a version check an
+ * already-present binary is skipped forever, so a bumped plugin never pulls the
+ * new binary.
+ *
+ *  - binary absent                                    → yes
+ *  - pinned version, installed reports the same one   → no
+ *  - pinned version, installed reports a different one → yes
+ *  - pinned version, installed version can't be read  → yes (can't confirm the
+ *    pin, so reinstall to be safe)
+ *  - unpinned (@latest) and present                   → no (a moving target
+ *    can't be verified without a network round-trip)
+ */
+export async function goDepNeedsInstall(pkg: string): Promise<boolean> {
+	const binaryName = extractGoBinaryName(pkg);
+	if (!(await isBinaryAvailable(binaryName))) return true;
+
+	const pinned = extractGoVersion(pkg);
+	if (!pinned) return false;
+
+	const installed = await getInstalledBinaryVersion(binaryName);
+	if (installed === null) return true;
+	return normalizeVersion(pinned) !== installed;
+}
+
 /**
  * Install Go packages via `go install`
  */
@@ -311,8 +370,7 @@ async function installGoPackages(
 	}
 
 	for (const pkg of packages) {
-		const binaryName = extractGoBinaryName(pkg);
-		if (await isBinaryAvailable(binaryName)) {
+		if (!(await goDepNeedsInstall(pkg))) {
 			result.skipped.push(`go:${pkg}`);
 			continue;
 		}
@@ -515,8 +573,7 @@ export async function checkMissingDeps(
 	if (setup.go?.length) {
 		const missingGo: string[] = [];
 		for (const pkg of setup.go) {
-			const bin = extractGoBinaryName(pkg);
-			if (!(await isBinaryAvailable(bin))) {
+			if (await goDepNeedsInstall(pkg)) {
 				missingGo.push(pkg);
 			}
 		}

package/src/ui/App.js

@@ -53,7 +53,7 @@ function Router() {
 }
 /**
  * GlobalKeyHandler Component
- * Handles global keyboard shortcuts (1-5, Tab, Escape, q, ?, Shift+D)
+ * Handles global keyboard shortcuts (1-8, Tab, Escape, q, Ctrl+C, ?, Shift+D)
  * Does not render anything (returns null)
  */
 function GlobalKeyHandler({ onDebugToggle, onExit, }) {
@@ -139,18 +139,26 @@ function GlobalKeyHandler({ onDebugToggle, onExit, }) {
                 }
             }
         }
-        // Escape/q to go back or exit
-        if (key.escape || input === "q") {
+        // q or Ctrl+C quits from anywhere — no need to bounce to home first.
+        if (input === "q" || (key.ctrl && input === "c")) {
+            onExit();
+            return;
+        }
+        // Escape goes back: registry → mcp, any other tab → plugins home,
+        // already-home → exit. But when a screen has a focused sub-view open
+        // (e.g. the Alias flag-detail editor), that sub-view owns Escape and
+        // backs out to itself — don't let the global handler jump to home.
+        // Scoped to the Escape branch ONLY so q/Ctrl+C still quit from anywhere.
+        if (key.escape) {
+            if (state.detailActive)
+                return;
             if (state.currentRoute.screen === "plugins") {
-                // On home screen, exit immediately
                 onExit();
             }
             else if (state.currentRoute.screen === "mcp-registry") {
-                // Go back to MCP from registry
                 navigateToScreen("mcp");
             }
             else {
-                // Go back to plugins (home)
                 navigateToScreen("plugins");
             }
         }
@@ -159,7 +167,8 @@ function GlobalKeyHandler({ onDebugToggle, onExit, }) {
             modal.message("claudeup Help", `Navigation
   ↑/↓ or j/k    Move selection
   Enter         Select / Toggle
-  Escape or q   Back / Quit
+  Escape        Back (to home)
+  q / Ctrl+C    Quit (from anywhere)
   ?             This help
 
 Quick Navigation

package/src/ui/App.tsx

@@ -89,7 +89,7 @@ function Router() {
 
 /**
  * GlobalKeyHandler Component
- * Handles global keyboard shortcuts (1-5, Tab, Escape, q, ?, Shift+D)
+ * Handles global keyboard shortcuts (1-8, Tab, Escape, q, Ctrl+C, ?, Shift+D)
  * Does not render anything (returns null)
  */
 function GlobalKeyHandler({
@@ -180,16 +180,24 @@ function GlobalKeyHandler({
 			}
 		}
 
-		// Escape/q to go back or exit
-		if (key.escape || input === "q") {
+		// q or Ctrl+C quits from anywhere — no need to bounce to home first.
+		if (input === "q" || (key.ctrl && input === "c")) {
+			onExit();
+			return;
+		}
+
+		// Escape goes back: registry → mcp, any other tab → plugins home,
+		// already-home → exit. But when a screen has a focused sub-view open
+		// (e.g. the Alias flag-detail editor), that sub-view owns Escape and
+		// backs out to itself — don't let the global handler jump to home.
+		// Scoped to the Escape branch ONLY so q/Ctrl+C still quit from anywhere.
+		if (key.escape) {
+			if (state.detailActive) return;
 			if (state.currentRoute.screen === "plugins") {
-				// On home screen, exit immediately
 				onExit();
 			} else if (state.currentRoute.screen === "mcp-registry") {
-				// Go back to MCP from registry
 				navigateToScreen("mcp");
 			} else {
-				// Go back to plugins (home)
 				navigateToScreen("plugins");
 			}
 		}
@@ -201,7 +209,8 @@ function GlobalKeyHandler({
 				`Navigation
   ↑/↓ or j/k    Move selection
   Enter         Select / Toggle
-  Escape or q   Back / Quit
+  Escape        Back (to home)
+  q / Ctrl+C    Quit (from anywhere)
   ?             This help
 
 Quick Navigation

package/src/ui/components/modals/ConfirmModal.js

@@ -9,6 +9,6 @@ export function ConfirmModal({ title, message, onConfirm, onCancel, }) {
             onCancel();
         }
     });
-    return (_jsxs("box", { flexDirection: "column", border: true, borderStyle: "rounded", borderColor: "#525252", backgroundColor: "#1C1C1E", paddingLeft: 3, paddingRight: 3, paddingTop: 1, paddingBottom: 1, width: 60, children: [_jsx("box", { marginBottom: 1, children: _jsx("text", { fg: "#EDEDED", children: _jsx("strong", { children: title }) }) }), _jsx("box", { marginBottom: 1, children: _jsx("text", { fg: "#A1A1AA", children: message }) }), _jsxs("box", { marginTop: 1, children: [_jsx("text", { fg: "#71717A", children: "Press " }), _jsx("text", { fg: "#EDEDED", children: "Y" }), _jsx("text", { fg: "#71717A", children: " to confirm \u2022 " }), _jsx("text", { fg: "#EDEDED", children: "N" }), _jsx("text", { fg: "#71717A", children: " to cancel" })] })] }));
+    return (_jsxs("box", { flexDirection: "column", border: true, borderStyle: "rounded", borderColor: "#525252", backgroundColor: "#1C1C1E", paddingLeft: 3, paddingRight: 3, paddingTop: 1, paddingBottom: 1, width: 60, children: [_jsx("box", { marginBottom: 1, children: _jsx("text", { fg: "#EDEDED", children: _jsx("strong", { children: title }) }) }), _jsx("box", { marginBottom: 1, children: _jsx("text", { fg: "#A1A1AA", children: message }) }), _jsxs("box", { marginTop: 1, flexDirection: "row", children: [_jsx("text", { fg: "#71717A", children: "Press " }), _jsx("text", { fg: "#EDEDED", children: "Y" }), _jsx("text", { fg: "#71717A", children: " to confirm \u2022 " }), _jsx("text", { fg: "#EDEDED", children: "N" }), _jsx("text", { fg: "#71717A", children: " to cancel" })] })] }));
 }
 export default ConfirmModal;

package/src/ui/components/modals/ConfirmModal.tsx

@@ -47,7 +47,7 @@ export function ConfirmModal({
 			<box marginBottom={1}>
 				<text fg="#A1A1AA">{message}</text>
 			</box>
-			<box marginTop={1}>
+			<box marginTop={1} flexDirection="row">
 				<text fg="#71717A">Press </text>
 				<text fg="#EDEDED">Y</text>
 				<text fg="#71717A"> to confirm • </text>