claude-threads 1.9.0 → 1.9.2

package/CHANGELOG.md

@@ -5,6 +5,21 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.9.2] - 2026-04-24
+
+### Fixed
+- **Unreadable `[object ErrorEvent]` in WebSocket error logs.** Recent Node / undici deliver a browser-style `ErrorEvent` (not a plain `Error`) to `ws.onerror`, and `` `${event}` `` stringifies that wrapper to `[object ErrorEvent]` — the original failure cause was being dropped. New `formatWebSocketError(err)` helper in `src/platform/utils.ts` pulls the first usable signal (`.message` → `.error.message` → `.type (code: .code)` → `String(err)`), wired into all five WebSocket error sites across Slack + Mattermost main clients, both MCP permission-server clients, and the UI re-emit. The Slack client's rejection and re-emitted `Error` now carry the underlying message too, instead of the opaque `"Socket Mode WebSocket error"`. (#347)
+- **Worktree creation under a parent branch gave a generic "Failed to create worktree" message.** When a flat branch `test` already exists and the user requests `test/add-unit-coverage`, git refuses with `fatal: 'refs/heads/test' exists; cannot create 'refs/heads/test/add-unit-coverage'`. `parseWorktreeError` now matches this specific shape and reports `Branch <parent> already exists and blocks <nested>` with the suggestion to pick a non-nested name or delete the parent branch first. (#347)
+
+## [1.9.1] - 2026-04-24
+
+### Internals
+- **Unified `Executor<TState>` contract.** New interface in `src/operations/executors/types.ts` formalizes what `MessageManager` actually relies on: `getState` / `reset` required, `handleReaction` / `serialize` optional. `BaseExecutor<T>` implements it. A new `contract.test.ts` iterates every executor and asserts the shape — catches drift when someone adds an executor without the required members. (#346)
+- **Uniform `handleReaction` signature across all seven reaction executors** — `(postId, emoji, user, action, ctx) => Promise<boolean>`. Previously `TaskList`, `Subagent`, and `WorktreePrompt` had slightly different shapes. `MessageManager.handleReaction` now dispatches via a `reactionDispatchList()` table instead of an if/else chain. (#346)
+- **`MessageManager.serialize()` aggregates executor state** for `SessionManager.persistSession`. The writer no longer reaches into individual executors via named getters (`getTaskListState()`, `getPendingContextPrompt()`). Legacy getters kept as `@deprecated` shims — they still have non-persistence consumers. (#346)
+- **Byte-identical `sessions.json` guarantee.** New snapshot tests in `manager.test.ts` pin the full payload's field set and run the new and legacy (`CLAUDE_THREADS_SERIALIZE_V2=0`) paths through a parity assertion. No persisted-schema change on disk. (#346)
+- **Rollback hatch:** `CLAUDE_THREADS_SERIALIZE_V2=0` falls back to the pre-refactor per-getter writer for one release. Removed in the next minor. (#346)
+
 ## [1.9.0] - 2026-04-24
 
 ### Added

package/dist/index.js

@@ -51565,6 +51565,23 @@ function truncateAtWord(str2, maxLength) {
 function escapeRegExp(string) {
   return string.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
 }
+function formatWebSocketError(err) {
+  if (err instanceof Error)
+    return err.message;
+  if (err && typeof err === "object") {
+    const e = err;
+    if (typeof e.message === "string" && e.message)
+      return e.message;
+    if (e.error instanceof Error)
+      return e.error.message;
+    if (typeof e.error === "string" && e.error)
+      return e.error;
+    if (typeof e.type === "string" && e.type) {
+      return typeof e.code === "string" || typeof e.code === "number" ? `${e.type} (code: ${e.code})` : e.type;
+    }
+  }
+  return String(err);
+}
 function getPlatformIcon(platformType) {
   switch (platformType) {
     case "slack":
@@ -52110,9 +52127,10 @@ class MattermostClient extends BasePlatformClient {
         this.onConnectionClosed();
       };
       this.ws.onerror = (event) => {
-        wsLogger.warn(`WebSocket error: ${event}`);
-        this.emit("error", event);
-        reject(event);
+        const msg = formatWebSocketError(event);
+        wsLogger.warn(`WebSocket error: ${msg}`);
+        this.emit("error", new Error(`WebSocket error: ${msg}`));
+        reject(new Error(`WebSocket error: ${msg}`));
       };
     });
   }
@@ -52540,11 +52558,12 @@ class SlackClient extends BasePlatformClient {
       };
       this.ws.onerror = (event) => {
         clearTimeout(connectionTimeout);
-        wsLogger.warn(`Socket Mode: WebSocket error: ${event}`);
+        const msg = formatWebSocketError(event);
+        wsLogger.warn(`Socket Mode: WebSocket error: ${msg}`);
         if (!this.isIntentionalDisconnect && !this.isReconnecting) {
-          this.emit("error", new Error("Socket Mode WebSocket error"));
+          this.emit("error", new Error(`Socket Mode WebSocket error: ${msg}`));
         }
-        doReject(new Error("Socket Mode WebSocket error"));
+        doReject(new Error(`Socket Mode WebSocket error: ${msg}`));
       };
     });
   }
@@ -53160,7 +53179,7 @@ class MattermostPermissionApi {
         }
       };
       ws.onerror = (event) => {
-        mcpLogger.error(`WebSocket error: ${event}`);
+        mcpLogger.error(`WebSocket error: ${formatWebSocketError(event)}`);
         if (!resolved) {
           resolved = true;
           clearTimeout(timeout);
@@ -53356,7 +53375,7 @@ class SlackPermissionApi {
           }
         };
         ws.onerror = (event) => {
-          mcpLogger.error(`Socket Mode WebSocket error: ${event}`);
+          mcpLogger.error(`Socket Mode WebSocket error: ${formatWebSocketError(event)}`);
           if (!resolved) {
             resolved = true;
             clearTimeout(timeout);
@@ -58611,7 +58630,15 @@ class TaskListExecutor extends BaseExecutor {
       await ctx.platform.updatePost(this.state.tasksPostId, displayContent);
     } catch {}
   }
-  async handleReaction(postId, emoji, action, ctx) {
+  serialize() {
+    return {
+      postId: this.state.tasksPostId,
+      content: this.state.lastTasksContent,
+      isMinimized: this.state.tasksMinimized,
+      isCompleted: this.state.tasksCompleted
+    };
+  }
+  async handleReaction(postId, emoji, _user, action, ctx) {
     ctx.logger.debug(`TaskListExecutor.handleReaction: postId=${postId.substring(0, 8)}, emoji=${emoji}, action=${action}, tasksPostId=${this.state.tasksPostId?.substring(0, 8) ?? "none"}`);
     if (postId !== this.state.tasksPostId) {
       ctx.logger.debug(`TaskListExecutor: postId does not match tasksPostId, ignoring`);
@@ -58880,7 +58907,7 @@ class SubagentExecutor extends BaseExecutor {
     }
     return false;
   }
-  async handleReaction(postId, emoji, action, ctx) {
+  async handleReaction(postId, emoji, _user, action, ctx) {
     ctx.logger.debug(`SubagentExecutor.handleReaction: postId=${postId.substring(0, 8)}, emoji=${emoji}, action=${action}`);
     if (!isMinimizeToggleEmoji(emoji)) {
       ctx.logger.debug(`SubagentExecutor: emoji ${emoji} is not minimize toggle, ignoring`);
@@ -59420,6 +59447,9 @@ class PromptExecutor extends BaseExecutor {
   getPendingContextPrompt() {
     return this.state.pendingContextPrompt;
   }
+  serialize() {
+    return this.state.pendingContextPrompt;
+  }
   hasPendingContextPrompt() {
     return this.state.pendingContextPrompt !== null;
   }
@@ -60782,12 +60812,12 @@ class MessageManager {
     await this.taskListExecutor.bumpToBottom(this.getExecutorContext());
   }
   getTaskListState() {
-    const state = this.taskListExecutor.getState();
+    return this.taskListExecutor.serialize();
+  }
+  serialize() {
     return {
-      postId: state.tasksPostId,
-      content: state.lastTasksContent,
-      isMinimized: state.tasksMinimized,
-      isCompleted: state.tasksCompleted
+      taskList: this.taskListExecutor.serialize(),
+      contextPrompt: this.promptExecutor.serialize()
     };
   }
   hydrateTaskListState(persisted) {
@@ -60880,33 +60910,27 @@ class MessageManager {
   getSession() {
     return this.session;
   }
+  reactionDispatchList() {
+    return [
+      { name: "QuestionApprovalExecutor", executor: this.questionApprovalExecutor },
+      { name: "MessageApprovalExecutor", executor: this.messageApprovalExecutor },
+      { name: "PromptExecutor", executor: this.promptExecutor },
+      { name: "BugReportExecutor", executor: this.bugReportExecutor },
+      { name: "TaskListExecutor", executor: this.taskListExecutor },
+      { name: "SubagentExecutor", executor: this.subagentExecutor }
+    ];
+  }
   async handleReaction(postId, emoji, user, action) {
     const logger = log18.forSession(this.sessionId);
     const ctx = this.getExecutorContext();
     logger.debug(`Routing reaction: postId=${postId}, emoji=${emoji}, user=${user}, action=${action}`);
-    if (await this.questionApprovalExecutor.handleReaction(postId, emoji, user, action, ctx)) {
-      logger.debug("Reaction handled by QuestionApprovalExecutor");
-      return true;
-    }
-    if (await this.messageApprovalExecutor.handleReaction(postId, emoji, user, action, ctx)) {
-      logger.debug("Reaction handled by MessageApprovalExecutor");
-      return true;
-    }
-    if (await this.promptExecutor.handleReaction(postId, emoji, user, action, ctx)) {
-      logger.debug("Reaction handled by PromptExecutor");
-      return true;
-    }
-    if (await this.bugReportExecutor.handleReaction(postId, emoji, user, action, ctx)) {
-      logger.debug("Reaction handled by BugReportExecutor");
-      return true;
-    }
-    if (await this.taskListExecutor.handleReaction(postId, emoji, action, ctx)) {
-      logger.debug("Reaction handled by TaskListExecutor");
-      return true;
-    }
-    if (await this.subagentExecutor.handleReaction(postId, emoji, action, ctx)) {
-      logger.debug("Reaction handled by SubagentExecutor");
-      return true;
+    for (const { name, executor } of this.reactionDispatchList()) {
+      if (!executor.handleReaction)
+        continue;
+      if (await executor.handleReaction(postId, emoji, user, action, ctx)) {
+        logger.debug(`Reaction handled by ${name}`);
+        return true;
+      }
     }
     logger.debug("Reaction not handled by any executor");
     return false;
@@ -66313,6 +66337,15 @@ function parseWorktreeError(error) {
       suggestion: "Try a different branch name, or use `!worktree list` to see existing worktrees"
     };
   }
+  const parentBlocksMatch = message.match(/'refs\/heads\/([^']+)' exists; cannot create '(?:refs\/heads\/)?([^']+)'/i);
+  if (parentBlocksMatch) {
+    const parent = parentBlocksMatch[1];
+    const nested = parentBlocksMatch[2];
+    return {
+      summary: `Branch ${parent} already exists and blocks ${nested}`,
+      suggestion: `Pick a name that does not start with ${parent}/, or delete the existing ${parent} branch first.`
+    };
+  }
   if (lowerMessage.includes("already exists")) {
     return {
       summary: "A worktree or branch with this name already exists",
@@ -68910,19 +68943,29 @@ class SessionManager extends EventEmitter4 {
     this.stopTyping(session);
   }
   persistSession(session) {
-    let persistedContextPrompt;
-    const contextPromptState = session.messageManager?.getPendingContextPrompt();
-    if (contextPromptState) {
-      persistedContextPrompt = {
-        postId: contextPromptState.postId,
-        queuedPrompt: contextPromptState.queuedPrompt,
-        queuedFiles: contextPromptState.queuedFiles,
-        threadMessageCount: contextPromptState.threadMessageCount,
-        createdAt: contextPromptState.createdAt,
-        availableOptions: contextPromptState.availableOptions
-      };
+    const useSerializeV2 = process.env.CLAUDE_THREADS_SERIALIZE_V2 !== "0";
+    let taskListSnapshot;
+    let contextPromptSnapshot;
+    if (useSerializeV2 && session.messageManager) {
+      const serialized = session.messageManager.serialize();
+      taskListSnapshot = serialized.taskList;
+      if (serialized.contextPrompt) {
+        contextPromptSnapshot = serialized.contextPrompt;
+      }
+    } else {
+      const legacyPrompt = session.messageManager?.getPendingContextPrompt();
+      if (legacyPrompt) {
+        contextPromptSnapshot = {
+          postId: legacyPrompt.postId,
+          queuedPrompt: legacyPrompt.queuedPrompt,
+          queuedFiles: legacyPrompt.queuedFiles,
+          threadMessageCount: legacyPrompt.threadMessageCount,
+          createdAt: legacyPrompt.createdAt,
+          availableOptions: legacyPrompt.availableOptions
+        };
+      }
+      taskListSnapshot = session.messageManager?.getTaskListState();
     }
-    const taskState = session.messageManager?.getTaskListState();
     const state = {
       platformId: session.platformId,
       threadId: session.threadId,
@@ -68937,10 +68980,10 @@ class SessionManager extends EventEmitter4 {
       sessionAllowedUsers: [...session.sessionAllowedUsers],
       forceInteractivePermissions: session.forceInteractivePermissions,
       sessionStartPostId: session.sessionStartPostId,
-      tasksPostId: taskState?.postId ?? null,
-      lastTasksContent: taskState?.content ?? null,
-      tasksCompleted: taskState?.isCompleted ?? false,
-      tasksMinimized: taskState?.isMinimized ?? false,
+      tasksPostId: taskListSnapshot?.postId ?? null,
+      lastTasksContent: taskListSnapshot?.content ?? null,
+      tasksCompleted: taskListSnapshot?.isCompleted ?? false,
+      tasksMinimized: taskListSnapshot?.isMinimized ?? false,
       worktreeInfo: session.worktreeInfo,
       isWorktreeOwner: session.isWorktreeOwner,
       pendingWorktreePrompt: session.pendingWorktreePrompt,
@@ -68948,7 +68991,7 @@ class SessionManager extends EventEmitter4 {
       queuedPrompt: session.queuedPrompt,
       queuedFiles: session.queuedFiles,
       firstPrompt: session.firstPrompt,
-      pendingContextPrompt: persistedContextPrompt,
+      pendingContextPrompt: contextPromptSnapshot,
       needsContextPromptOnNextMessage: session.needsContextPromptOnNextMessage,
       lifecyclePostId: session.lifecyclePostId,
       isPaused: session.lifecycle.state === "paused" || session.lifecycle.state === "interrupted",
@@ -80089,7 +80132,8 @@ function wirePlatformEvents(platformId, client, session, ui) {
     ui.setPlatformStatus(platformId, { reconnecting: true, reconnectAttempts: attempt });
   });
   client.on("error", (e) => {
-    ui.addLog({ level: "error", component: platformId, message: String(e) });
+    const message = e instanceof Error ? e.message : String(e);
+    ui.addLog({ level: "error", component: platformId, message });
   });
 }
 program.name("claude-threads").version(VERSION).description("Share Claude Code sessions in Mattermost").option("--url <url>", "Mattermost server URL").option("--token <token>", "Mattermost bot token").option("--channel <id>", "Mattermost channel ID").option("--bot-name <name>", "Bot mention name (default: claude-code)").option("--allowed-users <users>", "Comma-separated allowed usernames").option("--permission-mode <mode>", "Permission mode: default | auto | bypass (default: from config)").option("--skip-permissions", "[deprecated] Alias for --permission-mode bypass").option("--no-skip-permissions", "[deprecated] Alias for --permission-mode default").option("--chrome", "Enable Claude in Chrome integration").option("--no-chrome", "Disable Claude in Chrome integration").option("--worktree-mode <mode>", "Git worktree mode: off, prompt, require (default: prompt)").option("--keep-alive", "Enable system sleep prevention (default: enabled)").option("--no-keep-alive", "Disable system sleep prevention").option("--setup", "Run interactive setup wizard (reconfigure existing settings)").option("--debug", "Enable debug logging").option("--skip-version-check", "Skip Claude CLI version compatibility check").option("--auto-restart", "Enable auto-restart on updates (default when autoUpdate enabled)").option("--no-auto-restart", "Disable auto-restart on updates").option("--headless", "Run without interactive UI (logs to stdout)").parse();

package/dist/mcp/permission-server.js

@@ -50456,6 +50456,23 @@ class BaseExecutor {
   }
 }
 // src/platform/utils.ts
+function formatWebSocketError(err) {
+  if (err instanceof Error)
+    return err.message;
+  if (err && typeof err === "object") {
+    const e = err;
+    if (typeof e.message === "string" && e.message)
+      return e.message;
+    if (e.error instanceof Error)
+      return e.error.message;
+    if (typeof e.error === "string" && e.error)
+      return e.error;
+    if (typeof e.type === "string" && e.type) {
+      return typeof e.code === "string" || typeof e.code === "number" ? `${e.type} (code: ${e.code})` : e.type;
+    }
+  }
+  return String(err);
+}
 function truncateMessageSafely(message, maxLength, truncationIndicator = "... (truncated)") {
   if (message.length <= maxLength)
     return message;
@@ -51175,7 +51192,15 @@ class TaskListExecutor extends BaseExecutor {
       await ctx.platform.updatePost(this.state.tasksPostId, displayContent);
     } catch {}
   }
-  async handleReaction(postId, emoji4, action, ctx) {
+  serialize() {
+    return {
+      postId: this.state.tasksPostId,
+      content: this.state.lastTasksContent,
+      isMinimized: this.state.tasksMinimized,
+      isCompleted: this.state.tasksCompleted
+    };
+  }
+  async handleReaction(postId, emoji4, _user, action, ctx) {
     ctx.logger.debug(`TaskListExecutor.handleReaction: postId=${postId.substring(0, 8)}, emoji=${emoji4}, action=${action}, tasksPostId=${this.state.tasksPostId?.substring(0, 8) ?? "none"}`);
     if (postId !== this.state.tasksPostId) {
       ctx.logger.debug(`TaskListExecutor: postId does not match tasksPostId, ignoring`);
@@ -51444,7 +51469,7 @@ class SubagentExecutor extends BaseExecutor {
     }
     return false;
   }
-  async handleReaction(postId, emoji4, action, ctx) {
+  async handleReaction(postId, emoji4, _user, action, ctx) {
     ctx.logger.debug(`SubagentExecutor.handleReaction: postId=${postId.substring(0, 8)}, emoji=${emoji4}, action=${action}`);
     if (!isMinimizeToggleEmoji(emoji4)) {
       ctx.logger.debug(`SubagentExecutor: emoji ${emoji4} is not minimize toggle, ignoring`);
@@ -51984,6 +52009,9 @@ class PromptExecutor extends BaseExecutor {
   getPendingContextPrompt() {
     return this.state.pendingContextPrompt;
   }
+  serialize() {
+    return this.state.pendingContextPrompt;
+  }
   hasPendingContextPrompt() {
     return this.state.pendingContextPrompt !== null;
   }
@@ -52734,12 +52762,12 @@ class MessageManager {
     await this.taskListExecutor.bumpToBottom(this.getExecutorContext());
   }
   getTaskListState() {
-    const state = this.taskListExecutor.getState();
+    return this.taskListExecutor.serialize();
+  }
+  serialize() {
     return {
-      postId: state.tasksPostId,
-      content: state.lastTasksContent,
-      isMinimized: state.tasksMinimized,
-      isCompleted: state.tasksCompleted
+      taskList: this.taskListExecutor.serialize(),
+      contextPrompt: this.promptExecutor.serialize()
     };
   }
   hydrateTaskListState(persisted) {
@@ -52832,33 +52860,27 @@ class MessageManager {
   getSession() {
     return this.session;
   }
+  reactionDispatchList() {
+    return [
+      { name: "QuestionApprovalExecutor", executor: this.questionApprovalExecutor },
+      { name: "MessageApprovalExecutor", executor: this.messageApprovalExecutor },
+      { name: "PromptExecutor", executor: this.promptExecutor },
+      { name: "BugReportExecutor", executor: this.bugReportExecutor },
+      { name: "TaskListExecutor", executor: this.taskListExecutor },
+      { name: "SubagentExecutor", executor: this.subagentExecutor }
+    ];
+  }
   async handleReaction(postId, emoji4, user, action) {
     const logger = log3.forSession(this.sessionId);
     const ctx = this.getExecutorContext();
     logger.debug(`Routing reaction: postId=${postId}, emoji=${emoji4}, user=${user}, action=${action}`);
-    if (await this.questionApprovalExecutor.handleReaction(postId, emoji4, user, action, ctx)) {
-      logger.debug("Reaction handled by QuestionApprovalExecutor");
-      return true;
-    }
-    if (await this.messageApprovalExecutor.handleReaction(postId, emoji4, user, action, ctx)) {
-      logger.debug("Reaction handled by MessageApprovalExecutor");
-      return true;
-    }
-    if (await this.promptExecutor.handleReaction(postId, emoji4, user, action, ctx)) {
-      logger.debug("Reaction handled by PromptExecutor");
-      return true;
-    }
-    if (await this.bugReportExecutor.handleReaction(postId, emoji4, user, action, ctx)) {
-      logger.debug("Reaction handled by BugReportExecutor");
-      return true;
-    }
-    if (await this.taskListExecutor.handleReaction(postId, emoji4, action, ctx)) {
-      logger.debug("Reaction handled by TaskListExecutor");
-      return true;
-    }
-    if (await this.subagentExecutor.handleReaction(postId, emoji4, action, ctx)) {
-      logger.debug("Reaction handled by SubagentExecutor");
-      return true;
+    for (const { name, executor } of this.reactionDispatchList()) {
+      if (!executor.handleReaction)
+        continue;
+      if (await executor.handleReaction(postId, emoji4, user, action, ctx)) {
+        logger.debug(`Reaction handled by ${name}`);
+        return true;
+      }
     }
     logger.debug("Reaction not handled by any executor");
     return false;
@@ -57482,7 +57504,7 @@ class MattermostPermissionApi {
         }
       };
       ws.onerror = (event) => {
-        mcpLogger.error(`WebSocket error: ${event}`);
+        mcpLogger.error(`WebSocket error: ${formatWebSocketError(event)}`);
         if (!resolved) {
           resolved = true;
           clearTimeout(timeout);
@@ -57749,7 +57771,7 @@ class SlackPermissionApi {
           }
         };
         ws.onerror = (event) => {
-          mcpLogger.error(`Socket Mode WebSocket error: ${event}`);
+          mcpLogger.error(`Socket Mode WebSocket error: ${formatWebSocketError(event)}`);
           if (!resolved) {
             resolved = true;
             clearTimeout(timeout);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "claude-threads",
-  "version": "1.9.0",
+  "version": "1.9.2",
   "description": "Share Claude Code sessions live in a Mattermost channel with interactive features",
   "main": "dist/index.js",
   "type": "module",