claude-smart 0.2.48 → 0.2.49

package/plugin/vendor/reflexio/reflexio/server/services/storage/sqlite_storage/base/_fts_vec.py

@@ -6,6 +6,11 @@ index sidecar update is durable. They are sqlite-only — there is no
 supabase/postgres counterpart. Composed into ``SQLiteStorage`` ahead of
 ``SQLiteStorageBase``; the boot-time ``_migrate_vec_tables`` (residual in
 ``_base.py``) resolves ``self._vec_upsert`` through the composed MRO.
+
+When a ``commit_scope`` is active (``_scope_depth > 0``), the public helpers
+buffer the operation into ``_deferred_index_ops`` for post-commit flushing;
+the ``_..._now`` variants always execute immediately and are called by
+``_flush_index_op`` after the outer commit.
 """
 
 from __future__ import annotations
@@ -23,10 +28,50 @@ class SQLiteFtsVecMixin:
     conn: sqlite3.Connection
     _fetchall: Any
     _has_sqlite_vec: bool
+    _scope_depth: int
+    _deferred_index_ops: list[tuple[str, Any]]
+
+    # ------------------------------------------------------------------
+    # Dispatcher — called by commit_scope after the outer commit
+    # ------------------------------------------------------------------
+
+    def _flush_index_op(self, kind: str, args: Any) -> None:
+        """Dispatch a buffered index op after the outer commit."""
+        if kind == "fts_upsert":
+            table, rowid, text_fields = args
+            self._fts_upsert_now(table, rowid, **text_fields)
+        elif kind == "fts_delete":
+            table, rowid = args
+            self._fts_delete_now(table, rowid)
+        elif kind == "fts_upsert_profile":
+            profile_id, content = args
+            self._fts_upsert_profile_now(profile_id, content)
+        elif kind == "fts_delete_profile":
+            (profile_id,) = args
+            self._fts_delete_profile_now(profile_id)
+        elif kind == "vec_upsert":
+            table, rowid, embedding = args
+            self._vec_upsert_now(table, rowid, embedding)
+        elif kind == "vec_delete":
+            table, rowid = args
+            self._vec_delete_now(table, rowid)
+        else:
+            raise ValueError(f"unknown index op kind: {kind!r}")
+
+    # ------------------------------------------------------------------
+    # FTS helpers — public (defer when in scope) + _now (immediate)
+    # ------------------------------------------------------------------
 
-    # FTS helpers
     def _fts_upsert(self, table: str, rowid: int, **text_fields: str | None) -> None:
         """Insert or update an FTS row.  Deletes old entry first to avoid duplicates."""
+        if self._scope_depth > 0:
+            self._deferred_index_ops.append(("fts_upsert", (table, rowid, text_fields)))
+            return
+        self._fts_upsert_now(table, rowid, **text_fields)
+
+    def _fts_upsert_now(
+        self, table: str, rowid: int, **text_fields: str | None
+    ) -> None:
         with self._lock:
             self.conn.execute(f"DELETE FROM {table} WHERE rowid = ?", (rowid,))  # noqa: S608
             cols = list(text_fields.keys())
@@ -40,12 +85,26 @@ class SQLiteFtsVecMixin:
             self.conn.commit()
 
     def _fts_delete(self, table: str, rowid: int) -> None:
+        if self._scope_depth > 0:
+            self._deferred_index_ops.append(("fts_delete", (table, rowid)))
+            return
+        self._fts_delete_now(table, rowid)
+
+    def _fts_delete_now(self, table: str, rowid: int) -> None:
         with self._lock:
             self.conn.execute(f"DELETE FROM {table} WHERE rowid = ?", (rowid,))  # noqa: S608
             self.conn.commit()
 
     def _fts_upsert_profile(self, profile_id: str, content: str) -> None:
         """FTS for profiles uses profile_id TEXT as key column."""
+        if self._scope_depth > 0:
+            self._deferred_index_ops.append(
+                ("fts_upsert_profile", (profile_id, content))
+            )
+            return
+        self._fts_upsert_profile_now(profile_id, content)
+
+    def _fts_upsert_profile_now(self, profile_id: str, content: str) -> None:
         with self._lock:
             self.conn.execute(
                 "DELETE FROM profiles_fts WHERE profile_id = ?", (profile_id,)
@@ -57,15 +116,32 @@ class SQLiteFtsVecMixin:
             self.conn.commit()
 
     def _fts_delete_profile(self, profile_id: str) -> None:
+        if self._scope_depth > 0:
+            self._deferred_index_ops.append(("fts_delete_profile", (profile_id,)))
+            return
+        self._fts_delete_profile_now(profile_id)
+
+    def _fts_delete_profile_now(self, profile_id: str) -> None:
         with self._lock:
             self.conn.execute(
                 "DELETE FROM profiles_fts WHERE profile_id = ?", (profile_id,)
             )
             self.conn.commit()
 
-    # Vec helpers (sqlite-vec)
+    # ------------------------------------------------------------------
+    # Vec helpers (sqlite-vec) — public (defer when in scope) + _now (immediate)
+    # ------------------------------------------------------------------
+
     def _vec_upsert(self, table: str, rowid: int, embedding: list[float]) -> None:
         """Insert or update a vec table row. No-op when sqlite-vec is unavailable."""
+        if not self._has_sqlite_vec:
+            return
+        if self._scope_depth > 0:
+            self._deferred_index_ops.append(("vec_upsert", (table, rowid, embedding)))
+            return
+        self._vec_upsert_now(table, rowid, embedding)
+
+    def _vec_upsert_now(self, table: str, rowid: int, embedding: list[float]) -> None:
         if not self._has_sqlite_vec:
             return
         with self._lock:
@@ -78,6 +154,14 @@ class SQLiteFtsVecMixin:
 
     def _vec_delete(self, table: str, rowid: int) -> None:
         """Delete a vec table row. No-op when sqlite-vec is unavailable."""
+        if not self._has_sqlite_vec:
+            return
+        if self._scope_depth > 0:
+            self._deferred_index_ops.append(("vec_delete", (table, rowid)))
+            return
+        self._vec_delete_now(table, rowid)
+
+    def _vec_delete_now(self, table: str, rowid: int) -> None:
         if not self._has_sqlite_vec:
             return
         with self._lock:

package/plugin/vendor/reflexio/reflexio/server/services/storage/sqlite_storage/playbook/_agent.py

@@ -87,6 +87,7 @@ class AgentPlaybookStoreMixin:
     _fts_upsert: Any
     _vec_upsert: Any
     _delete_playbook_search_rows: Any
+    _own_transaction: Any
 
     def _index_agent_playbook_fts_vec(self, ap: AgentPlaybook) -> None:
         """Update the FTS and vector indexes for a single agent playbook row.
@@ -178,7 +179,8 @@ class AgentPlaybookStoreMixin:
             created_at_iso = _epoch_to_iso(ap.created_at)
             with self._lock:
                 self._insert_agent_playbook_row(self.conn, ap, created_at_iso)
-                self.conn.commit()
+                if self._own_transaction():
+                    self.conn.commit()
 
             self._index_agent_playbook_fts_vec(ap)
             saved.append(ap)
@@ -228,6 +230,7 @@ class AgentPlaybookStoreMixin:
 
         created_at_iso = _epoch_to_iso(ap.created_at)
         with self._lock:
+            own_txn = self._own_transaction()
             try:
                 self._insert_agent_playbook_row(self.conn, ap, created_at_iso)
                 _append_event_stmt(
@@ -242,9 +245,11 @@ class AgentPlaybookStoreMixin:
                     request_id=request_id,
                     reason=f"{AGGREGATE_REASON_PREFIX}{run_mode}",
                 )
-                self.conn.commit()
+                if own_txn:
+                    self.conn.commit()
             except Exception:
-                self.conn.rollback()
+                if own_txn:
+                    self.conn.rollback()
                 raise
 
         # FTS/vec indexing AFTER commit — these helpers self-commit and must
@@ -609,7 +614,8 @@ class AgentPlaybookStoreMixin:
                     to_status="archived",
                     status_namespace="lifecycle_status",
                 )
-            self.conn.commit()
+            if self._own_transaction():
+                self.conn.commit()
 
     @SQLiteStorageBase.handle_exceptions
     def archive_agent_playbooks_by_ids(self, agent_playbook_ids: list[int]) -> None:
@@ -648,7 +654,8 @@ class AgentPlaybookStoreMixin:
                     to_status="archived",
                     status_namespace="lifecycle_status",
                 )
-            self.conn.commit()
+            if self._own_transaction():
+                self.conn.commit()
 
     @SQLiteStorageBase.handle_exceptions
     def supersede_agent_playbooks_by_ids(
@@ -712,7 +719,8 @@ class AgentPlaybookStoreMixin:
                         request_id=request_id,
                     )
                     updated += 1
-            self.conn.commit()
+            if self._own_transaction():
+                self.conn.commit()
         return updated
 
     @SQLiteStorageBase.handle_exceptions
@@ -773,7 +781,8 @@ class AgentPlaybookStoreMixin:
                         request_id=request_id,
                     )
                     updated += 1
-            self.conn.commit()
+            if self._own_transaction():
+                self.conn.commit()
         return updated
 
     @SQLiteStorageBase.handle_exceptions

package/plugin/vendor/reflexio/reflexio/server/services/storage/sqlite_storage/playbook/_source_linkage.py

@@ -22,6 +22,7 @@ class PlaybookSourceLinkageMixin:
     _fetchall: Any
     _subject_ref_for_user_id: Any
     _assert_subject_writable_locked: Any
+    _own_transaction: Any
 
     @SQLiteStorageBase.handle_exceptions
     def set_source_user_playbook_ids_for_agent_playbook(
@@ -87,8 +88,10 @@ class PlaybookSourceLinkageMixin:
                     ids.append(source_id)
                     seen.add(source_id)
         with self._lock:
+            own_txn = self._own_transaction()
             try:
-                self.conn.execute("BEGIN IMMEDIATE")
+                if own_txn:
+                    self.conn.execute("BEGIN IMMEDIATE")
                 for user_playbook_id in by_id:
                     row = self.conn.execute(
                         """SELECT user_id, governance_subject_ref FROM user_playbooks
@@ -120,9 +123,11 @@ class PlaybookSourceLinkageMixin:
                         for upid, source_interaction_ids in by_id.items()
                     ],
                 )
-                self.conn.commit()
+                if own_txn:
+                    self.conn.commit()
             except Exception:
-                self.conn.rollback()
+                if own_txn:
+                    self.conn.rollback()
                 raise
 
     @SQLiteStorageBase.handle_exceptions

package/plugin/vendor/reflexio/reflexio/server/services/storage/sqlite_storage/playbook/_user.py

@@ -71,6 +71,7 @@ class UserPlaybookStoreMixin:
     _delete_playbook_search_rows: Any
     _subject_ref_for_user_id: Any
     _assert_subject_writable_locked: Any
+    _own_transaction: Any
 
     def _subject_ref_from_user_playbook_row(self, row: sqlite3.Row) -> str:
         subject_ref = row["governance_subject_ref"]
@@ -119,8 +120,10 @@ class UserPlaybookStoreMixin:
 
             created_at_iso = _epoch_to_iso(up.created_at)
             with self._lock:
+                own_txn = self._own_transaction()
                 try:
-                    self.conn.execute("BEGIN IMMEDIATE")
+                    if own_txn:
+                        self.conn.execute("BEGIN IMMEDIATE")
                     self._assert_subject_writable_locked(subject_ref)
                     cur = self.conn.execute(
                         """INSERT INTO user_playbooks
@@ -159,9 +162,11 @@ class UserPlaybookStoreMixin:
                     )
                     upid = cur.lastrowid or 0
                     up.user_playbook_id = upid
-                    self.conn.commit()
+                    if own_txn:
+                        self.conn.commit()
                 except Exception:
-                    self.conn.rollback()
+                    if own_txn:
+                        self.conn.rollback()
                     raise
 
             fts_parts = [up.trigger or "", up.content or ""]
@@ -789,7 +794,8 @@ class UserPlaybookStoreMixin:
                         to_status=None,
                         status_namespace=None,
                     )
-                self.conn.commit()
+                if self._own_transaction():
+                    self.conn.commit()
 
     @SQLiteStorageBase.handle_exceptions
     def supersede_user_playbooks_by_ids(
@@ -840,5 +846,6 @@ class UserPlaybookStoreMixin:
                         request_id=request_id,
                     )
                     updated += 1
-            self.conn.commit()
+            if self._own_transaction():
+                self.conn.commit()
         return updated

package/plugin/vendor/reflexio/reflexio/server/services/storage/sqlite_storage/profiles/_interaction_store.py

@@ -45,6 +45,7 @@ class InteractionStoreMixin:
     embedding_dimensions: int
     _subject_ref_for_user_id: Any
     _assert_subject_writable_locked: Any
+    _own_transaction: Any
 
     # ------------------------------------------------------------------
     # CRUD — Interactions
@@ -81,8 +82,10 @@ class InteractionStoreMixin:
         created_at_iso = _epoch_to_iso(interaction.created_at)
         subject_ref = self._subject_ref_for_user_id(interaction.user_id)
         with self._lock:
+            own_txn = self._own_transaction()
             try:
-                self.conn.execute("BEGIN IMMEDIATE")
+                if own_txn:
+                    self.conn.execute("BEGIN IMMEDIATE")
                 self._assert_subject_writable_locked(subject_ref)
                 if interaction.interaction_id:
                     self.conn.execute(
@@ -148,9 +151,11 @@ class InteractionStoreMixin:
                     )
                     iid = cur.lastrowid or 0
                     interaction.interaction_id = iid
-                self.conn.commit()
+                if own_txn:
+                    self.conn.commit()
             except Exception:
-                self.conn.rollback()
+                if own_txn:
+                    self.conn.rollback()
                 raise
         # Update FTS and vec
         self._fts_upsert(
@@ -168,12 +173,53 @@ class InteractionStoreMixin:
         self,
         user_id: str,  # noqa: ARG002
         interactions: list[Interaction],
+        *,
+        embeddings_prepared: bool = False,
     ) -> None:
         if not interactions:
             return
+        if not embeddings_prepared:
+            # Only generate embeddings for interactions that do not already have them.
+            # This allows callers to pre-populate embeddings (e.g. via
+            # prepare_interaction_embeddings) before opening a commit_scope so that no
+            # network I/O occurs inside the transaction.
+            to_embed = [i for i in interactions if not i.embedding]
+            if to_embed:
+                texts = [
+                    "\n".join([i.content or "", i.user_action_description or ""])
+                    for i in to_embed
+                ]
+                try:
+                    embeddings = self.llm_client.get_embeddings(
+                        texts, self.embedding_model_name, self.embedding_dimensions
+                    )
+                except EmbeddingUnavailableError as exc:
+                    logger.warning(
+                        "Embedding unavailable for interaction bulk insert; "
+                        "continuing without vectors: %s",
+                        exc,
+                    )
+                    embeddings = [[] for _ in texts]
+                for interaction, embedding in zip(to_embed, embeddings, strict=False):
+                    interaction.embedding = embedding
+        for interaction in interactions:
+            self._insert_interaction(interaction)
+
+    @SQLiteStorageBase.handle_exceptions
+    def prepare_interaction_embeddings(self, interactions: list[Interaction]) -> None:
+        """Pre-populate interaction.embedding for each interaction (no DB write).
+
+        Generates embeddings in one batch call so the write path inside a
+        commit_scope can skip the network round-trip.
+        """
+        if not interactions:
+            return
+        to_embed = [i for i in interactions if not i.embedding]
+        if not to_embed:
+            return
         texts = [
             "\n".join([i.content or "", i.user_action_description or ""])
-            for i in interactions
+            for i in to_embed
         ]
         try:
             embeddings = self.llm_client.get_embeddings(
@@ -181,14 +227,13 @@ class InteractionStoreMixin:
             )
         except EmbeddingUnavailableError as exc:
             logger.warning(
-                "Embedding unavailable for interaction bulk insert; "
+                "Embedding unavailable during prepare_interaction_embeddings; "
                 "continuing without vectors: %s",
                 exc,
             )
             embeddings = [[] for _ in texts]
-        for interaction, embedding in zip(interactions, embeddings, strict=False):
+        for interaction, embedding in zip(to_embed, embeddings, strict=False):
             interaction.embedding = embedding
-            self._insert_interaction(interaction)
 
     @SQLiteStorageBase.handle_exceptions
     def delete_user_interaction(self, request: DeleteUserInteractionRequest) -> None:

package/plugin/vendor/reflexio/reflexio/server/services/storage/sqlite_storage/profiles/_profile_store.py

@@ -77,6 +77,7 @@ class ProfileStoreMixin:
     _has_sqlite_vec: bool
     _subject_ref_for_user_id: Any
     _assert_subject_writable_locked: Any
+    _own_transaction: Any
 
     def _subject_ref_from_profile_row(self, row: sqlite3.Row) -> str:
         subject_ref = row["governance_subject_ref"]
@@ -224,8 +225,10 @@ class ProfileStoreMixin:
                 profile.embedding = self._get_embedding(embedding_text)
             embedding = profile.embedding
             with self._lock:
+                own_txn = self._own_transaction()
                 try:
-                    self.conn.execute("BEGIN IMMEDIATE")
+                    if own_txn:
+                        self.conn.execute("BEGIN IMMEDIATE")
                     self._assert_subject_writable_locked(subject_ref)
                     self.conn.execute(
                         """INSERT OR REPLACE INTO profiles
@@ -261,9 +264,11 @@ class ProfileStoreMixin:
                             subject_ref,
                         ),
                     )
-                    self.conn.commit()
+                    if own_txn:
+                        self.conn.commit()
                 except Exception:
-                    self.conn.rollback()
+                    if own_txn:
+                        self.conn.rollback()
                     raise
             fts_parts = [profile.content or ""]
             if profile.custom_features:
@@ -473,6 +478,24 @@ class ProfileStoreMixin:
         row = self._fetchone("SELECT COUNT(*) as cnt FROM profiles")
         return row["cnt"] if row else 0
 
+    @SQLiteStorageBase.handle_exceptions
+    def count_user_profiles_by_status(
+        self, user_ids: list[str], status: Status | None
+    ) -> int:
+        if not user_ids:
+            return 0
+
+        current_ts = _epoch_now()
+        status_frag, status_params = _build_status_sql([status])
+        ph = ",".join("?" for _ in user_ids)
+        sql = (
+            f"SELECT COUNT(*) as cnt FROM profiles "
+            f"WHERE user_id IN ({ph}) "
+            f"AND expiration_timestamp >= ? AND {status_frag}"
+        )
+        row = self._fetchone(sql, [*user_ids, current_ts, *status_params])
+        return row["cnt"] if row else 0
+
     @SQLiteStorageBase.handle_exceptions
     def update_all_profiles_status(
         self,
@@ -809,7 +832,8 @@ class ProfileStoreMixin:
                         status_namespace="lifecycle_status",
                     )
                     committed_ids.append(pid)
-            self.conn.commit()
+            if self._own_transaction():
+                self.conn.commit()
         return committed_ids
 
     @SQLiteStorageBase.handle_exceptions

package/plugin/vendor/reflexio/reflexio/server/services/storage/storage_base/__init__.py

@@ -1,5 +1,6 @@
 from reflexio.models.api_schema.domain.enums import Status
 
+from ._learning_jobs import LearningJob, LearningJobStatus, LearningJobStoreABC
 from ._agent_run import (
     NOT_APPLICABLE_ANSWER,
     AgentBinding,
@@ -22,6 +23,7 @@ from ._agent_run import (
     not_applicable_tool_result,
 )
 from ._base import BaseStorageCore, matches_status_filter
+from ._commit_scope import CommitScopeMixin
 from ._extras import ExtrasMixin
 from ._lineage import EntityType, LineageEventMixin
 from ._operations import OperationMixin
@@ -48,6 +50,8 @@ from .profiles import InteractionStoreMixin, ProfileSearchMixin, ProfileStoreMix
 
 
 class BaseStorage(
+    LearningJobStoreABC,
+    CommitScopeMixin,
     AgentRunMixin,
     ProfileStoreMixin,
     InteractionStoreMixin,
@@ -260,8 +264,21 @@ class BaseStorage(
             "purged_user_playbooks": len(purge_upb_ids),
         }
 
+    def learning_jobs_columns(self) -> list[str]:
+        """Return the column names of the learning_jobs table.
+
+        Each backend overrides this to query its own schema introspection
+        mechanism (SQLite: PRAGMA table_info; Postgres/Supabase:
+        information_schema.columns).
+        """
+        raise NotImplementedError
+
 
 __all__ = [
+    "LearningJob",
+    "LearningJobStatus",
+    "LearningJobStoreABC",
+    "CommitScopeMixin",
     "AgentBinding",
     "AgentRunMixin",
     "EntityType",

package/plugin/vendor/reflexio/reflexio/server/services/storage/storage_base/_commit_scope.py

@@ -0,0 +1,9 @@
+from abc import ABC, abstractmethod
+from contextlib import AbstractContextManager
+
+
+class CommitScopeMixin(ABC):
+    @abstractmethod
+    def commit_scope(self) -> AbstractContextManager[None]:
+        """Atomic multi-write transaction; see Workstream A plan Task 1."""
+        raise NotImplementedError