claude-remote-approver 0.5.0 → 0.5.2

package/README.md

@@ -25,7 +25,7 @@ cli.mjs hook
   │                                                 │
   └──SSE───▶ ntfy.sh/<topic>-response  ◀──POST──┘
   │
-  │  stdout JSON: { "behavior": "allow" } or { "behavior": "deny" }
+  │  stdout JSON: allow / deny / ask (CLI fallback)
   ▼
 Claude Code continues or stops
 ```
@@ -34,9 +34,13 @@ Claude Code continues or stops
 2. `cli.mjs hook` sends a notification to your ntfy topic with **Approve** and **Deny** action buttons.
 3. The hook subscribes to a response topic (`<topic>-response`) via server-sent events.
 4. When you tap a button on your phone, ntfy.sh publishes your decision to the response topic.
-5. The hook reads the decision, writes `{"behavior":"allow"}` or `{"behavior":"deny"}` to stdout, and exits.
+5. The hook reads the decision and writes `{"behavior":"allow"}` or `{"behavior":"deny"}` to stdout. If the notification fails or times out, the hook returns `{"behavior":"ask"}` so Claude Code falls back to the CLI prompt.
 6. Claude Code proceeds accordingly.
 
+### AskUserQuestion support
+
+When Claude Code calls the `AskUserQuestion` tool, the hook sends the question to your phone as a notification. Each option appears as an action button you can tap. If the question has more than 3 options, they are split across multiple notifications. If no response is received before the timeout, the hook falls back to the CLI prompt so you can answer at your terminal.
+
 ## Quick Start
 
 ```bash
@@ -179,7 +183,7 @@ Config file location: `~/.claude-remote-approver.json`
 |---|---|---|---|
 | `topic` | `string` | `""` | Your unique ntfy topic. Generated by `setup`. |
 | `ntfyServer` | `string` | `"https://ntfy.sh"` | The ntfy server URL. Change this if you self-host. |
-| `timeout` | `number` | `120` | Seconds to wait for a response before auto-denying. |
+| `timeout` | `number` | `120` | Seconds to wait for a response before falling back to CLI. |
 | `planTimeout` | `number` | `300` | Seconds to wait for ExitPlanMode (plan approval) responses. Plan reviews need more reading time. |
 | `autoApprove` | `string[]` | `[]` | Reserved for future use. |
 | `autoDeny` | `string[]` | `[]` | Reserved for future use. |
@@ -225,7 +229,7 @@ The public ntfy.sh server is convenient but means your permission request detail
 
 ### Timeout behavior
 
-If no response is received within the configured timeout (default: 120 seconds), the hook automatically **denies** the request. This fail-closed design ensures Claude Code does not proceed without explicit approval.
+If no response is received within the configured timeout (default: 120 seconds), the hook falls back to the **CLI prompt** (`ask`), so you can still respond at your terminal.
 
 ## Disclaimer
 
@@ -234,7 +238,7 @@ If no response is received within the configured timeout (default: 120 seconds),
 The authors are not responsible for any damages or losses arising from the use of this tool, including but not limited to:
 
 - Accidental approval of dangerous commands (e.g., mistapping Approve on your phone)
-- Unintended denial of safe commands (e.g., timeout, network issues)
+- Unintended CLI fallback when away from terminal (e.g., timeout, network issues)
 - Security breaches if the topic name is compromised
 
 **Not a substitute for careful review.** The push notification shows the tool name and a brief summary, but not the full context of what Claude Code is doing. Always review what you are approving.

package/bin/cli.mjs

@@ -12,6 +12,7 @@ import fs from "node:fs";
 import path from "node:path";
 import os from "node:os";
 import qrcode from "qrcode-terminal";
+import { ASK } from "../src/hook.mjs";
 
 // ---------------------------------------------------------------------------
 // main
@@ -87,8 +88,8 @@ export async function main(args, deps) {
       try {
         input = JSON.parse(deps.stdin);
       } catch {
-        const ask = { hookSpecificOutput: { hookEventName: "PermissionRequest", decision: { behavior: "ask" } } };
-        deps.stdout.write(JSON.stringify(ask) + "\n");
+        deps.stderr.write("[claude-remote-approver] Invalid hook input. Falling back to CLI.\n");
+        deps.stdout.write(JSON.stringify(ASK) + "\n");
         break;
       }
 
@@ -96,8 +97,8 @@ export async function main(args, deps) {
       try {
         result = await deps.processHook(input, deps);
       } catch {
-        const ask = { hookSpecificOutput: { hookEventName: "PermissionRequest", decision: { behavior: "ask" } } };
-        deps.stdout.write(JSON.stringify(ask) + "\n");
+        deps.stderr.write("[claude-remote-approver] Hook processing failed. Falling back to CLI.\n");
+        deps.stdout.write(JSON.stringify(ASK) + "\n");
         break;
       }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "claude-remote-approver",
-  "version": "0.5.0",
+  "version": "0.5.2",
   "description": "Approve or deny Claude Code permission prompts remotely from your phone via ntfy.sh",
   "type": "module",
   "bin": {

package/src/hook.mjs

@@ -3,9 +3,12 @@
 import crypto from "node:crypto";
 import { DEFAULT_CONFIG } from "./config.mjs";
 
-const ASK = Object.freeze({ hookSpecificOutput: Object.freeze({ hookEventName: "PermissionRequest", decision: Object.freeze({ behavior: "ask" }) }) });
+export const ASK = Object.freeze({ hookSpecificOutput: Object.freeze({ hookEventName: "PermissionRequest", decision: Object.freeze({ behavior: "ask" }) }) });
 const DENY = Object.freeze({ hookSpecificOutput: Object.freeze({ hookEventName: "PermissionRequest", decision: Object.freeze({ behavior: "deny" }) }) });
 const MAX_RETRIES = 3;
+export const RETRY_DELAY_MS = 1000;
+/** @internal Replaceable delay for testing. Do not use outside of tests. */
+export const _internal = { delay: ms => new Promise(r => setTimeout(r, ms)) };
 
 /**
  * Build ntfy action buttons for Approve / Deny.
@@ -37,6 +40,7 @@ export function buildActions(server, topic, requestId) {
 
 /**
  * Send with retry, returning null on exhausted retries.
+ * Uses linear backoff: delay = RETRY_DELAY_MS * attempt (1s, 2s, …).
  */
 export async function sendWithRetry(sendFn, params) {
   for (let i = 0; i < MAX_RETRIES; i++) {
@@ -44,9 +48,10 @@ export async function sendWithRetry(sendFn, params) {
       return await sendFn(params);
     } catch (err) {
       if (i === MAX_RETRIES - 1) {
-        console.error("sendNotification failed:", err);
+        console.error(`[claude-remote-approver] Notification failed after ${MAX_RETRIES} attempts:`, err.message, "— Falling back to CLI.");
         return null;
       }
+      await _internal.delay(RETRY_DELAY_MS * (i + 1));
     }
   }
   return null;
@@ -139,13 +144,14 @@ export async function processAskUserQuestion(input, deps) {
         timeout: config.timeout * 1000,
       });
     } catch (err) {
-      console.error("waitForResponse failed:", err);
+      console.error("[claude-remote-approver] Response listener failed:", err.message, "— Falling back to CLI.");
       return ASK;
     }
 
     if (response.answer) {
       answers[q.question] = response.answer;
     } else {
+      console.error("[claude-remote-approver] No answer received. Falling back to CLI.");
       return ASK;
     }
   }
@@ -211,11 +217,18 @@ export async function processHook(input, { loadConfig, sendNotification, waitFor
       timeout,
     });
   } catch (err) {
-    console.error("waitForResponse failed:", err);
+    console.error("[claude-remote-approver] Response listener failed:", err.message, "— Falling back to CLI.");
     return ASK;
   }
 
-  if (response.timeout || response.error) return ASK;
+  if (response.timeout) {
+    console.error("[claude-remote-approver] Timed out waiting for response. Falling back to CLI.");
+    return ASK;
+  }
+  if (response.error) {
+    console.error("[claude-remote-approver] Response error:", response.error.message, "— Falling back to CLI.");
+    return ASK;
+  }
   if (response.approved === false) return DENY;
   return { hookSpecificOutput: { hookEventName: "PermissionRequest", decision: { behavior: "allow" } } };
 }

package/src/ntfy.mjs

@@ -91,7 +91,7 @@ export async function waitForResponse({ server, topic, requestId, timeout }) {
     if (err?.name === "AbortError") {
       return { timeout: true };
     }
-    console.error("[claude-remote-approver] waitForResponse error:", err);
+    console.error("[claude-remote-approver] waitForResponse error:", err.message ?? err);
     return { error: err };
   }
 }