claude-plugin-viban 1.3.4 → 1.3.6

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "viban",
-  "version": "1.3.4",
+  "version": "1.3.6",
   "description": "Terminal Kanban TUI for AI-human collaborative issue tracking",
   "author": {
     "name": "happy-nut"

package/bin/viban

@@ -1526,13 +1526,17 @@ cmd_review() {
 
 cmd_done() {
     init_json
-    [[ -z "$1" ]] && { echo "Usage: viban done <id>"; exit 1; }
+    [[ -z "$1" ]] && { echo "Usage: viban done <id> [--remove]"; exit 1; }
+    local id="$1"
+    local remove=false
+    [[ "$2" == "--remove" ]] && remove=true
+
     # Cleanup worktree if exists
     local repo_root=$(git rev-parse --show-toplevel 2>/dev/null)
-    local wt_dir="$VIBAN_DATA_DIR/worktrees/$1"
+    local wt_dir="$VIBAN_DATA_DIR/worktrees/$id"
 
-    local branch="issue-$1"
-    local _ext_id=$(get_ext_id "$1")
+    local branch="issue-$id"
+    local _ext_id=$(get_ext_id "$id")
     if [[ -n "$_ext_id" && "$_ext_id" != "null" ]]; then
         local _issue_num="${_ext_id##*:}"
         if git -C "$repo_root" rev-parse --verify "issue-${_issue_num}" &>/dev/null 2>&1; then
@@ -1545,14 +1549,22 @@ cmd_done() {
         git -C "$repo_root" branch -D "$branch" 2>/dev/null
         echo "✓ worktree removed"
     fi
-    # Remove task (handle both string and number ID)
-    jq --argjson id "$1" 'del(.issues[]|select((.id|tonumber)==$id))' "$VIBAN_JSON" > "$VIBAN_JSON.tmp" && \
-    mv "$VIBAN_JSON.tmp" "$VIBAN_JSON"
 
-    # Clear iTerm2 session name
-    printf '\033]1;\007'
-
-    echo "✓ $(display_id "$1" "$(get_ext_id "$1")") completed & removed"
+    if $remove; then
+        # Delete card (old behavior)
+        jq --argjson id "$id" 'del(.issues[]|select((.id|tonumber)==$id))' \
+            "$VIBAN_JSON" > "$VIBAN_JSON.tmp" && mv "$VIBAN_JSON.tmp" "$VIBAN_JSON"
+        printf '\033]1;\007'
+        echo "✓ $(display_id "$id" "$(get_ext_id "$id")") completed & removed"
+    else
+        # Move to done status (non-destructive default)
+        local now=$(date -u +"%Y-%m-%dT%H:%M:%SZ")
+        jq --argjson id "$id" --arg now "$now" \
+            '(.issues[]|select((.id|tonumber)==$id)) |= . + {status:"done",assigned_to:null,updated_at:$now}' \
+            "$VIBAN_JSON" > "$VIBAN_JSON.tmp" && mv "$VIBAN_JSON.tmp" "$VIBAN_JSON"
+        printf '\033]1;\007'
+        echo "✓ $(display_id "$id" "$(get_ext_id "$id")") → done"
+    fi
 }
 
 cmd_get() { init_json; jq --argjson id "$1" '.issues[]|select((.id|tonumber)==$id)' "$VIBAN_JSON"; }
@@ -1673,7 +1685,7 @@ main() {
         attach) shift; cmd_attach "$@";;
         assign) cmd_assign "$2";;
         review) cmd_review "$2";;
-        done)   cmd_done "$2";;
+        done)   cmd_done "$2" "$3";;
         get)    cmd_get "$2";;
         edit)   [[ -z "$2" ]] && { echo "Usage: viban edit <id>"; exit 1; }; edit_issue "$2";;
         priority) cmd_priority "$2" "$3";;
@@ -1706,7 +1718,7 @@ main() {
             echo "  viban priority <id> <P0-P3>   Set priority"
             echo "  viban assign      Assign first backlog (by priority)"
             echo "  viban review      → Human Review"
-            echo "  viban done <id>   Complete & remove"
+            echo "  viban done <id> [--remove]   Complete (--remove to delete)"
             echo "  viban edit <id>   Edit task in editor"
             echo "  viban get <id>    Get task details (JSON)"
             echo "  viban migrate     Migrate: extract type from title"

package/docs/CLAUDE.md

@@ -278,7 +278,8 @@ viban list              # Display kanban board
 viban add "Title" "Desc" P2 feat  # Create issue
 viban assign [session]  # Assign top backlog issue
 viban review [id]       # Move issue to review
-viban done <id>         # Mark issue as done
+viban done <id>         # Mark issue as done (card stays on board)
+viban done <id> --remove  # Delete card permanently
 viban get <id>          # Get issue details (JSON)
 viban help              # Show help
 ```

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "claude-plugin-viban",
-  "version": "1.3.4",
+  "version": "1.3.6",
   "description": "Terminal Kanban TUI for AI-human collaborative issue tracking",
   "main": "bin/viban",
   "bin": {

package/skills/assign/SKILL.md

@@ -1,11 +1,11 @@
 ---
 name: assign
-description: "Assign first backlog issue — clarify if unclear, then finish"
+description: "Assign first backlog issue and resolve it through to review"
 ---
 
 # /assign
 
-Assign the first backlog issue. If the description is unclear or lacks context, interview the user and enrich the issue. **Do NOT start implementation.**
+Assign the first backlog issue and execute the full resolution workflow. If the description is unclear, interview the user first.
 
 > **CLI only** (no direct viban.json access)
 
@@ -24,7 +24,7 @@ done
 ```
 Look for `Issue Resolution Workflow` or `Workflow` section.
 
-If a workflow exists, follow its conventions for issue handling.
+If a workflow exists, **follow it exactly** — its pipeline, conventions, and stop points override the defaults below.
 
 ---
 
@@ -47,24 +47,11 @@ Display the issue title, description, priority, and type to the user.
 
 ## Step 3: Evaluate Clarity
 
-Assess whether the issue description provides enough context for someone to start working on it:
+Assess whether the issue description provides enough context to start working:
 
 - **Clear**: the symptom, affected area, and expected behavior are all understandable
 - **Unclear**: vague description, missing context, ambiguous scope, or multiple possible interpretations
 
-### If Clear
-
-Report the assignment and finish:
-
-```
-Issue #{id} assigned
-  Title: {title}
-  Priority: {priority} | Type: {type}
-  Status: in_progress
-
-Ready for work.
-```
-
 ### If Unclear
 
 Interview the user with AskUserQuestion to gather missing context. Ask about:
@@ -86,26 +73,50 @@ VIBAN_EOF
 # Re-add the issue with enriched description (edit via TUI or recreate)
 ```
 
-Then report:
+## Step 4: Execute Workflow
+
+Follow the workflow from Step 0. If no workflow was found, use this default pipeline:
+
+### 4.1 Analyze
+- Explore the codebase to understand the issue
+- Identify root cause and scope of change
+
+### 4.2 Implement
+- Create a branch: `git checkout -b issue-{ISSUE_ID}`
+- Make the fix/feature changes
+- Write or update tests as appropriate
 
+### 4.3 Verify
+- Run build and tests to confirm the fix works
+- Verify no regressions
+
+### 4.4 Ship
+- Commit with conventional message referencing the issue
+- Push and create a PR
+
+## Step 5: Move to Review
+
+After shipping (or at the workflow's stop point):
+
+```bash
+viban review $ISSUE_ID
 ```
-Issue #{id} assigned and clarified
-  Title: {title}
-  Priority: {priority} | Type: {type}
-  Status: in_progress
 
-Clarification added to issue description.
+Report completion:
+
+```
+Issue #{id} resolved → review
+  Title: {title}
+  PR: {pr_url}
 ```
 
 ---
 
 ## CRITICAL
 
-> - **NEVER read or write `viban.json` directly** — always use `viban` CLI commands (`viban assign`, `viban get`, `viban list`, etc.)
-> - **FORBIDDEN: `viban done`** — this DELETES the card permanently. NEVER run it.
-> - **FORBIDDEN: `viban review`** — the issue stays in `in_progress` for the next work session.
-> - This command **assigns only**. Do NOT create branches, write code, or start implementation.
-> - If the issue is clear, just report and finish immediately.
+> - **NEVER read or write `viban.json` directly** — always use `viban` CLI commands (`viban assign`, `viban get`, `viban list`, `viban done`, etc.)
+> - Always end with `viban review` (or `viban done` if the workflow specifies it).
+> - Respect workflow stop points — if the workflow says "stop before PR", stop there.
 
 ## CLI Reference
 
@@ -113,3 +124,6 @@ Clarification added to issue description.
 |---------|-------------|
 | `viban assign [session]` | Assign issue |
 | `viban get <id>` | View issue |
+| `viban done <id>` | Mark as done (non-destructive) |
+| `viban done <id> --remove` | Delete card permanently |
+| `viban review [id]` | Move to review |

package/skills/setup/SKILL.md

@@ -211,15 +211,15 @@ Ask only what the agent **cannot infer on its own**. One AskUserQuestion call, 3
   - "Stop before commit — I'll review the code first (review in terminal/IDE)"
 - multiSelect: false
 
-**Q2. Issue Numbering**
-- header: "Issue ID"
-- question: "How should issues be numbered when using `/viban:add`?"
+**Q2. Issue Tracker Sync**
+- header: "Sync"
+- question: "Sync issues with an external tracker (GitHub Issues, Jira, Linear, etc.)?"
 - options:
-  - "Auto — viban auto-assigns #1, #2, #3..."
-  - "Sync with provider — use `/viban:sync` to import from GitHub, Jira, Linear, etc."
-  - "Manual — ask for an external ID each time (e.g. PROJ-42, JIRA-123)"
+  - "Yes — set up two-way sync (issues imported from provider)"
+  - "No — auto-number locally (#1, #2, #3...)"
+  - "No — but use manual external IDs (e.g. PROJ-42)"
 - multiSelect: false
-- If user selects "Sync with provider", run `/viban:sync` to initialize sync after workflow setup completes.
+- If user selects "Yes", run `viban sync` to initialize sync after workflow setup completes.
 
 **Q3. Extra Rules**
 
@@ -302,12 +302,12 @@ Combine **auto-detected values** (Step 7) with **interview answers** (Step 8) to
 | Value | Source | Example |
 |-------|--------|---------|
 | Pipeline | Q1 | "Full auto" or "Stop before PR" |
-| Issue numbering | Q2 | "Auto" or "Manual" |
+| Issue tracker sync | Q2 | "Yes (sync)" or "No (auto)" or "No (manual IDs)" |
 | Extra rules | Q3 | User-typed rules or "None" |
 
 **Workflow generation principles:**
 - **Q1 (Pipeline) determines the entire automation structure** — which phases run automatically, where to stop, and whether to create PRs. "Full auto" = no stops + auto PR. "Stop before PR" = auto commit + user creates PR. "Stop before commit" = implement only + user reviews.
-- **Q2 (Issue numbering) determines how `/viban:add` handles IDs.** "Auto" = viban auto-assigns `#1`, `#2`. "Sync with provider" = use `/viban:sync` to import/sync issues from GitHub, Jira, Linear, etc. "Manual" = agent asks for an external ID each time and passes `--ext-id` to `viban add`. When manual, commits/PRs reference the external ID instead of `#N`.
+- **Q2 (Issue tracker sync) determines how issues are managed.** "Yes" = run `viban sync` after setup to import/sync issues from external tracker (GitHub, Jira, Linear, etc.), IDs come from provider. "No — auto-number" = viban auto-assigns `#1`, `#2`. "No — manual IDs" = agent asks for an external ID each time and passes `--ext-id` to `viban add`. When manual, commits/PRs reference the external ID instead of `#N`.
 - **Q3 (Extra rules) is appended verbatim to the Additional Rules section.** If user mentions conventions, evidence, CHANGELOG, language, etc., incorporate into the relevant phase.
 - **Commit/PR conventions are auto-detected from git history** (Step 7.2). If the user overrides via Q3, use the user's preference instead.
 - **Everything else uses smart defaults.** Analysis depth, implementation approach, quality gates, verification methods, issue numbering, post-merge — all auto-determined by the agent or set to sensible defaults.
@@ -413,7 +413,7 @@ If build/test fails: fix errors, return to Phase 3.
 
 ## Issue Management
 
-- Issue numbering: {FROM Q2: "Auto" = auto-increment (viban default), "Sync with provider" = use `/viban:sync` for external tracker integration, "Manual" = ask for external ID via `--ext-id` flag}
+- Issue tracking: {FROM Q2: "Yes" = synced with external tracker via `viban sync`, "No — auto-number" = auto-increment (viban default), "No — manual IDs" = ask for external ID via `--ext-id` flag}
 - Test evidence: include test output in PR body
 - Post-merge: auto-close issue (`viban done {id}`), delete branch