claude-notification-plugin 1.0.112 → 1.0.115

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "claude-notification-plugin",
-  "version": "1.0.112",
+  "version": "1.0.115",
   "description": "Claude Code task-completion notifications: Telegram, desktop notifications (Windows/macOS/Linux), sound, and voice",
   "author": {
     "name": "Viacheslav Makarov",

package/bin/install.js

@@ -107,10 +107,14 @@ function stopListenerIfRunning () {
   let stopped = false;
   const pidFromFile = (() => {
     try {
-      if (!fs.existsSync(pidFile)) return null;
+      if (!fs.existsSync(pidFile)) {
+        return null;
+      }
       const pid = parseInt(fs.readFileSync(pidFile, 'utf-8').trim(), 10);
       return Number.isInteger(pid) && pid > 0 ? pid : null;
-    } catch { return null; }
+    } catch {
+      return null; 
+    }
   })();
 
   if (pidFromFile && killProcessTree(pidFromFile)) {
@@ -398,24 +402,15 @@ async function fetchChatId (token) {
   return null;
 }
 
-function addHook (settings, event) {
+function removeHook (settings, event) {
   if (!settings.hooks[event]) {
-    settings.hooks[event] = [];
+    return;
   }
-
-  const exists = settings.hooks[event].some((matcher) =>
-    matcher.hooks?.some((h) => h.command?.includes(HOOK_COMMAND)),
+  settings.hooks[event] = settings.hooks[event].filter((matcher) =>
+    !matcher.hooks?.some((h) => h.command?.includes(HOOK_COMMAND)),
   );
-
-  if (!exists) {
-    settings.hooks[event].push({
-      hooks: [
-        {
-          type: 'command',
-          command: HOOK_COMMAND,
-        },
-      ],
-    });
+  if (settings.hooks[event].length === 0) {
+    delete settings.hooks[event];
   }
 }
 
@@ -595,16 +590,17 @@ Send any message to your bot in Telegram, then press Enter.\x1b[0m`);
     }
   }
 
-  settings.hooks = settings.hooks || {};
-
-  addHook(settings, 'UserPromptSubmit');
-  addHook(settings, 'Stop');
-  addHook(settings, 'Notification');
-
   // Register plugin as enabled
   settings.enabledPlugins = settings.enabledPlugins || {};
   settings.enabledPlugins[PLUGIN_KEY] = true;
 
+  // When the plugin is enabled, Claude Code loads hooks from hooks/hooks.json automatically.
+  // Remove any duplicate hooks from settings.json to avoid double notifications.
+  settings.hooks = settings.hooks || {};
+  removeHook(settings, 'UserPromptSubmit');
+  removeHook(settings, 'Stop');
+  removeHook(settings, 'Notification');
+
   // Register marketplace
   settings.extraKnownMarketplaces = settings.extraKnownMarketplaces || {};
   settings.extraKnownMarketplaces[MARKETPLACE_KEY] = {
@@ -635,7 +631,7 @@ Send any message to your bot in Telegram, then press Enter.\x1b[0m`);
   console.log(`
 Installed!
 ${listenerLine}
-Hooks registered:
+Plugin hooks (via hooks/hooks.json):
   - UserPromptSubmit (start timer)
   - Stop (task finished)
   - Notification (waiting for input)

package/bin/listener-cli.js

@@ -278,6 +278,91 @@ function ask (rl, question) {
   });
 }
 
+function askYesNo (rl, question) {
+  return new Promise((resolve) => {
+    rl.question(question, (answer) => {
+      const a = answer.trim().toLowerCase();
+      resolve(a === 'y' || a === 'yes');
+    });
+  });
+}
+
+function isValidPath (p) {
+  if (!p || p.includes('\0')) {
+    return false;
+  }
+  try {
+    path.resolve(p);
+    return true;
+  } catch {
+    return false;
+  }
+}
+
+function ensureDir (dirPath) {
+  try {
+    fs.mkdirSync(dirPath, { recursive: true });
+    return fs.existsSync(dirPath);
+  } catch {
+    return false;
+  }
+}
+
+function isValidAlias (alias) {
+  return /^[a-zA-Z0-9_-]+$/.test(alias);
+}
+
+function parsePositiveInt (str, fallback) {
+  if (!str) {
+    return fallback;
+  }
+  const n = parseInt(str, 10);
+  if (isNaN(n) || n <= 0) {
+    console.log(`  \u26a0 Invalid value "${str}". Using default: ${fallback}`);
+    return fallback;
+  }
+  return n;
+}
+
+function validateDir (inputPath, defaultPath) {
+  const chosen = inputPath || defaultPath;
+  if (!isValidPath(chosen)) {
+    console.log(`  \u26a0 Invalid path "${chosen}". Using default: ${defaultPath}`);
+    if (!ensureDir(defaultPath)) {
+      console.log(`  \u26a0 Cannot create "${defaultPath}". Please check permissions.`);
+    }
+    return defaultPath;
+  }
+  if (!ensureDir(chosen)) {
+    console.log(`  \u26a0 Cannot create "${chosen}". Using default: ${defaultPath}`);
+    ensureDir(defaultPath);
+    return defaultPath;
+  }
+  return chosen;
+}
+
+async function validateProjectPath (rl, inputPath) {
+  if (!inputPath) {
+    return null;
+  }
+  if (!isValidPath(inputPath)) {
+    console.log('  \u26a0 Invalid path. Project will not be set.');
+    return null;
+  }
+  const resolved = path.resolve(inputPath);
+  if (fs.existsSync(resolved) && fs.statSync(resolved).isDirectory()) {
+    return resolved;
+  }
+  const create = await askYesNo(rl, `  Directory "${resolved}" does not exist. Create it? (y/n): `);
+  if (create) {
+    if (ensureDir(resolved)) {
+      return resolved;
+    }
+    console.log(`  \u26a0 Cannot create "${resolved}".`);
+  }
+  return null;
+}
+
 async function setupListener () {
   let config = {};
   if (fs.existsSync(CONFIG_FILE)) {
@@ -313,33 +398,114 @@ Listener Setup
 Press Enter to keep current value shown in [brackets].
 `);
 
-  const worktreeBaseDir = await ask(rl, `Worktree base dir [${defaults.worktreeBaseDir}]: `) || defaults.worktreeBaseDir;
-  const taskTimeoutStr = await ask(rl, `Task timeout, minutes [${defaults.taskTimeoutMinutes}]: `) || String(defaults.taskTimeoutMinutes);
-  const maxQueueStr = await ask(rl, `Max queue per work dir [${defaults.maxQueuePerWorkDir}]: `) || String(defaults.maxQueuePerWorkDir);
-  const maxTotalStr = await ask(rl, `Max total tasks [${defaults.maxTotalTasks}]: `) || String(defaults.maxTotalTasks);
-  const logDir = await ask(rl, `Log dir [${defaults.logDir}]: `) || defaults.logDir;
-  const taskLogDir = await ask(rl, `Task log dir [${defaults.taskLogDir}]: `) || defaults.taskLogDir;
-  const projectPath = await ask(rl, `Default project path [${defaults.projectPath || '(none)'}]: `) || defaults.projectPath;
+  // --- Directories ---
+  const worktreeInput = await ask(rl, `Worktree base dir [${defaults.worktreeBaseDir}]: `);
+  L.worktreeBaseDir = validateDir(worktreeInput, defaults.worktreeBaseDir);
 
-  rl.close();
+  const logDirInput = await ask(rl, `Log dir [${defaults.logDir}]: `);
+  L.logDir = validateDir(logDirInput, defaults.logDir);
+
+  const taskLogDirInput = await ask(rl, `Task log dir [${defaults.taskLogDir}]: `);
+  L.taskLogDir = validateDir(taskLogDirInput, defaults.taskLogDir);
+
+  // --- Numeric params ---
+  const taskTimeoutStr = await ask(rl, `Task timeout, minutes [${defaults.taskTimeoutMinutes}]: `);
+  L.taskTimeoutMinutes = parsePositiveInt(taskTimeoutStr, defaults.taskTimeoutMinutes);
+
+  const maxQueueStr = await ask(rl, `Max queue per work dir [${defaults.maxQueuePerWorkDir}]: `);
+  L.maxQueuePerWorkDir = parsePositiveInt(maxQueueStr, defaults.maxQueuePerWorkDir);
+
+  const maxTotalStr = await ask(rl, `Max total tasks [${defaults.maxTotalTasks}]: `);
+  L.maxTotalTasks = parsePositiveInt(maxTotalStr, defaults.maxTotalTasks);
 
-  L.worktreeBaseDir = worktreeBaseDir;
-  L.taskTimeoutMinutes = parseInt(taskTimeoutStr, 10) || defaults.taskTimeoutMinutes;
-  L.maxQueuePerWorkDir = parseInt(maxQueueStr, 10) || defaults.maxQueuePerWorkDir;
-  L.maxTotalTasks = parseInt(maxTotalStr, 10) || defaults.maxTotalTasks;
-  L.logDir = logDir;
-  L.taskLogDir = taskLogDir;
+  // --- Default project ---
+  console.log('');
+  const projectInput = await ask(rl, `Default project path [${defaults.projectPath || '(none)'}]: `);
+  const rawProjectPath = projectInput || defaults.projectPath;
 
-  if (projectPath) {
-    L.projects = L.projects || {};
-    L.projects.default = L.projects.default || {};
-    L.projects.default.path = projectPath;
+  L.projects = L.projects || {};
+  let hasValidProject = false;
+
+  if (rawProjectPath) {
+    const validatedPath = await validateProjectPath(rl, rawProjectPath);
+    if (validatedPath) {
+      L.projects.default = L.projects.default || {};
+      L.projects.default.path = validatedPath;
+      hasValidProject = true;
+    } else {
+      delete L.projects.default;
+      console.log('  \u26a0 Default project will not be set. Listener will not start without at least one project.');
+    }
+  } else {
+    delete L.projects.default;
+    console.log('  \u26a0 No default project configured. Listener will not start without at least one project.');
+  }
+
+  // --- Additional projects loop ---
+  // Count existing non-default projects
+  const existingAliases = Object.keys(L.projects).filter(a => a !== 'default');
+  if (existingAliases.length > 0) {
+    console.log(`\nExisting projects: ${existingAliases.join(', ')}`);
   }
 
+  while (true) {
+    console.log('');
+    const addMore = await askYesNo(rl, 'Add another project? (y/n): ');
+    if (!addMore) {
+      break;
+    }
+
+    // Ask alias with validation loop
+    let alias = '';
+    while (true) {
+      alias = await ask(rl, 'Project alias: ');
+      if (!alias) {
+        console.log('  \u26a0 Alias cannot be empty.');
+        continue;
+      }
+      if (alias === 'default') {
+        console.log('  \u26a0 "default" is reserved. Choose a different name.');
+        continue;
+      }
+      if (!isValidAlias(alias)) {
+        console.log('  \u26a0 Invalid alias. Allowed characters: a-z, A-Z, 0-9, -, _');
+        continue;
+      }
+      if (L.projects[alias]) {
+        console.log(`  \u26a0 Alias "${alias}" already exists. Choose a different name.`);
+        continue;
+      }
+      break;
+    }
+
+    // Ask path with validation
+    const projPathInput = await ask(rl, `Project path for "${alias}": `);
+    if (!projPathInput) {
+      console.log(`  \u26a0 Project "${alias}" was not added (no path provided).`);
+      continue;
+    }
+
+    const validatedProjPath = await validateProjectPath(rl, projPathInput);
+    if (validatedProjPath) {
+      L.projects[alias] = { path: validatedProjPath };
+      hasValidProject = true;
+      console.log(`  \u2713 Project "${alias}" added: ${validatedProjPath}`);
+    } else {
+      console.log(`  \u26a0 Project "${alias}" was not added (invalid path).`);
+    }
+  }
+
+  rl.close();
+
   fs.writeFileSync(CONFIG_FILE, JSON.stringify(config, null, 2));
 
-  console.log(`
-Listener config saved to ${CONFIG_FILE}
-Run "claude-notify listener start" to apply.
-`);
+  const projectCount = Object.keys(L.projects).length;
+  console.log(`\nListener config saved to ${CONFIG_FILE}`);
+  if (hasValidProject || projectCount > 0) {
+    console.log('Run "claude-notify listener start" to apply.');
+  } else {
+    console.log('\u26a0 No projects configured. Listener will not start until at least one project is added.');
+    console.log('Run "claude-notify listener setup" again to add projects.');
+  }
+  console.log('');
 }

package/commit-sha

@@ -1 +1 @@
-f6763248ba170bad2656ef697ffc4710bbf6636c
+02ac0d7e44dac4ff0bb58a912fa8c92825f90cf4

package/listener/listener.js

@@ -51,10 +51,40 @@ if (!token || !chatId) {
 
 if (!config.listener?.projects || Object.keys(config.listener.projects).length === 0) {
   logger.error('No projects defined in config.listener.projects');
-  console.error('No projects defined in config.listener.projects');
+  console.error('No projects defined in config.listener.projects. Run "claude-notify listener setup" to configure.');
   process.exit(1);
 }
 
+// Validate project paths — skip projects with missing/invalid directories
+const validatedProjects = {};
+for (const [alias, proj] of Object.entries(config.listener.projects)) {
+  const projPath = typeof proj === 'string' ? proj : proj?.path;
+  if (!projPath) {
+    logger.warn(`Project "${alias}": no path configured, skipping`);
+    console.error(`\u26a0 Project "${alias}": no path configured, skipping`);
+    continue;
+  }
+  try {
+    const stat = fs.statSync(projPath);
+    if (!stat.isDirectory()) {
+      logger.warn(`Project "${alias}": path "${projPath}" is not a directory, skipping`);
+      console.error(`\u26a0 Project "${alias}": path "${projPath}" is not a directory, skipping`);
+      continue;
+    }
+    validatedProjects[alias] = proj;
+  } catch {
+    logger.warn(`Project "${alias}": path "${projPath}" does not exist, skipping`);
+    console.error(`\u26a0 Project "${alias}": path "${projPath}" does not exist, skipping`);
+  }
+}
+
+if (Object.keys(validatedProjects).length === 0) {
+  logger.error('No projects with valid paths found in config.listener.projects');
+  console.error('No projects with valid paths found. Run "claude-notify listener setup" to configure.');
+  process.exit(1);
+}
+
+config.listener.projects = validatedProjects;
 const listenerConfig = config.listener;
 const taskTimeoutMinutes = listenerConfig.taskTimeoutMinutes || 30;
 const taskTimeout = taskTimeoutMinutes * 60_000;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "claude-notification-plugin",
   "productName": "claude-notification-plugin",
-  "version": "1.0.112",
+  "version": "1.0.115",
   "description": "Claude Code task-completion notifications: Telegram, desktop notifications (Windows/macOS/Linux), sound, and voice",
   "type": "module",
   "engines": {