claude-memory-admin 1.9.0 → 1.10.1

package/public/views/tools.mjs

@@ -15,6 +15,7 @@ const PANELS = {
 };
 
 const installed = () => state.tools.filter((tool) => tool.found && PANELS[tool.id]);
+const missing = () => state.tools.filter((tool) => !tool.found && PANELS[tool.id]);
 
 const openKey = (id) => `toolOpen:${id}`;
 const isOpen = (id) => localStorage.getItem(openKey(id)) === '1';
@@ -126,19 +127,46 @@ function accordion(container, tool, slot) {
   container.append(panel);
 }
 
+function notInstalled(container, tool) {
+  container.append(node('div', { class: ui.contextRowStatic }, [
+    node('div', { class: ui.contextMain }, [
+      node('div', { class: ui.contextFile, text: tool.label }),
+    ]),
+    node('div', { class: ui.contextSize, text: 'not installed' }),
+  ]));
+
+  container.append(node('div', { class: ui.toolMissingBody }, [
+    node('p', { class: ui.noteTight, text: tool.blurb }),
+    node('a', {
+      class: ui.linkButton,
+      href: tool.repo,
+      target: '_blank',
+      rel: 'noopener noreferrer',
+      text: 'View on GitHub \u2197',
+    }),
+  ]));
+}
+
 export function renderTools(container) {
-  const tools = installed();
-  if (!tools.length) return;
+  const found = installed();
+  const absent = missing();
+  if (!found.length && !absent.length) return;
 
-  if (!state.aux.tools && localStorage.getItem(OPT_IN) === '1') start({ remember: false });
-  if (!state.aux.tools) return gate(container, tools);
+  if (found.length && !state.aux.tools && localStorage.getItem(OPT_IN) === '1') start({ remember: false });
+  const opted = Boolean(state.aux.tools);
 
-  container.append(node('div', { class: ui.listBar }, [
+  const bar = [
     node('span', { class: ui.sectionLabelInline, text: 'Companion tools' }),
     node('span', { class: ui.listSpacer }),
-    node('button', { class: ui.buttonSmall, text: 'Re-read', onclick: readAll }),
-    node('button', { class: ui.buttonSmall, text: 'Turn off', onclick: turnOff }),
-  ]));
+  ];
+  if (found.length && opted) {
+    bar.push(node('button', { class: ui.buttonSmall, text: 'Re-read', onclick: readAll }));
+    bar.push(node('button', { class: ui.buttonSmall, text: 'Turn off', onclick: turnOff }));
+  }
+  container.append(node('div', { class: ui.listBar }, bar));
+
+  if (found.length && !opted) gate(container, found);
+  else for (const tool of found) accordion(container, tool, state.aux.tools[tool.id]);
 
-  for (const tool of tools) accordion(container, tool, state.aux.tools[tool.id]);
+  for (const tool of absent) notInstalled(container, tool);
 }

package/server.mjs

@@ -12,6 +12,8 @@ import { projectsRoot, resolveRoot } from './src/projects.mjs';
 import { buildStore } from './src/model.mjs';
 import { resolveGlobalInstructions, resolveInstructions, summarise } from './src/instructions.mjs';
 import { settingsReport, summariseSettings } from './src/settings.mjs';
+import { costReport, writeUserSetting } from './src/cost.mjs';
+import { AGENTS_DIR, AGENT_FIELDS, agentsDirExists, listAgents, setAgentField } from './src/agents.mjs';
 import { listStores } from './src/stores.mjs';
 import { forgetPath, rememberPath } from './src/pathcache.mjs';
 import { searchAll } from './src/search.mjs';
@@ -147,15 +149,23 @@ function storeProjectDir(store) {
 
 /**
  * The global store holds instructions, not memory, and its directory is ~/.claude
- * itself. Every write endpoint below resolves a target inside `store.dir`, so
- * without this guard a delete aimed at it would land on the user's CLAUDE.md and
- * settings rather than on a memory file. It is read-only, and refused here once
- * rather than in each of the fifteen handlers.
+ * itself. Every memory write endpoint below resolves a target inside `store.dir`,
+ * so without this guard a delete aimed at it would land on the user's CLAUDE.md
+ * and settings rather than on a memory file. It is refused here once rather than
+ * in each of the fifteen handlers.
+ *
+ * The Cost handlers are the two exceptions, and the only writes this app makes
+ * outside a memory store. They do not take a path from the request at all: one
+ * writes an allowlisted key to ~/.claude/settings.json, the other one of two
+ * frontmatter fields in a named file inside ~/.claude/agents. Neither can reach
+ * an instruction file, which is what the rest of this guard exists to protect.
  */
-export function refuseWritesToGlobal(store, method) {
-  if (store.kind === 'global' && method !== 'GET') {
-    throw new Error('The global store is read-only: it holds instruction files, not memory.');
-  }
+const GLOBAL_WRITE_ACTIONS = new Set(['cost/setting', 'cost/agent']);
+
+export function refuseWritesToGlobal(store, method, action = null) {
+  if (store.kind !== 'global' || method === 'GET') return;
+  if (action && GLOBAL_WRITE_ACTIONS.has(action)) return;
+  throw new Error('The global store is read-only: it holds instruction files, not memory.');
 }
 
 /** A store with nothing to build a memory model from, in the shape the frontend expects. */
@@ -260,9 +270,9 @@ async function handleApi(req, res, url) {
   }
 
   const store = requireStore(decodeURIComponent(segments[2]));
-  refuseWritesToGlobal(store, req.method);
-  const dir = store.dir;
   const action = segments.slice(3).join('/');
+  refuseWritesToGlobal(store, req.method, action);
+  const dir = store.dir;
 
   if (!action && req.method === 'GET') {
     // buildStore reads every .md in the directory as a memory file, which for
@@ -312,6 +322,34 @@ async function handleApi(req, res, url) {
     return sendJson(res, 200, settingsReport({ projectDir: storeProjectDir(store) }));
   }
 
+  // The Cost segment. User scope only: the knobs it writes are about every
+  // session on the machine, and the file it writes them to is ~/.claude/settings.json.
+  if ((action === 'cost' || action.startsWith('cost/')) && store.kind !== 'global') {
+    return sendJson(res, 400, { error: 'The cost settings are user-scope, and are edited from the Global entry.' });
+  }
+
+  if (action === 'cost' && req.method === 'GET') {
+    return sendJson(res, 200, {
+      settings: costReport(),
+      agents: listAgents(),
+      agentsDir: AGENTS_DIR,
+      agentsDirExists: agentsDirExists(),
+      agentFields: AGENT_FIELDS,
+    });
+  }
+
+  if (action === 'cost/setting' && req.method === 'POST') {
+    const body = await readBody(req);
+    writeUserSetting(body.key, body.value ?? null);
+    return sendJson(res, 200, { settings: costReport() });
+  }
+
+  if (action === 'cost/agent' && req.method === 'POST') {
+    const body = await readBody(req);
+    const agents = setAgentField(body.file, body.field, body.value ?? null);
+    return sendJson(res, 200, { agents, agentsDir: AGENTS_DIR, agentsDirExists: agentsDirExists() });
+  }
+
   if (action === 'delete-preview' && req.method === 'POST') {
     const body = await readBody(req);
     return sendJson(res, 200, deletePreview(dir, body.file));

package/src/agents.mjs

@@ -0,0 +1,268 @@
+// User-scope subagent definitions: ~/.claude/agents/*.md.
+//
+// Not to be confused with ~/.claude/agent-memory (src/stores.mjs), which is what
+// those agents *remember*. This module is about what they *are*: a markdown file
+// whose frontmatter names the agent and, optionally, pins the model and effort
+// it runs at. Pinning a summariser to Haiku while a reviewer stays on Opus is the
+// finer-grained version of the CLAUDE_CODE_SUBAGENT_MODEL switch in src/cost.mjs,
+// which - worth remembering when both are set - outranks everything here.
+//
+// Only `model` and `effort` are writable. The prompt body, the tool lists and
+// every other field are read and shown but never rewritten: a body is prose
+// somebody wrote on purpose, and this tool has no view on it.
+
+import fs from 'node:fs';
+import os from 'node:os';
+import path from 'node:path';
+
+import { parseFrontmatter } from './parse.mjs';
+import { writeFileAtomic } from './mutate.mjs';
+
+export const AGENTS_DIR = path.join(os.homedir(), '.claude', 'agents');
+
+const MODEL_ID = /^claude-[A-Za-z0-9._[\]-]+$/;
+
+export const AGENT_FIELDS = {
+  model: {
+    unset: 'inherit',
+    allowModelId: true,
+    options: [
+      { value: null, label: 'inherit', note: 'the session model' },
+      { value: 'haiku', label: 'haiku' },
+      { value: 'sonnet', label: 'sonnet' },
+      { value: 'opus', label: 'opus' },
+      { value: 'fable', label: 'fable' },
+    ],
+  },
+  effort: {
+    unset: 'default',
+    allowModelId: false,
+    options: [
+      { value: null, label: 'default', note: 'the session effort' },
+      { value: 'low', label: 'low' },
+      { value: 'medium', label: 'medium' },
+      { value: 'high', label: 'high' },
+      { value: 'xhigh', label: 'xhigh' },
+      { value: 'max', label: 'max' },
+    ],
+  },
+};
+
+export const AGENT_PROBLEM_SEVERITY = {
+  'no-frontmatter': 'bad',
+  'missing-name': 'warn',
+  'missing-description': 'warn',
+  'name-mismatch': 'warn',
+  'unknown-model': 'warn',
+  'unknown-effort': 'warn',
+};
+
+function known(field, value) {
+  const spec = AGENT_FIELDS[field];
+  if (spec.options.some((option) => option.value === value)) return true;
+  return spec.allowModelId && MODEL_ID.test(value);
+}
+
+/**
+ * A filename this module is willing to touch, resolved inside the agents
+ * directory. The same shape as safeMemoryPath in src/mutate.mjs: a bare .md
+ * basename, no dotfiles, and a realpath check so a symlink cannot point the
+ * write somewhere else.
+ */
+export function safeAgentPath(dir, file) {
+  if (typeof file !== 'string' || !file || file.includes('\0')) {
+    throw new Error('Invalid filename');
+  }
+  if (file !== path.basename(file) || file.startsWith('.') || !file.endsWith('.md')) {
+    throw new Error(`Refusing to touch "${file}": must be a plain .md filename`);
+  }
+
+  const full = path.join(dir, file);
+  const rel = path.relative(dir, full);
+  if (rel.startsWith('..') || path.isAbsolute(rel)) {
+    throw new Error('Path escapes the agents directory');
+  }
+  if (fs.existsSync(full)) {
+    const realDir = fs.realpathSync(dir);
+    const realFull = fs.realpathSync(full);
+    if (path.relative(realDir, realFull).startsWith('..')) {
+      throw new Error('Path escapes the agents directory');
+    }
+  }
+  return full;
+}
+
+function describeAgent(dir, file) {
+  const full = path.join(dir, file);
+  const stem = file.replace(/\.md$/, '');
+
+  let text;
+  try {
+    text = fs.readFileSync(full, 'utf8');
+  } catch (err) {
+    return {
+      file,
+      name: stem,
+      description: '',
+      tools: '',
+      model: null,
+      effort: null,
+      bytes: 0,
+      problems: [{ kind: 'no-frontmatter', severity: 'bad', detail: err.message }],
+    };
+  }
+
+  const { data, hasFrontmatter } = parseFrontmatter(text);
+  const scalar = (key) => (typeof data[key] === 'string' ? data[key].trim() : '');
+  const name = scalar('name') || stem;
+  const model = scalar('model') || null;
+  const effort = scalar('effort') || null;
+
+  const problems = [];
+  const flag = (kind, detail) => problems.push({ kind, severity: AGENT_PROBLEM_SEVERITY[kind], detail });
+
+  if (!hasFrontmatter) {
+    flag('no-frontmatter', 'The file has no --- frontmatter block, so Claude Code does not read it as an agent definition.');
+  } else {
+    if (!scalar('name')) flag('missing-name', `No name: field, so the agent is addressed as "${stem}" after its file.`);
+    if (!scalar('description')) flag('missing-description', 'No description: field. Claude decides when to delegate from that description, so an agent without one is never chosen on its own.');
+    if (scalar('name') && scalar('name') !== stem) flag('name-mismatch', `Named "${scalar('name')}" in a file called "${file}".`);
+    if (model && !known('model', model)) flag('unknown-model', `model: ${model} is neither an alias nor a claude- model name.`);
+    if (effort && !known('effort', effort)) flag('unknown-effort', `effort: ${effort} is not one of low, medium, high, xhigh or max.`);
+  }
+
+  return {
+    file,
+    name,
+    description: scalar('description'),
+    tools: scalar('tools'),
+    model,
+    effort,
+    bytes: Buffer.byteLength(text, 'utf8'),
+    problems,
+  };
+}
+
+/**
+ * Every user-scope agent definition. A directory that is not there is the
+ * ordinary state of a machine whose owner has never written one, not a failure,
+ * so it answers with an empty list.
+ */
+export function listAgents({ dir = AGENTS_DIR } = {}) {
+  let entries;
+  try {
+    entries = fs.readdirSync(dir, { withFileTypes: true });
+  } catch {
+    return [];
+  }
+
+  return entries
+    .filter((entry) => entry.isFile() && entry.name.endsWith('.md') && !entry.name.startsWith('.'))
+    .map((entry) => describeAgent(dir, entry.name))
+    .sort((a, b) => a.name.localeCompare(b.name));
+}
+
+/** Whether the directory itself exists, which is what tells an empty list from a missing one. */
+export function agentsDirExists({ dir = AGENTS_DIR } = {}) {
+  try {
+    return fs.statSync(dir).isDirectory();
+  } catch {
+    return false;
+  }
+}
+
+const fieldLine = (field) => new RegExp(`^${field}[ \\t]*:`);
+
+/**
+ * Where a field that is not there yet should go: straight after the name or
+ * description when that line carries its value inline, and otherwise at the end
+ * of the block. Appending is always valid - a top-level key ends whatever nested
+ * block preceded it - so the nicer placement is only taken when it is provably
+ * safe, which rules out a folded or block scalar the insertion would land inside.
+ */
+function inlineScalarAt(block, key) {
+  const index = block.findIndex((line) => fieldLine(key).test(line));
+  if (index === -1) return -1;
+  const rest = block[index].slice(block[index].indexOf(':') + 1).trim();
+  if (!rest || rest.startsWith('|') || rest.startsWith('>')) return -1;
+  return index;
+}
+
+function insertionIndex(block) {
+  const description = block.findIndex((line) => fieldLine('description').test(line));
+  const inline = inlineScalarAt(block, 'description');
+  if (inline !== -1) return inline + 1;
+  if (description !== -1) return block.length;
+
+  const name = inlineScalarAt(block, 'name');
+  return name === -1 ? block.length : name + 1;
+}
+
+/**
+ * Rewrite one frontmatter field, leaving every other byte of the file alone:
+ * the body, the other fields, their order, their spacing and any comments among
+ * them. The same principle src/parse.mjs applies to MEMORY.md - edit the line
+ * that changed, never re-emit the document from a parse of it.
+ */
+export function rewriteAgentField(text, field, value) {
+  const lines = text.split('\n');
+  if (lines[0]?.trim() !== '---') {
+    throw new Error('This file has no frontmatter block, so there is nothing to set.');
+  }
+
+  let end = -1;
+  for (let i = 1; i < lines.length; i++) {
+    if (lines[i].trim() === '---') { end = i; break; }
+  }
+  if (end === -1) {
+    throw new Error('This file has an unterminated frontmatter block.');
+  }
+
+  const block = lines.slice(1, end);
+  const at = block.findIndex((line) => fieldLine(field).test(line));
+
+  if (value === null) {
+    if (at === -1) return text;
+    block.splice(at, 1);
+  } else if (at === -1) {
+    block.splice(insertionIndex(block), 0, `${field}: ${value}`);
+  } else {
+    block[at] = `${field}: ${value}`;
+  }
+
+  return [lines[0], ...block, ...lines.slice(end)].join('\n');
+}
+
+function normaliseAgentValue(field, value) {
+  const spec = AGENT_FIELDS[field];
+  if (value === null || value === undefined) return null;
+  if (typeof value !== 'string') throw new Error(`${field} takes a string, not ${typeof value}.`);
+
+  const trimmed = value.trim();
+  if (!trimmed || trimmed === spec.unset) return null;
+  if (known(field, trimmed)) return trimmed;
+
+  throw new Error(`"${trimmed}" is not a value ${field} accepts.`);
+}
+
+/**
+ * Set or clear `model` or `effort` on one agent file, atomically, and answer with
+ * the refreshed list so the caller renders what is on disk rather than what it
+ * hoped it wrote.
+ */
+export function setAgentField(file, field, value, { dir = AGENTS_DIR } = {}) {
+  if (!Object.prototype.hasOwnProperty.call(AGENT_FIELDS, field)) {
+    throw new Error(`"${field}" is not a field this tool writes. Only model and effort are editable here.`);
+  }
+
+  const full = safeAgentPath(dir, file);
+  if (!fs.existsSync(full)) throw new Error(`${file} is no longer there - reload and try again.`);
+
+  const next = normaliseAgentValue(field, value);
+  const original = fs.readFileSync(full, 'utf8');
+  const rewritten = rewriteAgentField(original, field, next);
+
+  if (rewritten !== original) writeFileAtomic(dir, file, rewritten);
+
+  return listAgents({ dir });
+}