claude-mem-lite 6.7.1 → 6.7.2

package/.claude-plugin/marketplace.json

@@ -9,7 +9,7 @@
   "plugins": [
     {
       "name": "claude-mem-lite",
-      "version": "6.7.1",
+      "version": "6.7.2",
       "source": "./",
       "homepage": "https://github.com/sdsrss/claude-mem-lite",
       "description": "Persistent long-term memory for Claude Code via MCP — captures coding decisions, bugfixes, and context across sessions. Hybrid FTS5 + TF-IDF search with episode batching. Single SQLite DB, no external services. A lighter, lower-cost alternative to claude-mem (episode batching + a smaller model; cost savings are an internal estimate, not a measured benchmark)."

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "claude-mem-lite",
-  "version": "6.7.1",
+  "version": "6.7.2",
   "description": "Persistent long-term memory for Claude Code via MCP — captures coding decisions, bugfixes, and context across sessions. Hybrid FTS5 + TF-IDF search with episode batching. Single SQLite DB, no external services. A lighter, lower-cost alternative to claude-mem (episode batching + a smaller model; cost savings are an internal estimate, not a measured benchmark).",
   "author": {
     "name": "sdsrss"

package/lib/file-edge-match.mjs

@@ -213,6 +213,26 @@ export function rankFileCandidates(files) {
     .map((x) => x.f);
 }
 
+/**
+ * The path a tool-use touched, whichever key the tool spells it with.
+ *
+ * `Edit` / `Write` / `Read` carry `file_path`; `NotebookEdit` carries
+ * `notebook_path` and NEVER `file_path`. That one rule had three separate
+ * spellings in this repo (an inline `??` in each recall script, a regex
+ * alternation in lib/hook-stdin.mjs) and a FOURTH site that simply did not know
+ * it — lib/import-jsonl.mjs gated its file edges on `file_path` alone, so every
+ * imported notebook edit built no (obs,file) edge at all and was unreachable
+ * through the recall path this module exists to serve. A second copy is exactly
+ * what produced R12 B-1; this is the home.
+ *
+ * @param {object|null|undefined} input a tool-use `input` / `tool_input` object
+ * @returns {string|undefined} the path, or undefined when the shape carries none
+ */
+export function toolEditPath(input) {
+  if (!input || typeof input !== 'object') return undefined;
+  return input.file_path ?? input.notebook_path;
+}
+
 /** Bind values for fileMatchClause, in placeholder order. */
 export function fileMatchParams(filePath) {
   const fname = basenameAnySep(filePath);

package/lib/import-jsonl.mjs

@@ -18,6 +18,8 @@ import { readFileSync, statSync } from 'fs';
 import { createHash } from 'crypto';
 import { scrubSecrets } from '../secret-scrub.mjs';
 import { scrubRecord } from './scrub-record.mjs';
+import { toolEditPath } from './file-edge-match.mjs';
+import { insertObservationFiles } from './observation-write.mjs';
 
 const TOOL_TO_TYPE = {
   Edit: 'change',
@@ -130,11 +132,16 @@ function importToolPair(db, toolUse, toolResult, project) {
       ? toolResult.content
       : JSON.stringify(toolResult?.content ?? '').slice(0, 4000);
 
+  // D#35: this gated on `input.file_path` alone, and `NotebookEdit` carries
+  // `notebook_path` and never `file_path` — so the branch named NotebookEdit
+  // while being unable to fire for it, and every imported notebook edit built
+  // no (obs,file) edge. `toolEditPath` is the single home for that rule.
+  const editedPath = toolEditPath(toolUse.input);
   const filesModified =
-    (toolName === 'Edit' || toolName === 'Write' || toolName === 'NotebookEdit') && toolUse.input?.file_path
-      ? [toolUse.input.file_path]
+    (toolName === 'Edit' || toolName === 'Write' || toolName === 'NotebookEdit') && editedPath
+      ? [editedPath]
       : [];
-  const filesRead = toolName === 'Read' && toolUse.input?.file_path ? [toolUse.input.file_path] : [];
+  const filesRead = toolName === 'Read' && editedPath ? [editedPath] : [];
 
   // `narrative` carries the body and `text` is the derived search blob
   // (lib/observation-write.mjs rebuildObservationDerived). Writing the payload to `text`
@@ -144,7 +151,18 @@ function importToolPair(db, toolUse, toolResult, project) {
   // write directly.
   const body = `${inputJson}\n---\n${resultText}`;
   const safe = scrubRecord('observations', {
-    title: `${toolName}: ${(toolUse.input?.command || toolUse.input?.file_path || '').slice(0, 80)}`,
+    // This string IS the cross-run dedup key: tryImportToolPair synthesizes it
+    // byte-for-byte from the same expression to decide whether a row was already
+    // imported, so the two sites must be widened TOGETHER or every import
+    // duplicates. An earlier cut of this round kept the title on `file_path`
+    // alone to avoid the migration — and shipped `NotebookEdit: ` with an empty
+    // label for exactly the rows D#35 had just made reachable. Pre-ship review:
+    // "the surface the round unblocked renders a row that identifies nothing."
+    //
+    // The cost is real and bounded: NotebookEdit rows imported before v6.7.2
+    // carry the old key, so the next import re-adds each of them ONCE and then
+    // matches forever. Stated in the CHANGELOG rather than absorbed silently.
+    title: `${toolName}: ${(toolUse.input?.command || toolEditPath(toolUse.input) || '').slice(0, 80)}`,
     subtitle: '',
     text: body,
     narrative: body,
@@ -154,28 +172,49 @@ function importToolPair(db, toolUse, toolResult, project) {
     search_aliases: null,
   });
 
-  db.prepare(
-    `
+  const inserted = db
+    .prepare(
+      `
     INSERT INTO observations
       (memory_session_id, project, text, type, title, subtitle, narrative, concepts, facts, files_read, files_modified, importance, created_at, created_at_epoch)
     VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
   `,
-  ).run(
-    memId(sessionId),
-    project,
-    safe.text,
-    type,
-    safe.title,
-    safe.subtitle,
-    safe.narrative,
-    safe.concepts,
-    safe.facts,
-    JSON.stringify(filesRead),
-    JSON.stringify(filesModified),
-    1,
-    ts,
-    Date.parse(ts) || Date.now(),
-  );
+    )
+    .run(
+      memId(sessionId),
+      project,
+      safe.text,
+      type,
+      safe.title,
+      safe.subtitle,
+      safe.narrative,
+      safe.concepts,
+      safe.facts,
+      JSON.stringify(filesRead),
+      JSON.stringify(filesModified),
+      1,
+      ts,
+      Date.parse(ts) || Date.now(),
+    );
+
+  // Import wrote `files_modified` as a JSON column and stopped there, so no
+  // imported observation had a row in the `observation_files` junction — and
+  // that junction is what the file-recall paths JOIN. Two of them can now return
+  // an imported row: `recallByFile` (CLI `recall` + `mem_recall`) and
+  // `searchByFile` (the UserPromptSubmit leg). The pre-tool recall leg JOINs it
+  // too but still CANNOT — pre-ship review measured three independent structural
+  // gates, two of them literals: `importance >= 2` against the `1` written
+  // below, and `lesson_learned` non-empty OR `type IN ('bugfix','decision')`
+  // against a NULL lesson and a type that is only ever `change`/`discovery`.
+  // Do not list it as a beneficiary without changing one of those.
+  //
+  // Measured before the fix: an
+  // `Edit` with `file_path` set produced `files_modified=["/repo/alpha.mjs"]`
+  // and ZERO junction rows, so the defect was never NotebookEdit-specific —
+  // D#35 named a symptom of it. Same call and same list as the canonical save
+  // path (lib/save-observation.mjs:324), which is why `insertObs` in the test
+  // helpers mirrors it and no existing test could see the gap.
+  insertObservationFiles(db, Number(inserted.lastInsertRowid), filesModified);
   return true;
 }
 
@@ -256,7 +295,7 @@ export async function importJsonl(db, path, { project }) {
     // Cross-call dedup: synthesize the title the previous run would have
     // written and check the seenObs set seeded from the DB.
     const toolName = useEv.name || 'unknown';
-    const titlePreview = `${toolName}: ${(useEv.input?.command || useEv.input?.file_path || '').slice(0, 80)}`;
+    const titlePreview = `${toolName}: ${(useEv.input?.command || toolEditPath(useEv.input) || '').slice(0, 80)}`;
     const ts = useEv.timestamp || new Date().toISOString();
     // Match the storage convention from importToolPair (memId-prefixed) so
     // the seenObs entries seeded from the DB can be matched on a re-run.

package/lib/recall-core.mjs

@@ -42,7 +42,7 @@ export function recallByFile(db, file, { limit = 10, includeNoise = false } = {}
     WHERE ${liveObsFilterSql('o')}
       AND ${fileMatchClause('of2')}
       ${noiseClause}
-    ORDER BY o.created_at_epoch DESC
+    ORDER BY o.importance DESC, o.created_at_epoch DESC, o.id DESC
     LIMIT ?
   `,
     )

package/npm-shrinkwrap.json

@@ -1,12 +1,12 @@
 {
   "name": "claude-mem-lite",
-  "version": "6.7.1",
+  "version": "6.7.2",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "claude-mem-lite",
-      "version": "6.7.1",
+      "version": "6.7.2",
       "os": [
         "darwin",
         "linux",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "claude-mem-lite",
-  "version": "6.7.1",
+  "version": "6.7.2",
   "description": "Persistent long-term memory for Claude Code via MCP — captures coding decisions, bugfixes, and context across sessions. Hybrid FTS5 + TF-IDF search with episode batching. Single SQLite DB, no external services. A lighter, lower-cost alternative to claude-mem (episode batching + a smaller model; cost savings are an internal estimate, not a measured benchmark).",
   "type": "module",
   "packageManager": "npm@10.9.2",

package/scripts/post-tool-recall.js

@@ -30,6 +30,7 @@ import { queueHookContext, flushHookStdout } from '../lib/hook-stdout.mjs';
 // P1-9: one bounded stdin reader. Import-free, like hook-stdout.mjs beside it.
 import { readHookStdin, TOOL_INPUT_FILE_MAX_BYTES } from '../lib/hook-stdin.mjs';
 import { cooldownPathFor as sharedCooldownPathFor } from '../lib/cooldown-path.mjs';
+import { toolEditPath } from '../lib/file-edge-match.mjs';
 
 const SALIENCE_BIND = process.env.CLAUDE_MEM_SALIENCE === 'bind';
 
@@ -59,7 +60,7 @@ async function main() {
     // v6.7.0 and this leg did not, which is the repo's most repeated failure shape:
     // a fix that closes ONE of the inputs reaching the same line. Caught in pre-ship
     // review of that very round.
-    filePath = e.tool_input?.file_path ?? e.tool_input?.notebook_path;
+    filePath = toolEditPath(e.tool_input);
     sessionId = e.session_id || null;
   } catch {
     return;

package/scripts/pre-tool-recall.js

@@ -25,6 +25,7 @@ import {
   fileMatchParams,
   basenameAnySep,
   jsonArrayLikeNeedle,
+  toolEditPath,
 } from '../lib/file-edge-match.mjs';
 import { fileIntelFor } from '../lib/file-intel.mjs';
 import { shouldWarnReread, buildRereadWarning, readFileMeta } from '../lib/reread-guard.mjs';
@@ -406,7 +407,7 @@ try {
     // additionalProperties:false. Reading only `file_path` made this hook a
     // no-op on every .ipynb edit (R12 audit, partition B-2). utils.mjs's
     // `case 'NotebookEdit'` already knew the shape differs; this leg did not.
-    filePath = event.tool_input?.file_path ?? event.tool_input?.notebook_path;
+    filePath = toolEditPath(event.tool_input);
     sessionId = event.session_id || null;
     toolName = event.tool_name || null;
     const off = event.tool_input?.offset;

package/scripts/user-prompt-search.js

@@ -524,7 +524,7 @@ function searchByFile(db, files, project, limit) {
       AND o.created_at_epoch > ?
       AND ${fileMatchClause('of2')}
       AND ${notLowSignalTitleClause('o')}
-    ORDER BY o.created_at_epoch DESC, o.id DESC
+    ORDER BY o.importance DESC, o.created_at_epoch DESC, o.id DESC
     LIMIT ?
   `);