claude-mem-lite 3.9.0 → 3.10.0

package/.claude-plugin/marketplace.json

@@ -10,7 +10,7 @@
   "plugins": [
     {
       "name": "claude-mem-lite",
-      "version": "3.9.0",
+      "version": "3.10.0",
       "source": "./",
       "description": "Persistent long-term memory for Claude Code via MCP — captures coding decisions, bugfixes, and context across sessions. Hybrid FTS5 + TF-IDF search with episode batching. Single SQLite DB, no external services. A lighter, lower-cost alternative to claude-mem (episode batching + a smaller model; cost savings are an internal estimate, not a measured benchmark)."
     }

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "claude-mem-lite",
-  "version": "3.9.0",
+  "version": "3.10.0",
   "description": "Persistent long-term memory for Claude Code via MCP — captures coding decisions, bugfixes, and context across sessions. Hybrid FTS5 + TF-IDF search with episode batching. Single SQLite DB, no external services. A lighter, lower-cost alternative to claude-mem (episode batching + a smaller model; cost savings are an internal estimate, not a measured benchmark).",
   "author": {
     "name": "sdsrss"

package/hook.mjs

@@ -553,7 +553,11 @@ async function handleStop() {
           // Union closed by extractAllInjected — one integration point so the
           // contract test in tests/citation-tracker-userprompt.test.mjs covers it.
           try {
-            const injected = extractAllInjected(transcriptPath);
+            // mainOnly: the injected denominator must use the same thread
+            // filter as citedMain (the numerator, below) — an obs injected only
+            // inside a subagent (sidechain) would otherwise enter the denominator
+            // but never the numerator and streak-demote despite being used there.
+            const injected = extractAllInjected(transcriptPath, { mainOnly: true });
             // P5 ①: cite-back signals — observations whose warned file the agent
             // edited this session. Union into injected so they're resolved (they
             // were injected via pre-tool-recall) and, below, into cited so the

package/lib/citation-tracker.mjs

@@ -182,8 +182,15 @@ function normalizeHookCommand(command) {
  *
  * @param {string|null|undefined} transcriptPath
  * @param {(ctx: {command: string, text: string}) => void} fn
+ * @param {object} [opts]
+ * @param {boolean} [opts.mainOnly=false] If true, skip attachments on sidechain
+ *   (subagent) transcript records. Mirrors extractCitationsFromTranscript's
+ *   mainOnly so the citation-decay injected DENOMINATOR uses the same thread
+ *   filter as the cited NUMERATOR — an obs injected only inside a subagent must
+ *   not enter the denominator, else it streak-demotes despite being used there.
  */
-function eachHookAttachment(transcriptPath, fn) {
+function eachHookAttachment(transcriptPath, fn, opts = {}) {
+  const { mainOnly = false } = opts;
   if (!transcriptPath || !existsSync(transcriptPath)) return;
   let raw;
   try { raw = readFileSync(transcriptPath, 'utf8'); } catch { return; }
@@ -192,6 +199,7 @@ function eachHookAttachment(transcriptPath, fn) {
     let entry;
     try { entry = JSON.parse(line); } catch { continue; }
     if (entry.type !== 'attachment') continue;
+    if (mainOnly && entry.isSidechain === true) continue;
     const att = entry.attachment;
     if (!att || att.type !== 'hook_success') continue;
     const stdout = att.stdout || '';
@@ -217,14 +225,14 @@ function eachHookAttachment(transcriptPath, fn) {
  * @param {string|null|undefined} transcriptPath
  * @returns {Set<number>} unique injected IDs (empty set on missing path/file)
  */
-export function extractInjectedFromPreToolUse(transcriptPath) {
+export function extractInjectedFromPreToolUse(transcriptPath, opts = {}) {
   const ids = new Set();
   eachHookAttachment(transcriptPath, ({ command, text }) => {
     if (!command.includes('pre-tool-recall')) return;
     INJECTED_RE.lastIndex = 0;
     let m;
     while ((m = INJECTED_RE.exec(text))) addObsId(ids, m[1]);
-  });
+  }, opts);
   return ids;
 }
 
@@ -251,7 +259,7 @@ const UPS_COMMAND_SUFFIX = 'hook.mjs user-prompt';
  * @param {string|null|undefined} transcriptPath
  * @returns {Set<number>}
  */
-export function extractInjectedFromUserPromptSubmit(transcriptPath) {
+export function extractInjectedFromUserPromptSubmit(transcriptPath, opts = {}) {
   const ids = new Set();
   eachHookAttachment(transcriptPath, ({ command, text }) => {
     if (!command.includes(UPS_COMMAND_SUFFIX)) return;
@@ -265,7 +273,7 @@ export function extractInjectedFromUserPromptSubmit(transcriptPath) {
       if (matches.length === 0) continue;
       addObsId(ids, matches[matches.length - 1][1]);
     }
-  });
+  }, opts);
   return ids;
 }
 
@@ -280,7 +288,7 @@ export function extractInjectedFromUserPromptSubmit(transcriptPath) {
  * @param {string|null|undefined} transcriptPath
  * @returns {Set<number>}
  */
-export function extractInjectedFromErrorRecall(transcriptPath) {
+export function extractInjectedFromErrorRecall(transcriptPath, opts = {}) {
   const ids = new Set();
   eachHookAttachment(transcriptPath, ({ command, text }) => {
     if (!command.includes('post-tool-use')) return;
@@ -290,7 +298,7 @@ export function extractInjectedFromErrorRecall(transcriptPath) {
     INJECTED_RE.lastIndex = 0;
     let m;
     while ((m = INJECTED_RE.exec(text))) addObsId(ids, m[1]);
-  });
+  }, opts);
   return ids;
 }
 
@@ -311,7 +319,7 @@ const FYI_LINE_ID_RE = /^#(\d{1,7})\s/;
  * @param {string|null|undefined} transcriptPath
  * @returns {Set<number>}
  */
-export function extractInjectedFromFyi(transcriptPath) {
+export function extractInjectedFromFyi(transcriptPath, opts = {}) {
   const ids = new Set();
   eachHookAttachment(transcriptPath, ({ command, text }) => {
     if (!command.includes('user-prompt-search')) return;
@@ -320,7 +328,7 @@ export function extractInjectedFromFyi(transcriptPath) {
       const m = FYI_LINE_ID_RE.exec(fyiLine);
       if (m) addObsId(ids, m[1]);
     }
-  });
+  }, opts);
   return ids;
 }
 
@@ -330,14 +338,18 @@ export function extractInjectedFromFyi(transcriptPath) {
  * user-prompt-search FYI block. Single integration point the Stop handler calls.
  *
  * @param {string|null|undefined} transcriptPath
+ * @param {object} [opts]
+ * @param {boolean} [opts.mainOnly=false] Skip sidechain-injected IDs. The
+ *   citation-decay caller passes true so the injected denominator matches the
+ *   mainOnly cited numerator; the P4 access-bump caller omits it (broader).
  * @returns {Set<number>}
  */
-export function extractAllInjected(transcriptPath) {
+export function extractAllInjected(transcriptPath, opts = {}) {
   return new Set([
-    ...extractInjectedFromPreToolUse(transcriptPath),
-    ...extractInjectedFromUserPromptSubmit(transcriptPath),
-    ...extractInjectedFromErrorRecall(transcriptPath),
-    ...extractInjectedFromFyi(transcriptPath),
+    ...extractInjectedFromPreToolUse(transcriptPath, opts),
+    ...extractInjectedFromUserPromptSubmit(transcriptPath, opts),
+    ...extractInjectedFromErrorRecall(transcriptPath, opts),
+    ...extractInjectedFromFyi(transcriptPath, opts),
   ]);
 }
 

package/lib/search-core.mjs

@@ -59,9 +59,26 @@ export function parseDateBounds(fromRaw, toRaw) {
  * per-source SQL double-applied it and gapped/overlapped pages, because the
  * obs hybrid path (AND→OR fallback / vector / concept stages) re-adds rows the
  * SQL OFFSET already skipped (#8217/#8638).
+ *
+ * D#30 re-audit (reopened): perSourceLimit MUST be offset-independent. The old
+ * `offset + limit + 10` term grew the pool for deeper pages, and because RRF
+ * fusion of FTS + vector ranks is candidate-pool-sensitive (an item present in
+ * BOTH lists outranks one in a single list), a larger pool RE-RANKS the prefix —
+ * so page(offset=0) and page(offset=N) sliced DIFFERENT orderings and overlapped
+ * /gapped on the real (vector-populated) DB. #8642 missed this because its guard
+ * test seeds no vectors (FTS-only is prefix-stable). The fix makes the pool a
+ * function of `limit` only:
+ *   - MIN_FUSION_POOL floor (= default limit 20 × the 3× buffer): every limit ≤ 20
+ *     fuses ONE 60-candidate pool, so same-limit --offset pages are disjoint/stable
+ *     and top-N is limit-stable (top-5 ⊂ top-10 ⊂ top-20). limit=20 offset=0 stays
+ *     byte-identical to before (60) → no change on the benchmarked single-page path.
+ *   - limit > 20 keeps limit*3 (the over-fetch buffer the fallback stages need).
+ * Trade-off: pages beyond the pool now return empty instead of the (overlapping,
+ * wrong) rows the offset-scaling used to surface — stability over deep reach.
  */
-export function computePerSourceWindow(limit, offset) {
-  return { perSourceLimit: Math.max(limit * 3, offset + limit + 10), perSourceOffset: 0 };
+export const MIN_FUSION_POOL = 60;
+export function computePerSourceWindow(limit, offset) { // eslint-disable-line no-unused-vars
+  return { perSourceLimit: Math.max(limit * 3, MIN_FUSION_POOL), perSourceOffset: 0 };
 }
 
 /** obs-side total query: when the AND→OR fallback fired, count the OR set. */

package/mem-cli.mjs

@@ -133,7 +133,15 @@ async function cmdSearch(db, args, { llm } = {}) {
   // --deep proceeds even when the literal query sanitizes to nothing — its LLM
   // rewrite may still produce searchable variants (F3, parity with server.mjs).
   if (!ftsQuery && deepMode === 'normal') {
-    fail(`[mem] No valid search terms in "${query}"`);
+    // A query that sanitizes to an empty FTS expression (only operators/punctuation/
+    // sub-min-length tokens) is a zero-result search, not a malformed one. In --json
+    // mode emit the same empty envelope as the no-match path below so programmatic
+    // consumers always get parseable stdout (the human path keeps the stderr hint).
+    if (jsonOutput) {
+      out(JSON.stringify({ query, total: 0, returned: 0, offset, limit, deep: false, results: [] }));
+    } else {
+      fail(`[mem] No valid search terms in "${query}"`);
+    }
     return;
   }
   // --deep ignores --or: each variant runs AND + the engine's built-in
@@ -607,7 +615,20 @@ function cmdTimeline(db, args) {
   if (flags.anchor !== undefined && flags.anchor !== true) {
     const resolved = resolveAnchorToken(db, flags.anchor, { project });
     if (!resolved.ok) {
-      fail(formatAnchorError(resolved.error, 'cli'));
+      // --json must always emit a parseable envelope. An explicit-but-missing anchor is
+      // a direct-lookup miss (like `get` on a bad id) → anchor:null + error code, rc=1.
+      if (jsonOutput) {
+        process.exitCode = 1;
+        out(JSON.stringify({
+          anchor: null,
+          anchor_note: formatAnchorError(resolved.error, 'mcp'),
+          before: [],
+          after: [],
+          error: resolved.error.code || 'anchor_resolution_failed',
+        }));
+      } else {
+        fail(formatAnchorError(resolved.error, 'cli'));
+      }
       return;
     }
     anchorId = resolved.anchorId;
@@ -663,7 +684,20 @@ function cmdTimeline(db, args) {
   // Window fetch (access-count bump + project auto-scope) shared with MCP.
   const win = fetchTimelineWindow(db, anchorId, { before, after, project });
   if (!win) {
-    fail(`[mem] Observation #${anchorId} not found`);
+    // Anchor resolved to a real id but the window fetch found no row (e.g. project
+    // mismatch). Same --json contract as the resolution-miss path above.
+    if (jsonOutput) {
+      process.exitCode = 1;
+      out(JSON.stringify({
+        anchor: null,
+        anchor_note: `Observation #${anchorId} not found.`,
+        before: [],
+        after: [],
+        error: 'id-not-found',
+      }));
+    } else {
+      fail(`[mem] Observation #${anchorId} not found`);
+    }
     return;
   }
   const { anchor, beforeRows, afterRows } = win;
@@ -1405,8 +1439,11 @@ function cmdUpdate(db, args) {
          `Prompts and sessions are append-only.`);
     return;
   }
+  // Strict parseIdToken gate (aligned with cmdDelete): a bare parseInt fallback
+  // truncated "3.9" → 3 and silently UPDATE'd the WRONG row #3 (no preview, no
+  // --confirm). Require an exact obs-id token; non-matching input → usage error.
   const parsed = raw ? parseIdToken(raw) : null;
-  const id = parsed && parsed.source === null ? parsed.id : parseInt(raw, 10);
+  const id = parsed && parsed.source === null ? parsed.id : NaN;
   if (!id || isNaN(id)) {
     fail('[mem] Usage: claude-mem-lite update <id> [--title T] [--type T] [--importance N] [--lesson T] [--narrative T] [--concepts T]');
     return;
@@ -2331,6 +2368,8 @@ Commands:
       --project P       Filter by project
     drop <D#N|ordinal>[,...]  Drop one or more deferred items (no fix needed)
       --reason "..."    Required audit trail
+      --project P       Project for ordinal resolution (default: current; must
+                        match the "defer list --project P" you read ordinals from)
 
   delete <id1,id2,...>  Delete observations by ID
     --confirm           Execute deletion (preview by default)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "claude-mem-lite",
-  "version": "3.9.0",
+  "version": "3.10.0",
   "description": "Persistent long-term memory for Claude Code via MCP — captures coding decisions, bugfixes, and context across sessions. Hybrid FTS5 + TF-IDF search with episode batching. Single SQLite DB, no external services. A lighter, lower-cost alternative to claude-mem (episode batching + a smaller model; cost savings are an internal estimate, not a measured benchmark).",
   "type": "module",
   "packageManager": "npm@10.9.2",