claude-mem-lite 3.87.0 → 3.89.0

package/server.mjs

@@ -50,7 +50,7 @@ import { ensureRegistryDb, collectRegistryStats, listResourcesRanked, formatRegi
 import { IMPORT_STRING_FIELDS, importResource, removeResource, reindexResources } from './lib/registry-core.mjs';
 import { searchResources } from './registry-retriever.mjs';
 import { probeOtherSources as probeIdSources, bucketIdTokens, splitDeferredTokens } from './lib/id-routing.mjs';
-import { saveObservation } from './lib/save-observation.mjs';
+import { saveObservation, formatSupersedeSkipped, formatSupersededNote } from './lib/save-observation.mjs';
 import { applyObsUpdate } from './lib/observation-write.mjs';
 import { EXPORT_COLUMNS_SQL } from './lib/export-columns.mjs';
 import { liveObsFilterSql } from './lib/inject-search-core.mjs';
@@ -58,7 +58,7 @@ import { recallByFile } from './lib/recall-core.mjs';
 import { fetchRecent } from './lib/recent-core.mjs';
 import { AUTO_MERGE_THRESHOLD } from './lib/dedup-constants.mjs';
 import {
-  insertDeferred, listOpenWithOrdinal, dropDeferred,
+  insertDeferred, listOpenWithOrdinal, dropDeferred, formatDropReasonHint,
   resolveDeferredIds, closeDeferredItems,
   getDeferredByIds, formatDeferredDetail,
   searchDeferredWork, formatDeferredSearchTrailer,
@@ -853,7 +853,9 @@ server.registerTool(
         // Resolve INSIDE tx + after dedup check so duplicate replays don't throw on
         // already-closed items. Mirrors mem-cli.mjs cmdSave shape.
         if (args.closes_deferred && args.closes_deferred.length > 0) {
-          closesIds = resolveDeferredIds(db, project, args.closes_deferred);
+          // D#195: 'dropped' is closable by the close verb (kept in sync with
+          // mem-cli.mjs cmdSave — same policy, both faces).
+          closesIds = resolveDeferredIds(db, project, args.closes_deferred, { allowStatuses: ['open', 'dropped'] });
           closeDeferredItems(db, closesIds, r.id);
         }
         return r;
@@ -869,22 +871,26 @@ server.registerTool(
     }
 
     if (result.kind === 'duplicate') {
-      return { content: [{ type: 'text', text: `Skipped: similar to existing #${result.existingId} in project "${project}". Use mem_get(ids=[${result.existingId}]) to review.` }] };
+      // D#201: this branch returns before the note below, so it renders its own.
+      const dupSkip = formatSupersedeSkipped(result.supersedeSkipped);
+      const dupText = `Skipped: similar to existing #${result.existingId} in project "${project}". Use mem_get(ids=[${result.existingId}]) to review.`;
+      return { content: [{ type: 'text', text: dupSkip ? `${dupText}\n${dupSkip}` : dupText }] };
     }
 
     const lessonNote = result.lessonCaptured ? ` 💡lesson captured` : '';
     const closedNote = closesIds && closesIds.length > 0
       ? ` Closed deferred: ${closesIds.map(i => `D#${i}`).join(', ')}.`
       : '';
-    const supersededNote = result.supersededIds && result.supersededIds.length > 0
-      ? ` Superseded: ${result.supersededIds.map(i => `#${i}`).join(', ')}.`
-      : '';
+    const supersededNote = formatSupersededNote(result);
     const nudge = buildLessonNudge({ type: result.type, id: result.id, lessonCaptured: result.lessonCaptured, surface: 'mcp' });
     // G1+G2: detached backfill worker (lesson for obligated types + aliases for
     // every save) — fill-only-empty, so an agent acting on the nudge still wins.
     const enrichNote = shouldQueueSaveEnrich(result) && queueSaveEnrich(result.id)
       ? ' (background enrichment queued)' : '';
-    return { content: [{ type: 'text', text: `Saved as observation #${result.id} [${result.type}] in project "${project}".${lessonNote}${closedNote}${supersededNote}${enrichNote}${nudge}` }] };
+    // D#201: on its own line rather than inside the success sentence.
+    const skipNote = formatSupersedeSkipped(result.supersedeSkipped);
+    const savedText = `Saved as observation #${result.id} [${result.type}] in project "${project}".${lessonNote}${closedNote}${supersededNote}${enrichNote}${nudge}`;
+    return { content: [{ type: 'text', text: skipNote ? `${savedText}\n${skipNote}` : savedText }] };
   })
 );
 
@@ -960,7 +966,11 @@ server.registerTool(
     if (r.changed === 0) {
       return { content: [{ type: 'text', text: `D#${realId} was not in 'open' status — drop is a no-op.` }] };
     }
-    return { content: [{ type: 'text', text: `Dropped D#${realId} in project "${project}". Reason: ${args.reason}` }] };
+    // D#195 (c): same advisory as the CLI's `defer drop`, so an agent reaching
+    // this through MCP gets the same steer toward `mem_save(closes_deferred)`.
+    const hint = formatDropReasonHint(args.reason);
+    const dropText = `Dropped D#${realId} in project "${project}". Reason: ${args.reason}`;
+    return { content: [{ type: 'text', text: hint ? `${dropText}\n${hint}` : dropText }] };
   })
 );
 

package/tool-schemas.mjs

@@ -191,13 +191,20 @@ const coerceDeferredTokens = z.preprocess(
   ])).min(1).max(20)
 );
 
-// Coerce supersedes input — array of positive observation ids (accept numeric
-// strings from MCP bridges that JSON-stringify ints). Empty/other shapes reject.
+// Coerce supersedes input — positive observation ids, plus `E#<n>` for an EVENT row
+// (D#205), which is the prefix those rows are rendered with in the injected lessons
+// block. Numeric strings are accepted because some MCP bridges JSON-stringify ints;
+// `E#<n>` is kept as a STRING and split by `splitSupersedeTokens`, since coercing it to
+// a number here would lose the only thing that says which table it names.
+// Empty/other shapes reject.
 const coerceSupersedes = z.preprocess(
   (v) => (Array.isArray(v)
     ? v.map(x => (typeof x === 'string' && /^\d+$/.test(x.trim()) ? parseInt(x.trim(), 10) : x))
     : v),
-  z.array(z.number().int().positive()).min(1).max(20)
+  z.array(z.union([
+    z.number().int().positive(),
+    z.string().regex(/^[Ee]#?\d+$/, 'expected a positive observation id or E#<n> for an event'),
+  ])).min(1).max(20)
 );
 
 export const memSaveSchema = {
@@ -216,7 +223,7 @@ export const memSaveSchema = {
   files: coerceStringArray.optional().describe('File paths associated with this observation. Stored in the `files_modified` column and rendered as `files` — passing a path here does not assert the file was edited; a file you only read belongs here too'),
   lesson_learned: z.string().max(500).optional().describe('Key lesson or takeaway, ≤500 chars (for bugfix: root cause & fix; for decision: rationale)'),
   closes_deferred: coerceDeferredTokens.optional().describe('Close one or more deferred_work items in the same project. Mixed array: bare integer = ordinal-within-project, "D#<n>" string = raw id. Transactional with the obs insert — a single invalid id rolls back the whole save.'),
-  supersedes: coerceSupersedes.optional().describe('Observation ids (same project) that this save overturns. They are marked superseded — dropped from live search — and linked to the new row (superseded_by). Use ONLY when this genuinely replaces a prior conclusion; do NOT use for merely-related or updated-but-still-valid memories.'),
+  supersedes: coerceSupersedes.optional().describe('Ids (same project) that this save overturns: a bare number for an observation, or E#<n> for an event — the same prefix events are shown with in the injected lessons block, so you can retire one by typing back what you read. They are marked superseded (dropped from live search); observations are also linked to the new row via superseded_by, events are not, because that column can only reference another event. Use ONLY when this genuinely replaces a prior conclusion; do NOT use for merely-related or updated-but-still-valid memories.'),
 };
 
 export const memStatsSchema = {