claude-mem-lite 2.71.3 → 2.71.4

package/.claude-plugin/marketplace.json

@@ -10,7 +10,7 @@
   "plugins": [
     {
       "name": "claude-mem-lite",
-      "version": "2.71.3",
+      "version": "2.71.4",
       "source": "./",
       "description": "Lightweight persistent memory system for Claude Code — FTS5 search, episode batching, error-triggered recall"
     }

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "claude-mem-lite",
-  "version": "2.71.3",
+  "version": "2.71.4",
   "description": "Lightweight persistent memory system for Claude Code — FTS5 search, episode batching, error-triggered recall",
   "author": {
     "name": "sdsrss"

package/bash-utils.mjs

@@ -15,9 +15,25 @@ export function detectBashSignificance(input, response) {
   // Skip error keyword matching when the command is a read/search operation
   // (grep output naturally contains matched keywords like "error")
   const isSearchCmd = /\b(grep|rg|ag|ack|cat|head|tail|less|more|find|locate|wc|file|which|type)\b/i.test(cmd);
-  const isError = !isSearchCmd
+  const looksLikeError = !isSearchCmd
     && /\berror\b|\bERR!|fail(ed|ure)?|exception|panic|traceback|errno|enoent|command not found/i.test(response)
     && response.length > 15;
+  // Green test summary exemption — "0 fail/failed/failures" in test-runner
+  // output (bun/jest/pytest) gets matched by the broad `fail(ed|ure)?` token
+  // above, driving episode.isError=true for passing runs. A live cluster-merge
+  // audit found 5 noise observations with "Error: <test>.ts ... 0 fail" titles
+  // from this path. Flip back to non-error iff a "0 fail" marker is present
+  // AND no hard-error signal (panic / ENOENT / AssertionError / TypeError /
+  // explicit FAIL banner / npm ERR!) coexists in the output.
+  const hasGreenTestSummary = looksLikeError
+    && /\b0\s+(fail|failed|failures)\b/i.test(response);
+  // NOTE: do not add `\bFAIL\s` here — with /i flag it would re-match the
+  // very `0 fail\n` token green-summary is trying to exempt. A real test
+  // failure produces "N fail" (N≥1) which never triggers hasGreenTestSummary,
+  // so a uppercase-FAIL fingerprint isn't needed for correctness.
+  const hasHardErrorSignal = hasGreenTestSummary
+    && /\bERR!|panic|traceback|enoent|command not found|exception|AssertionError|TypeError:|SyntaxError:/i.test(response);
+  const isError = looksLikeError && !(hasGreenTestSummary && !hasHardErrorSignal);
   // Match actual test runner invocations, not commands that merely reference "test" as a keyword
   const isTest = /\b(npm\s+test|npm\s+run\s+test|yarn\s+test|pnpm\s+test|pnpm\s+run\s+test|bun\s+test|go\s+test|cargo\s+test)\b/i.test(cmd)
     || /\b(jest|pytest|vitest|mocha|cypress|playwright)\b/i.test(cmd);

package/install.mjs

@@ -25,11 +25,10 @@ const MARKETPLACE_KEY = 'sdsrss';
 const PLUGIN_KEY = `claude-mem-lite@${MARKETPLACE_KEY}`;
 const NPM_INSTALL_CMD = 'npm install --omit=dev --no-audit --no-fund';
 
-import { createRequire } from 'module';
-
 import { RESOURCE_METADATA } from './install-metadata.mjs';
 import { scanPluginCacheHookPollution } from './plugin-cache-guard.mjs';
 import { SOURCE_FILES, HOOK_SCRIPT_FILES } from './source-files.mjs';
+import { probeBetterSqlite3Binding, ensureBetterSqlite3Working } from './lib/binding-probe.mjs';
 
 // Re-export for backward compatibility — tests/install-hook-scripts.test.mjs
 // and any external consumers still import HOOK_SCRIPT_FILES from install.mjs.
@@ -37,6 +36,12 @@ import { SOURCE_FILES, HOOK_SCRIPT_FILES } from './source-files.mjs';
 // can share it without a static cycle.
 export { HOOK_SCRIPT_FILES };
 
+// Re-export for backward compatibility — tests/install-bsqlite-probe.test.mjs
+// imports these from install.mjs. The implementation moved to lib/binding-probe.mjs
+// so scripts/launch.mjs can share the probe without importing install.mjs (which
+// pulls heavy install-only deps).
+export { probeBetterSqlite3Binding, ensureBetterSqlite3Working };
+
 export function copyHookScripts(srcDir, destDir) {
   for (const name of HOOK_SCRIPT_FILES) {
     const src = join(srcDir, name);
@@ -75,55 +80,6 @@ export function migrateLegacyClaudeMemData(oldDir, newDir, opts = {}) {
   return { action: 'backed-up', backupPath };
 }
 
-/**
- * Probe better-sqlite3's native binding by importing it from `installDir`'s
- * node_modules and opening an in-memory DB. Returns {ok, error?}. `npm install`
- * exits 0 even when the prebuilt .node binary mismatches the running Node ABI
- * (e.g. NODE_MODULE_VERSION 137 on Node v24), so install must verify before
- * declaring success — otherwise the next launch FATALs with "Could not locate
- * the bindings file".
- */
-export async function probeBetterSqlite3Binding(installDir) {
-  try {
-    const localRequire = createRequire(join(installDir, 'package.json'));
-    const Database = localRequire('better-sqlite3');
-    const db = new Database(':memory:');
-    db.close();
-    return { ok: true };
-  } catch (e) {
-    return { ok: false, error: e.message };
-  }
-}
-
-/**
- * Verify better-sqlite3 binding works in `installDir`; if not, run
- * `npm rebuild better-sqlite3` and re-probe. Returns
- * { ok: true, action: 'verified' | 'rebuilt' } on success or
- * { ok: false, error } if rebuild can't fix it. The `probe` and `rebuild`
- * deps are injectable so this can be unit-tested without a real npm
- * subprocess.
- */
-export async function ensureBetterSqlite3Working(installDir, deps = {}) {
-  const probe = deps.probe || (() => probeBetterSqlite3Binding(installDir));
-  const rebuild = deps.rebuild || (async () => {
-    execSync('npm rebuild better-sqlite3', { cwd: installDir, stdio: 'pipe' });
-  });
-
-  const first = await probe();
-  if (first.ok) return { ok: true, action: 'verified' };
-
-  try {
-    await rebuild();
-  } catch (e) {
-    return { ok: false, error: `rebuild failed: ${e.message}` };
-  }
-
-  const second = await probe();
-  if (second.ok) return { ok: true, action: 'rebuilt' };
-
-  return { ok: false, error: second.error || first.error };
-}
-
 /**
  * Derive invocation_name from resource name when metadata doesn't provide one.
  * Rules:
@@ -421,7 +377,12 @@ async function install() {
   } else {
     log('Ensuring dependencies installed...');
     try {
-      execSync(NPM_INSTALL_CMD, { cwd: INSTALL_DIR, stdio: 'pipe' });
+      // stderr inherited so users see real-time progress (network slowness,
+      // node-gyp compile spinner, prebuild-install fallback messages). With
+      // `stdio: 'pipe'` the install appeared to hang under the 5-min Bash
+      // timeout when better-sqlite3 had no Node v24 prebuild and had to
+      // compile from source — see bug audit 2026-05.
+      execSync(NPM_INSTALL_CMD, { cwd: INSTALL_DIR, stdio: ['ignore', 'pipe', 'inherit'] });
       ok('Dependencies installed');
     } catch (e) {
       fail('npm install failed: ' + e.message);

package/lib/binding-probe.mjs

@@ -0,0 +1,63 @@
+// lib/binding-probe.mjs — better-sqlite3 native binding probe + auto-rebuild.
+//
+// Shared by install.mjs (verify after `npm install`) and scripts/launch.mjs
+// (verify before launching the MCP server). `npm install` exits 0 even when
+// the prebuilt .node binary mismatches the running Node ABI (e.g. ABI v137 on
+// Node v24), and the presence of node_modules/better-sqlite3/ on disk is not
+// sufficient — the binding can be present-but-stale after a Node upgrade.
+
+import { execSync } from 'node:child_process';
+import { createRequire } from 'node:module';
+import { join } from 'node:path';
+
+/**
+ * Probe better-sqlite3's native binding by importing it from `installDir`'s
+ * node_modules and opening an in-memory DB. Returns {ok, error?}.
+ *
+ * @param {string} installDir Directory containing node_modules/better-sqlite3
+ * @returns {Promise<{ok: true} | {ok: false, error: string}>}
+ */
+export async function probeBetterSqlite3Binding(installDir) {
+  try {
+    const localRequire = createRequire(join(installDir, 'package.json'));
+    const Database = localRequire('better-sqlite3');
+    const db = new Database(':memory:');
+    db.close();
+    return { ok: true };
+  } catch (e) {
+    return { ok: false, error: e.message };
+  }
+}
+
+/**
+ * Verify better-sqlite3 binding works in `installDir`; if not, run
+ * `npm rebuild better-sqlite3` and re-probe. Returns
+ * { ok: true, action: 'verified' | 'rebuilt' } on success or
+ * { ok: false, error } if rebuild can't fix it. The `probe` and `rebuild`
+ * deps are injectable so this can be unit-tested without a real npm
+ * subprocess.
+ *
+ * @param {string} installDir Directory containing node_modules/better-sqlite3
+ * @param {{probe?: () => Promise<{ok: boolean, error?: string}>, rebuild?: () => Promise<void>}} [deps]
+ * @returns {Promise<{ok: true, action: 'verified' | 'rebuilt'} | {ok: false, error: string}>}
+ */
+export async function ensureBetterSqlite3Working(installDir, deps = {}) {
+  const probe = deps.probe || (() => probeBetterSqlite3Binding(installDir));
+  const rebuild = deps.rebuild || (async () => {
+    execSync('npm rebuild better-sqlite3', { cwd: installDir, stdio: 'pipe' });
+  });
+
+  const first = await probe();
+  if (first.ok) return { ok: true, action: 'verified' };
+
+  try {
+    await rebuild();
+  } catch (e) {
+    return { ok: false, error: `rebuild failed: ${e.message}` };
+  }
+
+  const second = await probe();
+  if (second.ok) return { ok: true, action: 'rebuilt' };
+
+  return { ok: false, error: second.error || first.error };
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "claude-mem-lite",
-  "version": "2.71.3",
+  "version": "2.71.4",
   "description": "Lightweight persistent memory system for Claude Code",
   "type": "module",
   "packageManager": "npm@10.9.2",
@@ -61,6 +61,7 @@
     "lib/id-routing.mjs",
     "lib/err-sampler.mjs",
     "lib/metrics.mjs",
+    "lib/binding-probe.mjs",
     "lib/mem-override.mjs",
     "lib/save-observation.mjs",
     "lib/deferred-work.mjs",

package/scripts/launch.mjs

@@ -30,6 +30,28 @@ if (!existsSync(join(ROOT, 'node_modules', 'better-sqlite3'))) {
   }
 }
 
+// Verify better-sqlite3 native binding matches the current Node ABI. The
+// directory-presence check above is necessary but not sufficient: a Node
+// version change (e.g. v22 → v24, ABI v127 → v137) leaves node_modules
+// intact but the .node binary stale → server FATALs with "Could not locate
+// the bindings file" on first DB open. Probe + auto-rebuild before launching.
+try {
+  const { ensureBetterSqlite3Working } = await import('../lib/binding-probe.mjs');
+  const verify = await ensureBetterSqlite3Working(ROOT);
+  if (!verify.ok) {
+    process.stderr.write(`[claude-mem-lite] better-sqlite3 binding unusable: ${verify.error}\n`);
+    process.stderr.write(`[claude-mem-lite] Repair: cd "${ROOT}" && npm rebuild better-sqlite3 --build-from-source\n`);
+    process.exit(1);
+  }
+  if (verify.action === 'rebuilt') {
+    process.stderr.write('[claude-mem-lite] Rebuilt better-sqlite3 binding for current Node ABI\n');
+  }
+} catch (e) {
+  // Probe module itself failed to load — fall through to server import and let
+  // the native FATAL surface as before. Don't block launch on a probe regression.
+  process.stderr.write(`[claude-mem-lite] binding probe skipped: ${e.message}\n`);
+}
+
 // Verify MCP SDK is importable (exports mapping intact).
 // Incomplete installs can leave the directory present but package.json missing,
 // causing Node.js to fail resolving subpath exports like /server/mcp.js.

package/source-files.mjs

@@ -44,6 +44,11 @@ export const SOURCE_FILES = [
   'lib/id-routing.mjs',
   'lib/err-sampler.mjs',
   'lib/metrics.mjs',
+  // v2.71.x: better-sqlite3 ABI probe + auto-rebuild. Shared by install.mjs
+  // (post-`npm install` verify) and scripts/launch.mjs (pre-server-launch
+  // self-heal after Node ABI changes). Missing from manifest → auto-update
+  // ships a stale install that FATALs on first DB open after Node upgrade.
+  'lib/binding-probe.mjs',
   // v2.41 god-module split — mem-cli.mjs router + per-cmd handlers under cli/
   'cli/common.mjs',
   'cli/fts-check.mjs',