claude-git-hooks 2.6.0 → 2.6.2

package/CHANGELOG.md

@@ -5,6 +5,49 @@ Todos los cambios notables en este proyecto se documentarán en este archivo.
 El formato está basado en [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 y este proyecto adhiere a [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.6.2] - 2025-12-12
+
+### 🐛 Fixed
+
+- **Parallel analysis stdin error handling** - Added graceful error handling for EOF errors during parallel execution (#43)
+    - **What was broken**: Unhandled 'error' events on stdin stream when Claude CLI process terminates unexpectedly during parallel analysis
+    - **Root cause**: `stdin.write()` failures emit asynchronous 'error' events that weren't being caught, causing uncaught exceptions with large prompts (18+ files) in parallel mode
+    - **Fix**: Added explicit error handler on `stdin` stream before writing prompt
+    - **Files changed**:
+        - `lib/utils/claude-client.js:287-308` - Added stdin error handler with detailed diagnostics
+    - **Impact**:
+        - Provides clear error message: "Failed to write to Claude stdin - process terminated unexpectedly"
+        - Logs diagnostic info: prompt length, error code, duration
+        - Suggests actionable fix: "Try reducing batch size or number of files per commit"
+    - **Compatibility**: No breaking changes, improves error reporting for all platforms
+
+### 🎯 User Experience
+
+- **Before**: Cryptic unhandled 'write EOF' exceptions crashed commit process with no actionable information
+- **After**: Clear error message with diagnostic context and suggested remediation
+- **Debug**: Added structured logging with prompt length and timing when EOF errors occur
+
+## [2.6.1] - 2025-12-04
+
+### 🐛 Fixed
+
+- **Windows spawn ENOENT errors** - Fixed critical issue where Claude CLI failed to execute on Windows with npm-installed tools
+    - **What was broken**: `spawn()` cannot execute `.cmd`/`.bat` files directly on Windows, causing `ENOENT` errors
+    - **Root cause**: npm on Windows creates both `claude` (non-executable) and `claude.cmd` (executable), and system was selecting the wrong one
+    - **Fix 1**: `which-command.js` now prefers `.cmd`/`.bat` extensions over extensionless entries when multiple matches found
+    - **Fix 2**: `claude-client.js` wraps `.cmd`/`.bat` commands with `cmd.exe /c` before spawning
+    - **Files changed**:
+        - `lib/utils/which-command.js:135-163` - Prefer `.cmd`/`.bat` in Windows path resolution
+        - `lib/utils/claude-client.js:165-179` - Wrap batch files with cmd.exe
+    - **Impact**: Fixes `analyze-diff` and commit hooks for Windows users with npm-installed Claude CLI
+    - **Compatibility**: No impact on Linux/macOS or Windows WSL setups, only affects Windows native npm installations
+
+### 🎯 User Experience
+
+- **Before**: Windows users with npm-installed Claude CLI got `ENOENT` errors on every command
+- **After**: Commands work seamlessly, same as other platforms
+- **Debug**: Added detailed logging for Windows .cmd file detection and wrapping
+
 ## [2.6.0] - 2025-12-02
 
 ### ✨ Added - Node.js 24 Compatibility

package/lib/utils/claude-client.js

@@ -162,7 +162,23 @@ const executeClaude = (prompt, { timeout = 120000, allowedTools = [] } = {}) =>
         finalArgs.push('--allowedTools', allowedTools.join(','));
     }
 
-    const fullCommand = finalArgs.length > 0 ? `${command} ${finalArgs.join(' ')}` : command;
+    // CRITICAL FIX: Windows .cmd/.bat file handling
+    // Why: spawn() cannot execute .cmd/.bat files directly on Windows (ENOENT error)
+    // Solution: Wrap with cmd.exe /c when command ends with .cmd or .bat
+    // Impact: Only affects Windows npm-installed CLI tools, no impact on other platforms
+    let spawnCommand = command;
+    let spawnArgs = finalArgs;
+
+    if (isWindows() && (command.endsWith('.cmd') || command.endsWith('.bat'))) {
+        logger.debug('claude-client - executeClaude', 'Wrapping .cmd/.bat with cmd.exe', {
+            originalCommand: command,
+            originalArgs: finalArgs
+        });
+        spawnCommand = 'cmd.exe';
+        spawnArgs = ['/c', command, ...finalArgs];
+    }
+
+    const fullCommand = spawnArgs.length > 0 ? `${spawnCommand} ${spawnArgs.join(' ')}` : spawnCommand;
 
     logger.debug(
         'claude-client - executeClaude',
@@ -176,7 +192,8 @@ const executeClaude = (prompt, { timeout = 120000, allowedTools = [] } = {}) =>
     // spawn streams data, exec buffers everything in memory
     // Node 24 Fix: Removed shell: true to avoid DEP0190 deprecation warning
     // We now use absolute paths from which(), so shell is not needed
-    const claude = spawn(command, finalArgs, {
+    // Windows .cmd/.bat fix: Wrapped with cmd.exe /c (see above)
+    const claude = spawn(spawnCommand, spawnArgs, {
         stdio: ['pipe', 'pipe', 'pipe'] // stdin, stdout, stderr
     });
 
@@ -263,13 +280,40 @@ const executeClaude = (prompt, { timeout = 120000, allowedTools = [] } = {}) =>
 
     // Write prompt to stdin
     // Why: Claude CLI reads prompt from stdin, not command arguments
+
+    // Handle stdin errors (e.g., EOF when process terminates unexpectedly)
+    // Why: write() failures can emit 'error' events asynchronously
+    // Common in parallel execution with large prompts
+    claude.stdin.on('error', (error) => {
+        logger.error(
+            'claude-client - executeClaude',
+            'stdin stream error (process may have terminated early)',
+            {
+                error: error.message,
+                code: error.code,
+                promptLength: prompt.length,
+                duration: Date.now() - startTime
+            }
+        );
+
+        reject(new ClaudeClientError('Failed to write to Claude stdin - process terminated unexpectedly', {
+            cause: error,
+            context: {
+                promptLength: prompt.length,
+                errorCode: error.code,
+                errorMessage: error.message,
+                suggestion: 'Try reducing batch size or number of files per commit'
+            }
+        }));
+    });
+
     try {
         claude.stdin.write(prompt);
         claude.stdin.end();
     } catch (error) {
         logger.error(
             'claude-client - executeClaude',
-            'Failed to write prompt to Claude CLI stdin',
+            'Failed to write prompt to Claude CLI stdin (synchronous error)',
             error
         );
 

package/lib/utils/which-command.js

@@ -132,12 +132,32 @@ const whichViaCommand = (command) => {
             timeout: 3000 // Don't wait forever
         });
 
-        // Windows 'where' returns multiple matches, take first
-        const firstMatch = result.split('\n')[0].trim();
+        // Windows 'where' returns multiple matches
+        const matches = result.split('\n').map(line => line.trim()).filter(line => line.length > 0);
+
+        // CRITICAL FIX: On Windows, prefer .cmd/.bat over extensionless entries
+        // Why: npm creates both 'claude' and 'claude.cmd', but only .cmd is executable via spawn()
+        // Example: where claude returns:
+        //   1. C:\Users\...\npm\claude       (NOT executable)
+        //   2. C:\Users\...\npm\claude.cmd   (executable)
+        if (isWin && matches.length > 1) {
+            const cmdMatch = matches.find(m => m.endsWith('.cmd') || m.endsWith('.bat'));
+            if (cmdMatch) {
+                logger.debug('which-command - whichViaCommand', 'Preferring .cmd/.bat over extensionless', {
+                    command,
+                    preferred: cmdMatch,
+                    allMatches: matches
+                });
+                return cmdMatch;
+            }
+        }
+
+        const firstMatch = matches[0];
 
         logger.debug('which-command - whichViaCommand', 'Found via command', {
             command,
-            path: firstMatch
+            path: firstMatch,
+            totalMatches: matches.length
         });
 
         return firstMatch;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-git-hooks",
-    "version": "2.6.0",
+    "version": "2.6.2",
     "description": "Git hooks with Claude CLI for code analysis and automatic commit messages",
     "type": "module",
     "bin": {