claude-git-hooks 2.3.1 → 2.4.1

package/lib/utils/claude-client.js

@@ -67,22 +67,49 @@ const isWSLAvailable = () => {
 
 /**
  * Get Claude command configuration for current platform
- * Why: On Windows, Claude CLI runs in WSL, so we need 'wsl' as command and 'claude' as arg
+ * Why: On Windows, try native Claude first, then WSL as fallback
  *
  * @returns {Object} { command, args } - Command and base arguments
- * @throws {ClaudeClientError} If Windows without WSL
+ * @throws {ClaudeClientError} If Claude not available on any method
  */
 const getClaudeCommand = () => {
     if (isWindows()) {
-        if (!isWSLAvailable()) {
-            throw new ClaudeClientError('WSL is required on Windows but not found', {
-                context: {
-                    platform: 'Windows',
-                    suggestion: 'Install WSL: https://docs.microsoft.com/en-us/windows/wsl/install'
-                }
-            });
+        // Try native Windows Claude first (e.g., installed via npm/scoop/choco)
+        try {
+            execSync('claude --version', { stdio: 'ignore', timeout: 3000 });
+            logger.debug('claude-client - getClaudeCommand', 'Using native Windows Claude CLI');
+            return { command: 'claude', args: [] };
+        } catch (nativeError) {
+            logger.debug('claude-client - getClaudeCommand', 'Native Claude not found, trying WSL');
+
+            // Fallback to WSL
+            if (!isWSLAvailable()) {
+                throw new ClaudeClientError('Claude CLI not found. Install Claude CLI natively on Windows or via WSL', {
+                    context: {
+                        platform: 'Windows',
+                        suggestions: [
+                            'Native Windows: npm install -g @anthropic-ai/claude-cli',
+                            'WSL: wsl --install, then install Claude in WSL'
+                        ]
+                    }
+                });
+            }
+
+            // Check if Claude is available in WSL
+            try {
+                execSync('wsl claude --version', { stdio: 'ignore', timeout: 5000 });
+                logger.debug('claude-client - getClaudeCommand', 'Using WSL Claude CLI');
+                return { command: 'wsl', args: ['claude'] };
+            } catch (wslError) {
+                throw new ClaudeClientError('Claude CLI not found in Windows or WSL', {
+                    context: {
+                        platform: 'Windows',
+                        nativeError: nativeError.message,
+                        wslError: wslError.message
+                    }
+                });
+            }
         }
-        return { command: 'wsl', args: ['claude'] };
     }
     return { command: 'claude', args: [] };
 };
@@ -114,8 +141,10 @@ const executeClaude = (prompt, { timeout = 120000 } = {}) => {
 
         // Why: Use spawn instead of exec to handle large prompts and responses
         // spawn streams data, exec buffers everything in memory
+        // shell: true needed on Windows to resolve .cmd/.bat executables
         const claude = spawn(command, args, {
-            stdio: ['pipe', 'pipe', 'pipe'] // stdin, stdout, stderr
+            stdio: ['pipe', 'pipe', 'pipe'], // stdin, stdout, stderr
+            shell: true // Required for Windows to find .cmd/.bat files
         });
 
         let stdout = '';

package/lib/utils/file-operations.js

@@ -250,13 +250,24 @@ const filterFiles = async (files, { maxSize = 100000, extensions = [] } = {}) =>
     logger.debug(
         'file-operations - filterFiles',
         'Filtering files',
-        { fileCount: files.length, maxSize, extensions }
+        {
+            fileCount: files.length,
+            maxSize,
+            extensions,
+            'process.cwd()': process.cwd(),
+            files: files
+        }
     );
 
     const results = await Promise.allSettled(
         files.map(async (filePath) => {
             // Check extension first (fast)
             if (!hasAllowedExtension(filePath, extensions)) {
+                logger.debug(
+                    'file-operations - filterFiles',
+                    'Extension rejected',
+                    { filePath }
+                );
                 return {
                     path: filePath,
                     size: 0,
@@ -267,6 +278,11 @@ const filterFiles = async (files, { maxSize = 100000, extensions = [] } = {}) =>
 
             // Check if file exists
             const exists = await fileExists(filePath);
+            logger.debug(
+                'file-operations - filterFiles',
+                'File exists check',
+                { filePath, exists }
+            );
             if (!exists) {
                 return {
                     path: filePath,
@@ -281,6 +297,11 @@ const filterFiles = async (files, { maxSize = 100000, extensions = [] } = {}) =>
                 const size = await getFileSize(filePath);
 
                 if (size > maxSize) {
+                    logger.debug(
+                        'file-operations - filterFiles',
+                        'File too large',
+                        { filePath, size, maxSize, 'size (KB)': Math.round(size / 1024), 'maxSize (KB)': Math.round(maxSize / 1024) }
+                    );
                     return {
                         path: filePath,
                         size,
@@ -289,6 +310,12 @@ const filterFiles = async (files, { maxSize = 100000, extensions = [] } = {}) =>
                     };
                 }
 
+                logger.debug(
+                    'file-operations - filterFiles',
+                    'File passed size check',
+                    { filePath, size, maxSize, 'size (KB)': Math.round(size / 1024) }
+                );
+
                 return {
                     path: filePath,
                     size,
@@ -297,6 +324,11 @@ const filterFiles = async (files, { maxSize = 100000, extensions = [] } = {}) =>
                 };
 
             } catch (error) {
+                logger.debug(
+                    'file-operations - filterFiles',
+                    'Error reading file',
+                    { filePath, error: error.message }
+                );
                 return {
                     path: filePath,
                     size: 0,
@@ -312,15 +344,17 @@ const filterFiles = async (files, { maxSize = 100000, extensions = [] } = {}) =>
         .filter(r => r.status === 'fulfilled')
         .map(r => r.value);
 
-    const validCount = fileMetadata.filter(f => f.valid).length;
+    const validFiles = fileMetadata.filter(f => f.valid);
+    const invalidFiles = fileMetadata.filter(f => !f.valid);
 
     logger.debug(
         'file-operations - filterFiles',
         'Filtering complete',
         {
             totalFiles: files.length,
-            validFiles: validCount,
-            invalidFiles: fileMetadata.length - validCount
+            validFiles: validFiles.length,
+            invalidFiles: invalidFiles.length,
+            rejectedFiles: invalidFiles.map(f => ({ path: f.path, reason: f.reason }))
         }
     );
 

package/lib/utils/logger.js

@@ -16,7 +16,7 @@
 
 class Logger {
     constructor({ debugMode = false } = {}) {
-        this.debugMode = debugMode || process.env.DEBUG === 'true';
+        this.debugMode = debugMode;
         this.colors = {
             reset: '\x1b[0m',
             red: '\x1b[31m',
@@ -138,4 +138,4 @@ class Logger {
 
 // Export singleton instance
 // Why: Single logger instance ensures consistent debug mode across entire application
-export default new Logger({ debugMode: process.env.DEBUG === 'true' });
+export default new Logger();

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-git-hooks",
-    "version": "2.3.1",
+    "version": "2.4.1",
     "description": "Git hooks with Claude CLI for code analysis and automatic commit messages",
     "type": "module",
     "bin": {

package/templates/CUSTOMIZATION_GUIDE.md

@@ -108,7 +108,7 @@ A preset is a **self-contained package** that customizes claude-hooks for a spec
 │ 3. CONFIGURATION MERGED                                     │
 │    defaults < user config < preset config                   │
 │    - File extensions: ['.java', '.xml', '.yml']             │
-│    - Max file size: 100KB                                   │
+│    - Max file size: 1MB                                     │
 │    - Parallel analysis: enabled                             │
 └────────────────────────┬────────────────────────────────────┘
                          │
@@ -282,7 +282,7 @@ cd python-django
 ```json
 {
     "analysis": {
-        "maxFileSize": 150000,
+        "maxFileSize": 1000000,
         "maxFiles": 12,
         "timeout": 180000
     },
@@ -306,9 +306,9 @@ cd python-django
 ```javascript
 {
   analysis: {
-    maxFileSize: 100000,  // 100KB
-    maxFiles: 10,
-    timeout: 120000       // 2 minutes
+    maxFileSize: 1000000,  // 1MB
+    maxFiles: 30,
+    timeout: 180000        // 3 minutes
   },
   subagents: {
     enabled: true,

package/templates/config.example.json

@@ -1,41 +1,41 @@
-{
-  "preset": null,
-  "analysis": {
-    "maxFileSize": 100000,
-    "maxFiles": 10,
-    "timeout": 120000,
-    "contextLines": 3,
-    "ignoreExtensions": []
-  },
-  "commitMessage": {
-    "autoKeyword": "auto",
-    "timeout": 180000
-  },
-  "subagents": {
-    "enabled": true,
-    "model": "haiku",
-    "batchSize": 3
-  },
-  "templates": {
-    "baseDir": ".claude",
-    "analysis": "CLAUDE_ANALYSIS_PROMPT_SONAR.md",
-    "guidelines": "CLAUDE_PRE_COMMIT_SONAR.md",
-    "commitMessage": "COMMIT_MESSAGE.md",
-    "analyzeDiff": "ANALYZE_DIFF.md",
-    "resolution": "CLAUDE_RESOLUTION_PROMPT.md",
-    "subagentInstruction": "SUBAGENT_INSTRUCTION.md"
-  },
-  "output": {
-    "outputDir": ".claude/out",
-    "debugFile": ".claude/out/debug-claude-response.json",
-    "resolutionFile": ".claude/out/claude_resolution_prompt.md",
-    "prAnalysisFile": ".claude/out/pr-analysis.json"
-  },
-  "system": {
-    "debug": false,
-    "wslCheckTimeout": 3000
-  },
-  "git": {
-    "diffFilter": "ACM"
-  }
-}
+{
+    "preset": "ai",
+    "analysis": {
+        "maxFileSize": 1000000,
+        "maxFiles": 30,
+        "timeout": 180000,
+        "contextLines": 3,
+        "ignoreExtensions": []
+    },
+    "commitMessage": {
+        "autoKeyword": "auto",
+        "timeout": 180000
+    },
+    "subagents": {
+        "enabled": false,
+        "model": "haiku",
+        "batchSize": 1
+    },
+    "templates": {
+        "baseDir": ".claude",
+        "analysis": "CLAUDE_ANALYSIS_PROMPT_SONAR.md",
+        "guidelines": "CLAUDE_PRE_COMMIT_SONAR.md",
+        "commitMessage": "COMMIT_MESSAGE.md",
+        "analyzeDiff": "ANALYZE_DIFF.md",
+        "resolution": "CLAUDE_RESOLUTION_PROMPT.md",
+        "subagentInstruction": "SUBAGENT_INSTRUCTION.md"
+    },
+    "output": {
+        "outputDir": ".claude/out",
+        "debugFile": ".claude/out/debug-claude-response.json",
+        "resolutionFile": ".claude/out/claude_resolution_prompt.md",
+        "prAnalysisFile": ".claude/out/pr-analysis.json"
+    },
+    "system": {
+        "debug": false,
+        "wslCheckTimeout": 3000
+    },
+    "git": {
+        "diffFilter": "ACM"
+    }
+}

package/templates/presets/ai/config.json

@@ -1,12 +1,12 @@
-{
-  "analysis": {
-    "maxFileSize": 100000,
-    "maxFiles": 10,
-    "timeout": 120000
-  },
-  "subagents": {
-    "enabled": false,
-    "model": "sonnet",
-    "batchSize": 3
-  }
-}
+{
+    "analysis": {
+        "maxFileSize": 1000000,
+        "maxFiles": 10,
+        "timeout": 300000
+    },
+    "subagents": {
+        "enabled": true,
+        "model": "haiku",
+        "batchSize": 3
+    }
+}

package/templates/presets/ai/preset.json

@@ -1,42 +1,37 @@
 {
-  "name": "ai",
-  "displayName": "AI/CLI (Node.js + Claude)",
-  "description": "Node.js CLI tools with Claude API integration",
-  "version": "1.0.0",
+    "name": "ai",
+    "displayName": "AI/CLI (Node.js + Claude)",
+    "description": "Node.js CLI tools with Claude API integration",
+    "version": "1.0.0",
 
-  "techStack": [
-    "Node.js",
-    "ES Modules",
-    "Claude API",
-    "CLI tools",
-    "Git hooks",
-    "Bash scripting",
-    "Markdown templates"
-  ],
+    "techStack": [
+        "Node.js",
+        "ES Modules",
+        "Claude API",
+        "CLI tools",
+        "Git hooks",
+        "Bash scripting",
+        "Markdown templates"
+    ],
 
-  "fileExtensions": [
-    ".js",
-    ".json",
-    ".md",
-    ".sh"
-  ],
+    "fileExtensions": [".js", ".json", ".md", ".sh"],
 
-  "focusAreas": [
-    "Claude API usage and best practices",
-    "Prompt engineering quality",
-    "CLI user experience",
-    "Error handling and logging",
-    "Git operations safety",
-    "Cross-platform compatibility",
-    "Token usage optimization",
-    "Security (API keys, secrets)"
-  ],
+    "focusAreas": [
+        "Claude API usage and best practices",
+        "Prompt engineering quality",
+        "CLI user experience",
+        "Error handling and logging",
+        "Git operations safety",
+        "Cross-platform compatibility",
+        "Token usage optimization",
+        "Security (API keys, secrets)"
+    ],
 
-  "templates": {
-    "analysis": "ANALYSIS_PROMPT.md",
-    "guidelines": "PRE_COMMIT_GUIDELINES.md",
-    "commitMessage": "../shared/COMMIT_MESSAGE.md",
-    "analyzeDiff": "../shared/ANALYZE_DIFF.md",
-    "resolution": "../shared/RESOLUTION_PROMPT.md"
-  }
+    "templates": {
+        "analysis": "ANALYSIS_PROMPT.md",
+        "guidelines": "PRE_COMMIT_GUIDELINES.md",
+        "commitMessage": "../shared/COMMIT_MESSAGE.md",
+        "analyzeDiff": "../shared/ANALYZE_DIFF.md",
+        "resolution": "../shared/RESOLUTION_PROMPT.md"
+    }
 }

package/templates/presets/backend/ANALYSIS_PROMPT.md

@@ -13,32 +13,35 @@ Perform a comprehensive code quality analysis focusing on these areas:
 ## Analysis Guidelines
 
 1. **Security First**: Check for OWASP Top 10 vulnerabilities, especially:
-   - SQL injection risks
-   - Authentication/authorization flaws
-   - Sensitive data exposure
-   - XML external entities (XXE)
-   - Insecure deserialization
+    - SQL injection risks
+    - Authentication/authorization flaws
+    - Sensitive data exposure
+    - XML external entities (XXE)
+    - Insecure deserialization
 
 2. **Spring Boot Best Practices**:
-   - Proper use of `@Transactional`
-   - Correct exception handling
-   - Appropriate use of DTOs vs Entities
-   - Proper dependency injection
-   - Configuration management
+    - Proper use of `@Transactional`
+    - Correct exception handling
+    - Appropriate use of DTOs vs Entities
+    - Proper dependency injection // Si intelligence -> recomendar @RequiredArgsConstructor || Si Automation -> recomendar @Autowired
+    - Configuration management
 
 3. **JPA/Hibernate**:
-   - N+1 query problems
-   - Lazy loading issues
-   - Proper use of relationships
-   - Query optimization
-   - Transaction boundaries
+    - N+1 query problems
+    - Lazy loading issues
+    - Proper use of relationships
+    - Query optimization
+    - Transaction boundaries
 
 4. **Code Quality**:
-   - SOLID principles
-   - DRY violations
-   - Proper error handling
-   - Logging best practices
-   - Test coverage
+    - SOLID principles
+    - DRY violations
+    - Proper error handling
+    - Logging should be like so
+        - debug: regular flow, operations details
+        - info: important business events
+        - warn: anomalies and manageable errors
+        - error: exceptions and errors
 
 ## Output Format
 
@@ -48,14 +51,6 @@ Respond with a valid JSON following the SonarQube format:
 {
   "QUALITY_GATE": "PASSED|FAILED",
   "approved": true|false,
-  "metrics": {
-    "reliability": "A|B|C|D|E",
-    "security": "A|B|C|D|E",
-    "maintainability": "A|B|C|D|E",
-    "coverage": 0-100,
-    "duplications": 0-100,
-    "complexity": "number"
-  },
   "issues": {
     "blocker": 0,
     "critical": 0,

package/templates/presets/backend/PRE_COMMIT_GUIDELINES.md

@@ -3,45 +3,63 @@
 ## Spring Boot Standards
 
 ### Controllers
-- Use proper HTTP methods and status codes
+
+- Use proper HTTP methods
+- Endpoints should handle entities as substantives
+- Make sure Response Codes include: [200, 201, 204, 400, 401, 403, 404, 409, 422, 500, 503] (if non-compliant classify as BLOCKER)
 - Validate input with `@Valid`
 - Handle exceptions with `@ExceptionHandler`
 - Keep controllers thin - business logic in services
 - Use DTOs for API contracts
 
 ### Services
+
 - Use `@Transactional` appropriately
 - Handle exceptions properly
 - Keep methods focused and small
 - Avoid business logic in controllers or repositories
 
 ### Repositories
+
 - Extend appropriate Spring Data interfaces
 - Use method naming conventions for queries
 - Optimize queries with `@Query` when needed
 - Avoid N+1 problems with `@EntityGraph`
 
 ### Entities
+
 - Use Lombok annotations appropriately
 - Define proper relationships (`@OneToMany`, `@ManyToOne`, etc.)
 - Use `@Version` for optimistic locking
 - Never expose entities in API - use DTOs
 
+### Mappers
+
+- Use Mapstruct for all mapping (If non-compliant, classify as MINOR)
+- Mappers should not have logic (If non-compliant, classify as MAJOR)
+
+### Logging
+
+- Recommend @Slf4j annotation in Lombok (If non-compliant, classify as MINOR)
+
 ## Security Requirements
 
 ### Authentication & Authorization
+
 - Never hardcode credentials
 - Use Spring Security properly
 - Validate JWT tokens correctly
 - Check permissions before operations
 
 ### Data Validation
+
 - Validate all user input
 - Use parameterized queries (JPA does this by default)
 - Sanitize data before logging
 - Never trust client-side validation alone
 
 ### SQL Injection Prevention
+
 - Always use JPA/JPQL or prepared statements
 - Never concatenate SQL strings
 - Be careful with native queries
@@ -50,35 +68,55 @@
 ## Performance
 
 ### Database
+
 - Use pagination for large result sets
 - Optimize queries with proper indexes
 - Avoid loading unnecessary data
 - Use projections when you don't need full entities
 
 ### Threading
+
 - Be careful with `@Async` methods
 - Use proper thread pool configuration
 - Avoid blocking operations in async methods
 - Handle exceptions in async methods
 
 ### Caching
+
 - Use `@Cacheable` appropriately
 - Clear caches when data changes
 - Don't cache sensitive data without encryption
 
 ## Testing
 
-- Write unit tests for business logic
+### Unit Tests
+
+- Unit tests should use exclusively JUnit 5, and specific annotations @SpringBootTest, @MockBean, @Test
 - Use `@DataJpaTest` for repository tests
 - Use `@WebMvcTest` for controller tests
 - Mock external dependencies
 - Aim for 80%+ coverage on new code
 
+### Integration Tests
+
+- Use `@SpringBootTest` with real application context
+- Test complete request-response flows
+- Verify database transactions and rollbacks
+- Test API endpoint integration with all layers
+- Use `@Transactional` with `@Rollback` for test data cleanup
+
+### Security Tests
+
+- Test authentication and authorization scenarios
+- Verify access control for protected endpoints
+- Test with invalid/expired tokens
+- Validate input sanitization and XSS prevention
+- Test SQL injection prevention with malicious input
+
 ## Common Issues to Avoid
 
 ❌ Returning entities from controllers
 ❌ Missing `@Transactional` on write operations
-❌ N+1 query problems
 ❌ Hardcoded secrets or credentials
 ❌ Catching and ignoring exceptions
 ❌ Missing input validation

package/templates/presets/backend/config.json

@@ -1,12 +1,12 @@
-{
-  "analysis": {
-    "maxFileSize": 100000,
-    "maxFiles": 10,
-    "timeout": 120000
-  },
-  "subagents": {
-    "enabled": true,
-    "model": "sonnet",
-    "batchSize": 3
-  }
-}
+{
+    "analysis": {
+        "maxFileSize": 1000000,
+        "maxFiles": 10,
+        "timeout": 300000
+    },
+    "subagents": {
+        "enabled": true,
+        "model": "haiku",
+        "batchSize": 3
+    }
+}

package/templates/presets/database/config.json

@@ -1,12 +1,12 @@
-{
-  "analysis": {
-    "maxFileSize": 150000,
-    "maxFiles": 8,
-    "timeout": 120000
-  },
-  "subagents": {
-    "enabled": false,
-    "model": "sonnet",
-    "batchSize": 2
-  }
-}
+{
+    "analysis": {
+        "maxFileSize": 1000000,
+        "maxFiles": 8,
+        "timeout": 300000
+    },
+    "subagents": {
+        "enabled": true,
+        "model": "haiku",
+        "batchSize": 2
+    }
+}