claude-git-hooks 2.17.1 → 2.17.2

package/CHANGELOG.md

@@ -5,6 +5,13 @@ Todos los cambios notables en este proyecto se documentarán en este archivo.
 El formato está basado en [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 y este proyecto adhiere a [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.17.2] - 2026-03-02
+
+### 🐛 Fixed
+- Improved pom.xml version detection to correctly distinguish project version from dependency/property versions (#76)
+- Fixed false version mismatch errors for Maven submodules with inherited parent versions
+
+
 ## [2.17.1] - 2026-03-02
 
 ### 🐛 Fixed

package/lib/utils/version-manager.js

@@ -21,6 +21,64 @@ import logger from './logger.js';
  */
 let cachedDiscoveryResult = null;
 
+/**
+ * Extracts the project version from pom.xml content (not dependency/property versions)
+ * Why: Maven POMs require context-aware parsing to distinguish the project's own
+ *      <version> tag from dependency versions, property references (${...}), or
+ *      inherited versions inside <parent> blocks.
+ *
+ * Taxative rule: In a Maven POM, the project coordinates (<groupId>, <artifactId>,
+ * <version>, <packaging>) are direct children of <project> and must appear BEFORE
+ * any section-level element. After </parent>, the project's own <version> (if explicit)
+ * will be in this "header" region before any section element.
+ *
+ * @param {string} content - pom.xml file content
+ * @returns {{ version: string|null, inherited: boolean }}
+ *   - version: The effective project version (explicit or from parent)
+ *   - inherited: true if version comes from <parent> block (no explicit project <version>)
+ */
+function extractPomProjectVersion(content) {
+    const hasParent = /<parent>[\s\S]*?<\/parent>/.test(content);
+
+    if (hasParent) {
+        // Section-level elements that mark the end of the project coordinates region.
+        // Any <version> tag inside these sections belongs to dependencies, plugins, etc.
+        const sectionTags = [
+            'properties', 'dependencies', 'dependencyManagement',
+            'build', 'profiles', 'modules', 'reporting',
+            'distributionManagement', 'repositories', 'pluginRepositories',
+            '\\/project'
+        ].join('|');
+
+        // Extract the "header" region: between </parent> and the first section element
+        const headerRegex = new RegExp(
+            `<\\/parent>([\\s\\S]*?)(?=<(?:${sectionTags})\\b)`
+        );
+        const headerMatch = content.match(headerRegex);
+
+        if (headerMatch) {
+            const versionMatch = headerMatch[1].match(/<version>([^<]+)<\/version>/);
+            if (versionMatch) {
+                return { version: versionMatch[1].trim(), inherited: false };
+            }
+        }
+
+        // No explicit project <version> found — fall back to <parent><version>
+        const parentVersionRegex = /<parent>[\s\S]*?<version>([^<]+)<\/version>[\s\S]*?<\/parent>/;
+        const parentMatch = content.match(parentVersionRegex);
+        if (parentMatch) {
+            return { version: parentMatch[1].trim(), inherited: true };
+        }
+
+        return { version: null, inherited: false };
+    }
+
+    // No parent block — first <version> after <project> is the project version
+    const projectVersionRegex = /<project[^>]*>[\s\S]*?<version>([^<]+)<\/version>/;
+    const match = content.match(projectVersionRegex);
+    return { version: match ? match[1].trim() : null, inherited: false };
+}
+
 /**
  * Registry of supported version file types
  * Why: Extensible system for multi-language version management
@@ -61,17 +119,8 @@ const VERSION_FILE_TYPES = {
         readVersion: (filePath) => {
             try {
                 const content = fs.readFileSync(filePath, 'utf8');
-                const hasParent = /<parent>[\s\S]*?<\/parent>/.test(content);
-
-                if (hasParent) {
-                    const afterParentRegex = /<\/parent>[\s\S]*?<version>([^<]+)<\/version>/;
-                    const match = content.match(afterParentRegex);
-                    return match ? match[1].trim() : null;
-                } else {
-                    const projectVersionRegex = /<project[^>]*>[\s\S]*?<version>([^<]+)<\/version>/;
-                    const match = content.match(projectVersionRegex);
-                    return match ? match[1].trim() : null;
-                }
+                const { version } = extractPomProjectVersion(content);
+                return version;
             } catch (error) {
                 logger.debug('version-manager - VERSION_FILE_TYPES', 'Failed to read pom.xml', {
                     filePath,
@@ -82,15 +131,22 @@ const VERSION_FILE_TYPES = {
         },
         writeVersion: (filePath, newVersion) => {
             const content = fs.readFileSync(filePath, 'utf8');
-            const hasParent = /<parent>[\s\S]*?<\/parent>/.test(content);
+            const { inherited } = extractPomProjectVersion(content);
 
             let newContent;
-            if (hasParent) {
-                const afterParentRegex = /(<\/parent>[\s\S]*?<version>)[^<]+(<\/version>)/;
-                newContent = content.replace(afterParentRegex, `$1${newVersion}$2`);
+            if (inherited) {
+                // Version is inherited from parent — update <parent><version> tag
+                const parentRegex = /(<parent>[\s\S]*?<version>)[^<]+(<\/version>[\s\S]*?<\/parent>)/;
+                newContent = content.replace(parentRegex, `$1${newVersion}$2`);
             } else {
-                const projectVersionRegex = /(<project[^>]*>[\s\S]*?<version>)[^<]+(<\/version>)/;
-                newContent = content.replace(projectVersionRegex, `$1${newVersion}$2`);
+                const hasParent = /<parent>[\s\S]*?<\/parent>/.test(content);
+                if (hasParent) {
+                    const afterParentRegex = /(<\/parent>[\s\S]*?<version>)[^<]+(<\/version>)/;
+                    newContent = content.replace(afterParentRegex, `$1${newVersion}$2`);
+                } else {
+                    const projectVersionRegex = /(<project[^>]*>[\s\S]*?<version>)[^<]+(<\/version>)/;
+                    newContent = content.replace(projectVersionRegex, `$1${newVersion}$2`);
+                }
             }
 
             if (content === newContent) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-git-hooks",
-    "version": "2.17.1",
+    "version": "2.17.2",
     "description": "Git hooks with Claude CLI for code analysis and automatic commit messages",
     "type": "module",
     "bin": {