claude-git-hooks 2.17.0 → 2.17.2

package/CHANGELOG.md

@@ -5,23 +5,44 @@ Todos los cambios notables en este proyecto se documentarán en este archivo.
 El formato está basado en [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 y este proyecto adhiere a [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.17.2] - 2026-03-02
+
+### 🐛 Fixed
+- Improved pom.xml version detection to correctly distinguish project version from dependency/property versions (#76)
+- Fixed false version mismatch errors for Maven submodules with inherited parent versions
+
+
+## [2.17.1] - 2026-03-02
+
+### 🐛 Fixed
+
+- Installer no longer crashes with `ENOTDIR` when running inside a Git worktree where `.git` is a file pointer instead of a directory
+- Hook management commands (`enable`, `disable`, `status`, `uninstall`) now correctly resolve the hooks path in worktree repos
+
+### 🔧 Changed
+
+- Extracted `getGitHooksPath()` to `helpers.js` — uses `git rev-parse --git-common-dir` to find the shared hooks directory in both regular repos and worktrees
+
 ## [2.17.0] - 2026-02-16
 
 ### ✨ Added
+
 - Automatic GitHub token setup now runs after installation
 
 ### 🔧 Changed
+
 - Simplified CLI help output to show concise command reference instead of verbose documentation
 - Commands in help output are now listed in alphabetical order for easier navigation
 - Installation success message now shows single help reference instead of detailed usage examples
 
 ### 🗑️ Removed
-- Removed extensive inline documentation from help output (use README for detailed docs)
 
+- Removed extensive inline documentation from help output (use README for detailed docs)
 
 ## [2.16.0] - 2026-02-15
 
 ### ✨ Added
+
 - Multi-file version discovery with recursive scanning up to 3 levels deep
 - Per-file version editing with `--interactive` flag for advanced control
 - Support for additional project types: build.gradle, build.gradle.kts, pyproject.toml, Cargo.toml, version.sbt
@@ -32,22 +53,25 @@ y este proyecto adhiere a [Semantic Versioning](https://semver.org/spec/v2.0.0.h
 - New UI components: `promptToggleList()` and `promptEditField()` in interactive-ui.js
 
 ### 🔧 Changed
+
 - Refactored version-manager.js to use new discovery-based API with `discoverVersionFiles()`, `updateVersionFiles()`, and `modifySuffix()`
 - Bump-version workflow now supports selecting specific files to update
 - Each file can have an independent target version when using per-file editing mode
 - Updated CLAUDE.md documentation with new version bump flow and API changes
 
 ### ⚠️ Deprecated
-- Legacy version-manager functions `detectProjectType()`, `getCurrentVersion()`, `updateVersion()`, and `getDiscoveredPaths()` replaced by new discovery API
 
+- Legacy version-manager functions `detectProjectType()`, `getCurrentVersion()`, `updateVersion()`, and `getDiscoveredPaths()` replaced by new discovery API
 
 ## [2.15.5] - 2026-02-12
 
 ### ✨ Added
+
 - Added comprehensive CI-safe integration test suite that runs without Claude CLI dependency
 - Added new test scripts: `test:integration:ci` for CI environments and `test:changed` for testing only modified files
 
 ### 🔧 Changed
+
 - Optimized CI matrix to run full OS/Node.js combinations only on push events, reducing PR build times
 - Refactored integration tests to verify installation workflow, hook lifecycle, config persistence, and CLI routing
 - Improved timeout handling in Claude CLI client by clearing timeouts consistently on all exit paths
@@ -55,35 +79,37 @@ y este proyecto adhiere a [Semantic Versioning](https://semver.org/spec/v2.0.0.h
 - Reduced Jest verbosity and coverage reporters for cleaner CI output
 
 ### 🐛 Fixed
+
 - Fixed potential timeout leak in claude-client.js where timeouts were not cleared on error or stdin failures
 
 ### 🗑️ Removed
-- Removed unused variables and parameters across multiple modules (analyze-diff, create-pr, install, config, changelog-generator, claude-client, claude-diagnostics, file-utils, git-operations, prompt-builder)
 
+- Removed unused variables and parameters across multiple modules (analyze-diff, create-pr, install, config, changelog-generator, claude-client, claude-diagnostics, file-utils, git-operations, prompt-builder)
 
 ## [2.15.4] - 2026-02-11
 
 ### ✨ Added
+
 - Added comprehensive unit tests for claude-diagnostics.js covering error detection, formatting, and recovery classification
 - Added unit tests for file-utils.js covering directory creation and file writing operations
 
-
 ## [2.15.3] - 2026-02-10
 
 ### ✨ Added
+
 - Unit tests for `generate-changelog.js` command covering CHANGELOG generation, version detection, and error handling
 - Unit tests for `github-client.js` covering CODEOWNERS parsing, reviewer detection, and GitHub repo parsing
 - Unit tests for `hooks.js` command covering enable, disable, status, and uninstall operations
 
-
 ## [2.15.2] - 2026-02-10
 
 ### 🔧 Changed
+
 - The bump-version command now uses the configured default branch (from github.pr.defaultBase) in the 'Next steps' output instead of hardcoded 'main'
 
 ### 🐛 Fixed
-- Fixed cross-platform path assertions in unit tests to use partial matching instead of exact paths, improving Windows compatibility
 
+- Fixed cross-platform path assertions in unit tests to use partial matching instead of exact paths, improving Windows compatibility
 
 ## [2.15.1] - 2026-02-10
 

package/lib/commands/helpers.js

@@ -95,6 +95,26 @@ export function getTemplatesPath() {
     return path.join(__dirname, '..', '..', 'templates');
 }
 
+/**
+ * Get the git hooks directory, correctly handling worktrees.
+ * In a worktree, hooks live in the main repo's .git/hooks, not the worktree's .git file.
+ * Uses `git rev-parse --git-common-dir` to find the shared git directory.
+ * @returns {string} Path to the git hooks directory
+ */
+export function getGitHooksPath() {
+    try {
+        let gitCommonDir = execSync('git rev-parse --git-common-dir', { encoding: 'utf8' }).trim();
+        // Handle Windows paths when running under WSL (e.g. C:\... -> /mnt/c/...)
+        if (/^[A-Za-z]:/.test(gitCommonDir)) {
+            gitCommonDir = gitCommonDir.replace(/^([A-Za-z]):/, (_, drive) => `/mnt/${drive.toLowerCase()}`);
+            gitCommonDir = gitCommonDir.replace(/\\/g, '/');
+        }
+        return path.join(gitCommonDir, 'hooks');
+    } catch (e) {
+        return path.join('.git', 'hooks');
+    }
+}
+
 /**
  * Detect if running on Windows
  * Why: Need to use 'wsl claude' instead of 'claude' on Windows

package/lib/commands/hooks.js

@@ -10,7 +10,8 @@ import {
     success,
     info,
     warning,
-    checkGitRepo
+    checkGitRepo,
+    getGitHooksPath
 } from './helpers.js';
 
 /**
@@ -22,11 +23,12 @@ export function runEnable(hookName) {
         error('You are not in a Git repository.');
     }
 
+    const hooksDir = getGitHooksPath();
     const hooks = hookName ? [hookName] : ['pre-commit', 'prepare-commit-msg'];
 
     hooks.forEach(hook => {
-        const disabledPath = `.git/hooks/${hook}.disabled`;
-        const enabledPath = `.git/hooks/${hook}`;
+        const disabledPath = path.join(hooksDir, `${hook}.disabled`);
+        const enabledPath = path.join(hooksDir, hook);
 
         if (fs.existsSync(disabledPath)) {
             fs.renameSync(disabledPath, enabledPath);
@@ -48,11 +50,12 @@ export function runDisable(hookName) {
         error('You are not in a Git repository.');
     }
 
+    const hooksDir = getGitHooksPath();
     const hooks = hookName ? [hookName] : ['pre-commit', 'prepare-commit-msg'];
 
     hooks.forEach(hook => {
-        const enabledPath = `.git/hooks/${hook}`;
-        const disabledPath = `.git/hooks/${hook}.disabled`;
+        const enabledPath = path.join(hooksDir, hook);
+        const disabledPath = path.join(hooksDir, `${hook}.disabled`);
 
         if (fs.existsSync(enabledPath)) {
             fs.renameSync(enabledPath, disabledPath);
@@ -75,10 +78,11 @@ export function runStatus() {
 
     info('Claude Git Hooks status:\n');
 
+    const hooksDir = getGitHooksPath();
     const hooks = ['pre-commit', 'prepare-commit-msg'];
     hooks.forEach(hook => {
-        const enabledPath = `.git/hooks/${hook}`;
-        const disabledPath = `.git/hooks/${hook}.disabled`;
+        const enabledPath = path.join(hooksDir, hook);
+        const disabledPath = path.join(hooksDir, `${hook}.disabled`);
 
         if (fs.existsSync(enabledPath)) {
             success(`${hook}: enabled`);
@@ -135,7 +139,7 @@ export function runUninstall() {
 
     info('Uninstalling Claude Git Hooks...');
 
-    const hooksPath = '.git/hooks';
+    const hooksPath = getGitHooksPath();
     const hooks = ['pre-commit', 'prepare-commit-msg'];
 
     hooks.forEach(hook => {

package/lib/commands/install.js

@@ -23,6 +23,7 @@ import {
     warning,
     checkGitRepo,
     getTemplatesPath,
+    getGitHooksPath,
     isWindows,
     getClaudeCommand,
     getPackageJson,
@@ -402,7 +403,7 @@ export async function runInstall(args) {
     await checkAndInstallDependencies(skipAuth);
 
     const templatesPath = getTemplatesPath();
-    const hooksPath = '.git/hooks';
+    const hooksPath = getGitHooksPath();
 
     // Create hooks directory if it doesn't exist
     if (!fs.existsSync(hooksPath)) {

package/lib/utils/installation-diagnostics.js

@@ -22,6 +22,7 @@
 import fs from 'fs';
 import path from 'path';
 import { getRepoRoot } from './git-operations.js';
+import { getGitHooksPath } from '../commands/helpers.js';
 
 /**
  * Gets installation diagnostics
@@ -60,7 +61,7 @@ export const getInstallationDiagnostics = () => {
         diagnostics.presetsDirPath = path.join(diagnostics.claudeDirPath, 'presets');
         diagnostics.presetsDirExists = fs.existsSync(diagnostics.presetsDirPath);
 
-        const gitHooksPath = path.join(diagnostics.repoRoot, '.git', 'hooks');
+        const gitHooksPath = getGitHooksPath();
         diagnostics.gitHooksExists = fs.existsSync(gitHooksPath);
     } catch (error) {
         // Not in a git repository - diagnostics.repoRoot will be null

package/lib/utils/version-manager.js

@@ -21,6 +21,64 @@ import logger from './logger.js';
  */
 let cachedDiscoveryResult = null;
 
+/**
+ * Extracts the project version from pom.xml content (not dependency/property versions)
+ * Why: Maven POMs require context-aware parsing to distinguish the project's own
+ *      <version> tag from dependency versions, property references (${...}), or
+ *      inherited versions inside <parent> blocks.
+ *
+ * Taxative rule: In a Maven POM, the project coordinates (<groupId>, <artifactId>,
+ * <version>, <packaging>) are direct children of <project> and must appear BEFORE
+ * any section-level element. After </parent>, the project's own <version> (if explicit)
+ * will be in this "header" region before any section element.
+ *
+ * @param {string} content - pom.xml file content
+ * @returns {{ version: string|null, inherited: boolean }}
+ *   - version: The effective project version (explicit or from parent)
+ *   - inherited: true if version comes from <parent> block (no explicit project <version>)
+ */
+function extractPomProjectVersion(content) {
+    const hasParent = /<parent>[\s\S]*?<\/parent>/.test(content);
+
+    if (hasParent) {
+        // Section-level elements that mark the end of the project coordinates region.
+        // Any <version> tag inside these sections belongs to dependencies, plugins, etc.
+        const sectionTags = [
+            'properties', 'dependencies', 'dependencyManagement',
+            'build', 'profiles', 'modules', 'reporting',
+            'distributionManagement', 'repositories', 'pluginRepositories',
+            '\\/project'
+        ].join('|');
+
+        // Extract the "header" region: between </parent> and the first section element
+        const headerRegex = new RegExp(
+            `<\\/parent>([\\s\\S]*?)(?=<(?:${sectionTags})\\b)`
+        );
+        const headerMatch = content.match(headerRegex);
+
+        if (headerMatch) {
+            const versionMatch = headerMatch[1].match(/<version>([^<]+)<\/version>/);
+            if (versionMatch) {
+                return { version: versionMatch[1].trim(), inherited: false };
+            }
+        }
+
+        // No explicit project <version> found — fall back to <parent><version>
+        const parentVersionRegex = /<parent>[\s\S]*?<version>([^<]+)<\/version>[\s\S]*?<\/parent>/;
+        const parentMatch = content.match(parentVersionRegex);
+        if (parentMatch) {
+            return { version: parentMatch[1].trim(), inherited: true };
+        }
+
+        return { version: null, inherited: false };
+    }
+
+    // No parent block — first <version> after <project> is the project version
+    const projectVersionRegex = /<project[^>]*>[\s\S]*?<version>([^<]+)<\/version>/;
+    const match = content.match(projectVersionRegex);
+    return { version: match ? match[1].trim() : null, inherited: false };
+}
+
 /**
  * Registry of supported version file types
  * Why: Extensible system for multi-language version management
@@ -61,17 +119,8 @@ const VERSION_FILE_TYPES = {
         readVersion: (filePath) => {
             try {
                 const content = fs.readFileSync(filePath, 'utf8');
-                const hasParent = /<parent>[\s\S]*?<\/parent>/.test(content);
-
-                if (hasParent) {
-                    const afterParentRegex = /<\/parent>[\s\S]*?<version>([^<]+)<\/version>/;
-                    const match = content.match(afterParentRegex);
-                    return match ? match[1].trim() : null;
-                } else {
-                    const projectVersionRegex = /<project[^>]*>[\s\S]*?<version>([^<]+)<\/version>/;
-                    const match = content.match(projectVersionRegex);
-                    return match ? match[1].trim() : null;
-                }
+                const { version } = extractPomProjectVersion(content);
+                return version;
             } catch (error) {
                 logger.debug('version-manager - VERSION_FILE_TYPES', 'Failed to read pom.xml', {
                     filePath,
@@ -82,15 +131,22 @@ const VERSION_FILE_TYPES = {
         },
         writeVersion: (filePath, newVersion) => {
             const content = fs.readFileSync(filePath, 'utf8');
-            const hasParent = /<parent>[\s\S]*?<\/parent>/.test(content);
+            const { inherited } = extractPomProjectVersion(content);
 
             let newContent;
-            if (hasParent) {
-                const afterParentRegex = /(<\/parent>[\s\S]*?<version>)[^<]+(<\/version>)/;
-                newContent = content.replace(afterParentRegex, `$1${newVersion}$2`);
+            if (inherited) {
+                // Version is inherited from parent — update <parent><version> tag
+                const parentRegex = /(<parent>[\s\S]*?<version>)[^<]+(<\/version>[\s\S]*?<\/parent>)/;
+                newContent = content.replace(parentRegex, `$1${newVersion}$2`);
             } else {
-                const projectVersionRegex = /(<project[^>]*>[\s\S]*?<version>)[^<]+(<\/version>)/;
-                newContent = content.replace(projectVersionRegex, `$1${newVersion}$2`);
+                const hasParent = /<parent>[\s\S]*?<\/parent>/.test(content);
+                if (hasParent) {
+                    const afterParentRegex = /(<\/parent>[\s\S]*?<version>)[^<]+(<\/version>)/;
+                    newContent = content.replace(afterParentRegex, `$1${newVersion}$2`);
+                } else {
+                    const projectVersionRegex = /(<project[^>]*>[\s\S]*?<version>)[^<]+(<\/version>)/;
+                    newContent = content.replace(projectVersionRegex, `$1${newVersion}$2`);
+                }
             }
 
             if (content === newContent) {

package/package.json

@@ -1,68 +1,68 @@
-{
-    "name": "claude-git-hooks",
-    "version": "2.17.0",
-    "description": "Git hooks with Claude CLI for code analysis and automatic commit messages",
-    "type": "module",
-    "bin": {
-        "claude-hooks": "./bin/claude-hooks"
-    },
-    "scripts": {
-        "test": "npm run test:all",
-        "test:all": "npm run lint && npm run test:smoke && npm run test:unit && npm run test:integration",
-        "test:smoke": "node --experimental-vm-modules node_modules/jest/bin/jest.js test/smoke --maxWorkers=1",
-        "test:unit": "node --experimental-vm-modules node_modules/jest/bin/jest.js test/unit --forceExit",
-        "test:integration": "node --experimental-vm-modules node_modules/jest/bin/jest.js test/integration --maxWorkers=1 --testTimeout=30000 --forceExit",
-        "test:integration:ci": "node --experimental-vm-modules node_modules/jest/bin/jest.js test/integration/ci-safe.test.js --maxWorkers=1 --testTimeout=30000 --forceExit",
-        "test:changed": "node --experimental-vm-modules node_modules/jest/bin/jest.js test/unit --changedSince=main --forceExit",
-        "test:watch": "node --experimental-vm-modules node_modules/jest/bin/jest.js --watch",
-        "test:coverage": "node --experimental-vm-modules node_modules/jest/bin/jest.js --coverage",
-        "lint": "eslint lib/ bin/claude-hooks",
-        "lint:fix": "eslint lib/ bin/claude-hooks --fix",
-        "format": "prettier --write \"lib/**/*.js\" \"bin/**\" \"test/**/*.js\"",
-        "precommit": "npm run lint && npm run test:smoke",
-        "prepublishOnly": "npm run test:all"
-    },
-    "keywords": [
-        "git",
-        "hooks",
-        "claude",
-        "ai",
-        "code-review",
-        "commit-messages",
-        "pre-commit",
-        "automation"
-    ],
-    "author": "Pablo Rovito",
-    "license": "MIT",
-    "repository": {
-        "type": "git",
-        "url": "https://github.com/pablorovito/claude-git-hooks.git"
-    },
-    "engines": {
-        "node": ">=16.9.0"
-    },
-    "engineStrict": false,
-    "os": [
-        "darwin",
-        "linux",
-        "win32"
-    ],
-    "preferGlobal": true,
-    "files": [
-        "bin/",
-        "lib/",
-        "templates/",
-        "README.md",
-        "CHANGELOG.md",
-        "LICENSE"
-    ],
-    "dependencies": {
-        "@octokit/rest": "^21.0.0"
-    },
-    "devDependencies": {
-        "@types/jest": "^29.5.0",
-        "eslint": "^8.57.0",
-        "jest": "^29.7.0",
-        "prettier": "^3.2.0"
-    }
-}
+{
+    "name": "claude-git-hooks",
+    "version": "2.17.2",
+    "description": "Git hooks with Claude CLI for code analysis and automatic commit messages",
+    "type": "module",
+    "bin": {
+        "claude-hooks": "./bin/claude-hooks"
+    },
+    "scripts": {
+        "test": "npm run test:all",
+        "test:all": "npm run lint && npm run test:smoke && npm run test:unit && npm run test:integration",
+        "test:smoke": "node --experimental-vm-modules node_modules/jest/bin/jest.js test/smoke --maxWorkers=1",
+        "test:unit": "node --experimental-vm-modules node_modules/jest/bin/jest.js test/unit --forceExit",
+        "test:integration": "node --experimental-vm-modules node_modules/jest/bin/jest.js test/integration --maxWorkers=1 --testTimeout=30000 --forceExit",
+        "test:integration:ci": "node --experimental-vm-modules node_modules/jest/bin/jest.js test/integration/ci-safe.test.js --maxWorkers=1 --testTimeout=30000 --forceExit",
+        "test:changed": "node --experimental-vm-modules node_modules/jest/bin/jest.js test/unit --changedSince=main --forceExit",
+        "test:watch": "node --experimental-vm-modules node_modules/jest/bin/jest.js --watch",
+        "test:coverage": "node --experimental-vm-modules node_modules/jest/bin/jest.js --coverage",
+        "lint": "eslint lib/ bin/claude-hooks",
+        "lint:fix": "eslint lib/ bin/claude-hooks --fix",
+        "format": "prettier --write \"lib/**/*.js\" \"bin/**\" \"test/**/*.js\"",
+        "precommit": "npm run lint && npm run test:smoke",
+        "prepublishOnly": "npm run test:all"
+    },
+    "keywords": [
+        "git",
+        "hooks",
+        "claude",
+        "ai",
+        "code-review",
+        "commit-messages",
+        "pre-commit",
+        "automation"
+    ],
+    "author": "Pablo Rovito",
+    "license": "MIT",
+    "repository": {
+        "type": "git",
+        "url": "https://github.com/pablorovito/claude-git-hooks.git"
+    },
+    "engines": {
+        "node": ">=16.9.0"
+    },
+    "engineStrict": false,
+    "os": [
+        "darwin",
+        "linux",
+        "win32"
+    ],
+    "preferGlobal": true,
+    "files": [
+        "bin/",
+        "lib/",
+        "templates/",
+        "README.md",
+        "CHANGELOG.md",
+        "LICENSE"
+    ],
+    "dependencies": {
+        "@octokit/rest": "^21.0.0"
+    },
+    "devDependencies": {
+        "@types/jest": "^29.5.0",
+        "eslint": "^8.57.0",
+        "jest": "^29.7.0",
+        "prettier": "^3.2.0"
+    }
+}