claude-git-hooks 1.5.5 → 2.0.0

package/bin/claude-hooks

@@ -1,11 +1,25 @@
 #!/usr/bin/env node
 
-const { execSync, spawn } = require('child_process');
-const fs = require('fs');
-const path = require('path');
-const os = require('os');
-const readline = require('readline');
-const https = require('https');
+import { execSync, spawn } from 'child_process';
+import fs from 'fs';
+import path from 'path';
+import os from 'os';
+import readline from 'readline';
+import https from 'https';
+import { fileURLToPath } from 'url';
+import { dirname } from 'path';
+import { executeClaude, extractJSON } from '../lib/utils/claude-client.js';
+
+// Why: ES6 modules don't have __dirname, need to recreate it
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = dirname(__filename);
+
+// Helper to read package.json
+// Why: ES6 modules can't use require() for JSON files
+const getPackageJson = () => {
+  const packagePath = path.join(__dirname, '..', 'package.json');
+  return JSON.parse(fs.readFileSync(packagePath, 'utf8'));
+};
 
 // Function to get the latest version from NPM
 function getLatestVersion(packageName) {
@@ -40,7 +54,7 @@ function getLatestVersion(packageName) {
 // Function to check version (used by hooks)
 async function checkVersionAndPromptUpdate() {
   try {
-    const currentVersion = require('../package.json').version;
+    const currentVersion = getPackageJson().version;
     const latestVersion = await getLatestVersion('claude-git-hooks');
 
     if (currentVersion === latestVersion) {
@@ -82,11 +96,6 @@ async function checkVersionAndPromptUpdate() {
   }
 }
 
-// Export for use in hooks
-if (typeof module !== 'undefined' && module.exports) {
-  module.exports = { checkVersionAndPromptUpdate };
-}
-
 // Colors for output
 const colors = {
   reset: '\x1b[0m',
@@ -142,45 +151,6 @@ function readPassword(prompt) {
   });
 }
 
-// Check if sudo password is correct
-function testSudoPassword(password) {
-  try {
-    execSync('echo "' + password + '" | sudo -S true', {
-      stdio: 'ignore',
-      timeout: 5000
-    });
-    return true;
-  } catch (e) {
-    return false;
-  }
-}
-
-// Install package with automatic sudo
-function installPackage(packageName, sudoPassword = null) {
-  try {
-    if (sudoPassword) {
-      if (os.platform() === 'linux') {
-        execSync(`echo "${sudoPassword}" | sudo -S apt-get update && echo "${sudoPassword}" | sudo -S apt-get install -y ${packageName}`, {
-          stdio: 'inherit'
-        });
-      }
-    } else {
-      if (os.platform() === 'linux') {
-        execSync(`sudo apt-get update && sudo apt-get install -y ${packageName}`, {
-          stdio: 'inherit'
-        });
-      } else if (os.platform() === 'darwin') {
-        execSync(`brew install ${packageName}`, {
-          stdio: 'inherit'
-        });
-      }
-    }
-    return true;
-  } catch (e) {
-    return false;
-  }
-}
-
 // Entertainment system
 class Entertainment {
   static jokes = [
@@ -368,25 +338,9 @@ async function install(args) {
     info('Installing Claude Git Hooks...');
   }
 
-  // Request sudo password at the beginning if necessary
-  let sudoPassword = null;
-  if (os.platform() === 'linux') {
-    const needsInstall = await checkIfInstallationNeeded();
-    if (needsInstall) {
-      info('Sudo access is needed for automatic dependency installation, please enter password');
-      sudoPassword = await readPassword('Enter your Ubuntu password for sudo: ');
-
-      if (sudoPassword && !testSudoPassword(sudoPassword)) {
-        warning('Incorrect password. Continuing without automatic installation.');
-        sudoPassword = null;
-      } else if (sudoPassword) {
-        success('Password verified. Proceeding with automatic installation.');
-      }
-    }
-  }
-
-  // Check dependencies with automatic installation
-  await checkAndInstallDependencies(sudoPassword, skipAuth);
+  // v2.0.0+: No sudo needed (pure Node.js, no system packages required)
+  // Check dependencies
+  await checkAndInstallDependencies(null, skipAuth);
 
   const templatesPath = getTemplatesPath();
   const hooksPath = '.git/hooks';
@@ -396,6 +350,15 @@ async function install(args) {
     fs.mkdirSync(hooksPath, { recursive: true });
   }
 
+  // Helper function to copy file with LF line endings
+  // Why: Bash scripts must have LF (Unix) line endings, not CRLF (Windows)
+  const copyWithLF = (sourcePath, destPath) => {
+    let content = fs.readFileSync(sourcePath, 'utf8');
+    // Convert CRLF to LF
+    content = content.replace(/\r\n/g, '\n');
+    fs.writeFileSync(destPath, content, 'utf8');
+  };
+
   // Hooks to install
   const hooks = ['pre-commit', 'prepare-commit-msg'];
 
@@ -410,18 +373,18 @@ async function install(args) {
       info(`Backup created: ${backupPath}`);
     }
 
-    // Copy hook
-    fs.copyFileSync(sourcePath, destPath);
+    // Copy hook with LF line endings (critical for bash)
+    copyWithLF(sourcePath, destPath);
     fs.chmodSync(destPath, '755');
     success(`${hook} installed`);
   });
 
-  // Copy version verification script
+  // Copy version verification script with LF line endings
   const checkVersionSource = path.join(templatesPath, 'check-version.sh');
   const checkVersionDest = path.join(hooksPath, 'check-version.sh');
 
   if (fs.existsSync(checkVersionSource)) {
-    fs.copyFileSync(checkVersionSource, checkVersionDest);
+    copyWithLF(checkVersionSource, checkVersionDest);
     fs.chmodSync(checkVersionDest, '755');
     success('Version verification script installed');
   }
@@ -500,41 +463,7 @@ async function checkAndInstallDependencies(sudoPassword = null, skipAuth = false
     error('npm is not installed.');
   }
 
-  // Check and install jq
-  try {
-    const jqVersion = execSync('jq --version', { encoding: 'utf8' }).trim();
-    success(`jq ${jqVersion}`);
-  } catch (e) {
-    warning('jq is not installed. Installing...');
-    if (installPackage('jq', sudoPassword)) {
-      success('jq installed successfully');
-    } else {
-      warning('Could not install jq automatically');
-      if (os.platform() === 'linux') {
-        console.log('Install it manually with: sudo apt install jq');
-      } else if (os.platform() === 'darwin') {
-        console.log('Install it manually with: brew install jq');
-      }
-    }
-  }
-
-  // Check and install curl
-  try {
-    const curlVersion = execSync('curl --version', { encoding: 'utf8' }).split('\n')[0];
-    success(`curl ${curlVersion.split(' ')[1]}`);
-  } catch (e) {
-    warning('curl is not installed. Installing...');
-    if (installPackage('curl', sudoPassword)) {
-      success('curl installed successfully');
-    } else {
-      warning('Could not install curl automatically');
-      if (os.platform() === 'linux') {
-        console.log('Install it manually with: sudo apt install curl');
-      } else if (os.platform() === 'darwin') {
-        console.log('Install it manually with: brew install curl');
-      }
-    }
-  }
+  // v2.0.0+: jq and curl are no longer needed (pure Node.js implementation)
 
   // Check Git
   try {
@@ -544,23 +473,7 @@ async function checkAndInstallDependencies(sudoPassword = null, skipAuth = false
     error('Git is not installed. Install Git and try again.');
   }
 
-  // Check standard Unix tools
-  const unixTools = ['sed', 'awk', 'grep', 'head', 'tail', 'stat', 'tput'];
-  const missingTools = [];
-
-  unixTools.forEach(tool => {
-    try {
-      execSync(`which ${tool}`, { stdio: 'ignore' });
-    } catch (e) {
-      missingTools.push(tool);
-    }
-  });
-
-  if (missingTools.length === 0) {
-    success('Standard Unix tools verified');
-  } else {
-    error(`Missing standard Unix tools: ${missingTools.join(', ')}. Retry installation in an Ubuntu console`);
-  }
+  // v2.0.0+: Unix tools (sed, awk, grep, etc.) no longer needed (pure Node.js implementation)
 
   // Check and install Claude CLI
   await checkAndInstallClaude();
@@ -576,21 +489,25 @@ async function checkAndInstallDependencies(sudoPassword = null, skipAuth = false
   sudoPassword = null;
 }
 
+// Detect if running on Windows
+// Why: Need to use 'wsl claude' instead of 'claude' on Windows
+function isWindows() {
+  return os.platform() === 'win32' || process.env.OS === 'Windows_NT';
+}
+
+// Get Claude command based on platform
+// Why: On Windows, Claude CLI runs in WSL, so we need 'wsl claude'
+function getClaudeCommand() {
+  return isWindows() ? 'wsl claude' : 'claude';
+}
+
 // Check if we need to install dependencies
 async function checkIfInstallationNeeded() {
-  const dependencies = ['jq', 'curl'];
-
-  for (const dep of dependencies) {
-    try {
-      execSync(`which ${dep}`, { stdio: 'ignore' });
-    } catch (e) {
-      return true; // Needs installation
-    }
-  }
+  // v2.0.0+: Only check Claude CLI (jq and curl no longer needed)
+  const claudeCmd = getClaudeCommand();
 
-  // Verificar Claude CLI
   try {
-    execSync('claude --version', { stdio: 'ignore' });
+    execSync(`${claudeCmd} --version`, { stdio: 'ignore' });
   } catch (e) {
     return true; // Needs Claude installation
   }
@@ -598,19 +515,28 @@ async function checkIfInstallationNeeded() {
   return false;
 }
 
-// Check and install Claude CLI
+// Check Claude CLI availability
 async function checkAndInstallClaude() {
+  const claudeCmd = getClaudeCommand();
+  const platform = isWindows() ? 'Windows (via WSL)' : os.platform();
+
   try {
-    execSync('claude --version', { stdio: 'ignore' });
-    success('Claude CLI detected');
+    execSync(`${claudeCmd} --version`, { stdio: 'ignore' });
+    success(`Claude CLI detected (${platform})`);
   } catch (e) {
-    info('Claude CLI not detected. Installing...');
-    try {
-      execSync('npm install -g @anthropic-ai/claude-cli', { stdio: 'inherit' });
-      success('Claude CLI installed successfully');
-    } catch (installError) {
-      error('Error installing Claude CLI. Install manually: npm install -g @anthropic-ai/claude-cli');
+    error(`Claude CLI not detected on ${platform}`);
+
+    if (isWindows()) {
+      console.log('\n⚠️  On Windows, Claude CLI must be installed in WSL:');
+      console.log('1. Open WSL terminal (wsl or Ubuntu from Start Menu)');
+      console.log('2. Follow installation at: https://docs.anthropic.com/claude/docs/claude-cli');
+      console.log('3. Verify with: wsl claude --version');
+    } else {
+      console.log('\nClaude CLI installation: https://docs.anthropic.com/claude/docs/claude-cli');
     }
+
+    console.log('\nAfter installation, run: claude-hooks install --force');
+    process.exit(1);
   }
 }
 
@@ -618,9 +544,15 @@ async function checkAndInstallClaude() {
 async function checkClaudeAuth() {
   info('Checking Claude authentication...');
 
+  // Get correct Claude command for platform
+  const claudeCmd = getClaudeCommand();
+  const cmdParts = claudeCmd.split(' ');
+  const command = cmdParts[0];
+  const args = [...cmdParts.slice(1), 'auth', 'status'];
+
   // Use spawn to not block, but with stdio: 'ignore' like the original
   const authPromise = new Promise((resolve, reject) => {
-    const child = spawn('claude', ['auth', 'status'], {
+    const child = spawn(command, args, {
       stdio: 'ignore',  // Igual que el original
       detached: false,
       windowsHide: true
@@ -736,20 +668,20 @@ function configureGit() {
   info('Configuring Git...');
 
   try {
-    // Configure line endings for WSL
-    execSync('git config core.autocrlf input', { stdio: 'ignore' });
-    success('Line endings configured for WSL (core.autocrlf = input)');
-
-    // Try to configure on Windows through PowerShell
-    try {
-      execSync('powershell.exe -Command "git config core.autocrlf true"', { stdio: 'ignore' });
+    // Configure line endings based on platform
+    // Why: CRLF/LF handling differs between Windows and Unix
+    if (isWindows()) {
+      // On Windows: Keep CRLF in working directory, convert to LF in repo
+      execSync('git config core.autocrlf true', { stdio: 'ignore' });
       success('Line endings configured for Windows (core.autocrlf = true)');
-    } catch (psError) {
-      info('Could not configure automatically on Windows');
+    } else {
+      // On Unix: Keep LF everywhere, convert CRLF to LF on commit
+      execSync('git config core.autocrlf input', { stdio: 'ignore' });
+      success('Line endings configured for Unix (core.autocrlf = input)');
     }
 
   } catch (e) {
-    warning('Error configuring Git');
+    warning('Error configuring Git: ' + e.message);
   }
 }
 
@@ -822,7 +754,7 @@ function disable(hookName) {
 }
 
 // Analyze-diff command
-function analyzeDiff(args) {
+async function analyzeDiff(args) {
   if (!checkGitRepo()) {
     error('You are not in a Git repository.');
     return;
@@ -930,10 +862,6 @@ function analyzeDiff(args) {
     return;
   }
 
-  // Create the prompt for Claude
-  const tempDir = `/tmp/claude-analyze-${Date.now()}`;
-  fs.mkdirSync(tempDir, { recursive: true });
-
   // Check if subagents should be used
   const useSubagents = process.env.CLAUDE_USE_SUBAGENTS === 'true';
   const subagentModel = process.env.CLAUDE_SUBAGENT_MODEL || 'haiku';
@@ -946,14 +874,13 @@ function analyzeDiff(args) {
     ? `\n\nIMPORTANT PARALLEL PROCESSING: If analyzing 3+ files, process them in batches of ${subagentBatchSize}. For EACH batch, create that many subagents in parallel using Task tool (send single message with multiple Task calls). Each subagent analyzes one file and provides insights. After ALL batches complete, consolidate into SINGLE JSON with ONE cohesive PR title/description. Model: ${subagentModel}. Example: 4 files with BATCH_SIZE=1 → 4 sequential batches of 1 subagent each. Example: 4 files with BATCH_SIZE=3 → batch 1 has 3 parallel subagents (files 1-3), batch 2 has 1 subagent (file 4).\n`
     : '';
 
-  const promptFile = path.join(tempDir, 'prompt.txt');
   const prompt = `Analyze the following changes. CONTEXT: ${contextDescription}
 ${subagentInstruction}
 Please generate:
 1. A concise and descriptive PR title (maximum 72 characters)
 2. A detailed PR description that includes:
    - Summary of changes
-   - Motivation/context  
+   - Motivation/context
    - Type of change (feature/fix/refactor/docs/etc)
    - Recommended testing
 3. A suggested branch name following the format: type/short-description (example: feature/add-user-auth, fix/memory-leak)
@@ -979,30 +906,15 @@ ${diffFiles}
 === FULL DIFF ===
 ${fullDiff.substring(0, 50000)} ${fullDiff.length > 50000 ? '\n... (truncated diff)' : ''}`;
 
-  fs.writeFileSync(promptFile, prompt);
-
   info('Sending to Claude for analysis...');
   const startTime = Date.now();
 
   try {
-    const response = execSync(`claude < "${promptFile}"`, { encoding: 'utf8', maxBuffer: 1024 * 1024 * 10 });
-
-    // Extraer el JSON de la respuesta
-    const jsonMatch = response.match(/\{[\s\S]*\}/);
-    if (!jsonMatch) {
-      error('Did not receive a valid JSON response from Claude.');
-      console.log('Complete response:', response);
-      return;
-    }
+    // Use cross-platform executeClaude from claude-client.js
+    const response = await executeClaude(prompt, { timeout: 180000 }); // 3 minutes for diff analysis
 
-    let result;
-    try {
-      result = JSON.parse(jsonMatch[0]);
-    } catch (e) {
-      error('Error parsing JSON response: ' + e.message);
-      console.log('JSON received:', jsonMatch[0]);
-      return;
-    }
+    // Extract JSON from response using claude-client utility
+    const result = extractJSON(response);
 
     // Show the results
     console.log('');
@@ -1080,9 +992,6 @@ ${fullDiff.substring(0, 50000)} ${fullDiff.length > 50000 ? '\n... (truncated di
 
   } catch (e) {
     error('Error executing Claude: ' + e.message);
-  } finally {
-    // Clean temporary files
-    fs.rmSync(tempDir, { recursive: true, force: true });
   }
 }
 
@@ -1192,7 +1101,7 @@ async function update() {
   info('Checking latest available version...');
 
   try {
-    const currentVersion = require('../package.json').version;
+    const currentVersion = getPackageJson().version;
     const latestVersion = await getLatestVersion('claude-git-hooks');
 
     const comparison = compareVersions(currentVersion, latestVersion);
@@ -1327,7 +1236,7 @@ async function main() {
       status();
       break;
     case 'analyze-diff':
-      analyzeDiff(args.slice(1));
+      await analyzeDiff(args.slice(1));
       break;
     case 'help':
     case '--help':