claude-git-hooks 1.5.3 → 1.5.4

package/CHANGELOG.md

@@ -5,6 +5,25 @@ Todos los cambios notables en este proyecto se documentarán en este archivo.
 El formato está basado en [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 y este proyecto adhiere a [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.5.4] - 2024-12-22
+
+### Fixed
+
+- 🔧 **Generación de prompt de resolución en modo SonarQube**
+  - Ahora se genera correctamente `claude_resolution_prompt.md` cuando el Quality Gate falla
+  - El archivo se genera cuando hay `blockingIssues`, independiente del tipo de fallo
+  - Corregido el flujo para que siempre muestre los issues críticos antes de generar el prompt
+
+- 🎯 **Unificación de lógica de análisis**
+  - Eliminada lógica duplicada entre modo "clásico" y SonarQube
+  - Ahora siempre se usa modo SonarQube (como se especificó en v1.4.1)
+  - Simplificación del flujo de decisión en el pre-commit hook
+
+### Changed
+
+- 📝 Refactorización del hook pre-commit para mayor claridad y mantenibilidad
+- 🔄 La función `generate_resolution_prompt` ahora se llama consistentemente cuando hay issues bloqueantes
+
 ## [1.5.3] - 2025-09-12
 
 ### Fixed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "claude-git-hooks",
-  "version": "1.5.3",
+  "version": "1.5.4",
   "description": "Git hooks con Claude CLI para análisis de código y generación automática de mensajes de commit",
   "main": "lib/index.js",
   "bin": {

package/templates/CLAUDE_RESOLUTION_PROMPT.md

@@ -5,7 +5,6 @@ repo:{{REPO_NAME}}
 branch:{{BRANCH_NAME}}
 commit:{{COMMIT_SHA}}
 files:{{FILE_COUNT}}
-mode:{{ANALYSIS_MODE}}
 
 CRITICAL_ISSUES:
 {{BLOCKING_ISSUES}}

package/templates/pre-commit

@@ -332,125 +332,95 @@ if $CLAUDE_CLI < "$PROMPT_FILE" > "$RESPONSE_FILE" 2>&1; then
         BLOCKING_ISSUES=$(echo "$JSON_RESPONSE" | jq -r '.blockingIssues[].description' 2>/dev/null | sed '/^$/d')
     fi
     
+    # Always use SonarQube mode (as per v1.4.1)
     QUALITY_GATE=$(echo "$JSON_RESPONSE" | jq -r '.QUALITY_GATE // ""' 2>/dev/null)
-    
-    if [ -n "$QUALITY_GATE" ] && [ "$QUALITY_GATE" != "null" ]; then
-        # Show SonarQube style results
-        echo
-        echo "╔════════════════════════════════════════════════════════════════════╗"
-        echo "║                     CODE QUALITY ANALYSIS                           ║"
-        echo "╚════════════════════════════════════════════════════════════════════╝"
+
+    # Show SonarQube style results
+    echo
+    echo "╔════════════════════════════════════════════════════════════════════╗"
+    echo "║                     CODE QUALITY ANALYSIS                           ║"
+    echo "╚════════════════════════════════════════════════════════════════════╝"
+    echo
+
+    # Quality Gate Status
+    if [ "$QUALITY_GATE" = "PASSED" ]; then
+        echo -e "${GREEN}✓ Quality Gate: PASSED${NC}"
+    else
+        echo -e "${RED}✗ Quality Gate: FAILED${NC}"
+    fi
+    echo
+
+    # Metrics
+    METRICS=$(echo "$JSON_RESPONSE" | jq -r '.metrics // {}' 2>/dev/null)
+    if [ "$METRICS" != "{}" ] && [ "$METRICS" != "null" ]; then
+        echo "📊 METRICS"
+        echo "├─ Reliability: $(echo "$METRICS" | jq -r '.reliability // "?"' 2>/dev/null)"
+        echo "├─ Security: $(echo "$METRICS" | jq -r '.security // "?"' 2>/dev/null)"
+        echo "├─ Maintainability: $(echo "$METRICS" | jq -r '.maintainability // "?"' 2>/dev/null)"
+        echo "├─ Coverage: $(echo "$METRICS" | jq -r '.coverage // "?"' 2>/dev/null)%"
+        echo "├─ Duplications: $(echo "$METRICS" | jq -r '.duplications // "?"' 2>/dev/null)%"
+        echo "└─ Complexity: $(echo "$METRICS" | jq -r '.complexity // "?"' 2>/dev/null)"
         echo
-        
-        # Quality Gate Status
-        if [ "$QUALITY_GATE" = "PASSED" ]; then
-            echo -e "${GREEN}✓ Quality Gate: PASSED${NC}"
-        else
-            echo -e "${RED}✗ Quality Gate: FAILED${NC}"
-        fi
+    fi
+
+    # Issues Summary
+    ISSUES=$(echo "$JSON_RESPONSE" | jq -r '.issues // {}' 2>/dev/null)
+    if [ "$ISSUES" != "{}" ] && [ "$ISSUES" != "null" ]; then
+        echo "📋 ISSUES SUMMARY"
+        BLOCKER=$(echo "$ISSUES" | jq -r '.blocker // 0' 2>/dev/null)
+        CRITICAL=$(echo "$ISSUES" | jq -r '.critical // 0' 2>/dev/null)
+        MAJOR=$(echo "$ISSUES" | jq -r '.major // 0' 2>/dev/null)
+        MINOR=$(echo "$ISSUES" | jq -r '.minor // 0' 2>/dev/null)
+        INFO=$(echo "$ISSUES" | jq -r '.info // 0' 2>/dev/null)
+        TOTAL=$((BLOCKER + CRITICAL + MAJOR + MINOR + INFO))
+
+        echo "Total: $TOTAL issues found"
+        [ "$BLOCKER" -gt 0 ] && echo -e "  ${RED}🔴 Blocker: $BLOCKER${NC}"
+        [ "$CRITICAL" -gt 0 ] && echo -e "  ${RED}🟠 Critical: $CRITICAL${NC}"
+        [ "$MAJOR" -gt 0 ] && echo -e "  ${YELLOW}🟡 Major: $MAJOR${NC}"
+        [ "$MINOR" -gt 0 ] && echo "  🔵 Minor: $MINOR"
+        [ "$INFO" -gt 0 ] && echo "  ⚪ Info: $INFO"
         echo
-        
-        # Metrics
-        METRICS=$(echo "$JSON_RESPONSE" | jq -r '.metrics // {}' 2>/dev/null)
-        if [ "$METRICS" != "{}" ] && [ "$METRICS" != "null" ]; then
-            echo "📊 METRICS"
-            echo "├─ Reliability: $(echo "$METRICS" | jq -r '.reliability // "?"' 2>/dev/null)"
-            echo "├─ Security: $(echo "$METRICS" | jq -r '.security // "?"' 2>/dev/null)"
-            echo "├─ Maintainability: $(echo "$METRICS" | jq -r '.maintainability // "?"' 2>/dev/null)"
-            echo "├─ Coverage: $(echo "$METRICS" | jq -r '.coverage // "?"' 2>/dev/null)%"
-            echo "├─ Duplications: $(echo "$METRICS" | jq -r '.duplications // "?"' 2>/dev/null)%"
-            echo "└─ Complexity: $(echo "$METRICS" | jq -r '.complexity // "?"' 2>/dev/null)"
-            echo
-        fi
-        
-        # Issues Summary
-        ISSUES=$(echo "$JSON_RESPONSE" | jq -r '.issues // {}' 2>/dev/null)
-        if [ "$ISSUES" != "{}" ] && [ "$ISSUES" != "null" ]; then
-            echo "📋 ISSUES SUMMARY"
-            BLOCKER=$(echo "$ISSUES" | jq -r '.blocker // 0' 2>/dev/null)
-            CRITICAL=$(echo "$ISSUES" | jq -r '.critical // 0' 2>/dev/null)
-            MAJOR=$(echo "$ISSUES" | jq -r '.major // 0' 2>/dev/null)
-            MINOR=$(echo "$ISSUES" | jq -r '.minor // 0' 2>/dev/null)
-            INFO=$(echo "$ISSUES" | jq -r '.info // 0' 2>/dev/null)
-            TOTAL=$((BLOCKER + CRITICAL + MAJOR + MINOR + INFO))
-            
-            echo "Total: $TOTAL issues found"
-            [ "$BLOCKER" -gt 0 ] && echo -e "  ${RED}🔴 Blocker: $BLOCKER${NC}"
-            [ "$CRITICAL" -gt 0 ] && echo -e "  ${RED}🟠 Critical: $CRITICAL${NC}"
-            [ "$MAJOR" -gt 0 ] && echo -e "  ${YELLOW}🟡 Major: $MAJOR${NC}"
-            [ "$MINOR" -gt 0 ] && echo "  🔵 Minor: $MINOR"
-            [ "$INFO" -gt 0 ] && echo "  ⚪ Info: $INFO"
-            echo
-        fi
-        
-        # Detailed Issues
-        DETAILS_COUNT=$(echo "$JSON_RESPONSE" | jq -r '.details | length' 2>/dev/null)
-        if [ "$DETAILS_COUNT" -gt 0 ] 2>/dev/null; then
-            echo "🔍 DETAILED ISSUES"
-            echo "$JSON_RESPONSE" | jq -r '.details[]? | 
-                "[\(.severity)] \(.type) in \(.file):\(.line // "?")\n   \(.message)\n"' 2>/dev/null
-        fi
-        
-        # Security Hotspots
-        HOTSPOTS=$(echo "$JSON_RESPONSE" | jq -r '.securityHotspots // 0' 2>/dev/null)
-        if [ "$HOTSPOTS" -gt 0 ] 2>/dev/null; then
-            echo "🔥 SECURITY HOTSPOTS: $HOTSPOTS found"
-            echo "   Review security-sensitive code carefully"
+    fi
 
-            echo
-        fi
-        
-        # Check if commit should be blocked
-        if [ "$QUALITY_GATE" = "FAILED" ] || [ "$APPROVED" = "false" ]; then
-            echo
-            error "❌ Commit blocked due to quality gate failure"
-            exit 1
-        fi
-        
+    # Detailed Issues
+    DETAILS_COUNT=$(echo "$JSON_RESPONSE" | jq -r '.details | length' 2>/dev/null)
+    if [ "$DETAILS_COUNT" -gt 0 ] 2>/dev/null; then
+        echo "🔍 DETAILED ISSUES"
+        echo "$JSON_RESPONSE" | jq -r '.details[]? |
+            "[\(.severity)] \(.type) in \(.file):\(.line // "?")\n   \(.message)\n"' 2>/dev/null
+    fi
+
+    # Security Hotspots
+    HOTSPOTS=$(echo "$JSON_RESPONSE" | jq -r '.securityHotspots // 0' 2>/dev/null)
+    if [ "$HOTSPOTS" -gt 0 ] 2>/dev/null; then
+        echo "🔥 SECURITY HOTSPOTS: $HOTSPOTS found"
+        echo "   Review security-sensitive code carefully"
         echo
-        log "✅ Code analysis completed. Quality gate passed."
-    else
-        # Show results in classic format
+    fi
+
+    # Check if commit should be blocked
+    if [ "$QUALITY_GATE" = "FAILED" ] || [ "$APPROVED" = "false" ]; then
         echo
-        echo "=== REVIEW RESULTS ==="
-        echo "Score: $SCORE/10"
-        
-        if [ -n "$RECOMMENDATIONS" ] && [ "$RECOMMENDATIONS" != "null" ]; then
+        error "❌ Commit blocked due to quality gate failure"
+
+        # Show blocking issues if they exist
+        if [ -n "$BLOCKING_ISSUES" ] && [ "$BLOCKING_ISSUES" != "null" ]; then
             echo
-            echo "=== RECOMMENDATIONS ==="
-            echo "$RECOMMENDATIONS" | sed 's/^/- /'
-        fi
-        
-        # Check if the commit should be blocked
-        if [ "$APPROVED" = "false" ]; then
-            error "❌ Commit rejected due to critical issues"
-            if [ -n "$BLOCKING_ISSUES" ] && [ "$BLOCKING_ISSUES" != "null" ]; then
-                echo
-                echo "=== CRITICAL ISSUES ==="
-                echo "$BLOCKING_ISSUES" | sed 's/^/- /'
-                
-                # Generate AI-friendly resolution prompt
-                generate_resolution_prompt
-            fi
-            exit 1
+            echo "=== CRITICAL ISSUES ==="
+            echo "$BLOCKING_ISSUES" | sed 's/^/- /'
         fi
 
-        # Show additional details if they exist
-        DETAILS=$(echo "$JSON_RESPONSE" | jq -r '.details // null')
-        if [ -n "$DETAILS" ] && [ "$DETAILS" != "null" ]; then
-            echo
-            echo "=== ADDITIONAL DETAILS ==="
-            # If details is a string, print it directly
-            if echo "$DETAILS" | jq -e 'type == "string"' >/dev/null 2>&1; then
-                echo "$DETAILS" | jq -r '.'
-            # If it's an object or array, format it
-            else
-                echo "$DETAILS" | jq '.'
-            fi
+        # Generate AI-friendly resolution prompt if there are blocking issues
+        if [ "$BLOCKING_COUNT" -gt 0 ]; then
+            generate_resolution_prompt
         fi
-        
-        log "✅ Review completed. Commit approved (Score: $SCORE/10)"
+
+        exit 1
     fi
+
+    echo
+    log "✅ Code analysis completed. Quality gate passed."
     
 else
     error "Error executing Claude CLI"