claude-flow 3.42.3 → 3.42.5

package/v3/@claude-flow/cli/dist/src/memory/memory-bridge.js

@@ -649,26 +649,26 @@ const _schemaEnsuredDbs = new WeakSet();
  */
 export function ensureBridgeSchema(db) {
     try {
-        db.exec(`CREATE TABLE IF NOT EXISTS memory_entries (
-      id TEXT PRIMARY KEY,
-      key TEXT NOT NULL,
-      namespace TEXT DEFAULT 'default',
-      content TEXT NOT NULL,
-      type TEXT DEFAULT 'semantic',
-      embedding TEXT,
-      embedding_model TEXT DEFAULT 'local',
-      embedding_dimensions INTEGER,
-      tags TEXT,
-      metadata TEXT,
-      owner_id TEXT,
-      created_at INTEGER NOT NULL DEFAULT (strftime('%s', 'now') * 1000),
-      updated_at INTEGER NOT NULL DEFAULT (strftime('%s', 'now') * 1000),
-      expires_at INTEGER,
-      last_accessed_at INTEGER,
-      access_count INTEGER DEFAULT 0,
-      status TEXT DEFAULT 'active',
-      provenance_type TEXT DEFAULT 'unknown',
-      UNIQUE(namespace, key)
+        db.exec(`CREATE TABLE IF NOT EXISTS memory_entries (
+      id TEXT PRIMARY KEY,
+      key TEXT NOT NULL,
+      namespace TEXT DEFAULT 'default',
+      content TEXT NOT NULL,
+      type TEXT DEFAULT 'semantic',
+      embedding TEXT,
+      embedding_model TEXT DEFAULT 'local',
+      embedding_dimensions INTEGER,
+      tags TEXT,
+      metadata TEXT,
+      owner_id TEXT,
+      created_at INTEGER NOT NULL DEFAULT (strftime('%s', 'now') * 1000),
+      updated_at INTEGER NOT NULL DEFAULT (strftime('%s', 'now') * 1000),
+      expires_at INTEGER,
+      last_accessed_at INTEGER,
+      access_count INTEGER DEFAULT 0,
+      status TEXT DEFAULT 'active',
+      provenance_type TEXT DEFAULT 'unknown',
+      UNIQUE(namespace, key)
     )`);
         // ADR-323 added provenance_type to bridgeStoreEntry's INSERT, and
         // ensureSchemaColumns() backfills it on the sql.js path — the bridge path
@@ -891,29 +891,29 @@ export async function bridgeStoreEntry(options) {
         //                                       error, NEVER a null demotion).
         // Upsert path (INSERT OR REPLACE) is unchanged.
         const insertSql = options.upsert
-            ? `INSERT OR REPLACE INTO memory_entries (
-          id, key, namespace, content, type,
-          embedding, embedding_dimensions, embedding_model,
-          tags, metadata, provenance_type, created_at, updated_at, expires_at, status
+            ? `INSERT OR REPLACE INTO memory_entries (
+          id, key, namespace, content, type,
+          embedding, embedding_dimensions, embedding_model,
+          tags, metadata, provenance_type, created_at, updated_at, expires_at, status
         ) VALUES (?, ?, ?, ?, 'semantic', ?, ?, ?, ?, ?, ?, ?, ?, ?, 'active')`
-            : `INSERT INTO memory_entries (
-          id, key, namespace, content, type,
-          embedding, embedding_dimensions, embedding_model,
-          tags, metadata, provenance_type, created_at, updated_at, expires_at, status
-        ) VALUES (?, ?, ?, ?, 'semantic', ?, ?, ?, ?, ?, ?, ?, ?, ?, 'active')
-        ON CONFLICT(namespace, key) DO UPDATE SET
-          id                    = excluded.id,
-          content               = excluded.content,
-          embedding             = excluded.embedding,
-          embedding_dimensions  = excluded.embedding_dimensions,
-          embedding_model       = excluded.embedding_model,
-          tags                  = excluded.tags,
-          metadata              = excluded.metadata,
-          provenance_type       = excluded.provenance_type,
-          created_at            = excluded.created_at,
-          updated_at            = excluded.updated_at,
-          expires_at            = excluded.expires_at,
-          status                = 'active'
+            : `INSERT INTO memory_entries (
+          id, key, namespace, content, type,
+          embedding, embedding_dimensions, embedding_model,
+          tags, metadata, provenance_type, created_at, updated_at, expires_at, status
+        ) VALUES (?, ?, ?, ?, 'semantic', ?, ?, ?, ?, ?, ?, ?, ?, ?, 'active')
+        ON CONFLICT(namespace, key) DO UPDATE SET
+          id                    = excluded.id,
+          content               = excluded.content,
+          embedding             = excluded.embedding,
+          embedding_dimensions  = excluded.embedding_dimensions,
+          embedding_model       = excluded.embedding_model,
+          tags                  = excluded.tags,
+          metadata              = excluded.metadata,
+          provenance_type       = excluded.provenance_type,
+          created_at            = excluded.created_at,
+          updated_at            = excluded.updated_at,
+          expires_at            = excluded.expires_at,
+          status                = 'active'
         WHERE memory_entries.status = 'deleted'`;
         // #1941: provision a `vector_indexes` row for this namespace before the
         // entry insert. AgentDB's HNSW/router keys lookups by namespace via this
@@ -948,10 +948,10 @@ export async function bridgeStoreEntry(options) {
         // stop reporting "HNSW index: 0 vectors" while embedded entries exist.
         try {
             ctx.db
-                .prepare(`UPDATE vector_indexes SET
-             total_vectors = (SELECT COUNT(*) FROM memory_entries
-                              WHERE namespace = ? AND embedding IS NOT NULL),
-             updated_at = ?
+                .prepare(`UPDATE vector_indexes SET
+             total_vectors = (SELECT COUNT(*) FROM memory_entries
+                              WHERE namespace = ? AND embedding IS NOT NULL),
+             updated_at = ?
            WHERE name = ?`)
                 .run(namespace, now, namespace);
         }
@@ -1094,12 +1094,12 @@ export async function bridgeSearchEntries(options) {
             // scale), so on any corpus over 1000 entries the newest — and often
             // most relevant — rows never reach scoring at all. bridgeListEntries()
             // already orders by updated_at DESC for the same reason; mirror it here.
-            const stmt = ctx.db.prepare(`
-        SELECT id, key, namespace, content, embedding, provenance_type
-        FROM memory_entries
-        WHERE ${ACTIVE_MEMORY_ROW_SQL} ${whereExtra}
-        ORDER BY updated_at DESC
-        LIMIT 1000
+            const stmt = ctx.db.prepare(`
+        SELECT id, key, namespace, content, embedding, provenance_type
+        FROM memory_entries
+        WHERE ${ACTIVE_MEMORY_ROW_SQL} ${whereExtra}
+        ORDER BY updated_at DESC
+        LIMIT 1000
       `);
             rows = filterParams.length > 0 ? stmt.all(...filterParams) : stmt.all();
         }
@@ -1232,12 +1232,12 @@ export async function bridgeListEntries(options) {
         // List
         const entries = [];
         try {
-            const stmt = ctx.db.prepare(`
-        SELECT id, key, namespace, content, embedding, access_count, created_at, updated_at, provenance_type
-        FROM memory_entries
-        WHERE ${statusFilter} ${extraFilter}
-        ORDER BY updated_at DESC
-        LIMIT ? OFFSET ?
+            const stmt = ctx.db.prepare(`
+        SELECT id, key, namespace, content, embedding, access_count, created_at, updated_at, provenance_type
+        FROM memory_entries
+        WHERE ${statusFilter} ${extraFilter}
+        ORDER BY updated_at DESC
+        LIMIT ? OFFSET ?
       `);
             const rows = stmt.all(...filterParams, limit, offset);
             for (const row of rows) {
@@ -1307,11 +1307,11 @@ export async function bridgeGetEntry(options) {
         }
         let row;
         try {
-            const stmt = ctx.db.prepare(`
-        SELECT id, key, namespace, content, embedding, access_count, created_at, updated_at, tags
-        FROM memory_entries
-        WHERE ${ACTIVE_MEMORY_ROW_SQL} AND key = ? AND namespace = ?
-        LIMIT 1
+            const stmt = ctx.db.prepare(`
+        SELECT id, key, namespace, content, embedding, access_count, created_at, updated_at, tags
+        FROM memory_entries
+        WHERE ${ACTIVE_MEMORY_ROW_SQL} AND key = ? AND namespace = ?
+        LIMIT 1
       `);
             row = stmt.get(key, namespace);
         }
@@ -1375,10 +1375,10 @@ export async function bridgeDeleteEntry(options) {
         // Soft delete using parameterized query
         let changes = 0;
         try {
-            const result = ctx.db.prepare(`
-        UPDATE memory_entries
-        SET status = 'deleted', updated_at = ?
-        WHERE key = ? AND namespace = ? AND ${ACTIVE_MEMORY_ROW_SQL}
+            const result = ctx.db.prepare(`
+        UPDATE memory_entries
+        SET status = 'deleted', updated_at = ?
+        WHERE key = ? AND namespace = ? AND ${ACTIVE_MEMORY_ROW_SQL}
       `).run(Date.now(), key, namespace);
             changes = result?.changes ?? 0;
         }
@@ -1617,12 +1617,12 @@ export async function bridgeSearchBruteForceCosine(queryEmbedding, options, dbPa
             // #2982/#2976: same unordered pre-rank truncation as bridgeSearchEntries
             // above — without ORDER BY, a corpus over 10000 rows silently drops
             // its newest entries before cosine scoring ever runs.
-            const stmt = ctx.db.prepare(`
-        SELECT id, key, namespace, content, embedding
-        FROM memory_entries
-        WHERE status = 'active' AND embedding IS NOT NULL ${nsFilter}
-        ORDER BY updated_at DESC
-        LIMIT 10000
+            const stmt = ctx.db.prepare(`
+        SELECT id, key, namespace, content, embedding
+        FROM memory_entries
+        WHERE status = 'active' AND embedding IS NOT NULL ${nsFilter}
+        ORDER BY updated_at DESC
+        LIMIT 10000
       `);
             rows = nsFilter
                 ? stmt.all(options.namespace)
@@ -1679,21 +1679,21 @@ export async function bridgeAddEmbedding(id, embedding, entry, dbPath) {
         // authoritative row, including provenance/tags/metadata; REPLACE deleted
         // that row and recreated it without provenance_type, silently resetting
         // every typed CLI/MCP write to "unknown".
-        ctx.db.prepare(`
-      INSERT INTO memory_entries (
-        id, key, namespace, content, type,
-        embedding, embedding_dimensions, embedding_model,
-        created_at, updated_at, status
-      ) VALUES (?, ?, ?, ?, 'semantic', ?, ?, 'Xenova/all-MiniLM-L6-v2', ?, ?, 'active')
-      ON CONFLICT(namespace, key) DO UPDATE SET
-        id                   = excluded.id,
-        content              = excluded.content,
-        type                 = excluded.type,
-        embedding            = excluded.embedding,
-        embedding_dimensions = excluded.embedding_dimensions,
-        embedding_model      = excluded.embedding_model,
-        updated_at           = excluded.updated_at,
-        status               = 'active'
+        ctx.db.prepare(`
+      INSERT INTO memory_entries (
+        id, key, namespace, content, type,
+        embedding, embedding_dimensions, embedding_model,
+        created_at, updated_at, status
+      ) VALUES (?, ?, ?, ?, 'semantic', ?, ?, 'Xenova/all-MiniLM-L6-v2', ?, ?, 'active')
+      ON CONFLICT(namespace, key) DO UPDATE SET
+        id                   = excluded.id,
+        content              = excluded.content,
+        type                 = excluded.type,
+        embedding            = excluded.embedding,
+        embedding_dimensions = excluded.embedding_dimensions,
+        embedding_model      = excluded.embedding_model,
+        updated_at           = excluded.updated_at,
+        status               = 'active'
     `).run(id, entry.key, entry.namespace, entry.content, embeddingJson, embedding.length, now, now);
         return true;
     }
@@ -1830,16 +1830,33 @@ export async function bridgeStorePattern(options) {
     try {
         const reasoningBank = registry.get('reasoningBank');
         const patternId = generateId('pattern');
-        if (reasoningBank && typeof reasoningBank.store === 'function') {
-            await reasoningBank.store({
-                id: patternId,
-                content: options.pattern,
-                type: options.type,
-                confidence: options.confidence,
+        // #3327 Finding A — the real method is `storePattern`, and it takes a
+        // ReasoningPattern, NOT the {id, content, type, confidence} shape used
+        // here before. `reasoningBank.store` has never existed on agentdb's
+        // ReasoningBank, so `typeof ... === 'function'` was always false and this
+        // branch was dead code — every write fell through to bridge-fallback while
+        // `agentdb_controllers` cheerfully reported `reasoningBank: enabled=true`.
+        //
+        // Contract (agentdb ReasoningBank.d.ts):
+        //   storePattern({ taskType, approach, successRate, uses?, avgReward?,
+        //                  tags?, metadata? }) => Promise<number>   // sqlite rowid
+        // The embedded text is `${taskType}: ${approach}`, so the caller's pattern
+        // text must land in `approach` for search to match on it.
+        if (reasoningBank && typeof reasoningBank.storePattern === 'function') {
+            const rowId = await reasoningBank.storePattern({
+                taskType: options.type,
+                approach: options.pattern,
+                successRate: options.confidence,
+                tags: [options.type, 'reasoning-pattern'],
                 metadata: options.metadata,
-                timestamp: Date.now(),
             });
-            return { success: true, patternId, controller: 'reasoningBank' };
+            // storePattern returns a numeric rowid; surface it as the caller-facing
+            // id so a later getPattern/deletePattern by this id resolves.
+            return {
+                success: true,
+                patternId: rowId != null ? String(rowId) : patternId,
+                controller: 'reasoningBank',
+            };
         }
         // Fallback: store via bridge SQL
         const patternValue = JSON.stringify({ pattern: options.pattern, type: options.type, confidence: options.confidence, metadata: options.metadata });
@@ -1873,7 +1890,13 @@ export async function bridgeStorePattern(options) {
         // be read back — return `patternId` (the real key) instead.
         return { success: true, patternId, controller: 'bridge-fallback' };
     }
-    catch {
+    catch (err) {
+        // #3327 Finding A — this catch is what hid the defect for months. When
+        // ReasoningBank threw `embedPassage is not a function`, the error was
+        // discarded and the caller saw an ordinary fallback, indistinguishable
+        // from "no controller registered". Record it so `agentdb_health` and the
+        // degraded `reason` can name the real cause instead of guessing.
+        bridgeFailureReason = err instanceof Error ? err.message : String(err);
         return null;
     }
 }
@@ -1895,11 +1918,17 @@ export async function bridgeSearchPatterns(options) {
             else {
                 results = await reasoningBank.search(options.query, { topK: options.topK || 5, minScore: options.minConfidence || 0.3 });
             }
+            // #3327 Finding A — agentdb returns ReasoningPattern[]: the text lives in
+            // `approach` and the cosine score in `similarity`. Neither `content`/
+            // `pattern` nor `score`/`confidence` exists on that shape, so the old
+            // mapping produced `content: ''` and `score: 0` for every hit even when
+            // the search itself succeeded. Read the real fields first, keeping the
+            // legacy names as fallbacks for the pre-agentdb shape.
             return {
                 results: Array.isArray(results) ? results.map((r) => ({
-                    id: r.id || r.patternId || '',
-                    content: r.content || r.pattern || '',
-                    score: r.score ?? r.confidence ?? 0,
+                    id: String(r.id ?? r.patternId ?? ''),
+                    content: r.approach ?? r.content ?? r.pattern ?? '',
+                    score: r.similarity ?? r.score ?? r.successRate ?? r.confidence ?? 0,
                 })) : [],
                 controller: 'reasoningBank',
             };
@@ -1954,7 +1983,12 @@ export async function bridgeSearchPatterns(options) {
             controller: 'bridge-fallback',
         } : null;
     }
-    catch {
+    catch (err) {
+        // #3327 Finding A — see bridgeStorePattern's catch. `embedQuery is not a
+        // function` died here silently, which is why search reported
+        // `reasoningBank-unavailable:registry-null` (a null return) even though
+        // the registry was present and the controller was reported enabled.
+        bridgeFailureReason = err instanceof Error ? err.message : String(err);
         return null;
     }
 }
@@ -2091,9 +2125,9 @@ export async function bridgeRecordCausalEdge(options) {
         const ctx = getDb(registry);
         if (ctx) {
             try {
-                ctx.db.prepare(`
-          INSERT OR REPLACE INTO memory_entries (id, key, namespace, content, type, created_at, updated_at, status)
-          VALUES (?, ?, 'causal-edges', ?, 'procedural', ?, ?, 'active')
+                ctx.db.prepare(`
+          INSERT OR REPLACE INTO memory_entries (id, key, namespace, content, type, created_at, updated_at, status)
+          VALUES (?, ?, 'causal-edges', ?, 'procedural', ?, ?, 'active')
         `).run(generateId('edge'), `${options.sourceId}→${options.targetId}`, JSON.stringify(options), Date.now(), Date.now());
                 return { success: true, controller: 'bridge-fallback' };
             }
@@ -2172,10 +2206,10 @@ export async function bridgeDeleteHierarchical(options) {
         const ctx = getDb(registry);
         if (ctx) {
             try {
-                const result = ctx.db.prepare(`
-          UPDATE memory_entries
-          SET status = 'deleted', updated_at = ?
-          WHERE key = ? AND namespace LIKE 'hierarchical%' AND status = 'active'
+                const result = ctx.db.prepare(`
+          UPDATE memory_entries
+          SET status = 'deleted', updated_at = ?
+          WHERE key = ? AND namespace LIKE 'hierarchical%' AND status = 'active'
         `).run(Date.now(), key);
                 const changes = result?.changes ?? 0;
                 if (changes > 0) {
@@ -2251,10 +2285,10 @@ export async function bridgeDeleteCausalEdge(options) {
         const ctx = getDb(registry);
         if (ctx) {
             try {
-                const result = ctx.db.prepare(`
-          UPDATE memory_entries
-          SET status = 'deleted', updated_at = ?
-          WHERE key = ? AND namespace = 'causal-edges' AND status = 'active'
+                const result = ctx.db.prepare(`
+          UPDATE memory_entries
+          SET status = 'deleted', updated_at = ?
+          WHERE key = ? AND namespace = 'causal-edges' AND status = 'active'
         `).run(Date.now(), edgeKey);
                 const changes = result?.changes ?? 0;
                 if (changes > 0) {
@@ -2326,18 +2360,18 @@ export async function bridgeDeleteCausalNode(options) {
         let deletedEdges = 0;
         let deletedNode = false;
         try {
-            const edgeResult = ctx.db.prepare(`
-        UPDATE memory_entries
-        SET status = 'deleted', updated_at = ?
-        WHERE namespace = 'causal-edges'
-          AND status = 'active'
-          AND (key LIKE ? OR key LIKE ?)
+            const edgeResult = ctx.db.prepare(`
+        UPDATE memory_entries
+        SET status = 'deleted', updated_at = ?
+        WHERE namespace = 'causal-edges'
+          AND status = 'active'
+          AND (key LIKE ? OR key LIKE ?)
       `).run(Date.now(), `${nodeId}→%`, `%→${nodeId}`);
             deletedEdges = edgeResult?.changes ?? 0;
-            const nodeResult = ctx.db.prepare(`
-        UPDATE memory_entries
-        SET status = 'deleted', updated_at = ?
-        WHERE key = ? AND status = 'active'
+            const nodeResult = ctx.db.prepare(`
+        UPDATE memory_entries
+        SET status = 'deleted', updated_at = ?
+        WHERE key = ? AND status = 'active'
       `).run(Date.now(), nodeId);
             deletedNode = (nodeResult?.changes ?? 0) > 0;
             await logAttestation(registry, 'delete', nodeId, { namespace: 'causal-nodes', deletedEdges });
@@ -2877,11 +2911,11 @@ export async function bridgeGetAllEmbeddings(options) {
     try {
         const dims = options?.dimensions ?? 384;
         const maxRows = options?.limit ?? 50000;
-        const rows = ctx.db.prepare(`
-      SELECT id, key, namespace, embedding
-      FROM memory_entries
-      WHERE status = 'active' AND embedding IS NOT NULL
-      LIMIT ?
+        const rows = ctx.db.prepare(`
+      SELECT id, key, namespace, embedding
+      FROM memory_entries
+      WHERE status = 'active' AND embedding IS NOT NULL
+      LIMIT ?
     `).all(maxRows);
         const results = [];
         for (const row of rows) {