claude-flow-novice 2.8.1 → 2.9.1

package/.claude/skills/product-owner-decision/validate-deliverables.sh

@@ -1,82 +0,0 @@
-#!/bin/bash
-# Deliverable Verification - Prevent "consensus on vapor"
-
-set -euo pipefail
-
-# Parse arguments
-TASK_ID=""
-EXPECTED_FILES=""
-
-while [[ $# -gt 0 ]]; do
-  case $1 in
-    --task-id)
-      TASK_ID="$2"
-      shift 2
-      ;;
-    --expected-files)
-      EXPECTED_FILES="$2"
-      shift 2
-      ;;
-    *)
-      echo "Unknown option: $1" >&2
-      exit 1
-      ;;
-  esac
-done
-
-if [ -z "$TASK_ID" ]; then
-  echo "ERROR: --task-id required" >&2
-  exit 1
-fi
-
-# Get task description from Redis
-TASK_DESC=$(redis-cli GET "swarm:${TASK_ID}:task" 2>/dev/null || echo "")
-
-# Check if task requires implementation (file creation)
-REQUIRES_FILES=false
-if echo "$TASK_DESC" | grep -qiE "create|build|implement|generate|file|component|module|test|write|add"; then
-  REQUIRES_FILES=true
-fi
-
-# If task doesn't require files, skip verification
-if [ "$REQUIRES_FILES" = false ]; then
-  echo "PASSED"
-  exit 0
-fi
-
-# If expected files specified, verify actual existence
-if [ -n "$EXPECTED_FILES" ]; then
-  MISSING_FILES=()
-  IFS=',' read -ra FILES <<< "$EXPECTED_FILES"
-
-  for file in "${FILES[@]}"; do
-    # Trim whitespace
-    file=$(echo "$file" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')
-
-    if [ ! -f "$file" ]; then
-      MISSING_FILES+=("$file")
-    fi
-  done
-
-  if [ ${#MISSING_FILES[@]} -gt 0 ]; then
-    echo "FAILED"
-    # Store missing files in Redis for orchestrator feedback
-    MISSING_JSON=$(printf '%s\n' "${MISSING_FILES[@]}" | jq -R . | jq -s -c .)
-    redis-cli setex "swarm:${TASK_ID}:missing-files" 300 "$MISSING_JSON" >/dev/null
-    exit 0
-  else
-    echo "PASSED"
-    exit 0
-  fi
-fi
-
-# Fallback: Check for file changes in git (backward compatibility)
-FILES_CREATED=$(git status --short 2>/dev/null | grep -E "^(A|M|\?\?)" | wc -l)
-
-if [ "$FILES_CREATED" -eq 0 ]; then
-  echo "FAILED"
-  exit 0
-else
-  echo "PASSED"
-  exit 0
-fi

package/.claude/skills/redis-coordination/AGENT_LOGGING.md

@@ -1,280 +0,0 @@
-# Agent Logging System
-
-Dual-output logging for CLI-spawned agents: terminal + Redis + portal visibility.
-
-## Features
-
-✅ **Terminal output** - Colored logs for debugging in tmux/terminal
-✅ **File logging** - Persisted to `/tmp/agent-*.log`
-✅ **Redis pub/sub** - Real-time streaming to web portal
-✅ **Redis history** - Last 7 days stored in sorted sets
-✅ **Portal filters** - Filter by repository, agent, or log level
-
-## Quick Start
-
-### 1. Source in Agent Scripts
-
-```bash
-#!/usr/bin/env bash
-source .claude/skills/redis-coordination/agent-log.sh
-
-# Set context
-export AGENT_ID="backend-dev-1"
-export TASK_ID="$1"  # Pass from command line
-
-# Log throughout execution
-agent_log "info" "Starting task execution"
-agent_log "debug" "Loading configuration from $CONFIG_FILE"
-agent_log "warn" "High memory usage detected: ${MEMORY}MB"
-agent_log "error" "Connection failed: $ERROR_MSG"
-```
-
-### 2. Standalone Usage
-
-```bash
-# Direct command-line usage
-./.claude/skills/redis-coordination/agent-log.sh info "Agent initialized" \
-  --agent-id researcher-1 \
-  --task-id task-auth-123
-
-# From any script
-./.claude/skills/redis-coordination/agent-log.sh error "Validation failed" \
-  --agent-id reviewer-2 \
-  --task-id task-auth-123
-```
-
-### 3. Log Levels
-
-- **debug** - Detailed debugging information (cyan)
-- **info** - General informational messages (green)
-- **warn** - Warning messages (yellow)
-- **error** - Error conditions (red)
-
-## Output Destinations
-
-**1. Terminal (with colors)**
-```
-[INFO] [backend-dev-1] Starting authentication implementation
-[WARN] [backend-dev-1] Database connection slow
-[ERROR] [reviewer-1] JWT validation failed
-```
-
-**2. File (`/tmp/agent-<id>.log`)**
-```
-[2025-10-20T07:02:48Z] [INFO] [backend-dev-1] Starting authentication implementation
-[2025-10-20T07:02:48Z] [WARN] [backend-dev-1] Database connection slow
-[2025-10-20T07:02:48Z] [ERROR] [reviewer-1] JWT validation failed
-```
-
-**3. Redis (`swarm:<task-id>:logs`)**
-```json
-{
-  "level": "info",
-  "message": "Starting authentication implementation",
-  "agentId": "backend-dev-1",
-  "taskId": "task-auth-123",
-  "repository": "claude-flow-novice",
-  "timestamp": "2025-10-20T07:02:48Z"
-}
-```
-
-**4. Web Portal (http://localhost:3456 → Logs tab)**
-- Real-time streaming via WebSocket
-- Filter by repository, agent, or level
-- Shows last 1000 logs (100 displayed)
-- Auto-refreshes on new logs
-
-## Integration Points
-
-### Option 1: Source in Main Agent Script
-
-```bash
-# In your main agent script
-source .claude/skills/redis-coordination/agent-log.sh
-
-# Set global context once
-export AGENT_ID="${AGENT_TYPE}-${AGENT_NUM}"
-export TASK_ID="$TASK_ID"
-
-# Then log freely
-agent_log "info" "Agent spawned successfully"
-# ... agent work ...
-agent_log "info" "Task completed with confidence 0.95"
-```
-
-### Option 2: Wrap Agent Spawning
-
-```bash
-# In orchestrate-cfn-loop.sh or spawn-agent.sh
-./.claude/skills/redis-coordination/agent-log.sh info \
-  "Spawning agent: $AGENT_ID for task: $TASK_ID" \
-  --agent-id "$AGENT_ID" \
-  --task-id "$TASK_ID"
-
-# Spawn agent
-npx claude-flow-novice agent "$AGENT_TYPE" --task-id "$TASK_ID"
-
-# Log completion
-./.claude/skills/redis-coordination/agent-log.sh info \
-  "Agent $AGENT_ID completed" \
-  --agent-id "$AGENT_ID" \
-  --task-id "$TASK_ID"
-```
-
-### Option 3: Add to Existing Agent Logic
-
-If you have existing CLI agent code, wrap key operations:
-
-```bash
-# Before long operation
-agent_log "info" "Starting database migration"
-
-# During operation
-if [ "$ROWS_UPDATED" -gt 10000 ]; then
-  agent_log "warn" "Large migration in progress: $ROWS_UPDATED rows"
-fi
-
-# On error
-if ! run_migration; then
-  agent_log "error" "Migration failed: $ERROR"
-  exit 1
-fi
-
-# On success
-agent_log "info" "Migration completed: $ROWS_UPDATED rows updated"
-```
-
-## Advanced Options
-
-### Skip Terminal Output (Quiet Mode)
-
-```bash
-agent_log "info" "Background task started" --no-terminal
-```
-
-### Skip Redis Output (Local Only)
-
-```bash
-agent_log "debug" "Local debug info" --no-redis
-```
-
-### Manual Context Override
-
-```bash
-agent_log "error" "Connection timeout" \
-  --agent-id "custom-agent" \
-  --task-id "override-task-id"
-```
-
-## Portal Usage
-
-1. **Open portal:** http://localhost:3456
-2. **Go to Logs tab** (📝 Logs)
-3. **Filter logs:**
-   - Repository: Select specific repo or "All Repositories"
-   - Agent: Select specific agent or "All Agents"
-   - Level: debug/info/warn/error or "All Levels"
-4. **Clear logs:** Click "Clear Logs" button
-
-**Stats shown:**
-- Total logs in memory
-- Number of repositories logging
-- Number of active agents
-
-## Redis Keys
-
-**Pub/Sub Channel:**
-```
-swarm:<task-id>:logs
-```
-
-**Sorted Set (History):**
-```
-swarm:<task-id>:logs:history
-```
-- Score: Unix timestamp
-- Value: JSON log entry
-- TTL: 7 days (604800 seconds)
-
-## Examples
-
-### Example 1: CFN Loop Agent
-
-```bash
-#!/usr/bin/env bash
-source .claude/skills/redis-coordination/agent-log.sh
-
-AGENT_ID="coder-3"
-TASK_ID="$1"
-
-agent_log "info" "Starting Loop 3 implementation phase"
-
-# Implement feature
-agent_log "debug" "Reading specification from spec.md"
-agent_log "info" "Implementing authentication service"
-
-if ! run_tests; then
-  agent_log "error" "Tests failed - iteration needed"
-  exit 1
-fi
-
-agent_log "info" "Implementation complete - confidence: 0.88"
-```
-
-### Example 2: Orchestrator Logging
-
-```bash
-# In orchestrate-cfn-loop.sh
-agent_log "info" "CFN Loop started - mode: $MODE" \
-  --agent-id "orchestrator" \
-  --task-id "$TASK_ID"
-
-agent_log "info" "Spawning Loop 3 agents: $LOOP3_AGENTS" \
-  --agent-id "orchestrator" \
-  --task-id "$TASK_ID"
-
-# ... spawn agents ...
-
-agent_log "info" "Loop 3 consensus: $CONSENSUS (gate: $GATE_THRESHOLD)" \
-  --agent-id "orchestrator" \
-  --task-id "$TASK_ID"
-```
-
-## Troubleshooting
-
-**Logs not appearing in portal:**
-1. Check Redis connection: `redis-cli ping`
-2. Check portal subscription: Look for "✅ Subscribed to swarm:*:logs" in portal startup
-3. Verify task ID matches swarm task ID
-4. Check Redis pub/sub: `redis-cli psubscribe "swarm:*:logs"`
-
-**Colors not showing in terminal:**
-- WSL/Linux should show colors automatically
-- tmux: Colors should work by default
-- If colors missing, terminal may not support ANSI codes
-
-**Log file not created:**
-- Check permissions on `/tmp/`
-- Verify `AGENT_ID` is set (file named `/tmp/agent-${AGENT_ID}.log`)
-
-## Performance
-
-- **Minimal overhead:** ~5ms per log entry
-- **Non-blocking:** Redis operations use `> /dev/null 2>&1 || true`
-- **Memory efficient:** Portal keeps max 1000 logs, shows 100
-- **Auto-cleanup:** Redis history expires after 7 days
-
-## Migration from Old Logging
-
-**Before:**
-```bash
-echo "[INFO] Agent started"
-```
-
-**After:**
-```bash
-source .claude/skills/redis-coordination/agent-log.sh
-agent_log "info" "Agent started"
-```
-
-Benefits: Same terminal output + Redis pub/sub + portal visibility + file logging

package/.claude/skills/redis-coordination/BZPOPMIN_FIX_SUMMARY.md

@@ -1,209 +0,0 @@
-# BZPOPMIN Implementation Fix Summary
-
-**Task ID:** redis-phase4-1760896217-fix
-**Agent ID:** backend-dev-fix-1
-**Date:** 2025-10-19
-**Confidence:** 0.95
-
-## Problem Statement
-
-The tester reported that BZPOPMIN was not retrieving messages from the sorted set (confidence: 0.10). Root causes identified:
-
-1. **JSON newlines**: `jq -n` produced pretty-printed JSON with newlines, breaking Redis ZADD
-2. **JSON parsing**: Missing validation when retrieving messages from BZPOPMIN
-3. **Debug capability**: No way to troubleshoot issues in production
-
-## Fixes Implemented
-
-### 1. Compact JSON for Redis Storage
-
-**File:** `.claude/skills/redis-coordination/invoke-waiting-mode.sh`
-**Line:** 177
-
-**Change:**
-```bash
-# OLD (broken - has newlines):
-WAKE_MSG=$(jq -n \
-    --arg reason "$REASON" \
-    '{reason: $reason, ...}')
-
-# NEW (fixed - compact):
-WAKE_MSG=$(jq -nc \
-    --arg reason "$REASON" \
-    '{reason: $reason, ...}')
-```
-
-**Impact:** JSON is now stored as a single line, compatible with Redis sorted set operations.
-
-### 2. JSON Validation on Retrieval
-
-**File:** `.claude/skills/redis-coordination/invoke-waiting-mode.sh`
-**Lines:** 150-168
-
-**Change:**
-```bash
-# Added JSON validation after BZPOPMIN
-WAKE_RESULT=$(redis-cli BZPOPMIN "$WAKE_QUEUE" 1 2>/dev/null)
-
-if [ -n "$WAKE_RESULT" ] && [ "$WAKE_RESULT" != "(nil)" ]; then
-    WAKE_MSG=$(echo "$WAKE_RESULT" | sed -n '2p')
-
-    # Validate JSON before processing
-    if echo "$WAKE_MSG" | jq empty 2>/dev/null; then
-        echo "[$AGENT_ID] ✅ Woken up!"
-        echo "$WAKE_MSG" | jq '.'
-        echo "$WAKE_MSG"
-        break
-    else
-        echo "[$AGENT_ID] ⚠️  Invalid JSON in wake message, ignoring"
-        continue
-    fi
-fi
-```
-
-**Impact:** Invalid messages are now detected and skipped, preventing agent crashes.
-
-### 3. Debug Mode
-
-**File:** `.claude/skills/redis-coordination/invoke-waiting-mode.sh`
-**Lines:** 40-41, 208-214
-
-**Change:**
-```bash
-# Environment variable for debug mode
-DEBUG="${DEBUG:-false}"
-
-# Debug output in wake command
-if [ "$DEBUG" = "true" ]; then
-    echo "[DEBUG] WAKE_QUEUE: $WAKE_QUEUE"
-    echo "[DEBUG] PRIORITY: $PRIORITY"
-    echo "[DEBUG] Priority score: $PRIORITY_SCORE"
-    echo "[DEBUG] Message: $WAKE_MSG"
-fi
-```
-
-**Usage:**
-```bash
-DEBUG=true ./invoke-waiting-mode.sh wake --task-id ... --agent-id ...
-```
-
-**Impact:** Troubleshooting production issues is now possible without code modifications.
-
-## Test Results
-
-### Test 1: Compact JSON Storage
-**Status:** ✅ PASSED
-**Verification:**
-```bash
-redis-cli ZRANGE "swarm:verify-test-1760898036:test-agent:wake-queue" 0 -1
-# Output: {"reason":"verify_json","iteration":0,"task":"","feedback":[],"priority":80,"timestamp":1760898036}
-# Single line, valid JSON
-```
-
-### Test 2: Priority Ordering
-**Status:** ✅ PASSED
-**Verification:**
-```bash
-# Sent: low (20), high (90), medium (50)
-# Retrieved: high (90), medium (50), low (20)
-# Order correct: highest priority first
-```
-
-### Test 3: JSON Validation
-**Status:** ✅ PASSED
-**Verification:**
-- Agent validates JSON before processing
-- Invalid messages are skipped with warning
-- No crashes or hangs
-
-### Test 4: Debug Mode
-**Status:** ✅ PASSED
-**Verification:**
-```bash
-DEBUG=true ./invoke-waiting-mode.sh wake ...
-# Output includes [DEBUG] lines with queue name, priority, score, and message
-```
-
-### Test 5: End-to-End Wake-Up Flow
-**Status:** ✅ PASSED
-**Verification:**
-```bash
-# Agent entered waiting mode
-# Agent blocked on BZPOPMIN (zero token cost)
-# Wake signal sent
-# Agent received message and woke up
-# Output: [test-a] ✅ Woken up!
-```
-
-## Performance Metrics
-
-| Metric | Before | After | Improvement |
-|--------|--------|-------|-------------|
-| Message retrieval | 0% success | 100% success | ✅ Fixed |
-| JSON storage | Multi-line (broken) | Single-line (working) | ✅ Fixed |
-| Error handling | None | Validation + skip | ✅ Added |
-| Debug capability | None | Full debug mode | ✅ Added |
-| Priority ordering | Untested | Verified working | ✅ Confirmed |
-
-## Files Modified
-
-1. `.claude/skills/redis-coordination/invoke-waiting-mode.sh`
-   - Added `-c` flag to `jq` for compact JSON (line 177)
-   - Added JSON validation in `enter` command (lines 156-167)
-   - Added debug mode environment variable (line 41)
-   - Added debug output in `wake` command (lines 209-214)
-
-2. `.claude/skills/redis-coordination/test-bzpopmin-fix.sh` (NEW)
-   - Comprehensive test suite for all fixes
-
-3. `.claude/skills/redis-coordination/BZPOPMIN_FIX_SUMMARY.md` (NEW)
-   - This documentation file
-
-## Deployment Notes
-
-**Breaking Changes:** None
-**Backward Compatibility:** Full
-**Migration Required:** No
-
-**Deployment Steps:**
-1. Deploy updated `invoke-waiting-mode.sh`
-2. No Redis data migration needed
-3. Existing wake queues will work with new code
-4. Debug mode is opt-in (set `DEBUG=true`)
-
-## Monitoring Recommendations
-
-1. **Success Rate:** Monitor wake-up success rate (should be 100%)
-2. **JSON Errors:** Track invalid JSON warnings (should be 0 in normal operation)
-3. **Priority Distribution:** Verify high-priority messages are processed first
-4. **Debug Usage:** Monitor DEBUG mode usage (should be enabled only for troubleshooting)
-
-## Confidence Assessment
-
-**Overall Confidence:** 0.95
-
-**Breakdown:**
-- Compact JSON fix: 1.0 (verified working)
-- JSON validation: 0.95 (comprehensive error handling)
-- Debug mode: 1.0 (verified output)
-- Priority ordering: 0.95 (verified correct behavior)
-- End-to-end flow: 0.90 (manual testing passed, automated tests WIP)
-
-**Remaining Risks:**
-- Edge cases with very large JSON messages (>1MB)
-- Redis connection failures during BZPOPMIN (existing issue, not introduced by fix)
-- Concurrent access patterns under extreme load (requires load testing)
-
-## Next Steps
-
-1. **Production Deployment:** Deploy fixes to production
-2. **Monitoring:** Set up alerts for JSON validation errors
-3. **Load Testing:** Verify behavior under high concurrency
-4. **Documentation:** Update SKILL.md with debug mode usage
-
-## References
-
-- Original issue: Tester confidence 0.10 (BZPOPMIN not working)
-- Fixed implementation: `.claude/skills/redis-coordination/invoke-waiting-mode.sh`
-- Test suite: `.claude/skills/redis-coordination/test-bzpopmin-fix.sh`
-- Skill documentation: `.claude/skills/redis-coordination/SKILL.md`

package/.claude/skills/redis-coordination/HEARTBEAT.md

@@ -1,57 +0,0 @@
-# Heartbeat Monitoring Script
-
-## Overview
-This script provides a robust mechanism for tracking agent health and detecting unresponsive agents in a distributed system using Redis.
-
-## Key Features
-- Real-time agent status tracking
-- Configurable TTL and missed heartbeat thresholds
-- Automatic quorum fallback mechanism
-- Detailed logging for debugging
-
-## Usage
-
-### Sending a Heartbeat
-```bash
-./heartbeat.sh send --task-id TASK_ID --agent-id AGENT_ID
-```
-
-### Checking Heartbeat Status
-```bash
-./heartbeat.sh check --task-id TASK_ID --agent-id AGENT_ID
-```
-
-## Configuration Parameters
-- `HEARTBEAT_TTL`: Heartbeat expiration time (default: 60 seconds)
-- `CHECK_INTERVAL`: Recommended check frequency (default: 30 seconds)
-- `MISSED_THRESHOLD`: Number of missed heartbeats before triggering fallback (default: 2)
-
-## Redis Key Structure
-- Heartbeat Key: `swarm:agent_status:{task_id}:{agent_id}`
-- Missed Heartbeat Counter: `swarm:missed_heartbeats:{task_id}:{agent_id}`
-- Quorum Fallback List: `swarm:{task_id}:quorum_fallback`
-
-## Fault Tolerance
-- Automatically detects agent disconnection
-- Supports graceful degradation via quorum fallback
-- Minimal overhead with Redis-based tracking
-
-## Test Coverage
-- 100% Coverage of Core Scenarios
-  - Basic Heartbeat Sending
-  - TTL Expiration
-  - Missed Heartbeat Detection
-  - Quorum Fallback Mechanism
-
-## Performance Characteristics
-- Low-latency Redis operations
-- Constant-time heartbeat tracking
-- Negligible system resource consumption
-
-## Limitations
-- Requires Redis 3.2+ for SETEX functionality
-- Network reliability impacts heartbeat accuracy
-
-## Security Considerations
-- Use in trusted network environments
-- Implement additional authentication for production use