claude-flow-novice 2.18.6 → 2.18.8

package/claude-assets/skills/cfn-agent-lifecycle/lib/spawning/spawn-worker.sh

@@ -1,198 +0,0 @@
-#!/bin/bash
-
-##############################################################################
-# ⚠️  DEPRECATED - This bash script is deprecated
-#
-# Deprecation Date: 2025-11-20
-# Removal Date: 2026-02-20 (90 days)
-# Replacement: dist/cli/spawn-agent-cli.js
-#
-# This script will be removed in 90 days. Please migrate to TypeScript.
-#
-# Migration Guide: See docs/BASH_DEPRECATION_NOTICE.md
-# TypeScript Benefits:
-#   - Type safety (zero runtime type errors)
-#   - 90%+ test coverage
-#   - Better performance
-#   - Comprehensive documentation
-#
-# Automatic Migration:
-#   Set USE_TYPESCRIPT=true to use TypeScript implementation automatically
-#
-##############################################################################
-
-set -eu
-
-# Get the project root directory
-SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-PROJECT_ROOT="$(cd "$SCRIPT_DIR/../../.." && pwd)"
-
-# Load team providers configuration
-PROVIDERS_CONFIG="${PROJECT_ROOT}/.claude/cfn-config/team-providers.json"
-
-# Validate configuration file exists
-if [[ ! -f "$PROVIDERS_CONFIG" ]]; then
-    echo "Error: Team providers configuration not found at $PROVIDERS_CONFIG"
-    exit 1
-fi
-
-# Function to validate provider configuration
-validate_provider_config() {
-    local team="$1"
-    local role="$2"  # coordinator or workers
-
-    # Use jq to validate JSON structure and extract provider details
-    if ! jq -e ".teams.${team}.${role}" "$PROVIDERS_CONFIG" &>/dev/null; then
-        echo "Error: Invalid or missing provider configuration for team=${team}, role=${role}"
-        exit 1
-    fi
-}
-
-# Function to select appropriate model based on complexity
-select_model() {
-    local team="$1"
-    local complexity="$2"  # simple or complex
-
-    # Retrieve model based on complexity and team configuration
-    local model=$(jq -r ".teams.${team}.workers.models.${complexity}" "$PROVIDERS_CONFIG")
-
-    if [[ "$model" == "null" ]]; then
-        # Fallback to default complexity from global config
-        local default_complexity=$(jq -r ".global_config.default_complexity // \"simple\"" "$PROVIDERS_CONFIG")
-        model=$(jq -r ".teams.${team}.workers.models.${default_complexity}" "$PROVIDERS_CONFIG")
-    fi
-
-    echo "$model"
-}
-
-# Function to get API key from environment
-get_api_key() {
-    local team="$1"
-    local role="$2"  # coordinator or workers
-
-    # Extract apiKeyEnvVar from config
-    local api_key_env_var=$(jq -r ".teams.${team}.${role}.apiKeyEnvVar" "$PROVIDERS_CONFIG")
-
-    if [[ "$api_key_env_var" == "null" ]]; then
-        echo "Error: apiKeyEnvVar not found for team=${team}, role=${role}"
-        exit 1
-    fi
-
-    # Get actual API key value from environment
-    local api_key_value="${!api_key_env_var:-}"
-
-    if [[ -z "$api_key_value" ]]; then
-        echo "Error: API key not found in environment variable: $api_key_env_var"
-        exit 1
-    fi
-
-    echo "$api_key_value"
-}
-
-# Main worker spawning logic
-spawn_worker() {
-    local team="$1"
-    local complexity="${2:-simple}"
-    local provider_mode="${3:-auto}"
-    local agent_type="${4:-}"
-    local task_context="${5:-}"
-
-    # Validate input parameters
-    validate_provider_config "$team" "workers"
-
-    # Retrieve provider details from config
-    local provider=$(jq -r ".teams.${team}.workers.provider" "$PROVIDERS_CONFIG")
-    local api_key_env_var=$(jq -r ".teams.${team}.workers.apiKeyEnvVar" "$PROVIDERS_CONFIG")
-    local base_url=$(jq -r ".teams.${team}.workers.baseUrl" "$PROVIDERS_CONFIG")
-
-    # Select model dynamically based on complexity
-    local model=$(select_model "$team" "$complexity")
-
-    # Get API key from environment
-    local api_key=$(get_api_key "$team" "workers")
-
-    # Provider routing logic
-    case "$provider_mode" in
-        auto)
-            # Use provider routing rules from config
-            case "$provider" in
-                zai)
-                    echo "Spawning Z.ai worker for team ${team} (Model: ${model}, Complexity: ${complexity})"
-
-                    # Set environment variables for Z.ai spawning
-                    export ZAI_API_KEY="$api_key"
-                    export ZAI_BASE_URL="$base_url"
-                    export ZAI_MODEL="$model"
-
-                    # Call actual spawning logic (to be implemented)
-                    # npx claude-flow-novice spawn "$agent_type" \
-                    #   --provider zai \
-                    #   --model "$model" \
-                    #   --context "$task_context"
-                    ;;
-                anthropic)
-                    echo "Spawning Anthropic worker for team ${team} (Model: ${model}, Complexity: ${complexity})"
-
-                    # Set environment variables for Anthropic spawning
-                    export ANTHROPIC_API_KEY="$api_key"
-                    export ANTHROPIC_BASE_URL="$base_url"
-                    export ANTHROPIC_MODEL="$model"
-
-                    # Call actual spawning logic (to be implemented)
-                    # npx claude-flow-novice spawn "$agent_type" \
-                    #   --provider anthropic \
-                    #   --model "$model" \
-                    #   --context "$task_context"
-                    ;;
-                *)
-                    echo "Error: Unsupported provider: ${provider}"
-                    exit 1
-                    ;;
-            esac
-            ;;
-        zai)
-            echo "Force spawning Z.ai worker for team ${team} (Model: ${model})"
-            local api_key=$(get_api_key "$team" "workers")
-            export ZAI_API_KEY="$api_key"
-            export ZAI_BASE_URL="$base_url"
-            export ZAI_MODEL="$model"
-            ;;
-        anthropic)
-            echo "Force spawning Anthropic worker for team ${team} (Model: ${model})"
-            local api_key=$(get_api_key "$team" "workers")
-            export ANTHROPIC_API_KEY="$api_key"
-            export ANTHROPIC_BASE_URL="$base_url"
-            export ANTHROPIC_MODEL="$model"
-            ;;
-        *)
-            echo "Error: Invalid provider mode: ${provider_mode}"
-            exit 1
-            ;;
-    esac
-
-    # Log successful configuration
-    echo "Worker configuration complete:"
-    echo "  Team: $team"
-    echo "  Provider: $provider"
-    echo "  Model: $model"
-    echo "  Base URL: $base_url"
-    echo "  Complexity: $complexity"
-}
-
-# Allow script to be used as a function or executed directly
-if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
-    # Script is being run directly
-    if [[ $# -lt 1 ]]; then
-        echo "Usage: $0 <team> [complexity] [provider_mode] [agent_type] [task_context]"
-        echo ""
-        echo "Arguments:"
-        echo "  team           - Team name (marketing, engineering, sales, support, finance)"
-        echo "  complexity     - simple|complex (default: simple)"
-        echo "  provider_mode  - auto|zai|anthropic (default: auto)"
-        echo "  agent_type     - Agent type to spawn (optional)"
-        echo "  task_context   - Task context for agent (optional)"
-        exit 1
-    fi
-
-    spawn_worker "$@"
-fi

package/claude-assets/skills/cfn-agent-tooling/SKILL.md

@@ -1,52 +0,0 @@
----
-name: cfn-agent-tooling
-description: Agent development tools - generation and validation
-version: 1.0.0
-tags: [mega-skill, agents, templates, validation, development]
-status: production
----
-
-# Agent Tooling Skill (Mega-Skill)
-
-**Version:** 1.0.0
-**Purpose:** Agent development tools - generation and validation
-**Status:** Production
-**Consolidates:** agent-template-generator, agent-validation-linter
-
----
-
-## Overview
-
-This mega-skill provides agent development tools:
-- **Generator** - Agent template scaffolding and generation
-- **Linter** - Agent profile validation and linting
-
----
-
-## Directory Structure
-
-```
-agent-tooling/
-├── SKILL.md
-├── lib/
-│   ├── generator/        # From agent-template-generator
-│   └── linter/           # From agent-validation-linter
-└── cli/
-```
-
----
-
-## Migration Paths
-
-| Old Path | New Path |
-|----------|----------|
-| agent-template-generator/ | agent-tooling/lib/generator/ |
-| agent-validation-linter/ | agent-tooling/lib/linter/ |
-
----
-
-## Version History
-
-### 1.0.0 (2025-12-02)
-- Consolidated 2 agent tooling skills into mega-skill
-

package/claude-assets/skills/cfn-agent-tooling/lib/generator/SKILL.md

@@ -1,440 +0,0 @@
----
-name: agent-template-generator
-description: Generates new agent profiles with consistent structure, automatic validation pattern injection, and test-driven protocols
-category: development
-version: 1.0.0
-dependencies: [bash, json-validation]
----
-
-# Agent Template Generator Skill
-
-**Purpose:** Creates new agent profiles with enforced consistency, automatic validation pattern inclusion, and test-driven development protocols.
-
-**Benefits:**
-- ✅ Consistent agent structure across all profiles
-- ✅ Automatic injection of centralized validation skill
-- ✅ Test-driven development pattern by default
-- ✅ Prevents validation anti-patterns
-- ✅ Reduces agent creation time (60 min → 5 min)
-
----
-
-## Quick Start
-
-### Generate a Specialist Agent
-
-```bash
-./.claude/skills/agent-template-generator/generate-agent.sh \
-  --name "api-security-specialist" \
-  --type "specialist" \
-  --description "MUST BE USED for API security audits, penetration testing, and vulnerability assessment"
-```
-
-### Generate a Validator Agent
-
-```bash
-./.claude/skills/agent-template-generator/generate-agent.sh \
-  --name "security-validator" \
-  --type "validator" \
-  --description "MUST BE USED for Loop 2 security validation and threat model review"
-```
-
-### Generate with Custom Configuration
-
-```bash
-./.claude/skills/agent-template-generator/generate-agent.sh \
-  --name "custom-agent" \
-  --type "specialist" \
-  --description "Agent description here" \
-  --model "haiku" \
-  --provider "anthropic" \
-  --provider-model "claude-3-haiku-20240307" \
-  --tools "[Read, Write, Bash, TodoWrite]"
-```
-
----
-
-## Command Reference
-
-### Required Arguments
-
-| Argument | Description | Example |
-|----------|-------------|---------|
-| `--name` | Agent name (lowercase-with-hyphens) | `api-security-specialist` |
-| `--description` | Agent description (MUST BE USED pattern) | `MUST BE USED for API security audits` |
-
-### Optional Arguments
-
-| Argument | Description | Default |
-|----------|-------------|---------|
-| `--type` | Agent type (specialist\|validator\|coordinator\|utility) | `specialist` |
-| `--tools` | Tool list (JSON array) | `[Read, Write, Edit, Bash, Grep, Glob, TodoWrite]` |
-| `--model` | Claude model (sonnet\|opus\|haiku) | `sonnet` |
-| `--acl-level` | Access control level (1-3) | `1` |
-| `--output-dir` | Output directory (overrides type-based default) | Auto-determined |
-| `--provider` | AI provider (zai\|kimi\|openrouter\|anthropic) | `zai` |
-| `--provider-model` | Provider-specific model | `glm-4.6` |
-
----
-
-## Agent Types and Output Directories
-
-| Type | Description | Default Output Directory |
-|------|-------------|--------------------------|
-| `specialist` | Domain-specific implementation (Loop 3) | `.claude/agents/cfn-dev-team/developers/` |
-| `validator` | Code review and validation (Loop 2) | `.claude/agents/cfn-dev-team/reviewers/quality/` |
-| `coordinator` | Multi-agent orchestration | `.claude/agents/cfn-dev-team/coordinators/` |
-| `utility` | Supporting tools and helpers | `.claude/agents/cfn-dev-team/utility/` |
-
----
-
-## Generated Template Structure
-
-### 1. YAML Frontmatter
-
-```yaml
----
-name: agent-name
-description: MUST BE USED description
-tools: [Read, Write, Edit, Bash, Grep, Glob, TodoWrite]
-model: sonnet
-type: specialist
-acl_level: 1
-validation_hooks:
-  - agent-template-validator
-  - test-coverage-validator
----
-```
-
-### 2. Provider Configuration
-
-```markdown
-<!-- PROVIDER_PARAMETERS
-provider: zai
-model: glm-4.6
--->
-```
-
-### 3. Success Criteria Integration ✅ AUTO-INJECTED
-
-**Automatically includes:**
-- Source centralized validation skill
-- validate_success_criteria() call
-- Helper function examples (list_test_suites, get_test_command, get_pass_threshold)
-
-```bash
-source .claude/skills/json-validation/validate-success-criteria.sh
-validate_success_criteria || exit 1
-```
-
-### 4. TDD Protocol ✅ AUTO-INJECTED
-
-**Automatically includes:**
-- Write Tests First guidelines
-- Implementation workflow
-- Validation steps with timing guidance
-
-### 5. Test-Driven Validation ✅ AUTO-INJECTED
-
-**Automatically includes:**
-- Test execution pattern
-- Result parsing with parse-test-results.sh
-- Completion reporting (NOT confidence scores)
-
-### 6. Customization Sections
-
-Generated template includes placeholders for:
-- Domain expertise
-- Core responsibilities
-- Best practices
-- Common pitfalls
-- Success metrics
-- Example workflows
-- Integration points
-
----
-
-## Workflow: Creating a New Agent
-
-### Step 1: Generate Template
-
-```bash
-./.claude/skills/agent-template-generator/generate-agent.sh \
-  --name "graphql-security-specialist" \
-  --type "specialist" \
-  --description "MUST BE USED for GraphQL schema security audits and injection prevention"
-```
-
-**Output:**
-```
-✅ Agent template created: .claude/agents/cfn-dev-team/developers/graphql-security-specialist.md
-
-Next steps:
-1. Customize the [DOMAIN EXPERTISE] placeholder
-2. Fill in Core Responsibilities
-3. Customize Domain-Specific Guidelines
-4. Define Success Metrics
-5. Add Example Workflows
-6. Document Integration Points
-7. Add relevant references
-
-Validation Pattern: ✅ Automatically included
-Test-Driven Protocol: ✅ Automatically included
-Provider Configuration: ✅ Set to zai (glm-4.6)
-```
-
-### Step 2: Customize Template
-
-Open generated file and replace placeholders:
-
-```bash
-# Edit the generated file
-code .claude/agents/cfn-dev-team/developers/graphql-security-specialist.md
-```
-
-**Customize:**
-1. Replace `[DOMAIN EXPERTISE - TO BE CUSTOMIZED]` with specific domain
-2. Fill in 3-5 core responsibilities
-3. Add domain-specific best practices
-4. Define success metrics
-5. Add 2-3 example workflows
-6. Document integration with other agents
-
-### Step 3: Validate Structure
-
-```bash
-# Verify frontmatter is valid YAML
-head -20 .claude/agents/cfn-dev-team/developers/graphql-security-specialist.md
-
-# Verify validation skill is sourced
-grep -A 5 "source .claude/skills/json-validation" .claude/agents/cfn-dev-team/developers/graphql-security-specialist.md
-```
-
-### Step 4: Test Agent
-
-```bash
-# Test with sample criteria
-AGENT_SUCCESS_CRITERIA='{"test_suites":[{"name":"security-tests","command":"npm run test:security","pass_threshold":0.95}]}' \
-  cfn-spawn agent graphql-security-specialist \
-    --task "Test validation integration"
-```
-
----
-
-## Examples
-
-### Example 1: API Security Specialist
-
-```bash
-./.claude/skills/agent-template-generator/generate-agent.sh \
-  --name "api-security-specialist" \
-  --type "specialist" \
-  --description "MUST BE USED for API security audits, penetration testing, and vulnerability assessment. Use PROACTIVELY for OAuth2 security, rate limiting, input validation. Keywords - API security, OWASP, penetration testing, vulnerability assessment"
-```
-
-### Example 2: Performance Validator
-
-```bash
-./.claude/skills/agent-template-generator/generate-agent.sh \
-  --name "performance-validator" \
-  --type "validator" \
-  --description "MUST BE USED for Loop 2 performance validation, load testing review, and bottleneck identification"
-```
-
-### Example 3: Epic Coordinator (Haiku Model)
-
-```bash
-./.claude/skills/agent-template-generator/generate-agent.sh \
-  --name "sprint-coordinator" \
-  --type "coordinator" \
-  --description "MUST BE USED for multi-sprint orchestration and epic decomposition" \
-  --model "haiku" \
-  --acl-level "3"
-```
-
-### Example 4: Custom Output Directory
-
-```bash
-./.claude/skills/agent-template-generator/generate-agent.sh \
-  --name "custom-specialist" \
-  --type "specialist" \
-  --description "Custom agent" \
-  --output-dir ".claude/agents/cfn-dev-team/custom"
-```
-
----
-
-## Validation Features
-
-### Automatic Injection
-
-All generated agents automatically include:
-
-1. **Centralized Validation Skill:**
-   ```bash
-   source .claude/skills/json-validation/validate-success-criteria.sh
-   validate_success_criteria || exit 1
-   ```
-
-2. **Test-Driven Protocol:**
-   - Write Tests First guidelines
-   - Implementation workflow
-   - Validation steps
-
-3. **Completion Protocol:**
-   - Test execution pattern
-   - Result parsing
-   - Report completion (NOT confidence scores)
-
-### Prevented Anti-Patterns
-
-Generator prevents:
-- ❌ Inline duplicate validation code
-- ❌ Missing validation on AGENT_SUCCESS_CRITERIA
-- ❌ Inconsistent test-driven protocols
-- ❌ Subjective confidence score reporting
-- ❌ Missing provider configuration
-
----
-
-## Benefits vs Manual Creation
-
-| Aspect | Manual Creation | Template Generator |
-|--------|----------------|-------------------|
-| Time | 60 minutes | 5 minutes (setup) + 10 minutes (customization) |
-| Validation Pattern | Must remember to include | ✅ Automatic injection |
-| Test-Driven Protocol | Must copy from existing agent | ✅ Automatic injection |
-| Structure Consistency | Prone to variation | ✅ Enforced consistency |
-| Security | May forget validation | ✅ Always includes CVSS 8.2 protection |
-| Provider Config | May forget to add | ✅ Always included |
-
-**Time Savings:** ~75% reduction in agent creation time
-
----
-
-## Testing
-
-### Test Template Generation
-
-```bash
-# Test basic generation
-./.claude/skills/agent-template-generator/generate-agent.sh \
-  --name "test-agent" \
-  --type "specialist" \
-  --description "Test agent for validation"
-
-# Verify output file
-ls -la .claude/agents/cfn-dev-team/developers/test-agent.md
-
-# Cleanup
-rm .claude/agents/cfn-dev-team/developers/test-agent.md
-```
-
-### Verify Validation Integration
-
-```bash
-# Generate agent
-./.claude/skills/agent-template-generator/generate-agent.sh \
-  --name "test-validator" \
-  --type "validator" \
-  --description "Test"
-
-# Verify validation skill is sourced
-grep "source .claude/skills/json-validation/validate-success-criteria.sh" \
-  .claude/agents/cfn-dev-team/reviewers/quality/test-validator.md
-
-# Cleanup
-rm .claude/agents/cfn-dev-team/reviewers/quality/test-validator.md
-```
-
----
-
-## Integration with Other Skills
-
-### 1. JSON Validation Skill
-
-**Dependency:** All generated agents automatically source `json-validation` skill.
-
-**Integration:**
-```bash
-source .claude/skills/json-validation/validate-success-criteria.sh
-validate_success_criteria || exit 1
-```
-
-### 2. CFN Loop Orchestration
-
-**Integration Point:** Generated agents include test execution pattern using `parse-test-results.sh`.
-
-**Pattern:**
-```bash
-RESULTS=$(./.claude/skills/cfn-loop-orchestration/helpers/parse-test-results.sh \
-    "jest" "$TEST_OUTPUT")
-```
-
-### 3. Redis Coordination
-
-**Integration Point:** Generated agents include completion reporting using `report-completion.sh`.
-
-**Pattern:**
-```bash
-./.claude/skills/cfn-redis-coordination/report-completion.sh \
-    --task-id "$TASK_ID" \
-    --agent-id "$AGENT_ID" \
-    --test-results "$RESULTS"
-```
-
----
-
-## Future Enhancements
-
-### v1.1.0 (Planned)
-- [ ] Interactive mode (prompts for each field)
-- [ ] Validation of generated agent structure
-- [ ] Template versioning support
-- [ ] Support for custom template paths
-
-### v2.0.0 (Future)
-- [ ] Multiple template variants (minimal, standard, comprehensive)
-- [ ] Agent capability auto-detection
-- [ ] Integration with agent-builder skill
-- [ ] Automated testing for generated agents
-
----
-
-## Troubleshooting
-
-### Error: Agent file already exists
-
-**Cause:** Attempting to generate agent that already exists.
-
-**Solution:**
-```bash
-# Remove existing file or choose different name
-rm .claude/agents/cfn-dev-team/developers/existing-agent.md
-
-# Or use different name
---name "existing-agent-v2"
-```
-
-### Error: Invalid agent type
-
-**Cause:** Using invalid agent type.
-
-**Valid types:**
-- `specialist`
-- `validator`
-- `coordinator`
-- `utility`
-
-### Generated agent has customization placeholders
-
-**Expected Behavior:** All generated agents include `[CUSTOMIZE]` and `[TO BE CUSTOMIZED]` markers.
-
-**Solution:** Replace all placeholders with domain-specific content.
-
----
-
-**Status:** Production-ready (v1.0.0)
-**Time Savings:** 75% reduction in agent creation time
-**Security:** Auto-injection of CVSS 8.2 validation protection
-**Consistency:** 100% structure enforcement across all new agents