claude-flow-novice 2.18.6 → 2.18.7

package/claude-assets/skills/cfn-validation-framework/lib/instrumentation/wrapped-executor.sh

@@ -1,291 +0,0 @@
-#!/usr/bin/env bash
-
-##############################################################################
-# CFN Validation Runner Process Instrumentation
-# Provides process wrapping, monitoring, and instrumentation for CFN agents
-#
-# Usage:
-#   source wrapped-executor.sh
-#   wrap_execution <command> <timeout> <log_prefix>
-#
-# Example:
-#   wrap_execution "npx claude-flow-novice agent coder" 300 "agent-execution"
-##############################################################################
-
-set -euo pipefail
-
-# Instrumentation state
-declare -A CFN_INSTRUMENT_STATE
-CFN_INSTRUMENT_STATE["active"]=false
-CFN_INSTRUMENT_STATE["start_time"]=0
-CFN_INSTRUMENT_STATE["pid"]=0
-CFN_INSTRUMENT_STATE["timeout"]=0
-CFN_INSTRUMENT_STATE["log_prefix"]=""
-
-# Default timeouts (seconds)
-readonly DEFAULT_TIMEOUT=300        # 5 minutes
-readonly MAX_TIMEOUT=3600           # 1 hour
-readonly WARNING_TIMEOUT=240        # 4 minutes
-
-# Resource limits
-# Note: MAX_MEMORY_MB may be set by task-mode-env-sanitizer.sh (4096)
-# Only set if not already defined
-: "${MAX_MEMORY_MB:=2048}"
-readonly MAX_CPU_PERCENT=80
-
-##############################################################################
-# Core Instrumentation Functions
-##############################################################################
-
-wrap_execution() {
-    local command="$1"
-    local timeout="${2:-$DEFAULT_TIMEOUT}"
-    local log_prefix="${3:-cfn-execution}"
-
-    # Validate timeout
-    if (( timeout > MAX_TIMEOUT )); then
-        timeout=$MAX_TIMEOUT
-        echo "⚠️ Timeout capped at ${MAX_TIMEOUT}s" >&2
-    fi
-
-    # Initialize instrumentation state
-    CFN_INSTRUMENT_STATE["active"]=true
-    CFN_INSTRUMENT_STATE["start_time"]=$(date +%s)
-    CFN_INSTRUMENT_STATE["timeout"]=$timeout
-    CFN_INSTRUMENT_STATE["log_prefix"]="$log_prefix"
-
-    echo "🔧 CFN Process Instrumentation v1.0.0" >&2
-    echo "   Command: $command" >&2
-    echo "   Timeout: ${timeout}s" >&2
-    echo "   PID: $$" >&2
-    echo "   Start: $(date -u +%Y-%m-%dT%H:%M:%SZ)" >&2
-
-    # Setup monitoring
-    setup_process_monitoring "$timeout" "$log_prefix"
-
-    # Execute with instrumentation
-    local result
-    result=$(execute_with_monitoring "$command" "$timeout" "$log_prefix")
-    local exit_code=$?
-
-    # Cleanup and report
-    cleanup_instrumentation "$exit_code"
-
-    return $exit_code
-}
-
-setup_process_monitoring() {
-    local timeout="$1"
-    local log_prefix="$2"
-
-    echo "   Setting up process monitoring..." >&2
-
-    # Start resource monitoring in background
-    (
-        local monitor_interval=30  # Check every 30 seconds
-        local elapsed=0
-
-        while (( elapsed < timeout )); do
-            sleep $monitor_interval
-            elapsed=$((elapsed + monitor_interval))
-
-            if [[ "${CFN_INSTRUMENT_STATE[active]}" == "true" ]]; then
-                check_resource_usage "$log_prefix" "$elapsed"
-            else
-                break
-            fi
-        done
-
-        # Timeout warning
-        if [[ "${CFN_INSTRUMENT_STATE[active]}" == "true" ]]; then
-            echo "⚠️ [$log_prefix] Approaching timeout: ${elapsed}s" >&2
-        fi
-    ) &
-
-    echo "   Resource monitoring started (interval: 30s)" >&2
-}
-
-check_resource_usage() {
-    local log_prefix="$1"
-    local elapsed="$2"
-
-    # Check memory usage
-    if command -v ps >/dev/null 2>&1; then
-        local memory_mb=$(ps -o rss= -p $$ 2>/dev/null | awk '{print int($1/1024)}' || echo "0")
-
-        if (( memory_mb > MAX_MEMORY_MB )); then
-            echo "⚠️ [$log_prefix] High memory: ${memory_mb}MB (limit: ${MAX_MEMORY_MB}MB)" >&2
-        fi
-    fi
-
-    # Check CPU usage (basic check)
-    if command -v top >/dev/null 2>&1; then
-        local cpu_percent=$(top -b -n 1 -p $$ 2>/dev/null | awk 'NR>7 {print $9}' | head -1 || echo "0")
-
-        if (( $(echo "$cpu_percent > $MAX_CPU_PERCENT" | bc -l 2>/dev/null || echo "0") )); then
-            echo "⚠️ [$log_prefix] High CPU: ${cpu_percent}%" >&2
-        fi
-    fi
-
-    # Warning timeout check
-    if (( elapsed > WARNING_TIMEOUT )); then
-        echo "⏰ [$log_prefix] Long running: ${elapsed}s" >&2
-    fi
-}
-
-execute_with_monitoring() {
-    local command="$1"
-    local timeout="$2"
-    local log_prefix="$3"
-
-    echo "   Executing: $command" >&2
-
-    # Store command PID for monitoring
-    local child_pid
-
-    # Execute command with timeout
-    if command -v timeout >/dev/null 2>&1; then
-        # Use system timeout if available
-        timeout "$timeout" bash -c "$command" &
-        child_pid=$!
-        CFN_INSTRUMENT_STATE["pid"]=$child_pid
-
-        echo "   Process PID: $child_pid" >&2
-
-        # Wait for completion with monitoring
-        local wait_result=0
-        while kill -0 $child_pid 2>/dev/null; do
-            sleep 5
-
-            # Check if we're approaching timeout
-            local elapsed=$(($(date +%s) - CFN_INSTRUMENT_STATE[start_time]))
-            if (( elapsed > timeout - 10 )); then
-                echo "⚠️ [$log_prefix] Approaching hard timeout, preparing graceful shutdown" >&2
-            fi
-        done
-
-        wait $child_pid
-        wait_result=$?
-
-    else
-        # Fallback without system timeout
-        echo "   Running without system timeout (not available)" >&2
-        bash -c "$command" &
-        child_pid=$!
-        CFN_INSTRUMENT_STATE["pid"]=$child_pid
-
-        # Basic wait (less safe)
-        wait $child_pid
-        wait_result=$?
-    fi
-
-    return $wait_result
-}
-
-cleanup_instrumentation() {
-    local exit_code="$1"
-    local elapsed=$(($(date +%s) - CFN_INSTRUMENT_STATE[start_time]))
-
-    echo "🧹 Process instrumentation cleanup" >&2
-    echo "   Exit code: $exit_code" >&2
-    echo "   Duration: ${elapsed}s" >&2
-
-    # Kill any remaining background processes
-    if [[ -n "${CFN_INSTRUMENT_STATE[pid]:-}" ]] && kill -0 "${CFN_INSTRUMENT_STATE[pid]}" 2>/dev/null; then
-        echo "   Terminating child process: ${CFN_INSTRUMENT_STATE[pid]}" >&2
-        kill -TERM "${CFN_INSTRUMENT_STATE[pid]}" 2>/dev/null || true
-        sleep 2
-        kill -KILL "${CFN_INSTRUMENT_STATE[pid]}" 2>/dev/null || true
-    fi
-
-    # Clear state
-    CFN_INSTRUMENT_STATE["active"]=false
-    CFN_INSTRUMENT_STATE["pid"]=0
-
-    echo "✅ Instrumentation cleanup complete" >&2
-}
-
-##############################################################################
-# Utility Functions
-##############################################################################
-
-get_instrumentation_status() {
-    if [[ "${CFN_INSTRUMENT_STATE[active]}" == "true" ]]; then
-        local elapsed=$(($(date +%s) - CFN_INSTRUMENT_STATE[start_time]))
-        echo "CFN Instrumentation Status: ACTIVE"
-        echo "  PID: $$"
-        echo "  Child PID: ${CFN_INSTRUMENT_STATE[pid]}"
-        echo "  Elapsed: ${elapsed}s"
-        echo "  Timeout: ${CFN_INSTRUMENT_STATE[timeout]}s"
-        echo "  Log Prefix: ${CFN_INSTRUMENT_STATE[log_prefix]}"
-    else
-        echo "CFN Instrumentation Status: INACTIVE"
-    fi
-}
-
-force_kill_execution() {
-    local signal="${1:-TERM}"
-
-    if [[ "${CFN_INSTRUMENT_STATE[active]}" == "true" ]] && [[ -n "${CFN_INSTRUMENT_STATE[pid]:-}" ]]; then
-        echo "🚨 Force killing execution: ${CFN_INSTRUMENT_STATE[pid]} (signal: $signal)" >&2
-        kill -"$signal" "${CFN_INSTRUMENT_STATE[pid]}" 2>/dev/null || true
-
-        if [[ "$signal" == "TERM" ]]; then
-            sleep 2
-            if kill -0 "${CFN_INSTRUMENT_STATE[pid]}" 2>/dev/null; then
-                kill -KILL "${CFN_INSTRUMENT_STATE[pid]}" 2>/dev/null || true
-            fi
-        fi
-    fi
-}
-
-##############################################################################
-# Signal Handlers
-##############################################################################
-
-setup_signal_handlers() {
-    trap 'handle_instrumentation_signal INT' INT
-    trap 'handle_instrumentation_signal TERM' TERM
-    trap 'handle_instrumentation_signal HUP' HUP
-}
-
-handle_instrumentation_signal() {
-    local signal="$1"
-    echo "🛑 Instrumentation received signal: $signal" >&2
-
-    if [[ "${CFN_INSTRUMENT_STATE[active]}" == "true" ]]; then
-        force_kill_execution TERM
-        cleanup_instrumentation 130
-    fi
-
-    exit 130
-}
-
-##############################################################################
-# Auto-initialization
-##############################################################################
-
-# If script is sourced, make instrumentation available
-if [[ "${BASH_SOURCE[0]}" != "${0}" ]]; then
-    echo "🔧 CFN Process Instrumentation loaded" >&2
-    echo "   Use: wrap_execution <command> <timeout> <log_prefix>" >&2
-    setup_signal_handlers
-fi
-
-# If script is executed directly, show usage
-if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
-    echo "CFN Process Instrumentation v1.0.0"
-    echo ""
-    echo "Usage:"
-    echo "  source wrapped-executor.sh"
-    echo "  wrap_execution \"command\" timeout log_prefix"
-    echo ""
-    echo "Example:"
-    echo "  wrap_execution \"npx claude-flow-novice agent coder\" 300 \"agent-execution\""
-    echo ""
-
-    # Test run if arguments provided
-    if [[ $# -gt 0 ]]; then
-        wrap_execution "$@"
-    fi
-fi

package/claude-assets/skills/cfn-validation-framework/lib/json/SKILL.md

@@ -1,431 +0,0 @@
----
-name: json-validation
-description: Centralized JSON validation for AGENT_SUCCESS_CRITERIA with defensive parsing and injection attack prevention (CVSS 8.2)
-category: security
-version: 1.0.0
-dependencies: [jq]
----
-
-# JSON Validation Skill
-
-**Purpose:** Provides centralized, defensive JSON parsing for `AGENT_SUCCESS_CRITERIA` environment variable to prevent injection attacks and ensure consistent error handling across all agents.
-
-**Security:** Prevents JSON injection attacks (CVSS 8.2) through strict validation before parsing.
-
-**Coverage:** Used by all 21 CFN Loop agents for test-driven validation.
-
----
-
-## Quick Start
-
-### Basic Usage
-
-```bash
-# Source the validation functions
-source .claude/skills/json-validation/validate-success-criteria.sh
-
-# Validate and parse AGENT_SUCCESS_CRITERIA
-if validate_success_criteria; then
-    echo "✅ Success criteria validated"
-
-    # Access parsed data
-    list_test_suites
-else
-    echo "❌ Validation failed"
-    exit 1
-fi
-```
-
-### Common Patterns
-
-**1. Validate criteria at agent startup:**
-```bash
-#!/usr/bin/env bash
-source .claude/skills/json-validation/validate-success-criteria.sh
-
-# Validate on startup (exits on failure)
-validate_success_criteria || exit 1
-
-# Continue with agent work...
-```
-
-**2. Extract test command for specific suite:**
-```bash
-source .claude/skills/json-validation/validate-success-criteria.sh
-validate_success_criteria
-
-# Get unit test command
-UNIT_TEST_CMD=$(get_test_command "unit-tests")
-
-if [[ -n "$UNIT_TEST_CMD" ]]; then
-    echo "Running: $UNIT_TEST_CMD"
-    eval "$UNIT_TEST_CMD"
-fi
-```
-
-**3. Check pass rate threshold:**
-```bash
-source .claude/skills/json-validation/validate-success-criteria.sh
-validate_success_criteria
-
-THRESHOLD=$(get_pass_threshold "integration-tests")
-echo "Required pass rate: $THRESHOLD"
-```
-
----
-
-## API Reference
-
-### Core Functions
-
-#### `validate_success_criteria()`
-**Description:** Validates and parses `AGENT_SUCCESS_CRITERIA` environment variable.
-
-**Returns:**
-- `0` - Success (criteria valid or not provided)
-- `1` - Invalid JSON structure
-
-**Exports:**
-- `$CRITERIA` - Parsed JSON criteria object
-- `$TEST_SUITES` - Extracted test suites array
-
-**Example:**
-```bash
-if validate_success_criteria; then
-    echo "Criteria loaded: $CRITERIA"
-fi
-```
-
----
-
-#### `get_test_suite(suite_name)`
-**Description:** Extract specific test suite by name.
-
-**Parameters:**
-- `suite_name` (string) - Name of test suite to retrieve
-
-**Returns:** JSON object for matching test suite, or empty string if not found
-
-**Example:**
-```bash
-suite=$(get_test_suite "unit-tests")
-echo "$suite" | jq .
-```
-
----
-
-#### `get_test_command(suite_name)`
-**Description:** Get test command for specific suite.
-
-**Parameters:**
-- `suite_name` (string) - Name of test suite
-
-**Returns:** Test command string (e.g., `"npm test"`), or empty if not found
-
-**Example:**
-```bash
-cmd=$(get_test_command "e2e-tests")
-if [[ -n "$cmd" ]]; then
-    eval "$cmd"
-fi
-```
-
----
-
-#### `get_pass_threshold(suite_name)`
-**Description:** Get pass rate threshold for specific suite.
-
-**Parameters:**
-- `suite_name` (string) - Name of test suite
-
-**Returns:** Pass rate threshold (e.g., `"0.95"`), or empty if not found
-
-**Example:**
-```bash
-threshold=$(get_pass_threshold "unit-tests")
-echo "Required: $threshold"
-```
-
----
-
-#### `list_test_suites()`
-**Description:** List all test suite names.
-
-**Returns:** Newline-separated list of suite names
-
-**Example:**
-```bash
-list_test_suites | while read -r suite; do
-    echo "Suite: $suite"
-done
-```
-
----
-
-#### `validate_criteria_structure()`
-**Description:** Validate that required fields are present in criteria.
-
-**Returns:**
-- `0` - Structure is valid
-- `1` - Required fields are missing
-
-**Validates:**
-- `test_suites` array exists
-- Each suite has `name` field
-- Each suite has `command` field
-
-**Example:**
-```bash
-if validate_criteria_structure; then
-    echo "✅ Criteria structure valid"
-fi
-```
-
----
-
-## Expected JSON Structure
-
-```json
-{
-  "test_suites": [
-    {
-      "name": "unit-tests",
-      "command": "npm test",
-      "pass_threshold": 0.95,
-      "framework": "jest"
-    },
-    {
-      "name": "integration-tests",
-      "command": "npm run test:integration",
-      "pass_threshold": 0.90,
-      "framework": "jest"
-    }
-  ]
-}
-```
-
-### Required Fields
-- `test_suites` (array) - Array of test suite objects
-  - `name` (string) - Unique identifier for test suite
-  - `command` (string) - Shell command to execute tests
-
-### Optional Fields
-- `pass_threshold` (number) - Minimum pass rate (0.0-1.0)
-- `framework` (string) - Test framework identifier (jest, mocha, pytest, etc.)
-- `coverage_threshold` (number) - Minimum coverage percentage
-- `timeout` (number) - Maximum execution time in seconds
-
----
-
-## Security Features
-
-### 1. JSON Injection Prevention (CVSS 8.2)
-
-**Attack Vector:** Malformed `AGENT_SUCCESS_CRITERIA` can crash agents or inject malicious commands.
-
-**Defense:**
-```bash
-# Validate before parsing
-if ! echo "$AGENT_SUCCESS_CRITERIA" | jq -e '.' >/dev/null 2>&1; then
-    echo "❌ Invalid JSON" >&2
-    return 1
-fi
-```
-
-**Result:** Agent exits safely on malformed input, preventing injection.
-
----
-
-### 2. Fallback Operators
-
-**Issue:** Missing fields cause jq to fail with non-zero exit code.
-
-**Defense:**
-```bash
-# Use fallback operators for safe field access
-TEST_SUITES=$(echo "$CRITERIA" | jq -r '.test_suites[] // empty')
-SUITE_NAME=$(echo "$suite" | jq -r '.name // "unnamed"')
-```
-
-**Result:** Graceful handling of missing fields without crashes.
-
----
-
-### 3. Error Message Safety
-
-**Issue:** Verbose errors can leak internal structure to attackers.
-
-**Defense:**
-```bash
-# Truncate error messages to prevent information disclosure
-echo "   Received: ${AGENT_SUCCESS_CRITERIA:0:100}..." >&2
-```
-
-**Result:** Limited error output prevents reconnaissance.
-
----
-
-## Error Handling
-
-### Common Errors
-
-**1. Invalid JSON:**
-```
-❌ Invalid JSON in AGENT_SUCCESS_CRITERIA
-   Expected valid JSON object with test_suites array
-   Received: {invalid json...
-```
-
-**Solution:** Fix JSON syntax in `AGENT_SUCCESS_CRITERIA` variable.
-
----
-
-**2. Missing required field:**
-```
-❌ Test suite 0 missing required field: name
-```
-
-**Solution:** Add `name` field to test suite object.
-
----
-
-**3. Empty criteria:**
-```bash
-# This is valid - agent runs without test-driven requirements
-AGENT_SUCCESS_CRITERIA=""
-validate_success_criteria  # Returns 0
-```
-
----
-
-## Testing
-
-### Unit Tests
-
-```bash
-# Run validation skill tests
-.claude/skills/json-validation/test-validate-success-criteria.sh
-```
-
-**Test Coverage:**
-- Valid JSON parsing
-- Invalid JSON rejection
-- Missing field detection
-- Fallback operator behavior
-- Function export verification
-- Security injection attempts
-
----
-
-## Integration with Agents
-
-### Before (Duplicated Code)
-
-Each agent had inline validation:
-
-```bash
-if [[ -n "${AGENT_SUCCESS_CRITERIA:-}" ]]; then
-    if ! echo "$AGENT_SUCCESS_CRITERIA" | jq -e '.' >/dev/null 2>&1; then
-        echo "❌ Invalid JSON in AGENT_SUCCESS_CRITERIA" >&2
-        exit 1
-    fi
-
-    CRITERIA=$(echo "$AGENT_SUCCESS_CRITERIA" | jq -r '.')
-    TEST_SUITES=$(echo "$CRITERIA" | jq -r '.test_suites[] // empty')
-    # ... more duplicate code
-fi
-```
-
-**Issues:** 21 agents × 15 lines = 315 lines of duplicate code
-
----
-
-### After (Centralized Skill)
-
-Agents source centralized validation:
-
-```bash
-source .claude/skills/json-validation/validate-success-criteria.sh
-validate_success_criteria || exit 1
-
-# Access parsed data directly
-list_test_suites
-get_test_command "unit-tests"
-```
-
-**Benefits:**
-- ✅ **DRY Principle:** Single source of truth (315 lines → 15 lines)
-- ✅ **Consistency:** All agents use identical validation logic
-- ✅ **Maintainability:** Fix once, apply to all 21 agents
-- ✅ **Testability:** Centralized test suite validates all edge cases
-
----
-
-## Performance
-
-**Validation Overhead:** <5ms per agent startup (negligible)
-
-**Benchmark:**
-```bash
-time (source .claude/skills/json-validation/validate-success-criteria.sh && validate_success_criteria)
-# Average: 3.2ms
-```
-
----
-
-## Migration Guide
-
-### Step 1: Update Agent Profile
-
-**Before:**
-```bash
-if [[ -n "${AGENT_SUCCESS_CRITERIA:-}" ]]; then
-    # Inline validation code...
-fi
-```
-
-**After:**
-```bash
-source .claude/skills/json-validation/validate-success-criteria.sh
-validate_success_criteria || exit 1
-```
-
-### Step 2: Use Helper Functions
-
-Replace manual parsing:
-```bash
-# Before
-UNIT_CMD=$(echo "$CRITERIA" | jq -r '.test_suites[] | select(.name == "unit-tests").command')
-
-# After
-UNIT_CMD=$(get_test_command "unit-tests")
-```
-
-### Step 3: Verify
-
-```bash
-# Test agent with sample criteria
-AGENT_SUCCESS_CRITERIA='{"test_suites":[{"name":"test","command":"echo ok"}]}' \
-  npx claude-flow-novice agent-spawn --agent database-architect --task "test validation"
-```
-
----
-
-## Roadmap
-
-### v1.1.0 (Planned)
-- [ ] Cache parsed criteria for multiple calls
-- [ ] Support for nested test suites
-- [ ] Schema validation (JSON Schema)
-
-### v2.0.0 (Future)
-- [ ] YAML format support
-- [ ] Test suite inheritance
-- [ ] Conditional test execution
-
----
-
-**Status:** Production-ready (v1.0.0)
-**Coverage:** 21/21 agents
-**Security:** CVSS 8.2 injection prevention
-**Maintenance:** Single source of truth for all validation logic