claude-flow-novice 2.15.9 → 2.15.11

package/README.md

@@ -4,7 +4,7 @@
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
 [![Node.js Version](https://img.shields.io/badge/node-%3E%3D18.0.0-brightgreen)](https://nodejs.org/)
 [![CI Pipeline](https://github.com/yourusername/claude-flow-novice/actions/workflows/ci.yml/badge.svg)](https://github.com/yourusername/claude-flow-novice/actions/workflows/ci.yml)
-[![Coverage Report](https://img.shields.io/badge/coverage-dynamic-blue)](docs/CI_CD_PIPELINE.md)
+[![Coverage Report](https://img.shields.io/badge/coverage-dynamic-blue)](.github/workflows)
 
 Autonomous self-correcting AI agent orchestration with multi-domain support and intelligent learning capabilities.
 
@@ -437,25 +437,220 @@ See `readme/logs-tools.md` for complete documentation.
 
 ## Testing
 
+Claude Flow Novice includes comprehensive test suites across multiple execution modes and test types. Choose the appropriate test runner based on your development context.
+
+### Quick Start
+
+```bash
+# Run all npm-based tests (unit, integration, e2e)
+npm test
+
+# Run CLI mode test suite (test-driven validation)
+./tests/cli-mode/run-all-tests.sh
+
+# Run Docker mode test suite (45 production tests)
+./tests/docker-mode/run-all-implementations.sh
+```
+
+### Test Execution Modes
+
+#### CLI Mode Tests (Production)
+Run the CLI mode test suite to validate end-to-end coordination, quality gates, and agent spawning:
+
+```bash
+# Full test suite with all assertions
+./tests/cli-mode/run-all-tests.sh
+
+# Expected runtime: ~5-10 minutes
+# Tests: 8 suites, 159 total assertions
+# Coverage: Redis coordination, threshold enforcement, agent spawning, path resolution
+```
+
+**Validates:**
+- `/cfn-loop-cli` slash command workflow
+- Coordinator spawning and orchestration
+- Loop 3 → Loop 2 → Product Owner progression
+- Quality gate enforcement (MVP/Standard/Enterprise modes)
+- Redis coordination layer
+- Agent tool access and permissions
+
+**Prerequisites:**
+- Redis running (`redis-server`)
+- Project built (`npm run build`)
+- Z.ai API key configured (`.env`) for integration tests
+
+**Documentation:** See `tests/cli-mode/README.md` for detailed test descriptions and results.
+
+#### Docker Mode Tests (Integration)
+Run the Docker mode test suite to validate real container-based orchestration:
+
+```bash
+# Run all 45 Docker test implementations
+./tests/docker-mode/run-all-implementations.sh
+
+# Expected runtime: ~3-5 minutes
+# Tests: 45 production tests across 3 suites
+# Coverage: Coordinator spawning, orchestrator workflow, TDD compliance
+```
+
+**Test Suites:**
+- Coordinator Spawning (13 tests): Container cleanup, exit codes, service discovery
+- Orchestrator Workflow (13 tests): Iteration management, monitoring, recovery
+- TDD Compliance (19 tests): Test-driven validation, metrics collection, parallel execution
+
+**Prerequisites:**
+- Docker daemon running (`docker ps`)
+- No port conflicts (Docker networks auto-created)
+- ~2GB available memory for container execution
+
+**Documentation:** See `tests/docker-mode/README.md` for test categories and patterns.
+
+#### NPM-Based Tests (Development)
+Run standard npm test commands for fast feedback during development:
+
 ```bash
 # Run all tests
 npm test
 
 # Run specific test suites
-npm run test:unit
-npm run test:integration
-npm run test:e2e
+npm run test:unit           # Unit tests only
+npm run test:integration    # Integration tests only
+npm run test:e2e           # End-to-end tests only
 
-# CFN Loop end-to-end tests
-./tests/cfn-v3/test-e2e-cfn-loop.sh
+# Run with coverage
+npm test -- --coverage
+
+# Watch mode (re-run on file changes)
+npm test -- --watch
+```
+
+**Expected runtime:**
+- Unit tests: ~1-2 minutes
+- Integration tests: ~2-3 minutes
+- E2E tests: ~3-5 minutes
+
+#### CFN Loop End-to-End Tests
+Run specialized CFN Loop tests for validation and debugging:
+
+```bash
+# Validate CFN Loop coordinator handoffs
 ./tests/cfn-v3/test-coordinator-handoffs.sh
+
+# Full CFN Loop e2e test
+./tests/cfn-v3/test-e2e-cfn-loop.sh
+
+# Enterprise change management tests
+./tests/enterprise/run-all-enterprise-tests.sh
 ```
 
----
+### Test Organization
+
+```
+tests/
+├── cli-mode/                          # CLI mode validation (8 tests, 159 assertions)
+│   ├── README.md                      # CLI test documentation
+│   ├── run-all-tests.sh              # Test runner
+│   └── test-*.sh                     # Individual test suites
+├── docker-mode/                       # Docker integration tests (45 tests)
+│   ├── README.md                      # Docker test documentation
+│   ├── run-all-implementations.sh     # Test runner
+│   └── implementations/
+│       ├── coordinator-spawning-real-tests.sh
+│       ├── orchestrator-workflow-real-tests.sh
+│       └── tdd-compliance-real-tests.sh
+├── docker/                            # Docker-based core tests
+│   ├── coordination/                  # Redis coordination tests
+│   ├── lifecycle/                     # Container lifecycle tests
+│   └── perf/                          # Performance benchmarks
+├── cfn-v3/                           # CFN Loop validation tests
+├── enterprise/                        # Enterprise mode tests
+├── CLAUDE.md                          # Test authoring standards
+├── test-utils.sh                      # Shared test utilities
+└── README.md                          # Test suite documentation
+```
+
+### Test Coverage Matrix
+
+| Mode | Type | Tests | Duration | Prerequisites |
+|------|------|-------|----------|---|
+| CLI | Unit + Integration + E2E | 159 assertions | 5-10 min | Redis, npm build |
+| Docker | Production integration | 45 tests | 3-5 min | Docker daemon |
+| NPM | Development | Variable | 1-5 min | Node.js, npm |
+| CFN Loop | Workflow validation | Variable | 5-15 min | Full environment |
+
+### Test Authoring Guidelines
+
+For developers writing new tests, see `tests/CLAUDE.md` which documents:
+- Boilerplate template structure
+- GIVEN/WHEN/THEN assertion patterns
+- Production testing requirements (BUG #21)
+- Infrastructure vs integration test patterns
+- Cleanup and resource management
+- Review checklist for test quality
+
+Key principles:
+- Infrastructure tests (mocks OK): Docker networking, volumes, Redis connectivity
+- Integration tests (real images/scripts): Agent spawning, CLI execution, production workflows
+- Always use `set -euo pipefail` and `trap cleanup EXIT`
+- Route output through `log_step`, `log_info`, `annotate`, `assert_success` helpers
+- Cite relevant bugs in test comments for future context
+
+### CI/CD Integration
+
+Tests run automatically in GitHub Actions on every push and pull request. See [CI/CD Pipeline Documentation](.github/workflows) for:
+- Coverage gates (80%+ lines/statements/functions)
+- Test failure notifications
+- Performance benchmarking
+- Security scanning
+- Deployment workflows
+
+### Troubleshooting
+
+**Redis not available:**
+```bash
+# Start Redis in background
+redis-server --daemonize yes
+
+# Or run in Docker
+docker run -d -p 6379:6379 redis:7-alpine
+```
+
+**Docker permission denied:**
+```bash
+# Add user to docker group
+sudo usermod -aG docker $USER
+newgrp docker
+```
+
+**Port conflicts:**
+```bash
+# Stop and remove existing containers
+docker stop $(docker ps -aq)
+docker rm $(docker ps -aq)
+
+# Clean up Docker networks
+docker network prune -f
+```
+
+**Test failures with unclear messages:**
+```bash
+# Run with verbose output
+DEBUG=true ./tests/cli-mode/run-all-tests.sh
+DEBUG=true ./tests/docker-mode/run-all-implementations.sh
+
+# Check test logs in .artifacts/
+tail -100 .artifacts/logs/test-execution.log
+```
 
-## Contributing
+### Related Documentation
 
-We welcome contributions! See [CONTRIBUTING.md](CONTRIBUTING.md) for guidelines.
+- **Test Suite Overview:** `tests/README.md`
+- **Test Authoring Standards:** `tests/CLAUDE.md`
+- **CLI Mode Details:** `tests/cli-mode/README.md`
+- **Docker Mode Details:** `tests/docker-mode/README.md`
+- **Test Coverage Analysis:** `tests/TEST_COVERAGE_MATRIX.md`
+- **CFN Loop Architecture:** `docs/CFN_LOOP_ARCHITECTURE.md`
+- **CI/CD Pipeline:** `.github/workflows`
 
 ### Development Setup
 
@@ -476,7 +671,7 @@ npm run build
 
 ### CI/CD Pipeline
 
-Comprehensive GitHub Actions automation with unit testing, integration testing, coverage gates (80%+ lines/statements/functions), security scanning, and deployment workflows. See [CI/CD Pipeline Documentation](docs/CI_CD_PIPELINE.md) for details.
+Comprehensive GitHub Actions automation with unit testing, integration testing, coverage gates (80%+ lines/statements/functions), security scanning, and deployment workflows. See [CI/CD Pipeline Documentation](.github/workflows) for details.
 
 ---
 

package/claude-assets/agents/cfn-dev-team/CLAUDE.md

@@ -603,14 +603,14 @@ npx claude-flow-novice agent-spawn backend-dev --task-id "${TASK_ID}"
 npx claude-flow-novice agent-spawn reviewer --task-id "${TASK_ID}"
 ```
 
-### Signaling Pattern (CLI Mode Only)
+### Signaling Pattern
 ```bash
-# CLI Mode: Signal completion
+# Signal completion (when coordination is required)
 if [[ -n "${TASK_ID:-}" && -n "${AGENT_ID:-}" ]]; then
   redis-cli lpush "swarm:${TASK_ID}:${AGENT_ID}:done" "complete"
 fi
 
-# CLI Mode: Wait for other agent (zero-token blocking)
+# Wait for other agent (zero-token blocking)
 if [[ -n "${TASK_ID:-}" ]]; then
   redis-cli blpop "swarm:${TASK_ID}:other-agent:done" 30
 fi
@@ -656,11 +656,11 @@ Agents participate in 3-loop validation:
 
 Complete your work and provide a structured response with:
 - Confidence score (0.0-1.0) based on work quality
-- Summary of analysis/review completed
-- List of findings or deliverables
-- Any recommendations made
+- Summary of work completed
+- List of deliverables created
+- Any recommendations or findings
 
-**Note:** Coordination instructions are provided when spawned via CLI.
+**Note:** Coordination handled automatically by the system.
 ```
 
 ### Validation Hooks
@@ -994,79 +994,7 @@ Now that you understand agent creation, explore:
 
 ---
 
-## CFN Loop Completion Protocol (MODE-SPECIFIC)
-
-**Date:** 2025-11-06
-**Status:** Memory Leak Fix Applied - ANTI-023 Resolution
-
-### ⚠️ CRITICAL: Mode-Specific Completion Required
-
-Agents MUST use different completion protocols based on how they were spawned:
-
-### Task Mode (Spawned via Task() tool in Main Chat)
-
-**Simply complete your work and return structured output.**
-
-```json
-{
-  "confidence": 0.85,
-  "status": "COMPLETE|NEEDS_WORK",
-  "summary": "Brief summary of work completed",
-  "deliverables": ["file1.ts", "file2.test.ts"]
-}
-```
-
-**❌ DO NOT:**
-- Use Redis commands (redis-cli)
-- Execute bash scripts for completion
-- Signal completion via CLI tools
-- **Main Chat receives your output automatically**
-
-### CLI Mode (Spawned via `npx claude-flow-novice agent-spawn`)
-
-**Step 1: Complete Work**
-Execute assigned task (implementation, validation, review, etc.)
-
-**Step 2: Signal Completion (CLI Mode Only)**
-```bash
-# CLI Mode: Signal completion
-if [[ -n "${TASK_ID:-}" && -n "${AGENT_ID:-}" ]]; then
-  redis-cli lpush "swarm:${TASK_ID}:${AGENT_ID}:done" "complete"
-fi
-```
-
-**Step 3: Report Confidence Score and Exit (CLI Mode Only)**
-```bash
-# CLI Mode: Report confidence
-if [[ -n "${TASK_ID:-}" && -n "${AGENT_ID:-}" ]]; then
-  ./.claude/skills/cfn-redis-coordination/invoke-waiting-mode.sh report \
-    --task-id "$TASK_ID" \
-    --agent-id "$AGENT_ID" \
-    --confidence [0.0-1.0] \
-    --iteration 1
-fi
-```
-
-### How to Tell Which Mode You're In
-
-- **Task Mode**: You were spawned via `Task("agent-name", "...")` in Main Chat
-- **CLI Mode**: You were spawned via `npx claude-flow-novice agent-spawn ...` command
-
-### Why This Matters
-
-- **Task Mode**: Main Chat handles everything, just return results
-- **CLI Mode**: Coordinator needs Redis signals to collect confidence scores
-- **Mixed protocols cause memory leaks** (ANTI-023 pattern)
-
-### Related Documentation
-
-- **Memory Leak Fix:** `docs/bugs/BUG_MEMORY_LEAK_VALIDATOR_FIX.md`
-- **Agent Lifecycle:** `.claude/agents/AGENT_LIFECYCLE.md`
-- **Main Documentation:** `CLAUDE.md:333-357` (Mode-specific protocols)
-
----
-
-**Document Version:** 4.2.0 (Memory Leak Fix - Mode-Specific Protocols)
-**Last Updated:** 2025-11-06
+**Document Version:** 4.3.0 (Unified Completion Protocol)
+**Last Updated:** 2025-11-19
 **Maintained By:** Claude Flow Novice Team
 **Feedback:** We'd love to hear how you're using agents! Share your creations.

package/claude-assets/agents/cfn-dev-team/architecture/base-template-generator.md

@@ -142,8 +142,8 @@ When generating templates, always consider the broader project context, existing
 
 Complete your work and provide a structured response with:
 - Confidence score (0.0-1.0) based on work quality
-- Summary of analysis/review completed
-- List of findings or deliverables
-- Any recommendations made
+- Summary of work completed
+- List of deliverables created
+- Any recommendations or findings
 
-**Note:** Coordination instructions are provided when spawned via CLI.
+**Note:** Coordination handled automatically by the system.

package/claude-assets/agents/cfn-dev-team/architecture/planner.md

@@ -123,9 +123,9 @@ Remember: A good plan executed now is better than a perfect plan executed never.
 
 Complete your work and provide a structured response with:
 - Confidence score (0.0-1.0) based on work quality
-- Summary of analysis/review completed
-- List of findings or deliverables
-- Any recommendations made
+- Summary of work completed
+- List of deliverables created
+- Any recommendations or findings
 
-**Note:** Coordination instructions are provided when spawned via CLI.
+**Note:** Coordination handled automatically by the system.
 

package/claude-assets/agents/cfn-dev-team/architecture/system-architect.md

@@ -115,10 +115,10 @@ await sqlite.memoryAdapter.set(
 **Core Insight:** Great architecture balances technical excellence with business needs, making informed trade-offs that enable long-term system health and adaptability.
 ## Completion Protocol
 
-Complete your architectural work and provide a structured response with:
-- Confidence score (0.0-1.0) based on architectural quality
-- Summary of design decisions made
+Complete your work and provide a structured response with:
+- Confidence score (0.0-1.0) based on work quality
+- Summary of work completed
 - List of deliverables created
-- Any assumptions or constraints identified
+- Any recommendations or findings
 
-**Note:** Coordination instructions are provided when spawned via CLI.
+**Note:** Coordination handled automatically by the system.