claude-flow-novice 2.15.5 → 2.15.7

package/claude-assets/skills/cfn-loop-orchestration/helpers/parse-test-results.sh

@@ -1,277 +1,56 @@
 #!/usr/bin/env bash
-set -euo pipefail
-
-parse_jest_output() {
-    local output="$1"
-    local total=0 passed=0 failed=0 skipped=0 duration=0
-    local failed_names=()
-
-    local tests_line=$(echo "$output" | grep "^Tests:" || echo "")
-    
-    if [ -n "$tests_line" ]; then
-        [[ "$tests_line" =~ ([0-9]+)[[:space:]]*passed ]] && passed="${BASH_REMATCH[1]}"
-        [[ "$tests_line" =~ ([0-9]+)[[:space:]]*failed ]] && failed="${BASH_REMATCH[1]}"
-        [[ "$tests_line" =~ ([0-9]+)[[:space:]]*skipped ]] && skipped="${BASH_REMATCH[1]}"
-        [[ "$tests_line" =~ ([0-9]+)[[:space:]]*total ]] && total="${BASH_REMATCH[1]}"
-    fi
-
-    # OPTIMIZATION: Replace bc with BASH arithmetic (75-150ms savings)
-    if [[ "$output" =~ Time:[[:space:]]*([0-9.]+)[[:space:]]*s ]]; then
-        duration=$(awk "BEGIN {printf \"%.0f\", ${BASH_REMATCH[1]} * 1000}")
-    fi
-
-    while IFS= read -r line; do
-        [[ "$line" =~ ●[[:space:]]*(.*) ]] && failed_names+=("${BASH_REMATCH[1]}")
-    done <<< "$output"
-
-    # OPTIMIZATION: Replace bc with awk
-    local pass_rate="0.0000"
-    if [ "$total" -gt 0 ]; then
-        pass_rate=$(awk "BEGIN {printf \"%.4f\", $passed / $total}")
-    fi
-
-    # OPTIMIZATION: Single jq call
-    local failed_names_json="[]"
-    [ ${#failed_names[@]} -gt 0 ] && failed_names_json=$(printf '%s\n' "${failed_names[@]}" | jq -Rs 'split("\n") | map(select(length > 0))')
-
-    cat <<EOF
-{"framework":"jest","total_tests":$total,"passed_tests":$passed,"failed_tests":$failed,"skipped_tests":$skipped,"pass_rate":$pass_rate,"duration_ms":$duration,"failed_test_names":$failed_names_json}
-EOF
-}
-
-parse_mocha_output() {
-    local output="$1"
-    local total=0 passed=0 failed=0 skipped=0 duration=0
-    local failed_names=()
-
-    [[ "$output" =~ ([0-9]+)[[:space:]]*passing ]] && passed="${BASH_REMATCH[1]}"
-    [[ "$output" =~ ([0-9]+)[[:space:]]*failing ]] && failed="${BASH_REMATCH[1]}"
-    [[ "$output" =~ ([0-9]+)[[:space:]]*pending ]] && skipped="${BASH_REMATCH[1]}"
-    total=$((passed + failed + skipped))
-
-    # OPTIMIZATION: Replace bc with awk
-    if [[ "$output" =~ passing[[:space:]]*\(([0-9]+)ms\) ]]; then
-        duration="${BASH_REMATCH[1]}"
-    elif [[ "$output" =~ passing[[:space:]]*\(([0-9.]+)s\) ]]; then
-        duration=$(awk "BEGIN {printf \"%.0f\", ${BASH_REMATCH[1]} * 1000}")
-    fi
-
-    while IFS= read -r line; do
-        [[ "$line" =~ ^[[:space:]]*[0-9]+\)[[:space:]]*(.*): ]] && failed_names+=("${BASH_REMATCH[1]}")
-    done <<< "$output"
-
-    # OPTIMIZATION: Replace bc with awk
-    local pass_rate="0.0000"
-    if [ "$total" -gt 0 ]; then
-        pass_rate=$(awk "BEGIN {printf \"%.4f\", $passed / $total}")
-    fi
-
-    # OPTIMIZATION: Single jq call
-    local failed_names_json="[]"
-    [ ${#failed_names[@]} -gt 0 ] && failed_names_json=$(printf '%s\n' "${failed_names[@]}" | jq -Rs 'split("\n") | map(select(length > 0))')
-
-    cat <<EOF
-{"framework":"mocha","total_tests":$total,"passed_tests":$passed,"failed_tests":$failed,"skipped_tests":$skipped,"pass_rate":$pass_rate,"duration_ms":$duration,"failed_test_names":$failed_names_json}
-EOF
-}
-
-parse_pytest_output() {
-    local output="$1"
-    local total=0 passed=0 failed=0 skipped=0 duration=0
-    local failed_names=()
-
-    [[ "$output" =~ ([0-9]+)[[:space:]]*passed ]] && passed="${BASH_REMATCH[1]}"
-    [[ "$output" =~ ([0-9]+)[[:space:]]*failed ]] && failed="${BASH_REMATCH[1]}"
-    [[ "$output" =~ ([0-9]+)[[:space:]]*skipped ]] && skipped="${BASH_REMATCH[1]}"
-    total=$((passed + failed + skipped))
-
-    # OPTIMIZATION: Replace bc with awk
-    [[ "$output" =~ in[[:space:]]+([0-9.]+)s ]] && duration=$(awk "BEGIN {printf \"%.0f\", ${BASH_REMATCH[1]} * 1000}")
-
-    while IFS= read -r line; do
-        [[ "$line" =~ FAILED[[:space:]]+([^[:space:]]+) ]] && failed_names+=("${BASH_REMATCH[1]}")
-    done <<< "$output"
-
-    # OPTIMIZATION: Replace bc with awk
-    local pass_rate="0.0000"
-    if [ "$total" -gt 0 ]; then
-        pass_rate=$(awk "BEGIN {printf \"%.4f\", $passed / $total}")
-    fi
-
-    # OPTIMIZATION: Single jq call
-    local failed_names_json="[]"
-    [ ${#failed_names[@]} -gt 0 ] && failed_names_json=$(printf '%s\n' "${failed_names[@]}" | jq -Rs 'split("\n") | map(select(length > 0))')
-
-    cat <<EOF
-{"framework":"pytest","total_tests":$total,"passed_tests":$passed,"failed_tests":$failed,"skipped_tests":$skipped,"pass_rate":$pass_rate,"duration_ms":$duration,"failed_test_names":$failed_names_json}
-EOF
-}
-
-parse_tap_output() {
-    local output="$1"
-    local total=0 passed=0 failed=0 skipped=0
-    local failed_names=()
-
-    [[ "$output" =~ 1\.\.([0-9]+) ]] && total="${BASH_REMATCH[1]}"
-    passed=$(echo "$output" | grep -c "^ok " || true)
-    failed=$(echo "$output" | grep -c "^not ok " || true)
-    skipped=$(echo "$output" | grep -c "^ok .* # SKIP" || true)
-    passed=$((passed - skipped))
-
-    while IFS= read -r line; do
-        [[ "$line" =~ ^not\ ok\ [0-9]+\ (.*) ]] && failed_names+=("${BASH_REMATCH[1]}")
-    done <<< "$output"
-
-    # OPTIMIZATION: Replace bc with awk
-    local pass_rate="0.0000"
-    if [ "$total" -gt 0 ]; then
-        pass_rate=$(awk "BEGIN {printf \"%.4f\", $passed / $total}")
-    fi
-
-    # OPTIMIZATION: Single jq call
-    local failed_names_json="[]"
-    [ ${#failed_names[@]} -gt 0 ] && failed_names_json=$(printf '%s\n' "${failed_names[@]}" | jq -Rs 'split("\n") | map(select(length > 0))')
+##############################################################################
+# Parse Test Results - TypeScript Wrapper
+# Parses test output from multiple testing frameworks
+#
+# This is a wrapper script that delegates to the TypeScript implementation
+# for better type safety and maintainability.
+#
+# Usage:
+#   parse-test-results.sh <framework|auto> <output_file_or_string>
+#
+# Frameworks:
+#   - jest: Jest testing framework
+#   - mocha: Mocha testing framework
+#   - pytest: Python pytest
+#   - tap: TAP (Test Anything Protocol)
+#   - go: Go test output
+#   - auto: Auto-detect framework
+#
+# Returns JSON:
+#   {
+#     "framework": "jest",
+#     "total": 10,
+#     "passed": 8,
+#     "failed": 2,
+#     "skipped": 0,
+#     "passRate": 0.8,
+#     "durationMs": 1234,
+#     "failedTestNames": ["test1", "test2"],
+#     "raw": "..."
+#   }
+##############################################################################
 
-    cat <<EOF
-{"framework":"tap","total_tests":$total,"passed_tests":$passed,"failed_tests":$failed,"skipped_tests":$skipped,"pass_rate":$pass_rate,"duration_ms":0,"failed_test_names":$failed_names_json}
-EOF
-}
-
-parse_junit_xml() {
-    local xml_file="$1"
-    [ ! -f "$xml_file" ] && echo '{"error":"File not found"}' && return 1
-
-    local total=0 failures=0 errors=0 skipped=0 duration=0
-
-    if command -v xmllint &>/dev/null; then
-        total=$(xmllint --xpath "sum(//testsuite/@tests)" "$xml_file" 2>/dev/null || echo "0")
-        failures=$(xmllint --xpath "sum(//testsuite/@failures)" "$xml_file" 2>/dev/null || echo "0")
-        errors=$(xmllint --xpath "sum(//testsuite/@errors)" "$xml_file" 2>/dev/null || echo "0")
-        skipped=$(xmllint --xpath "sum(//testsuite/@skipped)" "$xml_file" 2>/dev/null || echo "0")
-        duration=$(xmllint --xpath "sum(//testsuite/@time)" "$xml_file" 2>/dev/null || echo "0")
-    else
-        total=$(grep -oP 'tests="\K[0-9]+' "$xml_file" | awk '{s+=$1} END {print s}')
-        failures=$(grep -oP 'failures="\K[0-9]+' "$xml_file" | awk '{s+=$1} END {print s}')
-        errors=$(grep -oP 'errors="\K[0-9]+' "$xml_file" | awk '{s+=$1} END {print s}')
-        skipped=$(grep -oP 'skipped="\K[0-9]+' "$xml_file" | awk '{s+=$1} END {print s}')
-        duration=$(grep -oP 'time="\K[0-9.]+' "$xml_file" | awk '{s+=$1} END {print s}')
-    fi
-
-    total=${total:-0} failures=${failures:-0} errors=${errors:-0} skipped=${skipped:-0} duration=${duration:-0}
-    local failed=$((failures + errors))
-    local passed=$((total - failed - skipped))
-
-    # OPTIMIZATION: Replace bc with awk
-    local duration_ms=$(awk "BEGIN {printf \"%.0f\", $duration * 1000}")
-
-    local pass_rate="0.0000"
-    if [ "$total" -gt 0 ]; then
-        pass_rate=$(awk "BEGIN {printf \"%.4f\", $passed / $total}")
-    fi
-
-    cat <<EOF
-{"framework":"junit","total_tests":$total,"passed_tests":$passed,"failed_tests":$failed,"skipped_tests":$skipped,"pass_rate":$pass_rate,"duration_ms":$duration_ms,"failed_test_names":[]}
-EOF
-}
-
-parse_go_test_output() {
-    local output="$1"
-    local total=0 passed=0 failed=0 skipped=0 duration=0
-    local failed_names=()
-
-    passed=$(echo "$output" | grep -c "^--- PASS:" || true)
-    failed=$(echo "$output" | grep -c "^--- FAIL:" || true)
-    skipped=$(echo "$output" | grep -c "^--- SKIP:" || true)
-    total=$((passed + failed + skipped))
-
-    while IFS= read -r line; do
-        [[ "$line" =~ ^---\ FAIL:\ (.*) ]] && failed_names+=("${BASH_REMATCH[1]}")
-    done <<< "$output"
-
-    # OPTIMIZATION: Replace bc with awk
-    [[ "$output" =~ ok[[:space:]]+[^[:space:]]+[[:space:]]+([0-9.]+)s ]] && duration=$(awk "BEGIN {printf \"%.0f\", ${BASH_REMATCH[1]} * 1000}")
-
-    local pass_rate="0.0000"
-    if [ "$total" -gt 0 ]; then
-        pass_rate=$(awk "BEGIN {printf \"%.4f\", $passed / $total}")
-    fi
-
-    # OPTIMIZATION: Single jq call
-    local failed_names_json="[]"
-    [ ${#failed_names[@]} -gt 0 ] && failed_names_json=$(printf '%s\n' "${failed_names[@]}" | jq -Rs 'split("\n") | map(select(length > 0))')
-
-    cat <<EOF
-{"framework":"go","total_tests":$total,"passed_tests":$passed,"failed_tests":$failed,"skipped_tests":$skipped,"pass_rate":$pass_rate,"duration_ms":$duration,"failed_test_names":$failed_names_json}
-EOF
-}
-
-auto_detect_framework() {
-    local input="$1"
-
-    if [ -f "$input" ]; then
-        if grep -q "<testsuite" "$input" 2>/dev/null; then
-            echo "junit"
-            return 0
-        fi
-        input=$(cat "$input")
-    fi
-
-    if [[ "$input" =~ Test\ Suites: ]] || [[ "$input" =~ PASS[[:space:]]+.*\.test\.(js|ts) ]]; then
-        echo "jest"
-        return 0
-    fi
-
-    if [[ "$input" =~ [0-9]+\ passing ]] && [[ "$input" =~ [0-9]+\ failing ]]; then
-        echo "mocha"
-        return 0
-    fi
-
-    if [[ "$input" =~ ====.*passed.*==== ]] || [[ "$input" =~ FAILED.*\.py:: ]]; then
-        echo "pytest"
-        return 0
-    fi
-
-    if [[ "$input" =~ 1\.\.[0-9]+ ]] || [[ "$input" =~ ok\ [0-9]+ ]] || [[ "$input" =~ not\ ok\ [0-9]+ ]]; then
-        echo "tap"
-        return 0
-    fi
-
-    if [[ "$input" =~ ---\ PASS: ]] || [[ "$input" =~ ---\ FAIL: ]]; then
-        echo "go"
-        return 0
-    fi
-
-    echo "unknown"
-    return 1
-}
-
-parse_test_results() {
-    local framework="$1"
-    local input="$2"
+set -euo pipefail
 
-    if [ "$framework" = "auto" ]; then
-        framework=$(auto_detect_framework "$input")
-        if [ "$framework" = "unknown" ]; then
-            echo '{"error":"Unable to auto-detect testing framework"}'
-            return 1
-        fi
-    fi
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+SKILL_ROOT="$(cd "$SCRIPT_DIR/.." && pwd)"
 
-    local output="$input"
-    [ -f "$input" ] && output=$(cat "$input")
+# Path to compiled TypeScript
+TS_DIST="$SKILL_ROOT/dist/helpers/parse-test-results.js"
 
-    case "$framework" in
-        jest) parse_jest_output "$output" ;;
-        mocha) parse_mocha_output "$output" ;;
-        pytest) parse_pytest_output "$output" ;;
-        tap) parse_tap_output "$output" ;;
-        junit) parse_junit_xml "$input" ;;
-        go) parse_go_test_output "$output" ;;
-        *) echo '{"error":"Unknown framework"}' && return 1 ;;
-    esac
-}
+# Check if TypeScript implementation exists
+if [ ! -f "$TS_DIST" ]; then
+  echo "❌ Error: TypeScript implementation not found at: $TS_DIST" >&2
+  echo "   Run 'npm run build' in .claude/skills/cfn-loop-orchestration/" >&2
+  exit 1
+fi
 
-if [ "${BASH_SOURCE[0]}" = "${0}" ]; then
-    [ $# -lt 2 ] && echo "Usage: $0 <framework|auto> <output_file_or_string>" && exit 1
-    parse_test_results "$1" "$2"
+# Check if node is available
+if ! command -v node &>/dev/null; then
+  echo "❌ Error: Node.js is required but not found in PATH" >&2
+  exit 1
 fi
+
+# Execute TypeScript implementation
+exec node "$TS_DIST" "$@"

package/claude-assets/skills/cfn-loop-orchestration/jest.config.js

@@ -0,0 +1,67 @@
+module.exports = {
+  preset: 'ts-jest',
+  testEnvironment: 'node',
+  roots: ['<rootDir>/src', '<rootDir>/tests'],
+  testMatch: ['**/__tests__/**/*.ts', '**/?(*.)+(spec|test).ts'],
+  moduleFileExtensions: ['ts', 'js', 'json'],
+  transform: {
+    '^.+\\.ts$': [
+      'ts-jest',
+      {
+        tsconfig: {
+          esModuleInterop: true,
+          allowSyntheticDefaultImports: true,
+        },
+      },
+    ],
+  },
+  moduleNameMapper: {
+    '^@orchestrator/(.*)$': '<rootDir>/src/orchestrator/$1',
+    '^@gate-checker/(.*)$': '<rootDir>/src/gate-checker/$1',
+    '^@agent-spawner/(.*)$': '<rootDir>/src/agent-spawner/$1',
+    '^@redis/(.*)$': '<rootDir>/src/redis/$1',
+    '^@utils/(.*)$': '<rootDir>/src/utils/$1',
+    '^@types/(.*)$': '<rootDir>/src/types/$1',
+  },
+  collectCoverageFrom: [
+    'src/**/*.ts',
+    '!src/**/*.d.ts',
+    '!src/index.ts',
+  ],
+  coverageThreshold: {
+    global: {
+      branches: 80,
+      functions: 80,
+      lines: 80,
+      statements: 80,
+    },
+    './src/orchestrator/': {
+      branches: 100,
+      functions: 100,
+      lines: 100,
+      statements: 100,
+    },
+    './src/gate-checker/': {
+      branches: 100,
+      functions: 100,
+      lines: 100,
+      statements: 100,
+    },
+    './src/agent-spawner/': {
+      branches: 90,
+      functions: 90,
+      lines: 90,
+      statements: 90,
+    },
+    './src/utils/': {
+      branches: 80,
+      functions: 80,
+      lines: 80,
+      statements: 80,
+    },
+  },
+  setupFilesAfterEnv: ['<rootDir>/tests/setup.ts'],
+  testTimeout: 30000,
+  verbose: true,
+  collectCoverage: false,
+};

package/claude-assets/skills/cfn-loop-orchestration/orchestrate-wrapper.sh

@@ -0,0 +1,268 @@
+#!/bin/bash
+
+##############################################################################
+# CFN Loop Orchestration Wrapper - Parameter Validation & Fallback Enforcement
+# Version: 1.0.0 (BUG #22 Phase 2 - Parameter Fallback)
+#
+# Purpose:
+# Validates and enforces non-empty parameters for orchestrate.sh invocation.
+# Applies task-appropriate hardcoded fallbacks when parameters are empty or unset.
+# Guarantees that orchestrator is always called with valid, non-empty agent lists.
+#
+# Usage:
+#   ./orchestrate-wrapper.sh --task-id <id> \
+#                           --mode <mvp|standard|enterprise> \
+#                           [--loop3-agents <agents>] \
+#                           [--loop2-agents <agents>] \
+#                           [--product-owner <agent>] \
+#                           [--task-type <backend|full-stack|default>] \
+#                           [--max-iterations <n>] \
+#                           [other orchestrate.sh args...]
+#
+# Exit Codes:
+#   0 = Success (orchestrator invoked)
+#   1 = Invalid orchestrator path or orchestrator execution failed
+#   2 = Missing required parameters (task-id, mode)
+##############################################################################
+
+set -euo pipefail
+
+# Determine script location and project root
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+PROJECT_ROOT="$(cd "$SCRIPT_DIR/../../.." && pwd)"
+ORCHESTRATOR_PATH="$SCRIPT_DIR/orchestrate.sh"
+
+# Parameter storage
+TASK_ID=""
+MODE=""
+LOOP3_AGENTS=""
+LOOP2_AGENTS=""
+PRODUCT_OWNER=""
+TASK_TYPE="default"  # backend, full-stack, or default
+REMAINING_ARGS=()
+
+##############################################################################
+# Fallback Agent Configuration by Task Type
+##############################################################################
+
+# Default fallbacks (for generic tasks with no specific type)
+DEFAULT_LOOP3_AGENTS="backend-developer,coder"
+DEFAULT_LOOP2_AGENTS="code-reviewer,tester"
+DEFAULT_PRODUCT_OWNER="product-owner"
+
+# Backend-specific fallbacks (for API, database, infrastructure tasks)
+BACKEND_LOOP3_AGENTS="backend-developer,backend-dev"
+BACKEND_LOOP2_AGENTS="code-reviewer,security-specialist,tester"
+BACKEND_PRODUCT_OWNER="product-owner"
+
+# Full-stack fallbacks (for tasks requiring both backend and frontend)
+FULLSTACK_LOOP3_AGENTS="backend-developer,react-frontend-engineer"
+FULLSTACK_LOOP2_AGENTS="code-reviewer,security-specialist,tester,qa-engineer"
+FULLSTACK_PRODUCT_OWNER="product-owner"
+
+##############################################################################
+# Argument Parsing
+##############################################################################
+
+while [[ $# -gt 0 ]]; do
+  case $1 in
+    --task-id)
+      if [[ $# -lt 2 ]]; then
+        echo "Error: --task-id requires a value" >&2
+        exit 2
+      fi
+      TASK_ID="$2"
+      shift 2
+      ;;
+    --mode)
+      if [[ $# -lt 2 ]]; then
+        echo "Error: --mode requires a value" >&2
+        exit 2
+      fi
+      # Validate mode is one of: mvp, standard, enterprise
+      if [[ ! "$2" =~ ^(mvp|standard|enterprise)$ ]]; then
+        echo "Error: --mode must be one of: mvp, standard, enterprise (got: '$2')" >&2
+        exit 2
+      fi
+      MODE="$2"
+      shift 2
+      ;;
+    --loop3-agents)
+      if [[ $# -lt 2 ]]; then
+        echo "Error: --loop3-agents requires a value" >&2
+        exit 2
+      fi
+      LOOP3_AGENTS="$2"
+      shift 2
+      ;;
+    --loop2-agents)
+      if [[ $# -lt 2 ]]; then
+        echo "Error: --loop2-agents requires a value" >&2
+        exit 2
+      fi
+      LOOP2_AGENTS="$2"
+      shift 2
+      ;;
+    --product-owner)
+      if [[ $# -lt 2 ]]; then
+        echo "Error: --product-owner requires a value" >&2
+        exit 2
+      fi
+      PRODUCT_OWNER="$2"
+      shift 2
+      ;;
+    --task-type)
+      if [[ $# -lt 2 ]]; then
+        echo "Error: --task-type requires a value" >&2
+        exit 2
+      fi
+      TASK_TYPE="$2"
+      shift 2
+      ;;
+    *)
+      # Collect remaining arguments for orchestrator
+      REMAINING_ARGS+=("$1")
+      shift
+      ;;
+  esac
+done
+
+##############################################################################
+# Required Parameter Validation
+##############################################################################
+
+if [[ -z "$TASK_ID" ]]; then
+  echo "❌ Error: --task-id is required" >&2
+  exit 2
+fi
+
+if [[ -z "$MODE" ]]; then
+  echo "❌ Error: --mode is required" >&2
+  exit 2
+fi
+
+##############################################################################
+# Parameter Normalization & Fallback Enforcement
+##############################################################################
+
+# Helper function to check if a value is effectively empty
+# (handles empty strings, unset variables, and whitespace-only strings)
+is_empty() {
+  local value="${1:-}"
+  # Remove leading/trailing whitespace
+  value=$(echo "$value" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')
+  [[ -z "$value" ]]
+}
+
+# Apply task-type-specific fallbacks to empty parameters
+case "$TASK_TYPE" in
+  backend)
+    # Backend-specific task defaults
+    if is_empty "$LOOP3_AGENTS"; then
+      LOOP3_AGENTS="$BACKEND_LOOP3_AGENTS"
+    fi
+    if is_empty "$LOOP2_AGENTS"; then
+      LOOP2_AGENTS="$BACKEND_LOOP2_AGENTS"
+    fi
+    if is_empty "$PRODUCT_OWNER"; then
+      PRODUCT_OWNER="$BACKEND_PRODUCT_OWNER"
+    fi
+    ;;
+  full-stack)
+    # Full-stack task defaults
+    if is_empty "$LOOP3_AGENTS"; then
+      LOOP3_AGENTS="$FULLSTACK_LOOP3_AGENTS"
+    fi
+    if is_empty "$LOOP2_AGENTS"; then
+      LOOP2_AGENTS="$FULLSTACK_LOOP2_AGENTS"
+    fi
+    if is_empty "$PRODUCT_OWNER"; then
+      PRODUCT_OWNER="$FULLSTACK_PRODUCT_OWNER"
+    fi
+    ;;
+  *)
+    # Default/generic task fallbacks
+    if is_empty "$LOOP3_AGENTS"; then
+      LOOP3_AGENTS="$DEFAULT_LOOP3_AGENTS"
+    fi
+    if is_empty "$LOOP2_AGENTS"; then
+      LOOP2_AGENTS="$DEFAULT_LOOP2_AGENTS"
+    fi
+    if is_empty "$PRODUCT_OWNER"; then
+      PRODUCT_OWNER="$DEFAULT_PRODUCT_OWNER"
+    fi
+    ;;
+esac
+
+##############################################################################
+# Post-Fallback Parameter Validation
+##############################################################################
+
+# Verify all parameters are now non-empty (guaranteed by fallbacks)
+if is_empty "$LOOP3_AGENTS"; then
+  echo "❌ Fatal: LOOP3_AGENTS is empty (fallback failed)" >&2
+  echo "   Task Type: $TASK_TYPE" >&2
+  echo "   Value: '$LOOP3_AGENTS'" >&2
+  exit 1
+fi
+
+if is_empty "$LOOP2_AGENTS"; then
+  echo "❌ Fatal: LOOP2_AGENTS is empty (fallback failed)" >&2
+  echo "   Task Type: $TASK_TYPE" >&2
+  echo "   Value: '$LOOP2_AGENTS'" >&2
+  exit 1
+fi
+
+if is_empty "$PRODUCT_OWNER"; then
+  echo "❌ Fatal: PRODUCT_OWNER is empty (fallback failed)" >&2
+  echo "   Task Type: $TASK_TYPE" >&2
+  echo "   Value: '$PRODUCT_OWNER'" >&2
+  exit 1
+fi
+
+##############################################################################
+# Orchestrator Path Validation
+##############################################################################
+
+if [[ ! -f "$ORCHESTRATOR_PATH" ]]; then
+  echo "❌ Error: Orchestrator not found at $ORCHESTRATOR_PATH" >&2
+  exit 1
+fi
+
+if [[ ! -x "$ORCHESTRATOR_PATH" ]]; then
+  echo "⚠️  Warning: Orchestrator is not executable. Attempting to fix..." >&2
+  chmod +x "$ORCHESTRATOR_PATH" || {
+    echo "❌ Error: Cannot make orchestrator executable at $ORCHESTRATOR_PATH" >&2
+    exit 1
+  }
+fi
+
+##############################################################################
+# Agent Configuration Logging
+##############################################################################
+
+echo "📋 Agent Configuration ($(date +%Y-%m-%d' '%H:%M:%S)):" >&2
+echo "   Task ID: $TASK_ID" >&2
+echo "   Mode: $MODE" >&2
+echo "   Task Type: $TASK_TYPE" >&2
+echo "   Loop 3 Agents: $LOOP3_AGENTS" >&2
+echo "   Loop 2 Agents: $LOOP2_AGENTS" >&2
+echo "   Product Owner: $PRODUCT_OWNER" >&2
+echo "" >&2
+
+##############################################################################
+# Orchestrator Invocation with Validated Parameters
+##############################################################################
+
+# Use exec to replace this process with orchestrator
+# This ensures clean exit and proper signal handling
+exec "$ORCHESTRATOR_PATH" \
+  --task-id "$TASK_ID" \
+  --mode "$MODE" \
+  --loop3-agents "$LOOP3_AGENTS" \
+  --loop2-agents "$LOOP2_AGENTS" \
+  --product-owner "$PRODUCT_OWNER" \
+  "${REMAINING_ARGS[@]}"
+
+# Note: exec replaces the shell process, so code below never executes
+# Exit code comes directly from orchestrator execution