claude-flow-novice 2.15.5 → 2.15.6

package/.claude/skills/cfn-redis-coordination/tsconfig.json

@@ -0,0 +1,31 @@
+{
+  "compilerOptions": {
+    "target": "ES2022",
+    "module": "commonjs",
+    "lib": ["ES2022"],
+    "outDir": "./dist",
+    "rootDir": "./src",
+    "declaration": true,
+    "declarationMap": true,
+    "sourceMap": true,
+    "strict": true,
+    "noImplicitAny": true,
+    "strictNullChecks": true,
+    "strictFunctionTypes": true,
+    "strictBindCallApply": true,
+    "strictPropertyInitialization": true,
+    "noImplicitThis": true,
+    "alwaysStrict": true,
+    "noUnusedLocals": false,
+    "noUnusedParameters": false,
+    "noImplicitReturns": true,
+    "noFallthroughCasesInSwitch": true,
+    "esModuleInterop": true,
+    "skipLibCheck": true,
+    "forceConsistentCasingInFileNames": true,
+    "resolveJsonModule": true,
+    "moduleResolution": "node"
+  },
+  "include": ["src/**/*"],
+  "exclude": ["node_modules", "dist", "tests", "src/redis/**/*"]
+}

package/claude-assets/agents/cfn-dev-team/coordinators/cfn-v3-coordinator.md

@@ -809,16 +809,28 @@ Extract deliverables from task description:
 
 ### Step 1: Task Classification (REQUIRED)
 ```bash
+# BUG #23 FIX: Store task classification in Redis to persist across Bash tool calls
+# Each Bash tool call creates a new shell, so environment variables don't persist
+# Redis provides persistence across iterations
+
 # Classify task type (use hardcoded defaults if script fails)
 TASK_TYPE="infrastructure"  # Default fallback
 if [[ -f ".claude/skills/task-classifier/classify-task.sh" ]]; then
   CLASSIFIED_TYPE=$(bash .claude/skills/task-classifier/classify-task.sh "$TASK_DESCRIPTION" 2>/dev/null || echo "")
   [[ -n "$CLASSIFIED_TYPE" ]] && TASK_TYPE="$CLASSIFIED_TYPE"
 fi
+
+# Store task type in Redis for persistence across Bash tool calls
+redis-cli HSET "swarm:${TASK_ID}:config" "task_type" "$TASK_TYPE"
+echo "✅ Task type '$TASK_TYPE' stored in Redis: swarm:${TASK_ID}:config"
 ```
 
 ### Step 2: Agent Selection with Fallback (REQUIRED)
 ```bash
+# BUG #23 FIX: Store agent selections in Redis to persist across Bash tool calls
+# Environment variables are lost between Bash tool executions
+# Redis ensures parameters persist through validation and orchestrator invocation
+
 # Select agents with hardcoded fallbacks (never fail)
 LOOP3_AGENTS="terraform-engineer,devops-engineer"  # Infrastructure default
 LOOP2_AGENTS="security-auditor,compliance-checker,cost-optimizer"  # Validation default
@@ -835,6 +847,123 @@ if [[ -f ".claude/skills/cfn-agent-selector/select-agents.sh" ]]; then
     [[ -n "$PARSED_AGENTS" ]] && LOOP2_AGENTS="$PARSED_AGENTS"
   fi
 fi
+
+# Store agent selections in Redis for persistence
+redis-cli HSET "swarm:${TASK_ID}:config" "loop3_agents" "$LOOP3_AGENTS"
+redis-cli HSET "swarm:${TASK_ID}:config" "loop2_agents" "$LOOP2_AGENTS"
+redis-cli HSET "swarm:${TASK_ID}:config" "product_owner" "$PRODUCT_OWNER"
+
+echo "✅ Agent selections stored in Redis:"
+echo "   loop3_agents: $LOOP3_AGENTS"
+echo "   loop2_agents: $LOOP2_AGENTS"
+echo "   product_owner: $PRODUCT_OWNER"
+```
+
+### Step 2.5: MANDATORY Parameter Initialization (BUG #22 & BUG #23 FIX)
+
+**CRITICAL: Execute this BEFORE orchestrator invocation to prevent empty parameter errors.**
+
+This step implements defense-in-depth fixes for both BUG #22 and BUG #23:
+- BUG #22: Empty parameter validation with hardcoded fallbacks
+- BUG #23: Redis-first parameter retrieval to handle Bash tool session loss
+
+```bash
+# BUG #23 FIX: Read parameters from Redis with fallbacks
+# Bash tool creates new shell each call, so variables set in Step 2 may be lost
+# Redis provides persistent storage across all Bash tool executions
+LOOP3_AGENTS=$(redis-cli HGET "swarm:${TASK_ID}:config" "loop3_agents" 2>/dev/null || echo "")
+LOOP2_AGENTS=$(redis-cli HGET "swarm:${TASK_ID}:config" "loop2_agents" 2>/dev/null || echo "")
+PRODUCT_OWNER=$(redis-cli HGET "swarm:${TASK_ID}:config" "product_owner" 2>/dev/null || echo "")
+
+echo "🔄 Parameters retrieved from Redis (BUG #23 fix)"
+echo "   LOOP3_AGENTS='$LOOP3_AGENTS'"
+echo "   LOOP2_AGENTS='$LOOP2_AGENTS'"
+echo "   PRODUCT_OWNER='$PRODUCT_OWNER'"
+
+# BUG #22 FIX: Apply fallbacks if Redis returns empty (defense-in-depth)
+# Even if Redis succeeded, re-validate and apply defaults if empty
+LOOP3_AGENTS="${LOOP3_AGENTS:-backend-developer,frontend-developer}"
+LOOP2_AGENTS="${LOOP2_AGENTS:-code-reviewer,tester,security-specialist}"
+PRODUCT_OWNER="${PRODUCT_OWNER:-product-owner}"
+
+echo "🔒 Fallback parameters initialized (BUG #22 prevention)"
+echo "   LOOP3_AGENTS='$LOOP3_AGENTS'"
+echo "   LOOP2_AGENTS='$LOOP2_AGENTS'"
+echo "   PRODUCT_OWNER='$PRODUCT_OWNER'"
+
+# MANDATORY: Validate before orchestrator invocation
+if [[ -z "$LOOP3_AGENTS" ]] || [[ -z "$LOOP2_AGENTS" ]] || [[ -z "$PRODUCT_OWNER" ]]; then
+  echo "❌ FATAL: Agent parameters cannot be empty after Redis retrieval + fallback initialization" >&2
+  echo "   This indicates a critical logic error in parameter handling (BUG #22 & #23)" >&2
+  echo "   LOOP3_AGENTS='$LOOP3_AGENTS'" >&2
+  echo "   LOOP2_AGENTS='$LOOP2_AGENTS'" >&2
+  echo "   PRODUCT_OWNER='$PRODUCT_OWNER'" >&2
+  exit 1
+fi
+
+echo "✅ All parameters validated non-empty before orchestrator invocation (BUG #22 & #23 fixes applied)"
+```
+
+**Why This Matters:**
+
+1. **BUG #23 Fix - Redis Persistence**: Each Bash tool call creates a new shell
+   - Environment variables set in iteration N are lost in iteration N+1
+   - Redis provides persistent storage across all Bash tool executions
+   - Parameters stored in Step 2 are reliably retrieved in Step 2.5
+   - Prevents coordinator from being stuck in validation loop
+
+2. **BUG #22 Fix - Defense-in-Depth**: Multiple layers of protection against empty parameters
+   - Step 2 provides hardcoded defaults AND stores in Redis
+   - Step 2.5 reads from Redis then applies fallbacks if Redis fails
+   - Explicit validation catches any logic errors before orchestrator call
+
+3. **Clear Error Messages**: If validation fails, provides:
+   - Exact parameter values (shows what went wrong)
+   - Context about where failure occurred (BUG #22 or BUG #23)
+   - Actionable error message (indicates critical logic error)
+
+4. **Fail-Fast Principle**: Better to exit early with clear error than pass empty strings to orchestrator
+   - Orchestrator would fail with confusing error messages
+   - Empty parameters cause cascade failures in agent spawning
+   - Early validation prevents wasted iteration time
+
+**Testing BUG #22 & BUG #23 Fixes:**
+
+```bash
+# Test BUG #23 fix (Redis persistence across Bash tool calls)
+# Simulate multiple Bash tool executions (coordinator iterations)
+npx claude-flow-novice agent-spawn cfn-v3-coordinator \
+  --task-id test-bug23 \
+  --env TASK_DESCRIPTION="Test Redis parameter persistence"
+
+# Expected output in Step 2:
+# ✅ Agent selections stored in Redis:
+#    loop3_agents: backend-developer,frontend-developer
+#    loop2_agents: code-reviewer,tester,security-specialist
+#    product_owner: product-owner
+
+# Expected output in Step 2.5 (even in NEW Bash shell):
+# 🔄 Parameters retrieved from Redis (BUG #23 fix)
+#    LOOP3_AGENTS='backend-developer,frontend-developer'
+#    LOOP2_AGENTS='code-reviewer,tester,security-specialist'
+#    PRODUCT_OWNER='product-owner'
+# ✅ All parameters validated non-empty before orchestrator invocation (BUG #22 & #23 fixes applied)
+
+# Test BUG #22 fix (fallbacks when Redis fails)
+# Simulate Redis failure
+redis-cli SHUTDOWN NOSAVE
+
+# Run coordinator - should fall back to defaults
+npx claude-flow-novice agent-spawn cfn-v3-coordinator \
+  --task-id test-bug22 \
+  --env TASK_DESCRIPTION="Test fallback parameters"
+
+# Expected output:
+# 🔄 Parameters retrieved from Redis (BUG #23 fix)
+#    LOOP3_AGENTS=''  (Redis down)
+# 🔒 Fallback parameters initialized (BUG #22 prevention)
+#    LOOP3_AGENTS='backend-developer,frontend-developer'
+# ✅ All parameters validated non-empty before orchestrator invocation (BUG #22 & #23 fixes applied)
 ```
 
 ### Step 3: INVOKE ORCHESTRATOR (MANDATORY - NOT OPTIONAL)
@@ -842,15 +971,52 @@ fi
 **CRITICAL:** You MUST invoke orchestrator by iteration 3. DO NOT complete tasks directly.
 
 ```bash
+# BUG #23 FIX: Read parameters from Redis before invoking orchestrator
+# This ensures we use the SAME parameters that were validated in Step 2.5
+# Even if this is executed in a NEW Bash shell (which it likely is)
+LOOP3_AGENTS=$(redis-cli HGET "swarm:${TASK_ID}:config" "loop3_agents" 2>/dev/null || echo "backend-developer,frontend-developer")
+LOOP2_AGENTS=$(redis-cli HGET "swarm:${TASK_ID}:config" "loop2_agents" 2>/dev/null || echo "code-reviewer,tester,security-specialist")
+PRODUCT_OWNER=$(redis-cli HGET "swarm:${TASK_ID}:config" "product_owner" 2>/dev/null || echo "product-owner")
+
+# Apply final fallbacks if Redis returns empty (defense-in-depth)
+LOOP3_AGENTS="${LOOP3_AGENTS:-backend-developer,frontend-developer}"
+LOOP2_AGENTS="${LOOP2_AGENTS:-code-reviewer,tester,security-specialist}"
+PRODUCT_OWNER="${PRODUCT_OWNER:-product-owner}"
+
+echo "🔄 Orchestrator parameters loaded from Redis (BUG #23 fix):"
+echo "   LOOP3_AGENTS='$LOOP3_AGENTS'"
+echo "   LOOP2_AGENTS='$LOOP2_AGENTS'"
+echo "   PRODUCT_OWNER='$PRODUCT_OWNER'"
+
 # ALWAYS invoke orchestrator - this is your ONLY responsibility
-./.claude/skills/cfn-loop-orchestration/orchestrate.sh \
+
+# Store success criteria in Redis BEFORE spawning orchestrator
+# Using redis-cli HSET with stdin (-x) to avoid shell escaping issues
+REDIS_KEY="swarm:${TASK_ID}:context"
+cat <<'CRITERIA_EOF' | redis-cli -h "${REDIS_HOST:-localhost}" -p "${REDIS_PORT:-6379}" -x HSET "$REDIS_KEY" "success-criteria"
+{
+  "deliverables": [],
+  "acceptanceCriteria": ["Implementation complete"],
+  "test_suites": []
+}
+CRITERIA_EOF
+
+# Set TTL on context hash (24 hours)
+redis-cli -h "${REDIS_HOST:-localhost}" -p "${REDIS_PORT:-6379}" EXPIRE "$REDIS_KEY" 86400
+
+echo "✅ Success criteria stored in Redis: $REDIS_KEY"
+
+# BUG #22 & BUG #23 FIX: Use orchestrate-wrapper.sh with Redis-backed parameters
+# BUG #22: Wrapper provides additional validation and error handling
+# BUG #23: Parameters are read from Redis to survive Bash tool session boundaries
+./.claude/skills/cfn-loop-orchestration/orchestrate-wrapper.sh \
   --task-id "$TASK_ID" \
   --mode "standard" \
   --loop3-agents "$LOOP3_AGENTS" \
   --loop2-agents "$LOOP2_AGENTS" \
   --product-owner "$PRODUCT_OWNER" \
   --max-iterations 10 \
-  --success-criteria '{"deliverables":[],"acceptanceCriteria":["Implementation complete"]}'
+  --success-criteria "enabled"
 
 # The orchestrator handles ALL CFN Loop execution including:
 # - Loop 3 agent spawning and iteration
@@ -864,10 +1030,14 @@ fi
 
 **EXECUTION GUARANTEE:**
 - If steps 1-2 fail, use hardcoded defaults and proceed to step 3
+- **Step 2 stores parameters in Redis** (BUG #23 fix - persistence)
+- **Step 2.5 validates parameters from Redis** (BUG #22 + BUG #23 fix - retrieval + fallbacks)
+- **Step 3 reads parameters from Redis** (BUG #23 fix - fresh shell reads from persistent storage)
 - **Never exit without invoking orchestrator**
 - **Orchestrator invocation MUST happen by iteration 3**
 - This coordinator's ONLY job is to configure and invoke the orchestrator
 
+
 ## Multi-Worktree Coordination
 
 When spawning agents in multi-worktree environments (teams using git worktrees), inject environment variables for proper Docker isolation:

package/claude-assets/agents/cfn-dev-team/testers/api-testing-specialist.md

@@ -141,7 +141,7 @@ describe('User Service Pact', () => {
           headers: {
             'Authorization': term({
               matcher: '^Bearer [A-Za-z0-9-_]+\\.[A-Za-z0-9-_]+\\.[A-Za-z0-9-_]+$',
-              generate: 'Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIn0.dozjgNryP4J3jVmNHl0w5N_XgL0n3I9PlFUP0THsR8U'
+              generate: 'Bearer [REDACTED_JWT_TOKEN]'
             }),
             'Accept': 'application/json'
           }