claude-flow-novice 2.14.6 → 2.14.8

package/claude-assets/agents/cfn-dev-team/coordinators/cfn-v3-coordinator.md

@@ -108,7 +108,7 @@ fi
 **Agent Selection:**
 ```bash
 # Query registry and select agents
-AGENTS=$(bash ./.claude/skills/agent-selector/select-agents.sh \
+AGENTS=$(bash ./.claude/skills/cfn-agent-selector/select-agents.sh \
   --task-type "$TASK_TYPE" \
   --description "$TASK_DESCRIPTION" \
   --agent-registry ".claude/skills/agent-discovery/agents-registry.json")
@@ -267,6 +267,9 @@ echo "Estimated Iterations: $ESTIMATED_ITERATIONS"
 **CRITICAL CLI Mode Requirement:**
 You MUST invoke the orchestrator by iteration 3. Do not spend more than 2 iterations on setup. If agent discovery/selection fails, use hardcoded defaults and proceed to orchestrator invocation.
 
+**MANDATORY FOR E2E TESTING:**
+When spawned with --task-id parameter, you MUST ALWAYS invoke the orchestrator to ensure full CFN Loop execution. Even for simple tasks, delegate to orchestrator to test all coordination points (Loop 3, gate check, Loop 2, Product Owner decision).
+
 ### CLI Mode (Streamlined for Orchestrator Invocation)
 
 **STEP 1: Task Classification (1 iteration max)**
@@ -277,13 +280,13 @@ TASK_TYPE=$(bash ./.claude/skills/task-classifier/classify-task.sh "$TASK_DESCRI
 **STEP 2: Agent Selection with Fallback (1 iteration max)**
 ```bash
 # Try agent selector (fail fast if broken)
-if AGENTS=$(bash ./.claude/skills/agent-selector/select-agents.sh --task-type "$TASK_TYPE" --description "$TASK_DESCRIPTION" 2>/dev/null); then
+if AGENTS=$(bash ./.claude/skills/cfn-agent-selector/select-agents.sh --task-type "$TASK_TYPE" --description "$TASK_DESCRIPTION" 2>/dev/null); then
   LOOP3_AGENTS=$(echo "$AGENTS" | jq -r '.loop3 | join(",")')
   LOOP2_AGENTS=$(echo "$AGENTS" | jq -r '.loop2 | join(",")')
   PRODUCT_OWNER=$(echo "$AGENTS" | jq -r '.loop4')
 else
   # FALLBACK: Use hardcoded defaults for software-development
-  LOOP3_AGENTS="coder,backend-dev"
+  LOOP3_AGENTS="backend-developer"
   LOOP2_AGENTS="reviewer,tester"
   PRODUCT_OWNER="product-owner"
 fi
@@ -291,16 +294,18 @@ fi
 
 **STEP 3: INVOKE ORCHESTRATOR (REQUIRED - NOT OPTIONAL)**
 
-This is your PRIMARY responsibility. Execute this immediately after Step 2:
+**CRITICAL:** You MUST invoke orchestrator by iteration 3. DO NOT complete tasks yourself.
+
+Execute this immediately after Step 2 (use hardcoded fallback if agent selector fails):
 
 ```bash
-# Invoke orchestrator with selected agents
+# ALWAYS invoke orchestrator - do NOT complete task directly
 ./.claude/skills/cfn-loop-orchestration/orchestrate.sh \
   --task-id "$TASK_ID" \
   --mode "standard" \
-  --loop3-agents "$LOOP3_AGENTS" \
-  --loop2-agents "$LOOP2_AGENTS" \
-  --product-owner "$PRODUCT_OWNER" \
+  --loop3-agents "backend-developer" \
+  --loop2-agents "reviewer,tester" \
+  --product-owner "product-owner" \
   --max-iterations 10 \
   --success-criteria '{"deliverables":[],"acceptanceCriteria":["Implementation complete"]}'
 

package/claude-assets/agents/cfn-dev-team/product-owners/product-owner.md

@@ -2,7 +2,7 @@
 name: product-owner
 description: "CFN Loop Product Owner using Goal-Oriented Action Planning (GOAP) for autonomous scope enforcement and decision authority."
 tools: [Read, Write, Edit, Bash, TodoWrite]
-model: haiku
+model: sonnet
 color: purple
 type: strategic
 keywords: [product-owner, cfn-loop, goap, scope-enforcement, decision-authority, strategic-planning, autonomous-execution, consensus-validation]

package/claude-assets/agents/cfn-dev-team/test-agent.md

@@ -0,0 +1,141 @@
+# Epic Creator Deletion Issue - Complete Summary
+
+**Date:** 2025-11-03
+**Status:** RESOLVED
+**Versions:** v2.14.5 (epic-creator added), v2.14.6 (init bug fixed)
+
+---
+
+## Problem
+
+The `epic-creator.md` coordinator agent kept getting deleted from `.claude/agents/cfn-dev-team/coordinators/` after being created and committed.
+
+---
+
+## Root Cause
+
+**Every `npx claude-flow-novice` command triggered `cfn-init`**, which overwrote the entire `.claude/agents/cfn-dev-team/` directory from the npm package.
+
+### Why It Happened
+
+1. `package.json` has `"postinstall": "node scripts/init-project.js"`
+2. Running `npx claude-flow-novice agent backend-dev` triggers postinstall
+3. `init-project.js` ran `cfn-init` unconditionally
+4. cfn-init copied package version of cfn-dev-team/, overwriting local files
+5. epic-creator.md (and other local customizations) got deleted
+
+### Trigger Pattern
+
+```bash
+# Each of these triggered cfn-init:
+npx claude-flow-novice agent backend-dev
+npx claude-flow-novice agent reviewer
+npx claude-flow-novice agent epic-creator
+
+# In test sessions running hundreds of npx commands:
+# = hundreds of cfn-init runs = constant file deletion
+```
+
+---
+
+## Solution
+
+### Phase 1: Add epic-creator to Package (v2.14.5)
+
+```bash
+# Copy epic-creator to package assets
+cp .claude/agents/cfn-dev-team/coordinators/epic-creator.md \
+   claude-assets/agents/cfn-dev-team/coordinators/
+
+# Publish to npm
+npm version patch
+npm publish
+```
+
+**Result:** Users can now get epic-creator via normal installation.
+
+---
+
+### Phase 2: Fix Init-on-Every-NPX Bug (v2.14.6)
+
+**Changes to `scripts/init-project.js`:**
+
+```javascript
+async function initializeCfnProject() {
+  // Skip initialization if already initialized
+  const markerPath = '.claude/.cfn-initialized';
+  if (fs.existsSync(markerPath)) {
+    // Silently skip - already initialized
+    return;
+  }
+
+  // ... existing init logic ...
+
+  // Create marker file after successful init
+  fs.writeFileSync('.claude/.cfn-initialized', new Date().toISOString());
+}
+```
+
+**How It Works:**
+1. First `npx claude-flow-novice` command → runs full init → creates marker
+2. Subsequent commands → sees marker → skips init → files preserved
+3. Force reinit: `rm .claude/.cfn-initialized && npx cfn-init`
+
+---
+
+## Epic Creator Agent
+
+**Purpose:** Transforms natural language epic descriptions into structured JSON configs for CFN Loop execution.
+
+**Three Personas:**
+- **CTO:** Technical architecture, dependencies, risk assessment
+- **Product Owner:** Value prioritization, scope boundaries
+- **Project Manager:** Phase decomposition, deliverables, estimates
+
+**Key Features:**
+- Decomposes epics into 3-7 focused phases
+- Selects appropriate Loop 3/Loop 2 agents per phase
+- Defines concrete deliverables with file paths
+- Sets mode-appropriate thresholds (MVP/Standard/Enterprise)
+- Validates configuration completeness
+
+**Location:** `.claude/agents/cfn-dev-team/coordinators/epic-creator.md` (3.7KB)
+
+**Usage:**
+```bash
+npx claude-flow-novice agent epic-creator \
+  --prompt "Create epic for user authentication system with JWT and OAuth2"
+```
+
+---
+
+## Published Versions
+
+**v2.14.5** (Published 2025-11-03)
+- Includes epic-creator in package distribution
+- Users get it automatically on install
+
+**v2.14.6** (Published 2025-11-03)
+- Fixes init-on-every-npx bug
+- Preserves local customizations
+- Faster CLI performance
+
+**Install Latest:**
+```bash
+npm install claude-flow-novice@latest
+npx cfn-init  # Only runs once, creates marker
+```
+
+---
+
+## Current Status
+
+**RESOLVED:** Both epic-creator availability and init-on-every-npx bug are fixed.
+
+**Users on v2.14.6+ will:**
+- Get epic-creator automatically
+- Experience fast npx startup
+- Keep local customizations safe
+- Have stable cfn-dev-team directory
+
+**No further action required.**

package/claude-assets/agents/cfn-dev-team/utility/agent-builder.md

@@ -499,6 +499,41 @@ Before finalizing an agent template, verify:
 - [ ] Bash variables use `\$VARIABLE` in template examples
 - [ ] Multi-line strings properly indented
 
+## Post-Creation Validation
+
+**CRITICAL: After creating or updating any agent file, run agent name validation:**
+
+```bash
+./.claude/skills/agent-name-validation/validate-agent-names.sh
+```
+
+This ensures:
+- Filename matches frontmatter `name:` field
+- Agent can be discovered by spawning system
+- Naming consistency across codebase
+
+**Example:**
+```bash
+# After creating new agent
+Write: file_path=".claude/agents/cfn-dev-team/developers/api-developer.md"
+
+# Validate filename matches frontmatter
+./.claude/skills/agent-name-validation/validate-agent-names.sh
+
+# Check result
+if [ $? -eq 0 ]; then
+  echo "✅ Agent name validation passed"
+else
+  echo "❌ Agent name mismatch detected - review output"
+fi
+```
+
+**Common Issues:**
+- Filename: `backend-dev.md` but frontmatter: `name: backend-developer` ❌
+- Filename: `backend-developer.md` and frontmatter: `name: backend-developer` ✅
+
+See: `.claude/skills/agent-name-validation/SKILL.md` for full documentation
+
 ---
 
 ## Success Metrics

package/claude-assets/commands/cfn/run-tests.md

@@ -0,0 +1,119 @@
+---
+name: run-tests
+description: Run CFN test suites with benchmarking and regression detection
+category: testing
+---
+
+# Run CFN Tests
+
+Execute CFN test suites (Hello World + CFN E2E) with automatic benchmarking and regression detection.
+
+## Usage
+
+```bash
+# Run all tests
+/run-tests
+
+# Run specific suite
+/run-tests hello-world
+/run-tests cfn-e2e
+
+# With benchmarking
+/run-tests --benchmark
+
+# With regression detection
+/run-tests --detect-regressions --threshold 0.10
+```
+
+## Execution
+
+```bash
+./.claude/skills/cfn-test-runner/run-all-tests.sh \
+  --suite {{arg1:-all}} \
+  {{#if benchmark}}--benchmark{{/if}} \
+  {{#if detect-regressions}}--detect-regressions --threshold {{threshold:-0.10}}{{/if}}
+```
+
+## Test Suites
+
+### Hello World (4 tests)
+- Layer 0: Tool Validation (60s)
+- Layer 5: Coordinator Spawning (120s)
+- Layer 6: Review Handoff (180s)
+- Layer 7: Error Retry (150s)
+
+### CFN E2E (9 tests)
+- Coordinator → Orchestrator handoff
+- Loop 3 → Gate Check
+- Gate Pass → Loop 2
+- Loop 2 → Product Owner
+- Product Owner Decision
+- Iteration Cycle
+- Redis Key Structure
+- Error Recovery
+- Cleanup
+
+## Benchmarking
+
+Results stored in `.artifacts/test-benchmarks.db`:
+- Test run history (30 days)
+- Success rate trends
+- Duration tracking
+- Git commit correlation
+
+## Regression Detection
+
+Automatic alerts for:
+- Test failures (was passing)
+- Performance degradation (>10% slower)
+- Success rate drops (>10% decrease)
+
+View regressions:
+```sql
+sqlite3 .artifacts/test-benchmarks.db "SELECT * FROM regression_alerts WHERE acknowledged = 0"
+```
+
+## Examples
+
+**Standard test run:**
+```
+/run-tests
+```
+
+**With full benchmarking:**
+```
+/run-tests --benchmark --detect-regressions
+```
+
+**Specific suite only:**
+```
+/run-tests cfn-e2e --benchmark
+```
+
+## Output
+
+```
+==========================================
+CFN Test Suite Runner
+==========================================
+Suite: all
+Benchmark: true
+Detect Regressions: true
+Git: main @ abc123
+
+Hello World: 4 passed, 0 failed, 0 skipped (494s)
+CFN E2E: 7 passed, 0 failed, 2 skipped (356s)
+
+==========================================
+Test Summary
+==========================================
+Total: 13 tests
+Passed: 11
+Failed: 0
+Skipped: 2
+Duration: 850s
+Success Rate: 84.6%
+
+✅ Benchmark stored (run_id: 42)
+✅ No regressions detected
+```

package/claude-assets/hooks/cfn-post-edit.config.json

@@ -3,12 +3,14 @@
   "version": "2.0.0",
   "pipeline": "config/hooks/post-edit-pipeline.js",
   "triggerOn": ["Edit", "Write", "MultiEdit"],
-  "fileTypes": [".ts", ".tsx", ".js", ".jsx", ".json", ".md"],
+  "fileTypes": [".ts", ".tsx", ".js", ".jsx", ".json", ".md", ".sh", ".bash", ".py", ".rs"],
   "blocking": false,
   "exitCodes": {
     "0": "SUCCESS",
     "1": "ERROR",
-    "2": "SYNTAX_ERROR"
+    "2": "SYNTAX_ERROR",
+    "9": "BASH_VALIDATOR_ERROR",
+    "10": "BASH_VALIDATOR_WARNING"
   },
   "redis": {
     "enabled": true,
@@ -26,12 +28,17 @@
       "enabled": true,
       "noEmit": true,
       "skipLibCheck": true
+    },
+    "bash": {
+      "enabled": true,
+      "validators": ["pipe-safety", "dependency-checker", "line-endings"],
+      "timeout": 5000
     }
   },
   "feedback": {
     "provideSuggestions": true,
     "autoFixable": ["LINT_ISSUES"],
-    "nonBlocking": ["TYPE_WARNING", "LINT_ISSUES"],
-    "blocking": ["SYNTAX_ERROR"]
+    "nonBlocking": ["TYPE_WARNING", "LINT_ISSUES", "BASH_VALIDATOR_WARNING"],
+    "blocking": ["SYNTAX_ERROR", "BASH_VALIDATOR_ERROR"]
   }
 }

package/claude-assets/skills/agent-name-validation/README.md

@@ -0,0 +1,28 @@
+# Agent Name Validation Skill
+
+## Quick Start
+
+```bash
+./.claude/skills/agent-name-validation/validate-agent-names.sh
+```
+
+## What It Does
+
+Validates that agent filenames match their frontmatter `name:` field across the entire `.claude/agents/` directory.
+
+## Integration
+
+This skill is automatically run by the `agent-builder` agent after:
+- Creating new agents
+- Updating agent frontmatter
+- Renaming agent files
+
+## Files
+
+- `SKILL.md` - Complete documentation
+- `validate-agent-names.sh` - Validation script
+- `README.md` - This file
+
+## Usage in Agent Builder
+
+See `agent-builder.md` Post-Creation Validation section for integration details.

package/claude-assets/skills/agent-name-validation/SKILL.md

@@ -0,0 +1,168 @@
+# Agent Name Validation Skill
+
+**Version:** 1.0.0
+**Last Updated:** 2025-11-04
+**Owner:** agent-builder
+**Status:** Production
+
+## Overview
+
+Validates that agent filenames match their frontmatter `name:` field to ensure consistency and prevent discovery issues.
+
+## Purpose
+
+- Ensures agent files can be discovered correctly by the agent spawning system
+- Prevents mismatches between filename and agent identity
+- Maintains naming consistency across the codebase
+- Runs automatically after agent creation/updates
+
+## Usage
+
+### Basic Validation
+
+```bash
+./.claude/skills/agent-name-validation/validate-agent-names.sh
+```
+
+### Output Format
+
+```
+Validating agent filenames match frontmatter names...
+==============================================
+❌ MISMATCH: /path/to/backend-dev.md
+   Filename:    backend-dev
+   Frontmatter: backend-developer
+
+⚠️  WARNING: No frontmatter name found in /path/to/README.md
+==============================================
+✅ All agent files have matching names!
+```
+
+## Integration with Agent Builder
+
+The agent-builder agent automatically runs this validation after:
+
+1. Creating new agent files
+2. Updating agent frontmatter
+3. Renaming agent files
+
+### Post-Creation Validation
+
+```bash
+# After creating/updating an agent
+./.claude/skills/agent-name-validation/validate-agent-names.sh
+
+# Check exit code
+if [ $? -ne 0 ]; then
+    echo "⚠️  Agent name validation failed - please review mismatches"
+fi
+```
+
+## Validation Rules
+
+### ✅ Valid Patterns
+
+- Filename: `backend-developer.md` → Frontmatter: `name: backend-developer`
+- Filename: `api-tester.md` → Frontmatter: `name: api-tester`
+
+### ❌ Invalid Patterns
+
+- Filename: `backend-dev.md` → Frontmatter: `name: backend-developer` (mismatch)
+- Filename: `APITester.md` → Frontmatter: `name: api-tester` (case mismatch)
+
+### Ignored Files
+
+- `CLAUDE.md` - Documentation file, not an agent
+- Files without frontmatter (templates, READMEs)
+
+## Exit Codes
+
+- `0` - All agent files validated successfully
+- `1` - One or more mismatches found
+
+## Configuration
+
+### Excluded Files
+
+Edit the validation script to exclude additional files:
+
+```bash
+# Skip specific files
+if [ "$filename" = "CLAUDE" ] || [ "$filename" = "README" ]; then
+    continue
+fi
+```
+
+## Examples
+
+### Example 1: Successful Validation
+
+```bash
+$ ./.claude/skills/agent-name-validation/validate-agent-names.sh
+Validating agent filenames match frontmatter names...
+==============================================
+✅ All agent files have matching names!
+```
+
+### Example 2: Mismatch Detected
+
+```bash
+$ ./.claude/skills/agent-name-validation/validate-agent-names.sh
+Validating agent filenames match frontmatter names...
+==============================================
+❌ MISMATCH: .claude/agents/cfn-dev-team/developers/backend-dev.md
+   Filename:    backend-dev
+   Frontmatter: backend-developer
+==============================================
+❌ Found 1 mismatch(es)
+```
+
+## Troubleshooting
+
+### Issue: False Positives
+
+**Symptom:** Valid agent files reported as mismatches
+
+**Solution:** Verify frontmatter format:
+```yaml
+---
+name: agent-name  # Must be on line 2, no extra spaces
+---
+```
+
+### Issue: AWK Parsing Errors
+
+**Symptom:** No frontmatter names detected
+
+**Solution:** Check for:
+- Windows line endings (run `dos2unix` on files)
+- Missing `---` delimiters
+- Malformed YAML
+
+## Related Skills
+
+- **Agent Creation** (`.claude/skills/agent-creation/`) - Creates new agents
+- **Template Validation** (`.claude/skills/template-validation/`) - Validates agent structure
+- **Pre-Edit Backup** (`.claude/skills/pre-edit-backup/`) - Backup system for file changes
+
+## Maintenance
+
+### Adding New Validations
+
+To add additional validation rules, modify `validate-agent-names.sh`:
+
+```bash
+# Example: Validate agent type matches directory structure
+if [[ "$agent_file" == *"/testers/"* ]]; then
+    expected_type="validator"
+    actual_type=$(awk 'BEGIN{in_fm=0} /^---$/{in_fm++; next} in_fm==1 && /^type:/{print $2; exit}' "$agent_file")
+
+    if [ "$actual_type" != "$expected_type" ]; then
+        echo "⚠️  Type mismatch in $agent_file"
+    fi
+fi
+```
+
+## Version History
+
+- **1.0.0** (2025-11-04) - Initial release with filename validation

package/claude-assets/skills/agent-name-validation/validate-agent-names.sh

@@ -0,0 +1,47 @@
+#!/bin/bash
+
+# Script to validate agent filenames match frontmatter names
+# Usage: ./scripts/validate-agent-names.sh
+
+AGENTS_DIR="/mnt/c/Users/masha/Documents/claude-flow-novice/.claude/agents"
+MISMATCHES=0
+
+echo "Validating agent filenames match frontmatter names..."
+echo "=============================================="
+
+# Find all .md files in agents directory recursively
+while IFS= read -r -d '' agent_file; do
+    # Get filename without extension
+    filename=$(basename "$agent_file" .md)
+
+    # Skip CLAUDE.md files
+    if [ "$filename" = "CLAUDE" ]; then
+        continue
+    fi
+
+    # Extract frontmatter name (between --- blocks, look for 'name:' field)
+    frontmatter_name=$(awk 'BEGIN{in_fm=0} /^---$/{in_fm++; next} in_fm==1 && /^name:/{print $2; exit}' "$agent_file")
+
+    # Skip if no frontmatter name found
+    if [ -z "$frontmatter_name" ]; then
+        echo "⚠️  WARNING: No frontmatter name found in $agent_file"
+        continue
+    fi
+
+    # Compare filename with frontmatter name
+    if [ "$filename" != "$frontmatter_name" ]; then
+        echo "❌ MISMATCH: $agent_file"
+        echo "   Filename:    $filename"
+        echo "   Frontmatter: $frontmatter_name"
+        echo ""
+        ((MISMATCHES++))
+    fi
+done < <(find "$AGENTS_DIR" -name "*.md" -type f -print0)
+
+echo "=============================================="
+if [ $MISMATCHES -eq 0 ]; then
+    echo "✅ All agent files have matching names!"
+else
+    echo "❌ Found $MISMATCHES mismatch(es)"
+    exit 1
+fi

package/claude-assets/skills/cfn-agent-selector/SKILL.md

@@ -13,7 +13,7 @@ Recommends Loop 3 (producers) and Loop 2 (evaluators) agents based on:
 ## Usage
 
 ```bash
-AGENTS=$(./.claude/skills/agent-selector/select-agents.sh \
+AGENTS=$(./.claude/skills/cfn-agent-selector/select-agents.sh \
   --task-type "software-development" \
   --description "Implement JWT authentication with refresh tokens")
 
@@ -87,4 +87,5 @@ echo "$AGENTS" | jq '.loop2[]'  # ["reviewer", "tester", "security-auditor"]
 ## Integration
 
 Used by:
-- `.claude/agents/cfn-v3-coordinator.md` - Agent selection
+- `.claude/agents/cfn-v3-coordinator.md` - Agent selection
+- `.claude/skills/cfn-agent-selector/select-agents.sh` - Primary selection script

package/claude-assets/skills/cfn-loop-orchestration/orchestrate.sh

@@ -635,7 +635,7 @@ function spawn_product_owner() {
   # BLOCKER #2 FIX: Match execute-decision.sh actual parameters
   # Required: --task-id, --agent-id, --consensus, --threshold, --iteration, --max-iterations
   local decision_output
-  decision_output=$("$SCRIPT_DIR/.claude/skills/cfn-cfn-product-owner-decision/execute-decision.sh" \
+  decision_output=$("$SCRIPT_DIR/.claude/skills/cfn-product-owner-decision/execute-decision.sh" \
     --task-id "$task_id" \
     --agent-id "$PRODUCT_OWNER" \
     --consensus "$LOOP2_FINAL_CONSENSUS" \