claude-flow-novice 2.14.32 → 2.14.34

package/.claude/commands/switch-api.md

@@ -15,7 +15,7 @@ Switch Main Chat and Task() tool API provider between Z.ai (cost-optimized) and
 **Arguments:**
 - `status` - Show current routing configuration (default)
 - `zai` - Route Main Chat + Task tool to Z.ai for cost savings
-- `max` or `claude` - Route Main Chat + Task tool to Anthropic for quality
+- `max` - Route Main Chat + Task tool to Anthropic for quality (also accepts `claude` or `anthropic` as aliases)
 
 **What This Does:**
 

package/.claude/skills/cfn-loop-orchestration/orchestrate.sh

@@ -25,15 +25,9 @@ set -euo pipefail
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 PROJECT_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
 
-# ⚠️ ANTI-023 MEMORY LEAK PROTECTION: Block Task Mode agents
-# Task Mode agents spawn via Task() tool and should NOT use orchestration scripts
-if [[ -z "${TASK_ID:-}" || -z "${LOOP3_AGENTS:-}" ]]; then
-    echo "❌ TASK MODE DETECTED - Orchestration forbidden" >&2
-    echo "🚨 ANTI-023: This script is for CLI-spawned coordinators only" >&2
-    echo "💡 Task Mode coordination should be handled directly by Main Chat" >&2
-    echo "🔧 Coordinator spawned via Task() tool - Main Chat should coordinate directly" >&2
-    exit 1
-fi
+# ⚠️ ANTI-023 MEMORY LEAK PROTECTION:
+# Task Mode validation moved to after argument parsing at line 276
+# This allows proper CLI argument processing before validation
 
 # ⚠️ ANTI-023 MEMORY LEAK PROTECTION: Environment Sanitization
 # Load and apply environment sanitization to prevent memory leaks

package/.claude/skills/pre-edit-backup/backup.sh

@@ -0,0 +1,107 @@
+#!/bin/bash
+
+##############################################################################
+# Pre-Edit Backup Script - Creates safe file backups before modifications
+# Version: 1.0.0
+##############################################################################
+
+set -euo pipefail
+
+# Function to create backup of a file before editing
+create_backup() {
+    local file_path="$1"
+    local agent_id="${2:-unknown}"
+    local project_root="${3:-$(pwd)}"
+
+    # Validate inputs
+    if [[ -z "$file_path" ]]; then
+        echo "Error: File path is required" >&2
+        exit 1
+    fi
+
+    # Check if file exists
+    if [[ ! -f "$file_path" ]]; then
+        echo "Warning: File does not exist: $file_path" >&2
+        # Create empty backup path for new files
+        echo "$project_root/.backups/$agent_id/new-file-$(date +%s)-$(echo "$file_path" | tr '/' '_' | tr ' ' '_')"
+        return 0
+    fi
+
+    # Create backup directory structure
+    local backup_dir="$project_root/.backups/$agent_id"
+    local timestamp=$(date +%s)
+    local file_hash=$(md5sum "$file_path" | cut -d' ' -f1)
+    local backup_name="${timestamp}_${file_hash}"
+
+    # Create full backup path
+    local full_backup_path="$backup_dir/$backup_name"
+
+    # Create backup directory
+    mkdir -p "$full_backup_path"
+
+    # Copy original file to backup location
+    cp "$file_path" "$full_backup_path/original"
+
+    # Store backup metadata
+    cat > "$full_backup_path/metadata.json" << EOF
+{
+  "timestamp": "$timestamp",
+  "agent_id": "$agent_id",
+  "original_file": "$file_path",
+  "file_hash": "$file_hash",
+  "backup_path": "$full_backup_path",
+  "created_at": "$(date -u +%Y-%m-%dT%H:%M:%SZ)"
+}
+EOF
+
+    # Create revert script
+    cat > "$full_backup_path/revert.sh" << EOF
+#!/bin/bash
+# Revert script for $file_path
+set -euo pipefail
+
+echo "Reverting file: $file_path"
+cp "$full_backup_path/original" "$file_path"
+echo "✅ File reverted successfully"
+EOF
+
+    chmod +x "$full_backup_path/revert.sh"
+
+    # Output backup path for caller
+    echo "$full_backup_path"
+
+    echo "✅ Backup created: $full_backup_path" >&2
+}
+
+# Main execution
+if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
+    # Script called directly
+    if [[ $# -lt 1 ]]; then
+        echo "Usage: $0 <file_path> [--agent-id <id>] [--project-root <path>]" >&2
+        exit 1
+    fi
+
+    file_path="$1"
+    agent_id="unknown"
+    project_root="$(pwd)"
+
+    # Parse optional arguments
+    while [[ $# -gt 0 ]]; do
+        case $1 in
+            --agent-id)
+                agent_id="$2"
+                shift 2
+                ;;
+            --project-root)
+                project_root="$2"
+                shift 2
+                ;;
+            *)
+                # Skip unknown arguments
+                shift
+                ;;
+        esac
+    done
+
+    create_backup "$file_path" "$agent_id" "$project_root"
+fi

package/claude-assets/agents/cfn-dev-team/coordinators/cfn-v3-coordinator.md

@@ -16,18 +16,16 @@ You coordinate CFN Loop v3 execution with Redis-based agent orchestration and CL
 
 Orchestrate CFN Loop v3 execution using Redis coordination for CLI agent spawning, context management, and consensus collection.
 
-## Mode-Specific Execution
+## CLI Mode Execution (Coordinator is ALWAYS CLI Mode)
 
-**CLI Mode (Production):**
+**IMPORTANT:** This coordinator agent is **ALWAYS CLI mode**. Task mode coordination happens directly in Main Chat, not via coordinator agents.
+
+When spawned via CLI (`npx claude-flow-novice agent-spawn`), implement full Redis coordination:
 - Use Redis coordination for agent spawning
 - Store context in Redis for swarm recovery
 - Collect confidence scores via Redis signals
 - Use background execution with monitoring
-
-**Task Mode (Debugging):**
-- Direct Task() spawning (no Redis needed)
-- Main Chat handles coordination
-- Simple JSON response only
+- **ALWAYS invoke the orchestrator** - never handle tasks directly
 
 ## Redis Coordination Protocols
 
@@ -494,11 +492,75 @@ Extract deliverables from task description:
    - Estimate iteration count
    - Provide reasoning for choices
 
+## Execution Steps (CLI Mode Only)
+
+**CRITICAL:** This coordinator is ALWAYS CLI mode. There is no Task Mode execution path.
+
+### Step 1: Task Classification (REQUIRED)
+```bash
+# Classify task type (use hardcoded defaults if script fails)
+TASK_TYPE="infrastructure"  # Default fallback
+if [[ -f ".claude/skills/task-classifier/classify-task.sh" ]]; then
+  CLASSIFIED_TYPE=$(bash .claude/skills/task-classifier/classify-task.sh "$TASK_DESCRIPTION" 2>/dev/null || echo "")
+  [[ -n "$CLASSIFIED_TYPE" ]] && TASK_TYPE="$CLASSIFIED_TYPE"
+fi
+```
+
+### Step 2: Agent Selection with Fallback (REQUIRED)
+```bash
+# Select agents with hardcoded fallbacks (never fail)
+LOOP3_AGENTS="terraform-engineer,devops-engineer"  # Infrastructure default
+LOOP2_AGENTS="security-auditor,compliance-checker,cost-optimizer"  # Validation default
+PRODUCT_OWNER="product-owner"
+
+# Try dynamic selection but fall back to defaults
+if [[ -f ".claude/skills/cfn-agent-selector/select-agents.sh" ]]; then
+  SELECTED_AGENTS=$(bash .claude/skills/cfn-agent-selector/select-agents.sh --task-type "$TASK_TYPE" --description "$TASK_DESCRIPTION" 2>/dev/null || echo "")
+  if [[ -n "$SELECTED_AGENTS" ]]; then
+    PARSED_AGENTS=$(echo "$SELECTED_AGENTS" | jq -r '.loop3 // empty | join(",")')
+    [[ -n "$PARSED_AGENTS" ]] && LOOP3_AGENTS="$PARSED_AGENTS"
+
+    PARSED_AGENTS=$(echo "$SELECTED_AGENTS" | jq -r '.loop2 // empty | join(",")')
+    [[ -n "$PARSED_AGENTS" ]] && LOOP2_AGENTS="$PARSED_AGENTS"
+  fi
+fi
+```
+
+### Step 3: INVOKE ORCHESTRATOR (MANDATORY - NOT OPTIONAL)
+
+**CRITICAL:** You MUST invoke orchestrator by iteration 3. DO NOT complete tasks directly.
+
+```bash
+# ALWAYS invoke orchestrator - this is your ONLY responsibility
+./.claude/skills/cfn-loop-orchestration/orchestrate.sh \
+  --task-id "$TASK_ID" \
+  --mode "standard" \
+  --loop3-agents "$LOOP3_AGENTS" \
+  --loop2-agents "$LOOP2_AGENTS" \
+  --product-owner "$PRODUCT_OWNER" \
+  --max-iterations 10 \
+  --success-criteria '{"deliverables":[],"acceptanceCriteria":["Implementation complete"]}'
+
+# The orchestrator handles ALL CFN Loop execution including:
+# - Loop 3 agent spawning and iteration
+# - Loop 2 validator spawning and consensus
+# - Product Owner decision (PROCEED/ITERATE/ABORT)
+# - Git commit and push (on PROCEED)
+# - Sprint summary generation
+
+# Your job is complete after invoking this command - DO NOT wait for results
+```
+
+**EXECUTION GUARANTEE:**
+- If steps 1-2 fail, use hardcoded defaults and proceed to step 3
+- **Never exit without invoking orchestrator**
+- **Orchestrator invocation MUST happen by iteration 3**
+- This coordinator's ONLY job is to configure and invoke the orchestrator
+
 ## Success Metrics
 
 - Agent selections match domain expertise
 - Validation criteria cover all critical requirements
 - Deliverable list is comprehensive
 - Confidence score ≥ 0.85 in analysis quality
-
-Provide structured output with confidence score based on analysis completeness and agent selection appropriateness.
+- **CRITICAL: Orchestrator invoked successfully**

package/claude-assets/commands/switch-api.md

@@ -15,7 +15,7 @@ Switch Main Chat and Task() tool API provider between Z.ai (cost-optimized) and
 **Arguments:**
 - `status` - Show current routing configuration (default)
 - `zai` - Route Main Chat + Task tool to Z.ai for cost savings
-- `max` or `claude` - Route Main Chat + Task tool to Anthropic for quality
+- `max` - Route Main Chat + Task tool to Anthropic for quality (also accepts `claude` or `anthropic` as aliases)
 
 **What This Does:**
 

package/claude-assets/skills/cfn-loop-orchestration/orchestrate.sh

@@ -25,15 +25,9 @@ set -euo pipefail
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 PROJECT_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
 
-# ⚠️ ANTI-023 MEMORY LEAK PROTECTION: Block Task Mode agents
-# Task Mode agents spawn via Task() tool and should NOT use orchestration scripts
-if [[ -z "${TASK_ID:-}" || -z "${LOOP3_AGENTS:-}" ]]; then
-    echo "❌ TASK MODE DETECTED - Orchestration forbidden" >&2
-    echo "🚨 ANTI-023: This script is for CLI-spawned coordinators only" >&2
-    echo "💡 Task Mode coordination should be handled directly by Main Chat" >&2
-    echo "🔧 Coordinator spawned via Task() tool - Main Chat should coordinate directly" >&2
-    exit 1
-fi
+# ⚠️ ANTI-023 MEMORY LEAK PROTECTION:
+# Task Mode validation moved to after argument parsing at line 276
+# This allows proper CLI argument processing before validation
 
 # ⚠️ ANTI-023 MEMORY LEAK PROTECTION: Environment Sanitization
 # Load and apply environment sanitization to prevent memory leaks