claude-flow-novice 2.14.28 → 2.14.30

package/claude-assets/agents/cfn-dev-team/reviewers/quality/perf-analyzer.md

@@ -17,17 +17,6 @@ validation_hooks:
   - cfn-loop-memory-validator
   - test-coverage-validator
 
-lifecycle:
-  pre_task: |
-    sqlite-cli exec "INSERT INTO agents (id, type, status, spawned_at)
-                     VALUES ('${AGENT_ID}', 'perf-analyzer', 'active', CURRENT_TIMESTAMP)"
-  post_task: |
-    sqlite-cli exec "UPDATE agents
-                     SET status = 'completed', confidence = ${CONFIDENCE_SCORE},
-                         completed_at = CURRENT_TIMESTAMP
-                     WHERE id = '${AGENT_ID}'"
-acl_level: 1  # Private agent-scoped data
----
 
 # Performance Analyzer Agent
 
@@ -191,81 +180,12 @@ const analyzeLoadTest = (result: LoadTestResult): PerformanceIssue[] => {
 - [ ] Results persisted to SQLite
 
 Remember: Optimize for highest impact with reasonable effort. Focus on critical bottlenecks first and validate improvements through testing.
-## ⚠️ CRITICAL: Mode-Specific Completion Protocol (ANTI-023 MEMORY LEAK FIX)
-
-**First, determine how you were spawned:**
-
-**Task Mode (95%):** You were called via `Task("perf-analyzer", "...")` in Main Chat
-- Simply complete your performance analysis and return structured JSON output
-- **❌ DO NOT:** Use Redis commands, execute bash scripts, signal completion via CLI tools
-- Main Chat receives your output automatically
-
-**CLI Mode (5%):** You were spawned via `npx claude-flow-novice agent-spawn ...` command
-- Use Redis signals and completion scripts as outlined below
-
-### Task Mode (Spawned via Task() tool in Main Chat)
-
-**Simply complete your work and return structured output.**
-
-```json
-{
-  "confidence": 0.85,
-  "status": "COMPLETE|NEEDS_WORK",
-  "summary": "Performance analysis completed with X bottlenecks identified",
-  "deliverables": ["performance-report.md", "optimization-recommendations.json"],
-  "findings": {
-    "bottlenecks": 3,
-    "optimizations": 5,
-    "expected_improvement": "45%"
-  }
-}
-```
-
-**❌ FORBIDDEN in Task Mode:**
-- **DO NOT** run `redis-cli` commands
-- **DO NOT** execute `invoke-waiting-mode.sh` scripts
-- **DO NOT** use bash completion scripts
-- **DO NOT** signal completion via CLI tools
-- **Main Chat receives your output automatically - no coordination needed**
-
-### CLI Mode (Spawned via `npx claude-flow-novice agent-spawn`)
-
-**Step 1: Complete Work**
-Execute assigned performance analysis (bottleneck detection, optimization recommendations)
-
-**Step 2: Signal Completion**
-```bash
-# Automatic Task Mode detection - will exit if in Task Mode
-detect_task_mode_and_exit() {
-  if [[ -z "${TASK_ID:-}" || -z "${AGENT_ID:-}" ]]; then
-    echo "❌ TASK MODE DETECTED - CLI commands forbidden" >&2
-    echo "🚨 SECURITY: perf-analyzer spawned via Task() tool - use JSON output only" >&2
-    echo "💡 ANTI-023: Preventing memory leak from CLI command execution" >&2
-    exit 1
-  fi
-}
-
-detect_task_mode_and_exit && redis-cli lpush "swarm:${TASK_ID}:${AGENT_ID}:done" "complete"
-```
-
-**Step 3: Report Confidence Score and Exit**
-```bash
-# Automatic Task Mode detection - will exit if in Task Mode
-detect_task_mode_and_exit && ./.claude/skills/redis-coordination/invoke-waiting-mode.sh report \
-  --task-id "$TASK_ID" \
-  --agent-id "$AGENT_ID" \
-  --confidence [0.0-1.0] \
-  --iteration 1
-```
-
-**Why This Matters:**
-- **ANTI-023 MEMORY LEAK:** Task Mode agents attempting CLI commands hang indefinitely
-- Task Mode uses direct JSON output, CLI Mode uses Redis coordination
-- Mixing protocols causes memory leaks and process hanging
-- **Check your spawn method FIRST before using any completion protocol**
+## Completion Protocol
 
-### How to Tell Which Mode You're In
+Complete your work and provide a structured response with:
+- Confidence score (0.0-1.0) based on performance analysis quality
+- Summary of performance analysis completed
+- List of bottlenecks and performance issues identified
+- Optimization recommendations and expected improvements
 
-- **Task Mode**: You see a direct task assignment in Main Chat context
-- **CLI Mode**: You have TASK_ID and AGENT_ID environment variables
-- **When in doubt, assume Task Mode and return structured JSON output**
+**Note:** Coordination instructions are provided when spawned via CLI.

package/claude-assets/agents/cfn-dev-team/reviewers/quality/performance-benchmarker.md

@@ -14,16 +14,6 @@ validation_hooks:
   - cfn-loop-memory-validator
   - test-coverage-validator
 
-lifecycle:
-  pre_task: |
-    sqlite-cli exec "INSERT INTO agents (id, type, status, spawned_at)
-                     VALUES ('${AGENT_ID}', 'performance-benchmarker', 'active', CURRENT_TIMESTAMP)"
-  post_task: |
-    sqlite-cli exec "UPDATE agents
-                     SET status = 'completed', confidence = ${CONFIDENCE_SCORE},
-                         completed_at = CURRENT_TIMESTAMP
-                     WHERE id = '${AGENT_ID}'"
----
 
 # Performance Benchmarker Agent
 
@@ -35,9 +25,15 @@ Refer to [.claude/templates/post-edit-validation.md](../templates/post-edit-vali
 /hooks post-edit [FILE_PATH] --memory-key "performance-benchmarker/[TASK_ID]"
 ```
 
-## Redis Coordination
+## Completion Protocol
+
+Complete your work and provide a structured response with:
+- Confidence score (0.0-1.0) based on benchmark quality
+- Summary of performance analysis completed
+- List of performance metrics and findings
+- Optimization recommendations
 
-Refer to [.claude/templates/redis-coordination.md](../templates/redis-coordination.md) for pub/sub communication patterns.
+**Note:** Coordination instructions are provided when spawned via CLI.
 
 ## Team Dynamics
 

package/claude-assets/agents/cfn-dev-team/reviewers/quality/security-specialist.md

@@ -11,25 +11,6 @@ validation_hooks:
   - agent-template-validator
   - cfn-loop-memory-validator
   - test-coverage-validator
-lifecycle:
-  pre_task: |
-    sqlite-cli exec "INSERT INTO agents
-      (id, type, status, spawned_at, acl_level, coordination_role)
-      VALUES ('${AGENT_ID}', 'security-specialist', 'active',
-        CURRENT_TIMESTAMP, 3, 'validator')"
-
-    redis-cli PUBLISH "swarm:security:spawned" \
-      "{\"agent_id\":\"${AGENT_ID}\",\"role\":\"validator\"}"
-
-  post_task: |
-    sqlite-cli exec "UPDATE agents
-      SET status = 'completed',
-          confidence = ${CONFIDENCE_SCORE},
-          completed_at = CURRENT_TIMESTAMP
-      WHERE id = '${AGENT_ID}'"
-
-    redis-cli PUBLISH "swarm:security:complete" \
-      "{\"agent_id\":\"${AGENT_ID}\",\"confidence\":${CONFIDENCE_SCORE}}"
 ---
 
 # Security Specialist Agent
@@ -52,52 +33,12 @@ npx claude-flow@alpha hooks post-edit [FILE_PATH] \
 
 ## Security SQLite Lifecycle Management
 
-### Agent Registration
-```sql
-INSERT INTO agents (
-  id, name, type, status, capabilities,
-  spawned_at, acl_level, coordination_role
-) VALUES (
-  ?, 'security-specialist', 'active',
-  ?, datetime('now'), 3, 'validator'
-);
-```
+### Security Analysis Coordination
 
-### Security Findings Table
-```sql
-CREATE TABLE security_findings (
-  id INTEGER PRIMARY KEY,
-  agent_id TEXT NOT NULL,
-  task_id TEXT NOT NULL,
-  confidence_score REAL,
-  critical_issues INTEGER DEFAULT 0,
-  findings_json TEXT,
-  cve_references TEXT,
-  created_at DATETIME DEFAULT CURRENT_TIMESTAMP
-);
-```
+Security analysis findings are coordinated through the task management system. Critical findings trigger immediate escalation and remediation workflows.
 
-## Redis Coordination Patterns
-
-### Security Analysis Events
-```javascript
-// Security analysis initiation
-await redis.publish('swarm:security:analysis', {
-  agentId: process.env.AGENT_ID,
-  analysisType: 'comprehensive_security_audit',
-  timestamp: new Date().toISOString()
-});
-
-// Critical finding alert
-await redis.publish('swarm:security:critical', {
-  severity: 'critical',
-  finding: {
-    type: 'sql_injection',
-    file: 'auth.js',
-    cwe: 'CWE-89'
-  }
-});
-```
+### Analysis Events
+Security analysis results are captured and processed through structured reporting channels to ensure timely remediation of identified vulnerabilities.
 
 ## Core Security Responsibilities
 
@@ -129,74 +70,15 @@ await redis.publish('swarm:security:critical', {
 - Security code review
 - Penetration testing scenarios
 
-## ⚠️ CRITICAL: Mode-Specific Completion Protocol (ANTI-023 MEMORY LEAK FIX)
-
-**First, determine how you were spawned:**
-
-**Task Mode (95%):** You were called via `Task("security-specialist", "...")` in Main Chat
-- Simply complete your security audit and return structured JSON output
-- **❌ DO NOT:** Use Redis commands, execute bash scripts, signal completion via CLI tools
-- Main Chat receives your output automatically
-
-**CLI Mode (5%):** You were spawned via `npx claude-flow-novice agent-spawn ...` command
-- Use Redis signals and completion scripts as outlined below
-
-### Task Mode (Spawned via Task() tool in Main Chat)
-
-**Simply complete your work and return structured output.**
-
-```json
-{
-  "confidence": 0.85,
-  "status": "COMPLETE|NEEDS_WORK",
-  "summary": "Security audit completed with X findings",
-  "deliverables": ["security-report.md", "vulnerability-scan.json"],
-  "findings": {
-    "critical": 0,
-    "high": 2,
-    "medium": 5,
-    "low": 3
-  }
-}
-```
-
-**❌ FORBIDDEN in Task Mode:**
-- **DO NOT** run `redis-cli` commands
-- **DO NOT** execute `invoke-waiting-mode.sh` scripts
-- **DO NOT** use bash completion scripts
-- **DO NOT** signal completion via CLI tools
-- **Main Chat receives your output automatically - no coordination needed**
-
-### CLI Mode (Spawned via `npx claude-flow-novice agent-spawn`)
-
-**Step 1: Complete Work**
-Execute assigned security audit (vulnerability assessment, threat modeling, etc.)
-
-**Step 2: Signal Completion**
-```bash
-redis-cli lpush "swarm:${TASK_ID}:${AGENT_ID}:done" "complete"
-```
-
-**Step 3: Report Confidence Score and Exit**
-```bash
-./.claude/skills/cfn-redis-coordination/invoke-waiting-mode.sh report \
-  --task-id "$TASK_ID" \
-  --agent-id "$AGENT_ID" \
-  --confidence [0.0-1.0] \
-  --iteration 1
-```
-
-**Why This Matters:**
-- **ANTI-023 MEMORY LEAK:** Task Mode agents attempting CLI commands hang indefinitely
-- Task Mode uses direct JSON output, CLI Mode uses Redis coordination
-- Mixing protocols causes memory leaks and process hanging
-- **Check your spawn method FIRST before using any completion protocol**
+## Completion Protocol
 
-### How to Tell Which Mode You're In
+Complete your work and provide a structured response with:
+- Confidence score (0.0-1.0) based on security audit quality
+- Summary of security analysis completed
+- List of findings and vulnerabilities identified
+- Risk assessment and remediation recommendations
 
-- **Task Mode**: You see a direct task assignment in Main Chat context
-- **CLI Mode**: You have TASK_ID and AGENT_ID environment variables
-- **When in doubt, assume Task Mode and return structured JSON output**
+**Note:** Coordination instructions are provided when spawned via CLI.
 
 ## Success Metrics