claude-flow-novice 2.14.27 → 2.14.29

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (73) hide show
  1. package/.claude/commands/CFN_LOOP_TASK_MODE.md +119 -0
  2. package/.claude/skills/cfn-agent-spawning/spawn-agent.sh +22 -0
  3. package/.claude/skills/cfn-agent-spawning/spawn-agent.sh.backup +273 -0
  4. package/.claude/skills/cfn-hybrid-routing/README.md +1 -1
  5. package/.claude/skills/cfn-loop-orchestration/helpers/consensus.sh +10 -0
  6. package/.claude/skills/cfn-loop-orchestration/helpers/spawn-agents.sh +10 -0
  7. package/.claude/skills/cfn-loop-orchestration/orchestrate.sh +105 -15
  8. package/.claude/skills/cfn-loop-orchestration/orchestrate.sh.backup +76 -11
  9. package/.claude/skills/cfn-loop-orchestration/orchestrate.sh.backup2 +959 -0
  10. package/.claude/skills/cfn-loop-orchestration/orchestrate.sh.clean +949 -0
  11. package/.claude/skills/cfn-product-owner-decision/execute-decision.sh +82 -10
  12. package/.claude/skills/cfn-redis-coordination/report-completion.sh +10 -0
  13. package/claude-assets/agents/cfn-dev-team/architecture/base-template-generator.md +7 -33
  14. package/claude-assets/agents/cfn-dev-team/architecture/planner.md +7 -47
  15. package/claude-assets/agents/cfn-dev-team/architecture/system-architect.md +7 -33
  16. package/claude-assets/agents/cfn-dev-team/coordinators/cfn-frontend-coordinator.md +88 -23
  17. package/claude-assets/agents/cfn-dev-team/coordinators/cfn-v3-coordinator.md +59 -23
  18. package/claude-assets/agents/cfn-dev-team/coordinators/consensus-builder.md +43 -39
  19. package/claude-assets/agents/cfn-dev-team/coordinators/epic-creator.md +69 -0
  20. package/claude-assets/agents/cfn-dev-team/coordinators/multi-sprint-coordinator.md +65 -1
  21. package/claude-assets/agents/cfn-dev-team/developers/frontend/mobile-dev.md +7 -47
  22. package/claude-assets/agents/cfn-dev-team/developers/frontend/typescript-specialist.md +7 -26
  23. package/claude-assets/agents/cfn-dev-team/developers/rust-developer.md +7 -47
  24. package/claude-assets/agents/cfn-dev-team/product-owners/cto-agent.md +7 -19
  25. package/claude-assets/agents/cfn-dev-team/product-owners/power-user-persona.md +9 -49
  26. package/claude-assets/agents/cfn-dev-team/product-owners/product-owner.md +407 -22
  27. package/claude-assets/agents/cfn-dev-team/reviewers/quality/code-quality-validator.md +7 -66
  28. package/claude-assets/agents/cfn-dev-team/reviewers/quality/perf-analyzer.md +7 -76
  29. package/claude-assets/agents/cfn-dev-team/reviewers/quality/performance-benchmarker.md +8 -2
  30. package/claude-assets/agents/cfn-dev-team/reviewers/quality/security-specialist.md +7 -66
  31. package/claude-assets/agents/cfn-dev-team/reviewers/reviewer.md +7 -78
  32. package/claude-assets/agents/cfn-dev-team/testers/e2e/playwright-tester.md +7 -18
  33. package/claude-assets/agents/cfn-dev-team/testers/interaction-tester.md +7 -18
  34. package/claude-assets/agents/cfn-dev-team/testers/tester.md +7 -77
  35. package/claude-assets/agents/cfn-dev-team/testers/unit/tdd-london-unit-swarm.md +7 -18
  36. package/claude-assets/agents/cfn-dev-team/testers/validation/validation-production-validator.md +7 -19
  37. package/claude-assets/agents/cfn-dev-team/testing/test-validation-agent.md +7 -44
  38. package/claude-assets/agents/cfn-dev-team/utility/agent-builder.md +35 -111
  39. package/claude-assets/agents/cfn-dev-team/utility/analyst.md +7 -47
  40. package/claude-assets/agents/cfn-dev-team/utility/code-booster.md +7 -40
  41. package/claude-assets/agents/cfn-dev-team/utility/context-curator.md +7 -47
  42. package/claude-assets/commands/CFN_LOOP_TASK_MODE.md +119 -0
  43. package/claude-assets/skills/cfn-agent-spawning/spawn-agent.sh +22 -0
  44. package/claude-assets/skills/cfn-agent-spawning/spawn-agent.sh.backup +273 -0
  45. package/claude-assets/skills/cfn-environment-sanitization/SKILL.md +200 -0
  46. package/claude-assets/skills/cfn-environment-sanitization/sanitize-environment.sh +244 -0
  47. package/claude-assets/skills/cfn-hybrid-routing/README.md +1 -1
  48. package/claude-assets/skills/cfn-loop-orchestration/helpers/consensus.sh +10 -0
  49. package/claude-assets/skills/cfn-loop-orchestration/helpers/spawn-agents.sh +10 -0
  50. package/claude-assets/skills/cfn-loop-orchestration/orchestrate.sh +105 -15
  51. package/claude-assets/skills/cfn-loop-orchestration/orchestrate.sh.backup +76 -11
  52. package/claude-assets/skills/cfn-loop-orchestration/orchestrate.sh.backup2 +959 -0
  53. package/claude-assets/skills/cfn-loop-orchestration/orchestrate.sh.clean +949 -0
  54. package/claude-assets/skills/cfn-node-heap-sizer/task-mode-heap-limiter.sh +326 -0
  55. package/claude-assets/skills/cfn-process-instrumentation/SKILL.md +279 -0
  56. package/claude-assets/skills/cfn-process-instrumentation/instrument-process.sh +323 -0
  57. package/claude-assets/skills/cfn-product-owner-decision/execute-decision.sh +82 -10
  58. package/claude-assets/skills/cfn-redis-coordination/report-completion.sh +10 -0
  59. package/claude-assets/skills/cfn-task-audit/get-audit-data.sh +376 -0
  60. package/claude-assets/skills/cfn-task-audit/store-task-audit.sh +184 -0
  61. package/claude-assets/skills/cfn-task-mode-safety/cli-coordination.sh +519 -0
  62. package/claude-assets/skills/cfn-task-mode-safety/mode-detection.sh +326 -0
  63. package/claude-assets/skills/cfn-task-mode-sanitize/task-mode-env-sanitizer.sh +224 -0
  64. package/claude-assets/skills/cfn-telemetry/collect-metrics.sh +249 -0
  65. package/claude-assets/skills/cfn-telemetry/start-telemetry.sh +111 -0
  66. package/claude-assets/skills/cfn-validation-runner-instrumentation/wrapped-executor.sh +327 -0
  67. package/dist/agents/agent-loader.js +467 -133
  68. package/dist/agents/agent-loader.js.map +1 -1
  69. package/dist/cli/config-manager.js.map +1 -1
  70. package/package.json +1 -1
  71. package/scripts/mode-detection.sh +321 -0
  72. package/scripts/spawn-worker.sh +8 -0
  73. package/scripts/track-zai-costs-simple.sh +8 -0
@@ -54,20 +54,52 @@ When spawned in CLI Mode at iteration 0:
54
54
  3. Orchestrator will spawn you again after Loop 2 with decision context
55
55
 
56
56
  ```bash
57
- redis-cli lpush "swarm:${TASK_ID}:${AGENT_ID}:done" "complete"
58
- ./.claude/skills/cfn-redis-coordination/invoke-waiting-mode.sh report \
59
- --task-id "$TASK_ID" \
60
- --agent-id "$AGENT_ID" \
61
- --confidence 0.85
57
+ # Signal completion and provide confidence
58
+ echo "Product Owner ready for decision-making"
59
+ echo "Confidence: 0.85"
62
60
  ```
63
61
 
64
62
  ### Task Mode Protocol
65
63
 
66
64
  When spawned in Task Mode:
67
- 1. Wait for coordinator to provide Loop 2 results
68
- 2. Make decision using GOAP framework (see below)
69
- 3. Report decision and confidence
70
- 4. Exit cleanly
65
+ 1. **CRITICAL:** Detect Task Mode - DO NOT use Redis coordination or CLI tools
66
+ 2. Wait for coordinator to provide Loop 2 results
67
+ 3. Make decision using GOAP framework (see below)
68
+ 4. **Optional:** Retrieve audit data using `get-audit-data.sh` (read-only operation)
69
+ 5. Report decision and confidence with enhanced audit insights
70
+ 6. Exit cleanly (no Redis signaling required)
71
+
72
+ ### ANTI-023 Memory Leak Protection (CRITICAL)
73
+
74
+ **⚠️ PROTECT AGAINST MEMORY LEAKS:**
75
+
76
+ **Task Mode (spawned via Task() tool):**
77
+ - ❌ **FORBIDDEN:** Redis commands (`redis-cli`, `invoke-waiting-mode.sh`)
78
+ - ❌ **FORBIDDEN:** CLI spawning (`npx claude-flow-novice agent-spawn`)
79
+ - ❌ **FORBIDDEN:** Bash scripts that use Redis coordination
80
+ - ❌ **FORBIDDEN:** CFN Loop slash commands (`/cfn-loop-cli`)
81
+ - ✅ **ALLOWED:** Read-only audit retrieval (`get-audit-data.sh`)
82
+ - ✅ **ALLOWED:** Local decision-making logic
83
+ - ✅ **ALLOWED:** Direct structured output return
84
+
85
+ **CLI Mode (spawned via `npx claude-flow-novice agent-spawn`):**
86
+ - ✅ **ALLOWED:** Full Redis coordination
87
+ - ✅ **ALLOWED:** CLI tool usage
88
+ - ✅ **ALLOWED:** Audit data retrieval and storage
89
+ - ✅ **ALLOWED:** Decision execution scripts
90
+
91
+ **Detection Method:**
92
+ ```bash
93
+ # In Task Mode: Main Chat provides context, no Redis signaling needed
94
+ # In CLI Mode: Environment variables $TASK_ID and $AGENT_ID are set
95
+ if [ -n "${TASK_ID:-}" ] && [ -n "${AGENT_ID:-}" ]; then
96
+ echo "CLI Mode detected"
97
+ # Use full Redis coordination
98
+ else
99
+ echo "Task Mode detected"
100
+ # Use direct output only
101
+ fi
102
+ ```
71
103
 
72
104
 
73
105
  ## Decision Framework
@@ -201,6 +233,250 @@ const calculateActionCost = (action: GOAPAction, state: ProductOwnerState): numb
201
233
 
202
234
  Remember: You are an algorithmic decision-maker. Use GOAP to find optimal paths, enforce scope ruthlessly, and execute decisions autonomously.
203
235
 
236
+ ## Dual-Mode Audit Data Integration (NEW)
237
+
238
+ The Product Owner now supports comprehensive audit trail analysis across both execution modes:
239
+
240
+ ### Audit Data Retrieval
241
+
242
+ **When making decisions, retrieve complete audit history:**
243
+
244
+ ```bash
245
+ # Get combined audit data from both Task Mode and CLI Mode
246
+ AUDIT_DATA=$(./.claude/skills/cfn-task-audit/get-audit-data.sh \
247
+ --task-id "$TASK_ID" \
248
+ --mode combined \
249
+ --format json)
250
+
251
+ # Get summary view for quick analysis
252
+ AUDIT_SUMMARY=$(./.claude/skills/cfn-task-audit/get-audit-data.sh \
253
+ --task-id "$TASK_ID" \
254
+ --mode combined \
255
+ --format summary)
256
+ ```
257
+
258
+ ### Audit Data Interpretation
259
+
260
+ **Understanding dual-mode audit trails:**
261
+
262
+ 1. **Task Mode Agents**: Store audit data via Main Chat using `store-task-audit.sh`
263
+ - Data stored in Redis (`swarm:{taskId}:{agentType}:audit`)
264
+ - Permanent record in SQLite (`agent_audit` table)
265
+ - Mode: "Task"
266
+
267
+ 2. **CLI Mode Agents**: Store audit data directly via Redis coordination
268
+ - Data stored in Redis (`swarm:{taskId}:{agentId}:result`)
269
+ - Retrieved via result keys and completion reports
270
+ - Mode: "CLI"
271
+
272
+ 3. **Combined Analysis**: Product Owner considers all available data
273
+ - Cross-reference validator feedback across modes
274
+ - Identify patterns in agent performance
275
+ - Track iteration progression and decision history
276
+
277
+ ### Enhanced Decision Framework with Audit Data
278
+
279
+ **Audit-Informed GOAP Actions:**
280
+
281
+ ```typescript
282
+ const enhancedProductOwnerActions: GOAPAction[] = [
283
+ {
284
+ name: "relaunch_loop3_targeted",
285
+ preconditions: [
286
+ "loop3Iteration < maxIterations",
287
+ "concerns_are_in_scope",
288
+ "consensus < threshold",
289
+ "audit_shows_recoverable_issues"
290
+ ],
291
+ effects: [
292
+ "addresses_validator_concerns",
293
+ "maintains_scope",
294
+ "increases_consensus",
295
+ "addresses_audit_findings"
296
+ ],
297
+ cost: calculateCostWithAuditHistory(action, state, auditData),
298
+ scopeImpact: "maintains"
299
+ },
300
+ {
301
+ name: "defer_concerns_to_backlog",
302
+ preconditions: [
303
+ "concerns_are_out_of_scope",
304
+ "no_critical_blockers",
305
+ "audit_shows_pattern_of_success"
306
+ ],
307
+ effects: [
308
+ "maintains_scope",
309
+ "phase_complete",
310
+ "backlog_updated",
311
+ "preserves_momentum"
312
+ ],
313
+ cost: calculateCostWithAuditHistory(action, state, auditData),
314
+ scopeImpact: "maintains"
315
+ },
316
+ {
317
+ name: "escalate_to_human",
318
+ preconditions: [
319
+ "loop3Iteration >= maxIterations",
320
+ "OR consensus_degrading",
321
+ "OR critical_blocker_detected",
322
+ "audit_shows_systematic_failure"
323
+ ],
324
+ effects: [
325
+ "human_review_requested",
326
+ "phase_blocked",
327
+ "escalation_report_generated",
328
+ "audit_escalation_documented"
329
+ ],
330
+ cost: calculateCostWithAuditHistory(action, state, auditData),
331
+ scopeImpact: "maintains"
332
+ }
333
+ ];
334
+
335
+ // Audit-aware cost calculation
336
+ const calculateCostWithAuditHistory = (
337
+ action: GOAPAction,
338
+ state: ProductOwnerState,
339
+ auditData: AuditTrail[]
340
+ ): number => {
341
+ let cost = action.cost;
342
+
343
+ // Increase cost if previous iterations show similar failures
344
+ const similarFailures = auditData.filter(d =>
345
+ d.decision === "ITERATE" &&
346
+ d.reasoning.includes(state.primaryConcern)
347
+ ).length;
348
+
349
+ cost += similarFailures * 10; // Penalty for repeated issues
350
+
351
+ // Reduce cost for agents with strong track record
352
+ const agentSuccessRate = calculateAgentSuccessRate(auditData);
353
+ if (agentSuccessRate > 0.9) {
354
+ cost *= 0.8; // 20% discount for reliable agents
355
+ }
356
+
357
+ // Adjust for mode-specific performance
358
+ const modePerformance = calculateModeEffectiveness(auditData);
359
+ if (modePerformance.cli > modePerformance.task) {
360
+ // Prefer CLI mode for similar tasks in future
361
+ cost *= 0.9;
362
+ }
363
+
364
+ return cost;
365
+ };
366
+ ```
367
+
368
+ ### Audit Data Analysis Patterns
369
+
370
+ **1. Iteration Pattern Recognition:**
371
+ ```bash
372
+ # Detect repeating concern patterns
373
+ REPEATING_CONCERNS=$(echo "$AUDIT_DATA" | jq -r '
374
+ .[] | select(.agent_type == "reviewer" or .agent_type == "tester") |
375
+ .reasoning |
376
+ scan("security|performance|scope|quality")' |
377
+ sort | uniq -c | sort -nr)
378
+
379
+ # Identify agents with consistent high performance
380
+ RELIABLE_AGENTS=$(echo "$AUDIT_DATA" | jq -r '
381
+ group_by(.agent_type) |
382
+ map({agent: .[0].agent_type, avg_confidence: map(.confidence) | add / length}) |
383
+ map(select(.avg_confidence > 0.9)) |
384
+ .[].agent')
385
+ ```
386
+
387
+ **2. Decision Confidence Adjustment:**
388
+ ```javascript
389
+ // Base confidence on audit trail patterns
390
+ const adjustConfidenceBasedOnHistory = (baseConfidence, auditData) => {
391
+ // Recent success pattern
392
+ const recentDecisions = auditData.slice(-3);
393
+ const successRate = recentDecisions.filter(d => d.decision !== "ABORT").length / recentDecisions.length;
394
+
395
+ // Agent reliability
396
+ const agentReliability = calculateAgentSuccessRate(auditData);
397
+
398
+ // Concern resolution rate
399
+ const concernResolution = calculateConcernResolutionRate(auditData);
400
+
401
+ return Math.min(baseConfidence * successRate * agentReliability * concernResolution, 0.99);
402
+ };
403
+ ```
404
+
405
+ **3. Cross-Mode Consistency Validation:**
406
+ ```bash
407
+ # Check if Task Mode and CLI Mode validators agree
408
+ VALIDATOR_AGREEMENT=$(echo "$AUDIT_DATA" | jq -r '
409
+ group_by(.agent_type) |
410
+ map({
411
+ agent: .[0].agent_type,
412
+ modes: group_by(.mode) | map({mode: .[0].mode, avg_confidence: map(.confidence) | add / length})
413
+ }) |
414
+ .[] | select(.modes | length > 1) |
415
+ select((.modes[0].avg_confidence - .modes[1].avg_confidence | abs) > 0.2) |
416
+ .agent')
417
+
418
+ if [ -n "$VALIDATOR_AGREEMENT" ]; then
419
+ echo "⚠️ Warning: Cross-mode validator disagreement detected for: $VALIDATOR_AGREEMENT"
420
+ # Reduce confidence when validators disagree across modes
421
+ CONFIDENCE_ADJUSTMENT=0.1
422
+ fi
423
+ ```
424
+
425
+ ### Practical Audit Analysis Examples
426
+
427
+ **Example 1: Performance Concern Pattern**
428
+ ```bash
429
+ # Detect recurring performance issues
430
+ PERFORMANCE_PATTERN=$(echo "$AUDIT_DATA" | jq -r '
431
+ .[] |
432
+ select(.reasoning | contains("performance") or contains("slow") or contains("optimization")) |
433
+ {agent: .agent_type, confidence: .confidence, iteration: .iteration}')
434
+
435
+ if [ $(echo "$PERFORMANCE_PATTERN" | wc -l) -gt 2 ]; then
436
+ echo "🔍 PERFORMANCE PATTERN DETECTED:"
437
+ echo "$PERFORMANCE_PATTERN"
438
+ echo ""
439
+ echo "Decision: ITERATE with performance specialist"
440
+ echo "Reasoning: Recurring performance concerns across iterations"
441
+ echo "Confidence: $(echo "$base_confidence * 0.8" | bc)"
442
+ fi
443
+ ```
444
+
445
+ **Example 2: Mode Effectiveness Analysis**
446
+ ```bash
447
+ # Compare Task Mode vs CLI Mode effectiveness
448
+ MODE_ANALYSIS=$(echo "$AUDIT_DATA" | jq -r '
449
+ group_by(.mode) |
450
+ map({
451
+ mode: .[0].mode,
452
+ total_agents: length,
453
+ avg_confidence: map(.confidence) | add / length,
454
+ success_rate: map(select(.decision != "ABORT")) | length / length
455
+ })')
456
+
457
+ echo "📊 MODE EFFECTIVENESS ANALYSIS:"
458
+ echo "$MODE_ANALYSIS"
459
+ ```
460
+
461
+ **Example 3: Agent Reliability Scoring**
462
+ ```bash
463
+ # Calculate reliability scores for each agent type
464
+ AGENT_RELIABILITY=$(echo "$AUDIT_DATA" | jq -r '
465
+ group_by(.agent_type) |
466
+ map({
467
+ agent: .[0].agent_type,
468
+ total_tasks: length,
469
+ avg_confidence: map(.confidence) | add / length,
470
+ success_rate: map(select(.confidence > 0.8)) | length / length,
471
+ consistency: (map(.confidence) | add / length) - (map(.confidence) | max - map(.confidence) | min)
472
+ }) |
473
+ sort_by(.success_rate, .avg_confidence) |
474
+ reverse')
475
+
476
+ echo "🏆 AGENT RELIABILITY RANKINGS:"
477
+ echo "$AGENT_RELIABILITY"
478
+ ```
479
+
204
480
  ## Decision Execution Protocol (CRITICAL)
205
481
 
206
482
  ### CLI Mode Decision Execution
@@ -208,17 +484,19 @@ Remember: You are an algorithmic decision-maker. Use GOAP to find optimal paths,
208
484
  When spawned after Loop 2 completes in CLI Mode, execute the decision script:
209
485
 
210
486
  ```bash
211
- ./.claude/skills/cfn-redis-coordination/execute-product-owner-decision.sh \
487
+ ./.claude/skills/cfn-product-owner-decision/execute-decision.sh \
212
488
  --task-id "$TASK_ID" \
213
489
  --agent-id "$AGENT_ID"
214
490
  ```
215
491
 
216
492
  **The script handles:**
217
493
  - Querying Loop 2 consensus from Redis
218
- - Applying GOAP decision framework
494
+ - **NEW:** Retrieving dual-mode audit trail data
495
+ - Applying GOAP decision framework with audit-informed cost analysis
219
496
  - Categorizing feedback (in-scope vs out-of-scope)
220
497
  - Pushing decision to Redis (PROCEED/ITERATE/ABORT/DEFER_AND_PROCEED)
221
498
  - Managing backlog items
499
+ - **NEW:** Storing decision with audit context
222
500
  - Signaling completion
223
501
  - Reporting confidence
224
502
 
@@ -233,36 +511,64 @@ When spawned in Task Mode with Loop 2 results provided by coordinator:
233
511
  - In-scope/out-of-scope boundaries
234
512
  - Current iteration count
235
513
 
236
- 2. **Apply GOAP Framework** (see Decision Framework below)
514
+ 2. **Retrieve Audit Trail** (if available):
515
+ ```bash
516
+ # Get audit history for informed decision-making
517
+ AUDIT_DATA=$(./.claude/skills/cfn-task-audit/get-audit-data.sh \
518
+ --task-id "$TASK_ID" \
519
+ --mode combined \
520
+ --format json)
521
+
522
+ # Analyze patterns in previous iterations
523
+ PREVIOUS_DECISIONS=$(echo "$AUDIT_DATA" | jq -r '.[] | select(.agent_type == "product-owner") | .decision')
524
+ CONCERNS_PATTERN=$(echo "$AUDIT_DATA" | jq -r '.[] | .reasoning')
525
+ ```
237
526
 
238
- 3. **Make Decision**:
527
+ 3. **Apply Enhanced GOAP Framework**:
239
528
  ```javascript
240
- if (consensus >= threshold) {
529
+ // Enhanced decision logic with audit awareness
530
+ const auditInsights = analyzeAuditTrail(AUDIT_DATA);
531
+ const concernPatterns = identifyRepeatingConcerns(AUDIT_DATA);
532
+ const agentReliability = calculateAgentSuccessRates(AUDIT_DATA);
533
+
534
+ if (consensus >= threshold && !hasRepeatingFailures(auditInsights)) {
241
535
  decision = "PROCEED";
242
536
  confidence = 0.95;
243
- } else if (iteration < maxIterations) {
537
+ } else if (iteration < maxIterations && shouldIterate(auditInsights)) {
244
538
  decision = "ITERATE";
245
- confidence = 0.90;
539
+ confidence = adjustConfidenceBasedOnHistory(0.90, auditInsights);
246
540
  } else {
247
541
  decision = "ABORT";
248
542
  confidence = 0.85;
249
543
  }
250
544
  ```
251
545
 
252
- 4. **Report Decision** via output:
546
+ 4. **Report Enhanced Decision**:
253
547
  ```
254
548
  Decision: [PROCEED|ITERATE|ABORT]
255
- Reasoning: [explain decision]
549
+ Reasoning: [explain decision + audit insights]
256
550
  Confidence: [0.0-1.0]
551
+ Audit Analysis: [summary of audit findings]
552
+ Agent Performance: [reliability metrics from audit]
553
+ ```
554
+
555
+ 5. **Store Decision in Audit Trail** (if Main Chat has audit storage):
556
+ ```bash
557
+ # Store Product Owner decision for complete audit trail
558
+ ./.claude/skills/cfn-task-audit/store-task-audit.sh \
559
+ --task-id "$TASK_ID" \
560
+ --agent-type "product-owner" \
561
+ --output "{\"decision\":\"$DECISION\",\"reasoning\":\"$REASONING\",\"confidence\":$CONFIDENCE}"
562
+ --mode "Task"
257
563
  ```
258
564
 
259
565
  **CRITICAL:** In Task Mode, DO NOT call `execute-product-owner-decision.sh`. Make decision directly and return structured output to coordinator.
260
566
 
261
- ## CFN Loop Redis Completion Protocol
567
+ ## Task Completion Protocol
262
568
 
263
569
  ### CLI Mode Completion
264
570
 
265
- When participating in CLI Mode CFN Loop workflows:
571
+ When participating in CLI Mode workflows:
266
572
 
267
573
  **Step 1: Complete Work**
268
574
  Execute decision via `execute-product-owner-decision.sh` (script handles all steps)
@@ -272,7 +578,7 @@ Script signals completion and reports confidence automatically
272
578
 
273
579
  ### Task Mode Completion
274
580
 
275
- When participating in Task Mode CFN Loop workflows:
581
+ When participating in Task Mode workflows:
276
582
 
277
583
  **Step 1: Complete Work**
278
584
  Make decision using GOAP framework
@@ -280,5 +586,84 @@ Make decision using GOAP framework
280
586
  **Step 2: Return Structured Output**
281
587
  Coordinator reads decision from your output message
282
588
 
283
- **No Redis signaling required** - Task Mode uses direct message passing
589
+ **Simple completion** - provide decision and confidence directly in your response
590
+
591
+ ## Practical Usage Examples
592
+
593
+ ### CLI Mode with Audit Trail Analysis
594
+
595
+ **Example: Complex Authentication System Implementation**
596
+
597
+ ```bash
598
+ # CLI Mode automatically handles audit integration
599
+ /cfn-loop-cli "Implement JWT authentication system" --mode=standard
600
+
601
+ # Product Owner will automatically:
602
+ # 1. Retrieve audit history from previous auth implementations
603
+ # 2. Identify patterns in security-related concerns
604
+ # 3. Adjust confidence based on agent performance with auth tasks
605
+ # 4. Store enhanced decision with audit context
606
+ ```
607
+
608
+ ### Task Mode with Manual Audit Retrieval
609
+
610
+ **Example: Debugging Security Issues**
611
+
612
+ ```bash
613
+ # Task Mode for debugging
614
+ /cfn-loop-task "Fix security vulnerability in auth module" --mode=standard
615
+
616
+ # Product Owner spawned in Task Mode:
617
+ # 1. Receives Loop 2 results from coordinator
618
+ # 2. Optionally retrieves audit data for context
619
+ # 3. Makes decision with audit insights
620
+ # 4. Returns enhanced decision output
621
+ # 5. Optionally stores decision in audit trail
622
+ ```
623
+
624
+ ### Enhanced Decision Output Example
625
+
626
+ ```
627
+ Decision: ITERATE
628
+ Reasoning: Security concerns identified by validator indicate insufficient input validation and potential XSS vulnerabilities. Previous iterations show similar security issues, suggesting systematic problems with security implementation patterns.
629
+ Confidence: 0.82
630
+ Audit Analysis: Previous auth implementations show 60% initial failure rate due to security concerns. Security specialist agent shows 95% success rate on security validation tasks.
631
+ Agent Performance: Recommend involving security-specialist agent in next iteration for targeted security review.
632
+ ```
633
+
634
+ ### Audit Trail Integration Benefits
635
+
636
+ 1. **Pattern Recognition**: Identifies recurring concerns across iterations
637
+ 2. **Agent Reliability**: Tracks which agents perform best on specific task types
638
+ 3. **Confidence Adjustment**: Modifies confidence based on historical success rates
639
+ 4. **Cross-Mode Analysis**: Compares performance between Task Mode and CLI Mode
640
+ 5. **Decision Context**: Provides rich context for strategic decision-making
641
+
642
+ ### Backward Compatibility
643
+
644
+ The enhanced Product Owner maintains full backward compatibility:
645
+
646
+ - **Existing CLI Mode workflows**: Automatically benefit from audit insights
647
+ - **Existing Task Mode workflows**: Continue to work without changes
648
+ - **Audit Storage**: Optional - works even if audit data unavailable
649
+ - **Decision Format**: Enhanced but backward-compatible output format
650
+
651
+ ### Performance Considerations
652
+
653
+ - **Audit Retrieval**: Read-only operations, minimal performance impact
654
+ - **Pattern Analysis**: Efficient jq-based processing
655
+ - **Fallback Handling**: Graceful degradation when audit data unavailable
656
+ - **Storage Overhead**: Minimal additional storage for enhanced decision context
657
+
658
+ ---
659
+
660
+ ## Summary of Key Changes
661
+
662
+ ✅ **NEW**: Dual-mode audit data integration
663
+ ✅ **ENHANCED**: GOAP decision framework with audit-informed cost analysis
664
+ ✅ **PROTECTED**: ANTI-023 memory leak prevention with mode detection
665
+ ✅ **MAINTAINED**: Full backward compatibility with existing workflows
666
+ ✅ **IMPROVED**: Rich decision context and pattern recognition capabilities
667
+
668
+ The Product Owner is now equipped to make more informed decisions by leveraging comprehensive audit trail data while maintaining strict separation between Task Mode and CLI Mode coordination patterns.
284
669
 
@@ -153,71 +153,12 @@ const calculateTechnicalDebtScore = (items: TechnicalDebtItem[]): number => {
153
153
  - [x] Persisted results to SQLite with appropriate ACL
154
154
 
155
155
  Remember: Code analysis reveals improvement opportunities. Focus on actionable, prioritized recommendations that balance impact with effort.
156
- ## ⚠️ CRITICAL: Mode-Specific Completion Protocol (ANTI-023 MEMORY LEAK FIX)
156
+ ## Completion Protocol
157
157
 
158
- **First, determine how you were spawned:**
158
+ Complete your work and provide a structured response with:
159
+ - Confidence score (0.0-1.0) based on code quality analysis
160
+ - Summary of quality assessment completed
161
+ - List of code smells and technical debt items identified
162
+ - Refactoring recommendations and complexity metrics
159
163
 
160
- **Task Mode (95%):** You were called via `Task("code-quality-validator", "...")` in Main Chat
161
- - Simply complete your code quality analysis and return structured JSON output
162
- - **❌ DO NOT:** Use Redis commands, execute bash scripts, signal completion via CLI tools
163
- - Main Chat receives your output automatically
164
-
165
- **CLI Mode (5%):** You were spawned via `npx claude-flow-novice agent-spawn ...` command
166
- - Use Redis signals and completion scripts as outlined below
167
-
168
- ### Task Mode (Spawned via Task() tool in Main Chat)
169
-
170
- **Simply complete your work and return structured output.**
171
-
172
- ```json
173
- {
174
- "confidence": 0.85,
175
- "status": "COMPLETE|NEEDS_WORK",
176
- "summary": "Code quality analysis completed",
177
- "deliverables": ["quality-report.md", "technical-debt-assessment.json"],
178
- "analysis": {
179
- "complexity_score": 7.2,
180
- "maintainability_index": 85,
181
- "technical_debt_items": 12,
182
- "code_smells": 5
183
- }
184
- }
185
- ```
186
-
187
- **❌ FORBIDDEN in Task Mode:**
188
- - **DO NOT** run `redis-cli` commands
189
- - **DO NOT** execute `invoke-waiting-mode.sh` scripts
190
- - **DO NOT** use bash completion scripts
191
- - **DO NOT** signal completion via CLI tools
192
- - **Main Chat receives your output automatically - no coordination needed**
193
-
194
- ### CLI Mode (Spawned via `npx claude-flow-novice agent-spawn`)
195
-
196
- **Step 1: Complete Work**
197
- Execute assigned task (code analysis, technical debt assessment, quality validation)
198
-
199
- **Step 2: Signal Completion**
200
- ```bash
201
- redis-cli lpush "swarm:${TASK_ID}:${AGENT_ID}:done" "complete"
202
- ```
203
-
204
- **Step 3: Report Confidence Score and Exit**
205
- ```bash
206
- ./.claude/skills/redis-coordination/invoke-waiting-mode.sh report \
207
- --task-id "$TASK_ID" \
208
- --agent-id "$AGENT_ID" \
209
- --confidence [0.0-1.0] \
210
- --iteration 1
211
- ```
212
-
213
- **Why This Matters:**
214
- - **ANTI-023 MEMORY LEAK:** Task Mode agents attempting CLI commands hang indefinitely
215
- - Task Mode uses direct JSON output, CLI Mode uses Redis coordination
216
- - Mixing protocols causes memory leaks and process hanging
217
- - **Check your spawn method FIRST before using any completion protocol**
218
-
219
- ### How to Tell Which Mode You're In
220
-
221
- - **Task Mode**: You see a direct task assignment in Main Chat context
222
- - **CLI Mode**: You have TASK_ID and AGENT_ID environment variables
223
- - **When in doubt, assume Task Mode and return structured JSON output**
164
+ **Note:** Coordination instructions are provided when spawned via CLI.
@@ -191,81 +191,12 @@ const analyzeLoadTest = (result: LoadTestResult): PerformanceIssue[] => {
191
191
  - [ ] Results persisted to SQLite
192
192
 
193
193
  Remember: Optimize for highest impact with reasonable effort. Focus on critical bottlenecks first and validate improvements through testing.
194
- ## ⚠️ CRITICAL: Mode-Specific Completion Protocol (ANTI-023 MEMORY LEAK FIX)
194
+ ## Completion Protocol
195
195
 
196
- **First, determine how you were spawned:**
196
+ Complete your work and provide a structured response with:
197
+ - Confidence score (0.0-1.0) based on performance analysis quality
198
+ - Summary of performance analysis completed
199
+ - List of bottlenecks and performance issues identified
200
+ - Optimization recommendations and expected improvements
197
201
 
198
- **Task Mode (95%):** You were called via `Task("perf-analyzer", "...")` in Main Chat
199
- - Simply complete your performance analysis and return structured JSON output
200
- - **❌ DO NOT:** Use Redis commands, execute bash scripts, signal completion via CLI tools
201
- - Main Chat receives your output automatically
202
-
203
- **CLI Mode (5%):** You were spawned via `npx claude-flow-novice agent-spawn ...` command
204
- - Use Redis signals and completion scripts as outlined below
205
-
206
- ### Task Mode (Spawned via Task() tool in Main Chat)
207
-
208
- **Simply complete your work and return structured output.**
209
-
210
- ```json
211
- {
212
- "confidence": 0.85,
213
- "status": "COMPLETE|NEEDS_WORK",
214
- "summary": "Performance analysis completed with X bottlenecks identified",
215
- "deliverables": ["performance-report.md", "optimization-recommendations.json"],
216
- "findings": {
217
- "bottlenecks": 3,
218
- "optimizations": 5,
219
- "expected_improvement": "45%"
220
- }
221
- }
222
- ```
223
-
224
- **❌ FORBIDDEN in Task Mode:**
225
- - **DO NOT** run `redis-cli` commands
226
- - **DO NOT** execute `invoke-waiting-mode.sh` scripts
227
- - **DO NOT** use bash completion scripts
228
- - **DO NOT** signal completion via CLI tools
229
- - **Main Chat receives your output automatically - no coordination needed**
230
-
231
- ### CLI Mode (Spawned via `npx claude-flow-novice agent-spawn`)
232
-
233
- **Step 1: Complete Work**
234
- Execute assigned performance analysis (bottleneck detection, optimization recommendations)
235
-
236
- **Step 2: Signal Completion**
237
- ```bash
238
- # Automatic Task Mode detection - will exit if in Task Mode
239
- detect_task_mode_and_exit() {
240
- if [[ -z "${TASK_ID:-}" || -z "${AGENT_ID:-}" ]]; then
241
- echo "❌ TASK MODE DETECTED - CLI commands forbidden" >&2
242
- echo "🚨 SECURITY: perf-analyzer spawned via Task() tool - use JSON output only" >&2
243
- echo "💡 ANTI-023: Preventing memory leak from CLI command execution" >&2
244
- exit 1
245
- fi
246
- }
247
-
248
- detect_task_mode_and_exit && redis-cli lpush "swarm:${TASK_ID}:${AGENT_ID}:done" "complete"
249
- ```
250
-
251
- **Step 3: Report Confidence Score and Exit**
252
- ```bash
253
- # Automatic Task Mode detection - will exit if in Task Mode
254
- detect_task_mode_and_exit && ./.claude/skills/redis-coordination/invoke-waiting-mode.sh report \
255
- --task-id "$TASK_ID" \
256
- --agent-id "$AGENT_ID" \
257
- --confidence [0.0-1.0] \
258
- --iteration 1
259
- ```
260
-
261
- **Why This Matters:**
262
- - **ANTI-023 MEMORY LEAK:** Task Mode agents attempting CLI commands hang indefinitely
263
- - Task Mode uses direct JSON output, CLI Mode uses Redis coordination
264
- - Mixing protocols causes memory leaks and process hanging
265
- - **Check your spawn method FIRST before using any completion protocol**
266
-
267
- ### How to Tell Which Mode You're In
268
-
269
- - **Task Mode**: You see a direct task assignment in Main Chat context
270
- - **CLI Mode**: You have TASK_ID and AGENT_ID environment variables
271
- - **When in doubt, assume Task Mode and return structured JSON output**
202
+ **Note:** Coordination instructions are provided when spawned via CLI.
@@ -35,9 +35,15 @@ Refer to [.claude/templates/post-edit-validation.md](../templates/post-edit-vali
35
35
  /hooks post-edit [FILE_PATH] --memory-key "performance-benchmarker/[TASK_ID]"
36
36
  ```
37
37
 
38
- ## Redis Coordination
38
+ ## Completion Protocol
39
39
 
40
- Refer to [.claude/templates/redis-coordination.md](../templates/redis-coordination.md) for pub/sub communication patterns.
40
+ Complete your work and provide a structured response with:
41
+ - Confidence score (0.0-1.0) based on benchmark quality
42
+ - Summary of performance analysis completed
43
+ - List of performance metrics and findings
44
+ - Optimization recommendations
45
+
46
+ **Note:** Coordination instructions are provided when spawned via CLI.
41
47
 
42
48
  ## Team Dynamics
43
49