claude-flow-novice 2.10.5 → 2.10.6

package/claude-assets/skills/cfn-product-owner-decision/execute-decision.sh

@@ -0,0 +1,176 @@
+#!/bin/bash
+# Product Owner Decision Skill - Main Execution Wrapper
+# Guarantees decision execution via output parsing (solves BUG #11)
+
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+
+# Parse arguments
+TASK_ID=""
+AGENT_ID=""
+CONSENSUS=""
+THRESHOLD=""
+ITERATION=""
+MAX_ITERATIONS=""
+SUCCESS_CRITERIA=""
+EXPECTED_FILES=""
+
+while [[ $# -gt 0 ]]; do
+  case $1 in
+    --task-id)
+      TASK_ID="$2"
+      shift 2
+      ;;
+    --agent-id)
+      AGENT_ID="$2"
+      shift 2
+      ;;
+    --consensus)
+      CONSENSUS="$2"
+      shift 2
+      ;;
+    --threshold)
+      THRESHOLD="$2"
+      shift 2
+      ;;
+    --iteration)
+      ITERATION="$2"
+      shift 2
+      ;;
+    --max-iterations)
+      MAX_ITERATIONS="$2"
+      shift 2
+      ;;
+    --success-criteria)
+      SUCCESS_CRITERIA="$2"
+      shift 2
+      ;;
+    --expected-files)
+      EXPECTED_FILES="$2"
+      shift 2
+      ;;
+    *)
+      echo "Unknown option: $1" >&2
+      exit 1
+      ;;
+  esac
+done
+
+# Validate required parameters
+if [ -z "$TASK_ID" ] || [ -z "$AGENT_ID" ] || [ -z "$CONSENSUS" ] || \
+   [ -z "$THRESHOLD" ] || [ -z "$ITERATION" ] || [ -z "$MAX_ITERATIONS" ]; then
+  echo "ERROR: Missing required parameters" >&2
+  echo "Usage: $0 --task-id TASK_ID --agent-id AGENT_ID --consensus CONSENSUS --threshold THRESHOLD --iteration ITERATION --max-iterations MAX_ITERATIONS [--success-criteria JSON]" >&2
+  exit 1
+fi
+
+# Build Product Owner context
+PO_CONTEXT="CFN Loop iteration $ITERATION complete.
+
+Loop 2 Consensus: $CONSENSUS (threshold: $THRESHOLD)
+Task ID: $TASK_ID
+Agent ID: $AGENT_ID
+Max Iterations: $MAX_ITERATIONS
+
+Make your strategic decision: PROCEED, ITERATE, or ABORT
+
+Decision Framework:
+- PROCEED: Consensus >= $THRESHOLD AND deliverables verified
+- ITERATE: Consensus < $THRESHOLD AND iteration < $MAX_ITERATIONS
+- ABORT: Max iterations reached without consensus
+
+Output your decision clearly with reasoning.
+Format: Decision: [PROCEED|ITERATE|ABORT]"
+
+# Inject CFN Loop context if injection script exists
+INJECT_SCRIPT="$SCRIPT_DIR/.claude/skills/cfn-cfn-cfn-loop-orchestration/inject-loop-context.sh"
+if [[ -x "$INJECT_SCRIPT" ]]; then
+  PO_CONTEXT=$("$INJECT_SCRIPT" "loop4" "$PO_CONTEXT" 2>/dev/null || echo "$PO_CONTEXT")
+fi
+
+# Get agent timeout (if get_agent_timeout function available)
+if command -v get_agent_timeout &>/dev/null; then
+  PO_TIMEOUT=$(get_agent_timeout "product-owner" "$TASK_ID")
+else
+  PO_TIMEOUT=900  # Default 15 minutes
+fi
+
+# Spawn Product Owner and capture output
+PO_OUTPUT=$(timeout "$PO_TIMEOUT" npx claude-flow-novice agent product-owner \
+  --task-id "$TASK_ID" \
+  --agent-id "$AGENT_ID" \
+  --context "$PO_CONTEXT" 2>&1 || true)
+
+# Parse decision using skill parser
+DECISION_TYPE=$("$SCRIPT_DIR/parse-decision.sh" --output "$PO_OUTPUT")
+
+if [ -z "$DECISION_TYPE" ]; then
+  echo "❌ ERROR: Could not parse Product Owner decision" >&2
+  echo "Product Owner output:" >&2
+  echo "$PO_OUTPUT" >&2
+
+  # Fallback to ABORT on parse failure
+  DECISION_TYPE="ABORT"
+  REASONING="Failed to parse Product Owner decision from output"
+  CONFIDENCE=0.50
+else
+  # Extract reasoning (context around decision)
+  REASONING=$(echo "$PO_OUTPUT" | grep -A5 -i "decision" | tail -5 | tr '\n' ' ' | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')
+  CONFIDENCE=0.90
+fi
+
+# Validate deliverables for PROCEED decisions
+if [ "$DECISION_TYPE" = "PROCEED" ]; then
+  DELIVERABLE_ARGS="--task-id $TASK_ID"
+  if [ -n "$EXPECTED_FILES" ]; then
+    DELIVERABLE_ARGS="$DELIVERABLE_ARGS --expected-files $EXPECTED_FILES"
+  fi
+
+  DELIVERABLE_STATUS=$("$SCRIPT_DIR/validate-deliverables.sh" $DELIVERABLE_ARGS)
+
+  if [ "$DELIVERABLE_STATUS" = "FAILED" ]; then
+    # Retrieve missing files from Redis (if available)
+    MISSING_FILES_JSON=$(redis-cli get "swarm:${TASK_ID}:missing-files" 2>/dev/null || echo "[]")
+    MISSING_FILES_LIST=$(echo "$MISSING_FILES_JSON" | jq -r '.[]' | tr '\n' ', ' | sed 's/,$//')
+
+    # Override PROCEED → ITERATE
+    DECISION_TYPE="ITERATE"
+    if [ -n "$MISSING_FILES_LIST" ]; then
+      REASONING="Deliverable verification failed - missing files: $MISSING_FILES_LIST"
+    else
+      REASONING="Deliverable verification failed - no files created (consensus on plans only)"
+    fi
+    CONFIDENCE=0.75
+  fi
+fi
+
+# Build decision JSON
+DECISION_JSON=$(jq -n \
+  --arg decision "$DECISION_TYPE" \
+  --arg reasoning "${REASONING:-Parsed from Product Owner output}" \
+  --arg confidence "$CONFIDENCE" \
+  --arg iteration "$ITERATION" \
+  --arg consensus "$CONSENSUS" \
+  '{
+    decision: $decision,
+    reasoning: $reasoning,
+    confidence: ($confidence | tonumber),
+    iteration: ($iteration | tonumber),
+    consensus: ($consensus | tonumber),
+    timestamp: (now | todate)
+  }')
+
+# Push decision to Redis (orchestrator's responsibility, not agent's)
+DECISION_KEY="swarm:${TASK_ID}:${AGENT_ID}:decision"
+echo "$DECISION_JSON" | redis-cli -x LPUSH "$DECISION_KEY" >/dev/null
+
+# Signal Product Owner completion
+redis-cli LPUSH "swarm:${TASK_ID}:${AGENT_ID}:done" "complete" >/dev/null
+
+# Store decision in metrics
+redis-cli LPUSH "swarm:${TASK_ID}:metrics:product_owner_decisions" "$DECISION_JSON" >/dev/null
+redis-cli INCR "swarm:metrics:decisions:$(echo "$DECISION_TYPE" | tr '[:upper:]' '[:lower:]')" >/dev/null
+
+# Output decision JSON for orchestrator
+echo "$DECISION_JSON"

package/claude-assets/skills/cfn-product-owner-decision/parse-decision.sh

@@ -0,0 +1,66 @@
+#!/bin/bash
+# Product Owner Decision Parser - Robust pattern matching with fallbacks
+
+set -euo pipefail
+
+# Parse arguments
+OUTPUT=""
+
+while [[ $# -gt 0 ]]; do
+  case $1 in
+    --output)
+      OUTPUT="$2"
+      shift 2
+      ;;
+    *)
+      echo "Unknown option: $1" >&2
+      exit 1
+      ;;
+  esac
+done
+
+if [ -z "$OUTPUT" ]; then
+  echo "ERROR: --output required" >&2
+  exit 1
+fi
+
+# Pattern 1: Labeled decision (most explicit)
+# Example: "Decision: PROCEED"
+DECISION=$(echo "$OUTPUT" | grep -oiE "Decision:\s*(PROCEED|ITERATE|ABORT)" | \
+  grep -oE "(PROCEED|ITERATE|ABORT)" | head -1)
+
+if [ -n "$DECISION" ]; then
+  echo "$DECISION"
+  exit 0
+fi
+
+# Pattern 2: Standalone keyword (first occurrence)
+# Example: "I recommend we PROCEED with..."
+DECISION=$(echo "$OUTPUT" | grep -oE "(PROCEED|ITERATE|ABORT)" | head -1)
+
+if [ -n "$DECISION" ]; then
+  echo "$DECISION"
+  exit 0
+fi
+
+# Pattern 3: Case-insensitive fallback
+# Example: "proceed with deployment"
+DECISION=$(echo "$OUTPUT" | grep -oiE "(proceed|iterate|abort)" | head -1 | tr '[:lower:]' '[:upper:]')
+
+if [ -n "$DECISION" ]; then
+  echo "$DECISION"
+  exit 0
+fi
+
+# Pattern 4: JSON format fallback
+# Example: {"decision": "PROCEED"}
+DECISION=$(echo "$OUTPUT" | jq -r '.decision // empty' 2>/dev/null | grep -oE "(PROCEED|ITERATE|ABORT)" | head -1)
+
+if [ -n "$DECISION" ]; then
+  echo "$DECISION"
+  exit 0
+fi
+
+# No decision found - return empty (caller handles fallback to ABORT)
+echo ""
+exit 0

package/claude-assets/skills/cfn-product-owner-decision/validate-deliverables.sh

@@ -0,0 +1,82 @@
+#!/bin/bash
+# Deliverable Verification - Prevent "consensus on vapor"
+
+set -euo pipefail
+
+# Parse arguments
+TASK_ID=""
+EXPECTED_FILES=""
+
+while [[ $# -gt 0 ]]; do
+  case $1 in
+    --task-id)
+      TASK_ID="$2"
+      shift 2
+      ;;
+    --expected-files)
+      EXPECTED_FILES="$2"
+      shift 2
+      ;;
+    *)
+      echo "Unknown option: $1" >&2
+      exit 1
+      ;;
+  esac
+done
+
+if [ -z "$TASK_ID" ]; then
+  echo "ERROR: --task-id required" >&2
+  exit 1
+fi
+
+# Get task description from Redis
+TASK_DESC=$(redis-cli GET "swarm:${TASK_ID}:task" 2>/dev/null || echo "")
+
+# Check if task requires implementation (file creation)
+REQUIRES_FILES=false
+if echo "$TASK_DESC" | grep -qiE "create|build|implement|generate|file|component|module|test|write|add"; then
+  REQUIRES_FILES=true
+fi
+
+# If task doesn't require files, skip verification
+if [ "$REQUIRES_FILES" = false ]; then
+  echo "PASSED"
+  exit 0
+fi
+
+# If expected files specified, verify actual existence
+if [ -n "$EXPECTED_FILES" ]; then
+  MISSING_FILES=()
+  IFS=',' read -ra FILES <<< "$EXPECTED_FILES"
+
+  for file in "${FILES[@]}"; do
+    # Trim whitespace
+    file=$(echo "$file" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')
+
+    if [ ! -f "$file" ]; then
+      MISSING_FILES+=("$file")
+    fi
+  done
+
+  if [ ${#MISSING_FILES[@]} -gt 0 ]; then
+    echo "FAILED"
+    # Store missing files in Redis for orchestrator feedback
+    MISSING_JSON=$(printf '%s\n' "${MISSING_FILES[@]}" | jq -R . | jq -s -c .)
+    redis-cli setex "swarm:${TASK_ID}:missing-files" 300 "$MISSING_JSON" >/dev/null
+    exit 0
+  else
+    echo "PASSED"
+    exit 0
+  fi
+fi
+
+# Fallback: Check for file changes in git (backward compatibility)
+FILES_CREATED=$(git status --short 2>/dev/null | grep -E "^(A|M|\?\?)" | wc -l)
+
+if [ "$FILES_CREATED" -eq 0 ]; then
+  echo "FAILED"
+  exit 0
+else
+  echo "PASSED"
+  exit 0
+fi

package/claude-assets/skills/cfn-redis-coordination/AGENT_LOGGING.md

@@ -0,0 +1,280 @@
+# Agent Logging System
+
+Dual-output logging for CLI-spawned agents: terminal + Redis + portal visibility.
+
+## Features
+
+✅ **Terminal output** - Colored logs for debugging in tmux/terminal
+✅ **File logging** - Persisted to `/tmp/agent-*.log`
+✅ **Redis pub/sub** - Real-time streaming to web portal
+✅ **Redis history** - Last 7 days stored in sorted sets
+✅ **Portal filters** - Filter by repository, agent, or log level
+
+## Quick Start
+
+### 1. Source in Agent Scripts
+
+```bash
+#!/usr/bin/env bash
+source .claude/skills/redis-coordination/agent-log.sh
+
+# Set context
+export AGENT_ID="backend-dev-1"
+export TASK_ID="$1"  # Pass from command line
+
+# Log throughout execution
+agent_log "info" "Starting task execution"
+agent_log "debug" "Loading configuration from $CONFIG_FILE"
+agent_log "warn" "High memory usage detected: ${MEMORY}MB"
+agent_log "error" "Connection failed: $ERROR_MSG"
+```
+
+### 2. Standalone Usage
+
+```bash
+# Direct command-line usage
+./.claude/skills/redis-coordination/agent-log.sh info "Agent initialized" \
+  --agent-id researcher-1 \
+  --task-id task-auth-123
+
+# From any script
+./.claude/skills/redis-coordination/agent-log.sh error "Validation failed" \
+  --agent-id reviewer-2 \
+  --task-id task-auth-123
+```
+
+### 3. Log Levels
+
+- **debug** - Detailed debugging information (cyan)
+- **info** - General informational messages (green)
+- **warn** - Warning messages (yellow)
+- **error** - Error conditions (red)
+
+## Output Destinations
+
+**1. Terminal (with colors)**
+```
+[INFO] [backend-dev-1] Starting authentication implementation
+[WARN] [backend-dev-1] Database connection slow
+[ERROR] [reviewer-1] JWT validation failed
+```
+
+**2. File (`/tmp/agent-<id>.log`)**
+```
+[2025-10-20T07:02:48Z] [INFO] [backend-dev-1] Starting authentication implementation
+[2025-10-20T07:02:48Z] [WARN] [backend-dev-1] Database connection slow
+[2025-10-20T07:02:48Z] [ERROR] [reviewer-1] JWT validation failed
+```
+
+**3. Redis (`swarm:<task-id>:logs`)**
+```json
+{
+  "level": "info",
+  "message": "Starting authentication implementation",
+  "agentId": "backend-dev-1",
+  "taskId": "task-auth-123",
+  "repository": "claude-flow-novice",
+  "timestamp": "2025-10-20T07:02:48Z"
+}
+```
+
+**4. Web Portal (http://localhost:3456 → Logs tab)**
+- Real-time streaming via WebSocket
+- Filter by repository, agent, or level
+- Shows last 1000 logs (100 displayed)
+- Auto-refreshes on new logs
+
+## Integration Points
+
+### Option 1: Source in Main Agent Script
+
+```bash
+# In your main agent script
+source .claude/skills/redis-coordination/agent-log.sh
+
+# Set global context once
+export AGENT_ID="${AGENT_TYPE}-${AGENT_NUM}"
+export TASK_ID="$TASK_ID"
+
+# Then log freely
+agent_log "info" "Agent spawned successfully"
+# ... agent work ...
+agent_log "info" "Task completed with confidence 0.95"
+```
+
+### Option 2: Wrap Agent Spawning
+
+```bash
+# In orchestrate-cfn-loop.sh or spawn-agent.sh
+./.claude/skills/redis-coordination/agent-log.sh info \
+  "Spawning agent: $AGENT_ID for task: $TASK_ID" \
+  --agent-id "$AGENT_ID" \
+  --task-id "$TASK_ID"
+
+# Spawn agent
+npx claude-flow-novice agent "$AGENT_TYPE" --task-id "$TASK_ID"
+
+# Log completion
+./.claude/skills/redis-coordination/agent-log.sh info \
+  "Agent $AGENT_ID completed" \
+  --agent-id "$AGENT_ID" \
+  --task-id "$TASK_ID"
+```
+
+### Option 3: Add to Existing Agent Logic
+
+If you have existing CLI agent code, wrap key operations:
+
+```bash
+# Before long operation
+agent_log "info" "Starting database migration"
+
+# During operation
+if [ "$ROWS_UPDATED" -gt 10000 ]; then
+  agent_log "warn" "Large migration in progress: $ROWS_UPDATED rows"
+fi
+
+# On error
+if ! run_migration; then
+  agent_log "error" "Migration failed: $ERROR"
+  exit 1
+fi
+
+# On success
+agent_log "info" "Migration completed: $ROWS_UPDATED rows updated"
+```
+
+## Advanced Options
+
+### Skip Terminal Output (Quiet Mode)
+
+```bash
+agent_log "info" "Background task started" --no-terminal
+```
+
+### Skip Redis Output (Local Only)
+
+```bash
+agent_log "debug" "Local debug info" --no-redis
+```
+
+### Manual Context Override
+
+```bash
+agent_log "error" "Connection timeout" \
+  --agent-id "custom-agent" \
+  --task-id "override-task-id"
+```
+
+## Portal Usage
+
+1. **Open portal:** http://localhost:3456
+2. **Go to Logs tab** (📝 Logs)
+3. **Filter logs:**
+   - Repository: Select specific repo or "All Repositories"
+   - Agent: Select specific agent or "All Agents"
+   - Level: debug/info/warn/error or "All Levels"
+4. **Clear logs:** Click "Clear Logs" button
+
+**Stats shown:**
+- Total logs in memory
+- Number of repositories logging
+- Number of active agents
+
+## Redis Keys
+
+**Pub/Sub Channel:**
+```
+swarm:<task-id>:logs
+```
+
+**Sorted Set (History):**
+```
+swarm:<task-id>:logs:history
+```
+- Score: Unix timestamp
+- Value: JSON log entry
+- TTL: 7 days (604800 seconds)
+
+## Examples
+
+### Example 1: CFN Loop Agent
+
+```bash
+#!/usr/bin/env bash
+source .claude/skills/redis-coordination/agent-log.sh
+
+AGENT_ID="coder-3"
+TASK_ID="$1"
+
+agent_log "info" "Starting Loop 3 implementation phase"
+
+# Implement feature
+agent_log "debug" "Reading specification from spec.md"
+agent_log "info" "Implementing authentication service"
+
+if ! run_tests; then
+  agent_log "error" "Tests failed - iteration needed"
+  exit 1
+fi
+
+agent_log "info" "Implementation complete - confidence: 0.88"
+```
+
+### Example 2: Orchestrator Logging
+
+```bash
+# In orchestrate-cfn-loop.sh
+agent_log "info" "CFN Loop started - mode: $MODE" \
+  --agent-id "orchestrator" \
+  --task-id "$TASK_ID"
+
+agent_log "info" "Spawning Loop 3 agents: $LOOP3_AGENTS" \
+  --agent-id "orchestrator" \
+  --task-id "$TASK_ID"
+
+# ... spawn agents ...
+
+agent_log "info" "Loop 3 consensus: $CONSENSUS (gate: $GATE_THRESHOLD)" \
+  --agent-id "orchestrator" \
+  --task-id "$TASK_ID"
+```
+
+## Troubleshooting
+
+**Logs not appearing in portal:**
+1. Check Redis connection: `redis-cli ping`
+2. Check portal subscription: Look for "✅ Subscribed to swarm:*:logs" in portal startup
+3. Verify task ID matches swarm task ID
+4. Check Redis pub/sub: `redis-cli psubscribe "swarm:*:logs"`
+
+**Colors not showing in terminal:**
+- WSL/Linux should show colors automatically
+- tmux: Colors should work by default
+- If colors missing, terminal may not support ANSI codes
+
+**Log file not created:**
+- Check permissions on `/tmp/`
+- Verify `AGENT_ID` is set (file named `/tmp/agent-${AGENT_ID}.log`)
+
+## Performance
+
+- **Minimal overhead:** ~5ms per log entry
+- **Non-blocking:** Redis operations use `> /dev/null 2>&1 || true`
+- **Memory efficient:** Portal keeps max 1000 logs, shows 100
+- **Auto-cleanup:** Redis history expires after 7 days
+
+## Migration from Old Logging
+
+**Before:**
+```bash
+echo "[INFO] Agent started"
+```
+
+**After:**
+```bash
+source .claude/skills/redis-coordination/agent-log.sh
+agent_log "info" "Agent started"
+```
+
+Benefits: Same terminal output + Redis pub/sub + portal visibility + file logging