claude-evolve 1.8.37 → 1.8.39

package/bin/claude-evolve-ideate

@@ -933,13 +933,18 @@ ideate_ai_strategies() {
   
   echo "[INFO] Strategy results: $strategies_succeeded/$strategies_attempted succeeded" >&2
 
-  # REQUIRE ALL strategies to succeed - no partial results
-  # Accepting partial results leads to endless loops with 1 idea per generation
-  if [[ $strategies_succeeded -eq $strategies_attempted ]]; then
+  # Accept partial results - if ANY strategy succeeded, that's enough
+  # The workers will process what we have, and next ideation run can add more
+  # AIDEV-NOTE: Previously required ALL strategies to succeed, which caused
+  # endless ideation loops because CSV writes weren't rolled back on "rejection"
+  if [[ $strategies_succeeded -gt 0 ]]; then
+    if [[ $strategies_succeeded -lt $strategies_attempted ]]; then
+      echo "[INFO] Partial success: $strategies_succeeded/$strategies_attempted strategies completed" >&2
+      echo "[INFO] Workers will process existing ideas, next ideation can add more" >&2
+    fi
     return 0
   else
-    echo "[ERROR] Not all ideation strategies succeeded ($strategies_succeeded/$strategies_attempted)" >&2
-    echo "[ERROR] Rejecting partial results - will retry with exponential backoff" >&2
+    echo "[ERROR] All ideation strategies failed (0/$strategies_attempted)" >&2
     return 1
   fi
 }
@@ -1662,6 +1667,18 @@ wait_seconds=300  # Start with 5 minutes
 max_wait_seconds=300  # Cap at 5 minutes
 
 while true; do
+  # AIDEV-NOTE: Check if we already have enough pending ideas for this generation
+  # This prevents endless ideation loops when partial results were written but
+  # the function returned failure (e.g., 2/4 strategies succeeded)
+  pending_count=$(grep -c "^gen${CURRENT_GENERATION}-.*,pending" "$FULL_CSV_PATH" 2>/dev/null || echo "0")
+  if [[ $pending_count -ge $TOTAL_IDEAS ]]; then
+    echo "[INFO] Already have $pending_count pending ideas for generation $CURRENT_GENERATION (target: $TOTAL_IDEAS)"
+    echo "[INFO] Skipping ideation - workers will process existing ideas"
+    exit 0
+  elif [[ $pending_count -gt 0 ]]; then
+    echo "[INFO] Found $pending_count existing pending ideas for generation $CURRENT_GENERATION (target: $TOTAL_IDEAS)"
+  fi
+
   if [[ $use_strategies == true ]]; then
     echo "[INFO] Multi-strategy AI generation mode"
     if ideate_ai_strategies; then

package/bin/claude-evolve-run

@@ -1,6 +1,8 @@
 #!/bin/bash
 
-set -e
+# AIDEV-NOTE: Don't use set -e globally - it causes silent exits on any command failure
+# Instead, handle errors explicitly where needed
+# set -e  # DISABLED - was causing silent dispatcher crashes
 
 # Load configuration  
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
@@ -579,8 +581,8 @@ last_stuck_check=0
 
 # Main dispatch loop
 while true; do
-  # Clean up finished workers
-  cleanup_workers
+  # Clean up finished workers (with error protection)
+  cleanup_workers || echo "[WARN] cleanup_workers had an error, continuing..." >&2
 
   # Check if API limit was reached
   if [[ "$api_limit_reached" == "true" ]]; then
@@ -631,8 +633,17 @@ except Exception as e:
     fi
   fi
 
-  # Get current status
-  csv_stats=$(get_csv_stats "$FULL_CSV_PATH")
+  # Get current status (with error handling to prevent silent crashes)
+  csv_stats=$(get_csv_stats "$FULL_CSV_PATH") || {
+    echo "[ERROR] Failed to get CSV stats, retrying in 5 seconds..." >&2
+    sleep 5
+    continue
+  }
+  if [[ -z "$csv_stats" ]]; then
+    echo "[ERROR] Empty CSV stats, retrying in 5 seconds..." >&2
+    sleep 5
+    continue
+  fi
   read -r total_rows complete_count pending_count <<< "$csv_stats"
   active_workers=${#worker_pids[@]}
   

package/bin/claude-evolve-worker

@@ -729,7 +729,8 @@ with EvolutionCSV('$FULL_CSV_PATH') as csv:
   
   if [[ $candidates_processed -ge $WORKER_MAX_CANDIDATES ]]; then
     echo "[WORKER-$$] Reached maximum candidates ($WORKER_MAX_CANDIDATES), exiting for refresh"
-    break
+    echo "[WORKER-$$] Worker exiting (will be restarted by dispatcher if running via 'claude-evolve run')"
+    exit 0
   fi
 done
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "claude-evolve",
-  "version": "1.8.37",
+  "version": "1.8.39",
   "bin": {
     "claude-evolve": "./bin/claude-evolve",
     "claude-evolve-main": "./bin/claude-evolve-main",