claude-dock 1.1.0 → 1.2.0

package/init.lua

@@ -13,7 +13,7 @@ local config = {
     addButtonWidth = 40,
     utilityButtonWidth = 28,
     initialSlots = 3,
-    elementsPerSlot = 4,  -- bg, border, title, status
+    elementsPerSlot = 5,  -- bg, border, title, status, notification badge
     baseElements = 6,     -- dock bg + border + help btn + help text + minimize btn + minimize text
     windowCaptureDelay = 0.3,
     windowCaptureRetries = 5,
@@ -32,7 +32,9 @@ local config = {
         minBtnText = { red = 0.6, green = 0.6, blue = 0.9, alpha = 1 },
         helpBtnBg = { red = 0.2, green = 0.18, blue = 0.12, alpha = 1 },
         helpBtnText = { red = 0.9, green = 0.8, blue = 0.5, alpha = 1 },
-    }
+        notificationBadge = { red = 1, green = 0.3, blue = 0.3, alpha = 1 },
+    },
+    notificationBadgeSize = 12,
 }
 
 -- State
@@ -100,7 +102,7 @@ cleanup()  -- Clean up any previous instance
 local function initSlots()
     for i = 1, slotCount do
         if not slots[i] then
-            slots[i] = { windowId = nil, customName = nil, pending = false }
+            slots[i] = { windowId = nil, customName = nil, pending = false, hasNotification = false }
         end
     end
 end
@@ -152,6 +154,33 @@ local function getWindowTitle(win)
     return title
 end
 
+-- Find slot index by window ID
+local function findSlotByWindowId(windowId)
+    if not windowId then return nil end
+    for i, slot in ipairs(slots) do
+        if slot.windowId == windowId then
+            return i
+        end
+    end
+    return nil
+end
+
+-- Set notification for a slot (only if window is not focused)
+local function setSlotNotification(slotIndex)
+    local slot = slots[slotIndex]
+    if not slot then return end
+
+    local win = getWindow(slot.windowId)
+    if win then
+        local focusedWin = hs.window.focusedWindow()
+        -- Only show notification if window is not currently focused
+        if not focusedWin or focusedWin:id() ~= slot.windowId then
+            slot.hasNotification = true
+            updateSlotDisplay(slotIndex)
+        end
+    end
+end
+
 -- Tooltip helpers
 local function showTooltipAt(text, x, y)
     if tooltip then tooltip:delete() end
@@ -358,16 +387,19 @@ local function updateSlotDisplay(slotIndex)
             status = "active"
             bgColor = config.colors.slotActive
         end
+    elseif slot.windowId then
+        -- Window exists but not visible (probably on another space)
+        title = slot.customName or "Terminal"
+        status = "(other space)"
+        bgColor = config.colors.slotMinimized
     else
-        -- Don't clear customName if we're waiting for a window to spawn
-        if not slot.pending then
-            slot.windowId = nil
-            slot.customName = nil
-            title = "Empty"
-            status = "click to open"
-        else
+        -- No window assigned
+        if slot.pending then
             title = slot.customName or "Opening..."
             status = "launching"
+        else
+            title = "Empty"
+            status = "click to open"
         end
         bgColor = config.colors.slotEmpty
     end
@@ -381,6 +413,12 @@ local function updateSlotDisplay(slotIndex)
     if dock[baseIdx + 3] then
         dock[baseIdx + 3].text = status
     end
+    -- Update notification badge visibility
+    if dock[baseIdx + 4] then
+        dock[baseIdx + 4].fillColor = slot.hasNotification
+            and config.colors.notificationBadge
+            or { red = 0, green = 0, blue = 0, alpha = 0 }
+    end
 end
 
 updateAllSlots = function()
@@ -454,6 +492,9 @@ local function onSlotClick(slotIndex, isOptionClick)
         return
     end
 
+    -- Clear notification when clicked
+    slot.hasNotification = false
+
     local win = getWindow(slot.windowId)
     if win then
         if win:isMinimized() then
@@ -491,7 +532,7 @@ end
 -- Add a new slot and launch terminal
 local function addSlot()
     slotCount = slotCount + 1
-    slots[slotCount] = { windowId = nil, customName = nil, pending = false }
+    slots[slotCount] = { windowId = nil, customName = nil, pending = false, hasNotification = false }
 
     if dock then
         dock:delete()
@@ -625,6 +666,16 @@ createDock = function()
             textSize = 10,
             textFont = ".AppleSystemUIFont",
         })
+
+        -- Notification badge (top-right corner of slot, overlapping edge like app badges)
+        local badgeSize = config.notificationBadgeSize
+        dock:appendElements({
+            type = "circle",
+            action = "fill",
+            center = { x = slotX + config.slotWidth - badgeSize/3, y = config.margin + badgeSize/3 },
+            radius = badgeSize / 2,
+            fillColor = { red = 0, green = 0, blue = 0, alpha = 0 },  -- Hidden by default
+        })
     end
 
     -- Add button (right side)
@@ -710,12 +761,64 @@ end
 -- Window event watcher for immediate updates
 windowFilter = hs.window.filter.new("Terminal")
 windowFilter:subscribe({
-    hs.window.filter.windowDestroyed,
     hs.window.filter.windowMinimized,
     hs.window.filter.windowUnminimized,
-    hs.window.filter.windowFocused,
 }, updateAllSlots)
 
+-- Handle window destruction - clear the slot
+windowFilter:subscribe(hs.window.filter.windowDestroyed, function(win, appName, event)
+    -- win may be nil at this point, so we need to check all slots
+    for i, slot in ipairs(slots) do
+        if slot.windowId then
+            local existingWin = getWindow(slot.windowId)
+            if not existingWin then
+                -- Try to verify window is truly gone (not just on another space)
+                -- by checking all Terminal windows
+                local allTerminals = hs.window.filter.new("Terminal"):getWindows()
+                local found = false
+                for _, w in ipairs(allTerminals) do
+                    if w:id() == slot.windowId then
+                        found = true
+                        break
+                    end
+                end
+                if not found then
+                    slot.windowId = nil
+                    slot.customName = nil
+                    slot.hasNotification = false
+                end
+            end
+        end
+    end
+    updateAllSlots()
+end)
+
+-- Clear notification when window is focused
+windowFilter:subscribe(hs.window.filter.windowFocused, function(win)
+    if win then
+        local slotIndex = findSlotByWindowId(win:id())
+        if slotIndex then
+            slots[slotIndex].hasNotification = false
+        end
+    end
+    updateAllSlots()
+end)
+
+-- Watch for window title changes (indicates terminal activity)
+windowFilter:subscribe(hs.window.filter.windowTitleChanged, function(win)
+    if win then
+        local slotIndex = findSlotByWindowId(win:id())
+        if slotIndex then
+            local focusedWin = hs.window.focusedWindow()
+            -- Only show notification if this window isn't focused
+            if not focusedWin or focusedWin:id() ~= win:id() then
+                slots[slotIndex].hasNotification = true
+                updateSlotDisplay(slotIndex)
+            end
+        end
+    end
+end)
+
 -- Periodic refresh as fallback
 updateTimer = hs.timer.doEvery(2, function()
     if dock and dock:isShowing() then
@@ -798,6 +901,26 @@ if showRepositionedMsg then
     end)
 end
 
+-- Global function to trigger notification on a slot (for testing or external use)
+-- Usage: triggerNotification(1) to trigger on slot 1
+function triggerNotification(slotIndex)
+    if slotIndex and slots[slotIndex] then
+        setSlotNotification(slotIndex)
+        return true
+    end
+    return false
+end
+
+-- Global function to clear notification on a slot
+function clearNotification(slotIndex)
+    if slotIndex and slots[slotIndex] then
+        slots[slotIndex].hasNotification = false
+        updateSlotDisplay(slotIndex)
+        return true
+    end
+    return false
+end
+
 -- ===================
 -- TESTS (run with: hs -c "runTests()")
 -- ===================
@@ -974,6 +1097,44 @@ function runTests()
         assert(type(hideHelpPanel) == "function", "hideHelpPanel should be a function")
     end)
 
+    -- Notification badge tests
+    test("config has notification badge color", function()
+        assert(config.colors.notificationBadge, "notificationBadge color should exist")
+        assert(config.notificationBadgeSize, "notificationBadgeSize should exist")
+    end)
+
+    test("slots have hasNotification field", function()
+        slots = {}
+        slotCount = 2
+        initSlots()
+        assert(slots[1].hasNotification == false, "slot should have hasNotification = false")
+        restore()
+    end)
+
+    test("findSlotByWindowId returns nil for unknown window", function()
+        assertEqual(findSlotByWindowId(999999999), nil)
+    end)
+
+    test("findSlotByWindowId returns nil for nil input", function()
+        assertEqual(findSlotByWindowId(nil), nil)
+    end)
+
+    test("triggerNotification is a function", function()
+        assert(type(triggerNotification) == "function", "triggerNotification should be a function")
+    end)
+
+    test("clearNotification is a function", function()
+        assert(type(clearNotification) == "function", "clearNotification should be a function")
+    end)
+
+    test("triggerNotification returns false for invalid slot", function()
+        assertEqual(triggerNotification(9999), false)
+    end)
+
+    test("clearNotification returns false for invalid slot", function()
+        assertEqual(clearNotification(9999), false)
+    end)
+
     print("\n=== Results: " .. passed .. " passed, " .. failed .. " failed ===\n")
     return failed == 0
 end

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "claude-dock",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "description": "A lightweight terminal dock for macOS to manage Claude Code sessions",
   "bin": {
     "claude-dock": "bin/cli.js"