claude-dev-env 8.92.3 → 8.93.0

package/hooks/blocking/reply_length_gate.py

@@ -77,9 +77,11 @@ later pass, so this gate denies it and the model resends a shorter one.
 
 from __future__ import annotations
 
+import itertools
 import json
 import os
 import re
+import shlex
 import sys
 from pathlib import Path
 
@@ -87,6 +89,7 @@ hooks_root_directory = str(Path(__file__).resolve().parent.parent)
 if hooks_root_directory not in sys.path:
     sys.path.insert(0, hooks_root_directory)
 
+from gh_post_body_texts import extract_mcp_body_texts
 from json_file_reader import read_json_object
 from visual_reply_rules import (
     VisualReplyRules,
@@ -106,6 +109,17 @@ from hooks_constants.hook_specific_output_keys import (
     HOOK_SPECIFIC_OUTPUT_KEY,
 )
 from hooks_constants.reply_length_gate_constants import (
+    ALL_CHECKED_MCP_TOOL_NAMES,
+    BASH_TOOL_NAME,
+    COMMAND_KEY,
+    COMMENT_RETRY_INSTRUCTION,
+    DETAILS_BLOCK_PATTERN,
+    ALL_GH_BODY_FLAGS,
+    ALL_GH_COMMENT_ACTIONS,
+    ALL_GH_COMMENT_GROUPS,
+    GH_BODY_FLAG_PREFIX,
+    GH_PROGRAM_NAME,
+    SHELL_OPERATOR_CHARACTERS,
     ALL_CHECKED_TOOL_NAMES,
     ALL_DECISION_CARD_LENGTH_KEYS,
     ALL_DECISION_CARD_PROSE_KEYS,
@@ -482,6 +496,81 @@ def tool_violation(
     return None if violation is None else (violation, reply_text)
 
 
+def github_comment_texts(tool_name: object, all_tool_input: dict[str, object]) -> list[str]:
+    """Return the GitHub comment texts one call would post, or an empty list.
+
+    ::
+
+        mcp__github__add_issue_comment {"body": "Done."}  -> ["Done."]
+        Bash 'gh pr comment 12 --body "Done."'            -> ["Done."]
+        Bash 'git push && gh pr comment 12 --body "Done."' -> ["Done."]
+        Bash 'gh pr create --body "Long body"'            -> []
+    """
+    if tool_name in ALL_CHECKED_MCP_TOOL_NAMES:
+        return extract_mcp_body_texts(all_tool_input)
+    command = all_tool_input.get(COMMAND_KEY)
+    if tool_name != BASH_TOOL_NAME or not isinstance(command, str):
+        return []
+    try:
+        command_lexer = shlex.shlex(command, posix=True, punctuation_chars=True)
+        command_lexer.whitespace_split = True
+        all_command_tokens = list(command_lexer)
+    except ValueError:
+        return []
+    return gh_comment_bodies(all_command_tokens)
+
+
+def gh_comment_bodies(all_command_tokens: list[str]) -> list[str]:
+    """Return the ``--body`` values of each ``gh pr|issue comment|review`` call in the tokens.
+
+    ::
+
+        git push && gh -R o/r pr comment 12 --body "Done."  -> ["Done."]
+        gh pr create --body "Long body"                     -> []
+    """
+    all_bodies: list[str] = []
+    for each_command_tokens in gh_command_token_runs(all_command_tokens):
+        all_pairs = list(itertools.pairwise(each_command_tokens))
+        if not any(
+            each_group in ALL_GH_COMMENT_GROUPS and each_action in ALL_GH_COMMENT_ACTIONS
+            for each_group, each_action in all_pairs
+        ):
+            continue
+        all_bodies.extend(
+            each_token[len(GH_BODY_FLAG_PREFIX):]
+            for each_token in each_command_tokens
+            if each_token.startswith(GH_BODY_FLAG_PREFIX)
+        )
+        all_bodies.extend(each_value for each_flag, each_value in all_pairs if each_flag in ALL_GH_BODY_FLAGS)
+    return all_bodies
+
+
+def is_command_token(token: str) -> bool:
+    """Return True when the token is part of a command, False for ``&&``, ``||``, ``;`` or ``|``."""
+    return not set(token) <= SHELL_OPERATOR_CHARACTERS
+
+
+def gh_command_token_runs(all_command_tokens: list[str]) -> list[list[str]]:
+    """Return the tokens after each ``gh`` token, up to the next shell operator."""
+    all_runs: list[list[str]] = []
+    for each_index, each_token in enumerate(all_command_tokens):
+        if each_token == GH_PROGRAM_NAME:
+            all_runs.append(list(itertools.takewhile(is_command_token, all_command_tokens[each_index + 1:])))
+    return all_runs
+
+
+def github_comment_violation(tool_name: object, all_tool_input: dict[str, object]) -> tuple[str, str] | None:
+    """Return the deny reason and text for an over-long GitHub comment, or None.
+
+    Fenced code blocks and collapsed ``<details>`` blocks carry no words.
+    """
+    for each_comment_text in github_comment_texts(tool_name, all_tool_input):
+        violation = length_violation(DETAILS_BLOCK_PATTERN.sub(" ", each_comment_text))
+        if violation is not None:
+            return violation + COMMENT_RETRY_INSTRUCTION, each_comment_text
+    return None
+
+
 def write_flowchart_advice(tool_name: object, all_tool_input: dict[str, object]) -> None:
     """Print the flowchart advice for an allowed widget call that is not a flowchart."""
     mode_rules = active_mode_rules()
@@ -502,7 +591,9 @@ def main() -> int:
     tool_input = hook_input.get(TOOL_INPUT_KEY)
     if not isinstance(tool_input, dict):
         return ALLOW_EXIT_CODE
-    checked = tool_violation(tool_name, tool_input, hook_input.get(TRANSCRIPT_PATH_KEY))
+    checked = github_comment_violation(tool_name, tool_input) or tool_violation(
+        tool_name, tool_input, hook_input.get(TRANSCRIPT_PATH_KEY)
+    )
     if checked is None:
         write_flowchart_advice(tool_name, tool_input)
         return ALLOW_EXIT_CODE

package/hooks/blocking/test_reply_length_gate.py

@@ -1022,3 +1022,46 @@ def test_should_leave_the_transcript_unread_when_the_text_cites_nothing(
 def test_should_split_prose_sentences_outside_fenced_blocks() -> None:
     reply_text = "First one. Second one?\n```\nskipped. code\n```\nThird"
     assert reply_length_gate.prose_sentences(reply_text) == ["First one.", "Second one?", "", "Third"]
+
+
+LONG_GITHUB_COMMENT = " ".join(
+    "Sentence number one of a long comment that keeps going." for _ in range(50)
+)
+SHORT_GITHUB_COMMENT = "Fixed the cap check. The test now covers it. Checks pass."
+
+
+def test_should_deny_long_github_comment(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+) -> None:
+    exit_code, error_text = run_gate(
+        monkeypatch, capsys, "mcp__github__add_issue_comment", {"body": LONG_GITHUB_COMMENT}
+    )
+    assert exit_code == 2
+    assert "50 sentences, limit 3" in error_text
+
+
+def test_should_allow_short_github_comment_with_code_and_details(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+) -> None:
+    comment_text = (
+        SHORT_GITHUB_COMMENT
+        + "\n```\n" + LONG_GITHUB_COMMENT + "\n```\n"
+        + "<details><summary>Log</summary>\n" + LONG_GITHUB_COMMENT + "\n</details>"
+    )
+    exit_code, error_text = run_gate(
+        monkeypatch, capsys, "mcp__github__add_issue_comment", {"body": comment_text}
+    )
+    assert (exit_code, error_text) == (0, "")
+
+
+def test_should_read_gh_comment_body_and_skip_pr_create() -> None:
+    comment_command = f'gh pr comment 12 --body "{LONG_GITHUB_COMMENT}"'
+    create_command = f'gh pr create --body "Run gh pr comment 12 to reply. {LONG_GITHUB_COMMENT}"'
+    assert reply_length_gate.github_comment_texts("Bash", {"command": comment_command}) == [LONG_GITHUB_COMMENT]
+    assert reply_length_gate.github_comment_texts("Bash", {"command": create_command}) == []
+    multiline_command = 'gh pr comment 12 --body "' + LONG_GITHUB_COMMENT.replace(". ", ".\n") + '"'
+    assert len(reply_length_gate.github_comment_texts("Bash", {"command": multiline_command})) == 1
+    flagged_command = f'git push\ngh -R o/r pr comment 12 --body "note=x. {LONG_GITHUB_COMMENT}"'
+    assert reply_length_gate.github_comment_texts("Bash", {"command": flagged_command}) == [f"note=x. {LONG_GITHUB_COMMENT}"]
+    chained_command = f"git push && {comment_command}"
+    assert reply_length_gate.github_comment_texts("Bash", {"command": chained_command}) == [LONG_GITHUB_COMMENT]

package/hooks/hooks.json

@@ -273,6 +273,16 @@
             "timeout": 15
           }
         ]
+      },
+      {
+        "matcher": "Bash|mcp__github__add_issue_comment|mcp__github__update_issue_comment|mcp__github__add_reply_to_pull_request_comment|mcp__github__add_comment_to_pending_review|mcp__github__pull_request_review_write",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/blocking/reply_length_gate.py",
+            "timeout": 10
+          }
+        ]
       }
     ],
     "UserPromptSubmit": [

package/hooks/hooks_constants/reply_length_gate_constants.py

@@ -159,3 +159,25 @@ UNSEEN_CITATION_MESSAGE = (
 )
 
 ADDITIONAL_CONTEXT_KEY = "additionalContext"
+ALL_CHECKED_MCP_TOOL_NAMES = frozenset(
+    {
+        "mcp__github__add_issue_comment",
+        "mcp__github__update_issue_comment",
+        "mcp__github__add_reply_to_pull_request_comment",
+        "mcp__github__add_comment_to_pending_review",
+        "mcp__github__pull_request_review_write",
+    }
+)
+BASH_TOOL_NAME = "Bash"
+COMMAND_KEY = "command"
+SHELL_OPERATOR_CHARACTERS = frozenset("&|;")
+GH_PROGRAM_NAME = "gh"
+ALL_GH_COMMENT_GROUPS = frozenset({"pr", "issue"})
+ALL_GH_COMMENT_ACTIONS = frozenset({"comment", "review"})
+ALL_GH_BODY_FLAGS = frozenset({"--body", "-b"})
+GH_BODY_FLAG_PREFIX = "--body="
+DETAILS_BLOCK_PATTERN = re.compile(r"<details\b.*?</details>", re.IGNORECASE | re.DOTALL)
+COMMENT_RETRY_INSTRUCTION = (
+    " A comment on GitHub holds at most three short sentences."
+    " Put detail in the pull request body, a code block, or a collapsed <details> block, then post again."
+)

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.92.3",
+    "version": "8.93.0",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {