claude-dev-env 8.9.0 → 8.11.0

package/scripts/tests/test_policy_lint_rules_check_catalog.py

@@ -10,7 +10,7 @@ from __future__ import annotations
 from pathlib import Path
 
 import pytest
-from policy_lint.check_catalog import check_id_for_message
+from policy_lint.check_catalog import check_id_for_message, severity_for_check_id
 from policy_lint.config.check_catalog_constants import (
     ALL_CHECK_CATALOG_ENTRIES,
     UNCLASSIFIED_CHECK_NAME,
@@ -71,6 +71,17 @@ ALL_MESSAGE_SAMPLES: tuple[tuple[str, str], ...] = (
         "missing-return-annotation",
     ),
     ("src/app.py:3: Single-letter variable 'p'", "single-letter-variable"),
+    (
+        "Line 45: public function 'run' is exercised by no test in the module's"
+        " paired test suite, though that suite already exercises this module",
+        "paired-test-missing-function",
+    ),
+    (
+        "app.py public function 'run' is a public function this stem-matched test"
+        " suite defines its module for but exercises nowhere, though the suite"
+        " already covers another public function in that module",
+        "paired-test-omitted-function",
+    ),
 )
 
 
@@ -149,3 +160,16 @@ def test_a_diagnostic_reports_the_check_identifier_it_carries() -> None:
     )
 
     assert diagnostic.as_dict()["check_id"] == "code-rules/constant-outside-config"
+
+
+@pytest.mark.parametrize(
+    "check_name", ("paired-test-missing-function", "paired-test-omitted-function")
+)
+def test_a_paired_test_check_reports_as_a_warning(check_name: str) -> None:
+    assert severity_for_check_id(f"{_BUNDLING_RULE_ID}/{check_name}") is Severity.WARNING
+
+
+def test_an_unclassified_check_reports_as_an_error() -> None:
+    unclassified_check_id = f"{_BUNDLING_RULE_ID}/{UNCLASSIFIED_CHECK_NAME}"
+
+    assert severity_for_check_id(unclassified_check_id) is Severity.ERROR

package/scripts/tests/test_policy_lint_rules_pairing.py

@@ -14,6 +14,7 @@ from policy_lint.model import (
     Document,
     DocumentSet,
     SelectionKind,
+    Severity,
 )
 
 _MODULE_DOCSTRING_BEFORE = '''"""Before."""
@@ -117,6 +118,17 @@ def test_pairing_requires_a_test_for_python_body_changes(tmp_path: Path) -> None
     assert len(all_diagnostics) == 1
 
 
+def test_pairing_reports_an_unpaired_change_as_a_recorded_warning(
+    tmp_path: Path,
+) -> None:
+    all_diagnostics = _pairing_diagnostics(
+        tmp_path,
+        _changed_document(_BODY_AFTER, _BODY_BEFORE),
+    )
+    assert [each.severity for each in all_diagnostics] == [Severity.WARNING]
+    assert all_diagnostics[0].check_id == "test-pairing"
+
+
 def test_pairing_rejects_python_syntax_errors_without_a_test(tmp_path: Path) -> None:
     all_diagnostics = _pairing_diagnostics(
         tmp_path,
@@ -186,10 +198,10 @@ def test_cursor_verifier_constants_require_the_changed_driver_suite(
     tmp_path: Path,
 ) -> None:
     constants_path = PurePosixPath(
-        ".cursor/skills/verify-claude-dev-env/scripts/verify_installer_constants/constants.mjs"
+        ".agents/skills/verify/scripts/verify_installer_constants/constants.mjs"
     )
     suite_path = PurePosixPath(
-        ".cursor/skills/verify-claude-dev-env/scripts/verify-installer.test.mjs"
+        ".agents/skills/verify/scripts/verify-installer.test.mjs"
     )
     constants_change = _body_change_at(constants_path)
     assert _diagnostic_paths(tmp_path, constants_change) == (constants_path,)
@@ -528,6 +540,23 @@ def test_pairing_accepts_installer_modules_with_the_cursor_rules_suite(
     assert all_paths == ()
 
 
+_INSTALLER_MODULE_PATH = PurePosixPath("packages/claude-dev-env/bin/install.mjs")
+_AGENTS_HOME_SUITE_PATH = PurePosixPath(
+    "packages/claude-dev-env/bin/install.agents-home.test.mjs"
+)
+
+
+def test_pairing_accepts_installer_module_with_the_agents_home_suite(
+    tmp_path: Path,
+) -> None:
+    all_paths = _diagnostic_paths(
+        tmp_path,
+        _body_change_at(_INSTALLER_MODULE_PATH),
+        _body_change_at(_AGENTS_HOME_SUITE_PATH),
+    )
+    assert all_paths == ()
+
+
 _COMMENT_RULES_PRODUCTION_PATH = PurePosixPath(
     "packages/claude-dev-env/hooks/blocking/code_rules_comments.py"
 )

package/scripts/tests/test_policy_lint_selection.py

@@ -285,6 +285,41 @@ def test_base_source_should_compare_merge_base_and_read_worktree_bytes(
     assert selected_document.origin == ContentOrigin.REVISION_DIFF
 
 
+def test_base_file_that_was_a_directory_at_base_should_have_no_prior_text(
+    tmp_path: Path,
+) -> None:
+    repository_root = _initialize_repository(tmp_path)
+    _commit_text(repository_root, "skills/verify/notes.md", "base-text\n")
+    _run_git(repository_root, "checkout", "--quiet", "-b", "feature")
+    _run_git(repository_root, "rm", "--quiet", "-r", "--", "skills")
+    _commit_text(repository_root, "skills", "../shared/skills\n")
+
+    document_set = select_documents(LintRequest.base(repository_root, "main"))
+    selected_document = _document_for(document_set, "skills")
+
+    assert selected_document.text == "../shared/skills\n"
+    assert selected_document.prior_text is None
+
+
+def test_base_directory_pointer_should_be_left_out_of_the_selection(
+    tmp_path: Path,
+) -> None:
+    repository_root = _initialize_repository(tmp_path)
+    _commit_text(repository_root, "shared/skills/verify/notes.md", "base-text\n")
+    _run_git(repository_root, "checkout", "--quiet", "-b", "feature")
+    try:
+        os.symlink("shared/skills", repository_root / "skills", target_is_directory=True)
+    except OSError as error:
+        pytest.skip(f"this host cannot create a directory pointer: {error}")
+    _run_git(repository_root, "add", "--", "skills")
+    _run_git(repository_root, "commit", "--quiet", "-m", "selection pointer fixture")
+
+    document_set = select_documents(LintRequest.base(repository_root, "main"))
+
+    assert "skills" not in _all_selected_paths(document_set)
+    assert "shared/skills" not in _all_selected_paths(document_set)
+
+
 def test_base_selection_records_merge_base_revision_and_staged_does_not(
     tmp_path: Path,
 ) -> None:

package/hooks/blocking/tdd_enforcer.py

@@ -1,195 +0,0 @@
-"""BDD Automate-phase gate (production code touch).
-
-Blocks a write to a production source file when no matching test was modified
-within the freshness window, enforcing "TDD IS NON-NEGOTIABLE" from CLAUDE.md.
-The gate records each candidate test's content hash at every sighting and
-compares that hash on the next write. A first sighting requires content that
-differs from HEAD. A stored failing pytest run is read before that fallback
-and applies while the candidate's content still matches the stored hash.
-Each concern lives in a ``tdd_enforcer_parts`` submodule; this entry wires them
-into one PreToolUse gate and re-exports their surface for the test suite.
-"""
-
-import json
-import sys
-from pathlib import Path
-
-try:
-    _hooks_root_directory = str(Path(__file__).resolve().parent.parent)
-    _blocking_directory = str(Path(__file__).resolve().parent)
-    for each_bootstrap_directory in (_hooks_root_directory, _blocking_directory):
-        if each_bootstrap_directory not in sys.path:
-            sys.path.insert(0, each_bootstrap_directory)
-    from code_rules_shared import (
-        is_agent_home_tooling,
-        is_ephemeral_script_path,
-        is_under_session_scratchpad,
-    )
-    from codex_apply_patch import (
-        payload_patch_target_paths,
-    )
-    from hooks_constants.pre_tool_use_dispatcher_constants import APPLY_PATCH_TOOL_NAME
-    from tdd_enforcer_parts import (
-        candidate_paths,
-        content_analysis,
-        content_hash_store,
-        decisions,
-        freshness,
-        git_tracking,
-        path_classification,
-    )
-    from tdd_enforcer_parts.config.tdd_enforcer_constants import PYTHON_SOURCE_EXTENSION
-except ImportError as import_error:
-    raise ImportError(
-        "tdd_enforcer: cannot import its tdd_enforcer_parts submodules; "
-        "ensure the hooks directory is importable."
-    ) from import_error
-
-
-def _is_session_scratchpad_write(file_path: str, input_data: dict) -> bool:
-    return is_under_session_scratchpad(file_path, input_data)
-
-
-def _is_agent_home_tooling_write(file_path: str) -> bool:
-    """A coding agent's own home-directory tooling is outside the TDD gate."""
-    return is_agent_home_tooling(file_path)
-
-
-production_extensions = path_classification.production_extensions
-skip_extensions = path_classification.skip_extensions
-_is_inside_dotclaude_segment = path_classification._is_inside_dotclaude_segment
-_directory_skip_components = path_classification._directory_skip_components
-_matches_any_skip_pattern = path_classification._matches_any_skip_pattern
-_extract_written_content = path_classification._extract_written_content
-candidate_test_paths_for = candidate_paths.candidate_test_paths_for
-_ancestor_tests_directories = candidate_paths._ancestor_tests_directories
-_parent_walk_limit = candidate_paths._parent_walk_limit
-_freshness_seconds = freshness._freshness_seconds
-_read_candidate_text = freshness._read_candidate_text
-has_recorded_or_fresh_test = content_hash_store.has_recorded_or_fresh_test
-_is_constants_only_python_content = content_analysis._is_constants_only_python_content
-_is_post_edit_import_only = content_analysis._is_post_edit_import_only
-_is_post_edit_constants_only = content_analysis._is_post_edit_constants_only
-is_absent_but_tracked = git_tracking.is_absent_but_tracked
-build_deny_reason = decisions.build_deny_reason
-emit_allow = decisions.emit_allow
-emit_deny = decisions.emit_deny
-
-
-def _resolve_payload(input_data: dict) -> tuple[str, dict, str]:
-    tool_input = input_data.get("tool_input", {})
-    return input_data.get("tool_name", ""), tool_input, tool_input.get("file_path", "")
-
-
-def _is_silently_skipped(
-    file_path: str, extension: str, path: Path, repository_root: str = ""
-) -> bool:
-    if _is_inside_dotclaude_segment(file_path) or is_ephemeral_script_path(
-        file_path, repository_root
-    ):
-        return True
-    if _is_agent_home_tooling_write(file_path):
-        return True
-    if extension in skip_extensions():
-        return True
-    if extension not in production_extensions():
-        return True
-    path_with_forward_slashes = str(path).lower().replace("\\", "/")
-    return _matches_any_skip_pattern(path.name.lower(), path_with_forward_slashes)
-
-
-def _edit_is_constants_or_import_only(
-    tool_name: str, tool_input: dict, path: Path, extension: str
-) -> bool:
-    if (
-        tool_name not in ("Edit", "MultiEdit")
-        or extension != PYTHON_SOURCE_EXTENSION
-        or not path.exists()
-    ):
-        return False
-    existing_content = _read_candidate_text(path)
-    if existing_content is None:
-        return False
-    if _is_post_edit_import_only(existing_content, tool_name, tool_input):
-        return True
-    return _is_post_edit_constants_only(existing_content, tool_name, tool_input)
-
-
-def _write_is_exempt(
-    tool_name: str, tool_input: dict, path: Path, extension: str
-) -> bool:
-    if is_absent_but_tracked(path):
-        return True
-    written_content = _extract_written_content(tool_name, tool_input)
-    if (
-        tool_name == "Write"
-        and extension == PYTHON_SOURCE_EXTENSION
-        and _is_constants_only_python_content(written_content)
-    ):
-        return True
-    return _edit_is_constants_or_import_only(tool_name, tool_input, path, extension)
-
-
-def _decide_for_target(
-    tool_name: str, tool_input: dict, file_path: str, input_data: dict
-) -> tuple[bool, str] | None:
-    """Return (is_allowed, deny_reason) for one target file, or None to skip silently."""
-    if not file_path:
-        return None
-    if _is_session_scratchpad_write(file_path, input_data):
-        return None
-    path = Path(file_path)
-    extension = path.suffix.lower()
-    repository_root = str(input_data.get("cwd") or "")
-    if _is_silently_skipped(file_path, extension, path, repository_root):
-        return None
-    if _write_is_exempt(tool_name, tool_input, path, extension):
-        return True, ""
-    all_candidates = candidate_test_paths_for(path)
-    session_id = str(input_data.get("session_id") or "")
-    is_recorded_or_fresh = has_recorded_or_fresh_test(
-        all_candidates, session_id, repository_root, _freshness_seconds()
-    )
-    if is_recorded_or_fresh:
-        return True, ""
-    return False, build_deny_reason(path, all_candidates)
-
-
-def _decide_apply_patch(input_data: dict, tool_input: dict) -> None:
-    """Run the TDD gate over every file a Codex apply_patch payload touches."""
-    for each_file_path in payload_patch_target_paths(input_data, tool_input):
-        decision = _decide_for_target(
-            APPLY_PATCH_TOOL_NAME, tool_input, each_file_path, input_data
-        )
-        if decision is None:
-            continue
-        is_allowed, deny_reason = decision
-        if not is_allowed:
-            emit_deny(deny_reason)
-            return
-    emit_allow()
-
-
-def main() -> None:
-    """Run the TDD gate over one PreToolUse Write, Edit, MultiEdit, or apply_patch payload."""
-    try:
-        input_data = json.load(sys.stdin)
-    except json.JSONDecodeError:
-        sys.exit(0)
-    tool_name, tool_input, file_path = _resolve_payload(input_data)
-    if tool_name == APPLY_PATCH_TOOL_NAME:
-        _decide_apply_patch(input_data, tool_input)
-        sys.exit(0)
-    decision = _decide_for_target(tool_name, tool_input, file_path, input_data)
-    if decision is None:
-        sys.exit(0)
-    is_allowed, deny_reason = decision
-    if is_allowed:
-        emit_allow()
-        sys.exit(0)
-    emit_deny(deny_reason)
-    sys.exit(0)
-
-
-if __name__ == "__main__":
-    main()

package/hooks/blocking/tdd_enforcer_parts/candidate_paths.py

@@ -1,142 +0,0 @@
-"""Resolve the test files whose freshness can satisfy the gate for a module.
-
-Given a production file, builds every path a matching test could live at: the
-flat sibling ``test_<stem>.py``, the package-mirroring candidates under an
-ancestor ``tests`` directory, and the split test family for ``code_rules_*``
-modules.
-"""
-
-from pathlib import Path
-
-from tdd_enforcer_parts.config.tdd_enforcer_constants import (
-    ALL_JAVASCRIPT_TEST_EXTENSIONS,
-    ALL_REPO_BOUNDARY_SENTINELS,
-    PARENT_WALK_LIMIT,
-    PYTHON_SOURCE_EXTENSION,
-)
-
-
-def _tests_directory_name() -> str:
-    return "tests"
-
-
-def _parent_walk_limit() -> int:
-    return PARENT_WALK_LIMIT
-
-
-def _repo_boundary_sentinels() -> frozenset[str]:
-    return ALL_REPO_BOUNDARY_SENTINELS
-
-
-def _split_module_stem_prefix() -> str:
-    return "code_rules_"
-
-
-def _split_test_family_glob() -> str:
-    return "test_code_rules_enforcer_*.py"
-
-
-def _javascript_test_extensions() -> frozenset[str]:
-    return ALL_JAVASCRIPT_TEST_EXTENSIONS
-
-
-def _is_repo_boundary(candidate_directory: Path) -> bool:
-    for each_sentinel in _repo_boundary_sentinels():
-        if (candidate_directory / each_sentinel).exists():
-            return True
-    return False
-
-
-def _ancestor_tests_directories(start_directory: Path) -> list[tuple[Path, Path]]:
-    """Collect each ancestor's sibling ``tests`` directory up to the repo root.
-
-    Args:
-        start_directory: Directory of the production file under edit.
-
-    Returns:
-        Ordered ``(ancestor, tests_directory)`` pairs, nearer ancestors first.
-    """
-    all_pairs: list[tuple[Path, Path]] = []
-    current_directory = start_directory
-    remaining_steps = _parent_walk_limit()
-    while remaining_steps > 0:
-        remaining_steps -= 1
-        sibling_tests = current_directory / _tests_directory_name()
-        if sibling_tests.is_dir():
-            all_pairs.append((current_directory, sibling_tests))
-        if _is_repo_boundary(current_directory):
-            break
-        if current_directory.parent == current_directory:
-            break
-        current_directory = current_directory.parent
-    return all_pairs
-
-
-def _split_family_candidates(directory: Path, stem: str) -> list[Path]:
-    if not stem.startswith(_split_module_stem_prefix()):
-        return []
-    return sorted(directory.glob(_split_test_family_glob()))
-
-
-def _flat_stem_candidates(directory: Path, stem: str) -> list[Path]:
-    return [directory / f"test_{stem}.py", directory / f"{stem}_test.py"]
-
-
-def _mirrored_nested_candidates(
-    directory: Path, ancestor: Path, tests_directory: Path, stem: str
-) -> list[Path]:
-    all_candidates: list[Path] = []
-    nested_directory = tests_directory
-    for each_relative_part in directory.relative_to(ancestor).parts:
-        nested_directory = nested_directory / each_relative_part
-        all_candidates.append(nested_directory / f"test_{stem}.py")
-    return all_candidates
-
-
-def _nested_tests_candidates(directory: Path, stem: str) -> list[Path]:
-    all_candidates: list[Path] = []
-    for each_ancestor, each_tests_directory in _ancestor_tests_directories(directory):
-        all_candidates.append(each_tests_directory / f"test_{stem}.py")
-        all_candidates.extend(
-            _mirrored_nested_candidates(directory, each_ancestor, each_tests_directory, stem)
-        )
-    return all_candidates
-
-
-def _python_candidate_test_paths(directory: Path, stem: str) -> list[Path]:
-    all_candidates = _flat_stem_candidates(directory, stem)
-    all_candidates.extend(_nested_tests_candidates(directory, stem))
-    all_candidates.extend(_split_family_candidates(directory, stem))
-    return all_candidates
-
-
-def _javascript_candidate_test_paths(directory: Path, stem: str, extension: str) -> list[Path]:
-    return [directory / f"{stem}.test{extension}", directory / f"{stem}.spec{extension}"]
-
-
-def candidate_test_paths_for(production_path: Path) -> list[Path]:
-    """Return the test files that can satisfy the gate for a production file.
-
-    ::
-
-        pkg/orders.py -> pkg/test_orders.py, pkg/orders_test.py,
-                         pkg/tests/test_orders.py (and package mirrors)
-
-    ``code_rules_*`` Python modules also gain the split test family. Plain
-    stem-derived candidates always come first.
-
-    Args:
-        production_path: The production source file being written or edited.
-
-    Returns:
-        Ordered candidate test paths; stem-derived siblings precede any
-        split-family additions.
-    """
-    directory = production_path.parent
-    stem = production_path.stem
-    extension = production_path.suffix.lower()
-    if extension == PYTHON_SOURCE_EXTENSION:
-        return _python_candidate_test_paths(directory, stem)
-    if extension in _javascript_test_extensions():
-        return _javascript_candidate_test_paths(directory, stem, extension)
-    return []

package/hooks/blocking/tdd_enforcer_parts/config/__init__.py

@@ -1 +0,0 @@
-"""Configuration home for the TDD-enforcer parts constants."""

package/hooks/blocking/tdd_enforcer_parts/config/tdd_enforcer_constants.py

@@ -1,49 +0,0 @@
-"""Constants for the TDD-enforcer hook and its decomposed parts modules.
-
-Centralizes the freshness window, the ancestor-walk limit, the git-tracking
-and git-diff command tokens, the source-file extension sets, the join
-separator, and the last-observed-hash store's filename shape and JSON keys.
-The store's JSON keys also cover a recorded failing-test-run entry: the test
-file's content hash at failure time, the failure timestamp, the failing
-command, and its exit status.
-"""
-
-from __future__ import annotations
-
-FRESHNESS_WINDOW_SECONDS: int = 600
-PARENT_WALK_LIMIT: int = 10
-GIT_LS_FILES_TIMEOUT_SECONDS: int = 10
-GIT_DIFF_TIMEOUT_SECONDS: int = 10
-GIT_EXECUTABLE_NAME: str = "git"
-GIT_LS_FILES_SUBCOMMAND: str = "ls-files"
-GIT_DIFF_SUBCOMMAND: str = "diff"
-GIT_DIFF_QUIET_FLAG: str = "--quiet"
-GIT_HEAD_REVISION: str = "HEAD"
-GIT_PATHSPEC_SEPARATOR: str = "--"
-HASH_STATE_FILE_PREFIX: str = "claude-tdd-test-hashes-"
-HASH_STATE_FILE_SUFFIX: str = ".json"
-REPOSITORY_ROOT_DIGEST_LENGTH: int = 16
-STORED_CONTENT_HASH_KEY: str = "hash"
-STORED_CHANGED_AT_KEY: str = "changed_at"
-STORED_FAILURE_HASH_KEY: str = "failed_hash"
-STORED_FAILED_AT_KEY: str = "failed_at"
-STORED_FAILURE_COMMAND_KEY: str = "failed_command"
-STORED_FAILURE_EXIT_STATUS_KEY: str = "failed_exit_status"
-PYTHON_SOURCE_EXTENSION: str = ".py"
-ENTRY_HOOK_FILE_NAME: str = "tdd_enforcer.py"
-NEWLINE_JOIN_SEPARATOR: str = "\n"
-ALL_PRODUCTION_EXTENSIONS: frozenset[str] = frozenset({".py", ".ts", ".tsx", ".js", ".jsx"})
-ALL_SKIP_EXTENSIONS: frozenset[str] = frozenset(
-    {".md", ".json", ".yaml", ".yml", ".toml", ".ini", ".cfg", ".txt"}
-)
-ALL_SKIP_NAME_PATTERNS: frozenset[str] = frozenset(
-    {"test_", "_test.", ".test.", "tests/", "__tests__/", "conftest", "fixture", "mock", "stub"}
-)
-ALL_DIRECTORY_SKIP_COMPONENTS: frozenset[str] = frozenset(
-    {"conftest", "fixture", "fixtures", "mock", "mocks", "stub", "stubs"}
-)
-ALL_DOTCLAUDE_PATH_SEGMENTS: frozenset[str] = frozenset({".claude"})
-ALL_REPO_BOUNDARY_SENTINELS: frozenset[str] = frozenset(
-    {".git", "pyproject.toml", "package.json", "Cargo.toml", "go.mod"}
-)
-ALL_JAVASCRIPT_TEST_EXTENSIONS: frozenset[str] = frozenset({".tsx", ".ts", ".jsx", ".js"})