claude-dev-env 8.88.1 → 8.88.3

package/hooks/session/test_deepen_default_rewrite.py

@@ -0,0 +1,90 @@
+"""Tests for the role-shaped default rewrite."""
+
+from __future__ import annotations
+
+import sys
+from pathlib import Path
+
+sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
+sys.path.insert(0, str(Path(__file__).resolve().parent))
+
+from deepen_default_rewrite import role_default_rewrite
+from deepen_role_gate import refusal_reason
+from hooks_constants.deepen_first_prompt_constants import ALL_FOUR_QUESTION_STEMS, DEEPEN_MARKER
+
+
+def _role_line(rewrite: str, label: str) -> str:
+    return next(each for each in rewrite.splitlines() if each.startswith(label))[len(label) :].strip()
+
+
+def test_should_pass_the_gate_for_a_plain_task() -> None:
+    task = "Add dark mode to the settings page"
+    rewrite = role_default_rewrite(task)
+    assert rewrite.startswith(DEEPEN_MARKER)
+    assert refusal_reason(task, rewrite) is None
+    assert _role_line(rewrite, "SCOPE (role):") == task
+    assert _role_line(rewrite, "EXAMPLES (illustration only):") == "none"
+
+
+def test_should_not_paste_the_four_question_stems() -> None:
+    rewrite = role_default_rewrite("Add dark mode to the settings page")
+    assert not any(each_stem in rewrite for each_stem in ALL_FOUR_QUESTION_STEMS)
+
+
+def test_should_move_a_marked_example_out_of_the_scope() -> None:
+    task = "fix the flaky tests, e.g. test_auth and test_cache, and keep CI fast"
+    rewrite = role_default_rewrite(task)
+    assert refusal_reason(task, rewrite) is None
+    assert _role_line(rewrite, "SCOPE (role):") == "fix the flaky tests and keep CI fast"
+    assert _role_line(rewrite, "EXAMPLES (illustration only):") == "test_auth and test_cache"
+
+
+def test_should_ask_before_narrowing_when_the_scope_names_the_example() -> None:
+    task = "Fix the login failure. For example, the login failure on Safari."
+    rewrite = role_default_rewrite(task)
+    assert refusal_reason(task, rewrite) is None
+    assert _role_line(rewrite, "ZOOM-IN BLOCKER:").startswith("the scope names something")
+
+
+def test_should_keep_every_hard_constraint_line() -> None:
+    task = "Keep the build green. For example, the login failure.\n\nHARD CONSTRAINTS\n- Never open a pull request.\n"
+    rewrite = role_default_rewrite(task)
+    assert refusal_reason(task, rewrite) is None
+    assert "- Never open a pull request." in rewrite.splitlines()
+
+
+def test_should_keep_every_task_sentence_in_scope_when_the_task_opens_with_context() -> None:
+    task = "We have a Django app. Add CSV export to the reports page, e.g. the monthly sales report, and keep the existing URLs."
+    rewrite = role_default_rewrite(task)
+    assert refusal_reason(task, rewrite) is None
+    assert _role_line(rewrite, "SCOPE (role):") == (
+        "We have a Django app. Add CSV export to the reports page and keep the existing URLs."
+    )
+    assert _role_line(rewrite, "EXAMPLES (illustration only):") == "the monthly sales report"
+
+
+def test_should_clip_a_long_scope_and_point_at_the_full_task() -> None:
+    task = "Refactor the module. " * 40
+    rewrite = role_default_rewrite(task.strip())
+    scope = _role_line(rewrite, "SCOPE (role):")
+    assert scope.endswith("(the rest is in the task below)")
+    assert len(scope) < len(task)
+    assert refusal_reason(task.strip(), rewrite) is None
+
+
+def test_should_keep_a_marker_word_inside_a_longer_word_in_the_scope() -> None:
+    task = "Search the codebase for examples of deprecated API calls and replace each one with the new client."
+    rewrite = role_default_rewrite(task)
+    assert refusal_reason(task, rewrite) is None
+    assert _role_line(rewrite, "SCOPE (role):") == task
+    assert _role_line(rewrite, "EXAMPLES (illustration only):") == "none"
+    assumption_task = "Avoid such assumptions in the parser and add input validation."
+    assert _role_line(role_default_rewrite(assumption_task), "SCOPE (role):") == assumption_task
+
+
+def test_should_move_every_marked_example_in_a_sentence_out_of_the_scope() -> None:
+    task = "Speed up the slow pages such as the dashboard, and cache reads, e.g. the user lookup, and keep the API stable."
+    rewrite = role_default_rewrite(task)
+    assert refusal_reason(task, rewrite) is None
+    assert _role_line(rewrite, "SCOPE (role):") == "Speed up the slow pages and cache reads and keep the API stable."
+    assert _role_line(rewrite, "EXAMPLES (illustration only):") == "the dashboard; the user lookup"

package/hooks/session/test_deepen_first_prompt.py

@@ -31,6 +31,7 @@ from hooks_constants.deepen_first_prompt_constants import (
     REFUSAL_EXAMPLE_NOUN_IN_SCOPE,
     REFUSAL_MISSING_ROLE_LINES,
     REFUSAL_RESTATES_FOUR_QUESTIONS,
+    ALL_FOUR_QUESTION_STEMS,
     SKIP_DEEPEN_ENV_VAR,
     USER_PROMPT_SUBMIT_EVENT_NAME,
     CURSOR_BEFORE_SUBMIT_PROMPT_EVENT_NAME,
@@ -341,12 +342,20 @@ def test_should_strip_the_deepen_slash_before_rewriting() -> None:
     assert deepen.task_text_for_deepen("/deepen fix the login page") == "fix the login page"
 
 
-def test_should_refuse_the_paste_path_as_the_known_bad() -> None:
+def test_should_refuse_the_paste_path_as_the_known_bad(monkeypatch: pytest.MonkeyPatch) -> None:
+    pasted_questions = "\n".join(ALL_FOUR_QUESTION_STEMS)
+    monkeypatch.setenv(DEEPEN_REWRITE_ENV_VAR, _role_rewrite(pasted_questions))
     decision = deepen.decide_first_prompt(_payload("Add dark mode to the settings page"))
     assert isinstance(decision, deepen.Refuse)
     assert decision.reason == REFUSAL_RESTATES_FOUR_QUESTIONS
 
 
+def test_should_deepen_with_the_default_rewrite_when_nothing_is_configured() -> None:
+    decision = deepen.decide_first_prompt(_payload("Add dark mode to the settings page"))
+    assert isinstance(decision, deepen.Deepen)
+    assert "SCOPE (role): Add dark mode to the settings page" in decision.rewritten_prompt
+
+
 def test_should_refuse_the_filled_four_answer_stub_without_role_lines(
     monkeypatch: pytest.MonkeyPatch,
 ) -> None:
@@ -427,6 +436,7 @@ def test_should_print_a_json_refusal_for_the_paste_path(
     monkeypatch: pytest.MonkeyPatch,
 ) -> None:
     monkeypatch.setenv("CDE_DEEPEN_OUTPUT", DEEPEN_OUTPUT_JSON)
+    monkeypatch.setenv(DEEPEN_REWRITE_ENV_VAR, _role_rewrite("\n".join(ALL_FOUR_QUESTION_STEMS)))
     printed = _run_main(_payload("Add dark mode to the settings page"))
     assert json.loads(printed) == {
         "decision": "refuse",
@@ -438,4 +448,5 @@ def test_should_stay_silent_in_rewrite_mode_when_the_gate_refuses(
     monkeypatch: pytest.MonkeyPatch,
 ) -> None:
     monkeypatch.setenv("CDE_DEEPEN_OUTPUT", DEEPEN_OUTPUT_REWRITE)
+    monkeypatch.setenv(DEEPEN_REWRITE_ENV_VAR, _FILLED_FOUR_ANSWERS)
     assert _run_main(_payload("Add dark mode to the settings page")) == ""

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.88.1",
+    "version": "8.88.3",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {