claude-dev-env 8.79.0 → 8.81.0

package/hooks/hooks_constants/gh_command_words_constants.py

@@ -0,0 +1,64 @@
+"""Names the ``gh`` options that take a separate value, and the option prefix and value separator.
+
+A reader of a ``gh`` command skips the token after each of these options, so
+``gh -R o/r pr list`` reads as ``pr list`` and ``gh pr merge 12 --body -h``
+reads ``-h`` as the body text. ``-f``, ``-F``, ``-H``, ``-p`` and ``-t`` take a value in
+``gh api``, ``gh workflow run`` and ``gh pr create`` alike.
+"""
+
+from __future__ import annotations
+
+__all__ = [
+    "ALL_GH_OPTIONS_WITH_A_VALUE",
+    "GH_OPTION_PREFIX",
+    "GH_OPTION_VALUE_SEPARATOR",
+]
+
+ALL_GH_OPTIONS_WITH_A_VALUE: frozenset[str] = frozenset(
+    {
+        "-R",
+        "--repo",
+        "--hostname",
+        "--config",
+        "-H",
+        "--header",
+        "--head",
+        "-X",
+        "--method",
+        "-F",
+        "--field",
+        "--body-file",
+        "-f",
+        "--raw-field",
+        "--input",
+        "-q",
+        "--jq",
+        "-t",
+        "--template",
+        "-p",
+        "--preview",
+        "--title",
+        "--cache",
+        "--json",
+        "-b",
+        "--body",
+        "-B",
+        "--base",
+        "-S",
+        "--search",
+        "-L",
+        "--limit",
+        "-s",
+        "--state",
+        "-l",
+        "--label",
+        "-a",
+        "--assignee",
+        "-A",
+        "--author",
+        "-m",
+        "--milestone",
+    }
+)
+GH_OPTION_PREFIX: str = "-"
+GH_OPTION_VALUE_SEPARATOR: str = "="

package/hooks/hooks_constants/headless_claude_broker_gate_constants.py

@@ -3,9 +3,7 @@
 Holds the Claude program name and its profile-launcher prefix, the Windows
 launcher suffixes stripped before the name check, the two print-mode flags, the
 hook name the block log records, and the deny message that names the broker
-command to run instead. It also names the environment variable a Claude Code
-cloud session sets, where the gate stands aside because the session has one
-account.
+command to run instead.
 """
 
 from __future__ import annotations
@@ -18,8 +16,6 @@ __all__ = [
     "PRINT_MODE_LONG_FLAG_WITH_VALUE_PREFIX",
     "GATE_HOOK_NAME",
     "BROKER_COMMAND_DENY_REASON",
-    "CLOUD_SESSION_ENV_VAR",
-    "CLOUD_SESSION_ENV_TRUE_VALUE",
 ]
 
 CLAUDE_PROGRAM_NAME: str = "claude"
@@ -28,8 +24,6 @@ ALL_WINDOWS_LAUNCHER_SUFFIXES: tuple[str, ...] = (".cmd", ".exe", ".ps1", ".bat"
 ALL_PRINT_MODE_FLAGS: frozenset[str] = frozenset({"-p", "--print"})
 PRINT_MODE_LONG_FLAG_WITH_VALUE_PREFIX: str = "--print="
 GATE_HOOK_NAME: str = "headless_claude_broker_gate.py"
-CLOUD_SESSION_ENV_VAR: str = "CLAUDE_CODE_REMOTE"
-CLOUD_SESSION_ENV_TRUE_VALUE: str = "true"
 BROKER_COMMAND_DENY_REASON: str = (
     "BLOCKED: Start a headless Claude session through the account broker. "
     "Run: python \"$HOME/.claude/scripts/account_broker.py\" run --product claude "

package/hooks/hooks_constants/hook_block_logger.py

@@ -1,15 +1,30 @@
 """Shared fail-safe logger for hook block events.
 
 Every blocking hook calls log_hook_block at the moment it decides to block,
-so the user has a single log showing what tripped and why.
+so the user has a single log showing what tripped and why. A GitHub token or
+an Authorization header value in the preview is replaced before it is written.
 """
 
 import datetime
 import json
+import re
 from pathlib import Path
 
 _HOOK_BLOCKS_LOG_RELATIVE_PATH = ".claude/logs/hook-blocks.log"
 _MAX_PREVIEW_LENGTH = 500
+_REDACTION_MARKER = "[REDACTED]"
+_GITHUB_TOKEN_PATTERN = re.compile(r"\b(?:gh[pousr]_|github_pat_)[A-Za-z0-9_]+")
+_AUTHORIZATION_VALUE_PATTERN = re.compile(
+    r"(?P<header>authorization['\"]?\s*:\s*['\"]?)[^'\"\r\n]+", re.IGNORECASE
+)
+
+
+def _preview_without_secrets(offending_input_preview: str) -> str:
+    """Return the preview with GitHub tokens and Authorization header values replaced."""
+    without_tokens = _GITHUB_TOKEN_PATTERN.sub(_REDACTION_MARKER, offending_input_preview)
+    return _AUTHORIZATION_VALUE_PATTERN.sub(
+        lambda each_match: each_match.group("header") + _REDACTION_MARKER, without_tokens
+    )
 
 
 def log_hook_block(
@@ -31,7 +46,8 @@ def log_hook_block(
         block_reason: The human-readable reason the hook is blocking.
         tool_name: The Claude tool name when available, e.g. ``Bash``.
         offending_input_preview: A short excerpt of the input that triggered
-            the block; truncated to 500 characters before writing.
+            the block; secrets are replaced, then it is truncated to 500
+            characters before writing.
     """
     try:
         home_directory = Path.home()
@@ -51,7 +67,9 @@ def log_hook_block(
         if tool_name is not None:
             log_record["tool"] = tool_name
         if offending_input_preview is not None:
-            log_record["preview"] = offending_input_preview[:_MAX_PREVIEW_LENGTH]
+            log_record["preview"] = _preview_without_secrets(offending_input_preview)[
+                :_MAX_PREVIEW_LENGTH
+            ]
 
         with log_path.open("a", encoding="utf-8") as log_file:
             log_file.write(json.dumps(log_record) + "\n")

package/hooks/hooks_constants/merge_review_gate_constants.py

@@ -25,6 +25,10 @@ PR_NUMBER_PATTERN = re.compile(r"(?:^|\s)#?(?P<number>\d+)(?:\s|$)")
 PR_URL_PATTERN = re.compile(
     r"github\.com/(?P<owner>[\w.-]+)/(?P<repo>[\w.-]+)/pull/(?P<number>\d+)"
 )
+RULINGS_LINK_PATTERN = re.compile(
+    r"https://github\.com/(?P<owner>[\w.-]+)/(?P<repo>[\w.-]+)/pull/(?P<number>\d+)"
+    r"#issuecomment-\d+"
+)
 REPO_OPTION_PATTERN = re.compile(r"(?:-R|--repo)[\s=](?P<owner>[\w.-]+)/(?P<repo>[\w.-]+)")
 MATCH_HEAD_PATTERN = re.compile(r"--match-head-commit[\s=](?P<sha>[0-9a-fA-F]{7,40})")
 API_SHA_FIELD_PATTERN = re.compile(r"(?:-f|-F|--field|--raw-field)[\s=]sha=(?P<sha>[0-9a-fA-F]{7,40})")
@@ -43,15 +47,21 @@ RECEIPT_FILE_NAME_TEMPLATE = "{owner}__{repo}__{number}.json"
 REPOSITORY_SEPARATOR = ","
 RECEIPT_HEAD_KEY = "head"
 RECEIPT_FINDINGS_KEY = "findings"
+RECEIPT_RULED_OUT_KEY = "ruled_out"
+RECEIPT_RULINGS_KEY = "rulings"
 RECORD_COMMAND = "python3 ~/.claude/scripts/merge_review_receipt.py"
 
 NO_CLEAN_REVIEW_REASON_TEMPLATE = (
     "{slug}#{number} has no clean review on the head you are merging. Run the review "
     "loop: review the pull request head with `{review_command}`, fix and push every "
     "finding, and review again "
-    "until a pass reports zero findings. Record that pass with `"
+    "until a pass reports zero findings or every finding is ruled out with file:line "
+    "evidence. Record that pass with `"
     + RECORD_COMMAND
-    + " {slug} {number} <head sha> 0`, then merge pinned to that head."
+    + " {slug} {number} <head sha> <finding count>`, adding `--ruled-out <finding count> "
+    "--rulings <link to the rulings comment on this pull request>` when every finding is "
+    "ruled out, then merge "
+    "pinned to that head."
 )
 UNPINNED_MERGE_REASON_TEMPLATE = (
     "{slug}#{number} has a clean review for {head}, but this merge names no head. "
@@ -60,7 +70,8 @@ UNPINNED_MERGE_REASON_TEMPLATE = (
 )
 STALE_REVIEW_REASON_TEMPLATE = (
     "{slug}#{number} was reviewed clean at {head}, and this merge names {pinned}. "
-    "Review the new head until a pass reports zero findings, record it, then merge."
+    "Review the new head until a pass reports zero findings or every finding is ruled "
+    "out, record it, then merge."
 )
 AUTO_MERGE_REASON_TEMPLATE = (
     "Auto-merge on {slug}#{number} names no head, so it could merge a head no review "

package/hooks/hooks_constants/mod_handoff.py

@@ -13,10 +13,9 @@ import json
 import os
 from pathlib import Path
 
+from hooks_constants.cloud_session import is_cloud_session
 from hooks_constants.mod_handoff_constants import (
     ALL_SETTINGS_FILE_NAMES_IN_PRECEDENCE_ORDER,
-    CLOUD_SESSION_ENV_TRUE_VALUE,
-    CLOUD_SESSION_ENV_VAR,
     CLAUDE_CONFIG_DIR_ENV_VAR,
     CLAUDE_PROJECT_DIR_ENV_VAR,
     DEFAULT_CLAUDE_CONFIG_DIRECTORY_NAME,
@@ -81,7 +80,7 @@ def is_mod_plugin_enabled(plugin_name: str) -> bool:
     Args:
         plugin_name: The plugin that holds the mod replacing the calling hook.
     """
-    if os.environ.get(CLOUD_SESSION_ENV_VAR, "").strip().lower() == CLOUD_SESSION_ENV_TRUE_VALUE:
+    if is_cloud_session():
         return False
     is_enabled = False
     for each_path in all_settings_paths_in_precedence_order():

package/hooks/hooks_constants/mod_handoff_constants.py

@@ -8,8 +8,6 @@ from __future__ import annotations
 
 __all__ = [
     "ALL_SETTINGS_FILE_NAMES_IN_PRECEDENCE_ORDER",
-    "CLOUD_SESSION_ENV_TRUE_VALUE",
-    "CLOUD_SESSION_ENV_VAR",
     "CLAUDE_CONFIG_DIR_ENV_VAR",
     "CLAUDE_PROJECT_DIR_ENV_VAR",
     "DEFAULT_CLAUDE_CONFIG_DIRECTORY_NAME",
@@ -22,8 +20,6 @@ __all__ = [
 ]
 
 ENABLED_PLUGINS_SETTINGS_KEY = "enabledPlugins"
-CLOUD_SESSION_ENV_VAR = "CLAUDE_CODE_REMOTE"
-CLOUD_SESSION_ENV_TRUE_VALUE = "true"
 PLUGIN_MARKETPLACE_SEPARATOR = "@"
 SHELL_GUARDS_PLUGIN_NAME = "shell-guards"
 SESSION_PROMPTS_PLUGIN_NAME = "session-prompts"

package/hooks/hooks_constants/piped_pytest_blocker_constants.py

@@ -19,8 +19,9 @@ that consumes these program, wrapper, and option constants lives in
 ``pytest_invocation``.
 
 Two wrapper shapes reach the program behind them differently. ``sudo``,
-``uvx``, ``xargs``, ``env``, and ``timeout`` take their own options and then the
-command, and ``ALL_WRAPPER_OPTION_GRAMMARS_BY_NAME`` names each one's
+``uvx``, ``xargs``, ``env``, ``timeout``, ``command``, and ``exec`` take their own
+options and then the command, and a shell keyword such as ``if``, ``then``,
+``do``, or ``!`` runs the command after it, and ``ALL_WRAPPER_OPTION_GRAMMARS_BY_NAME`` names each one's
 value-taking options, its flag-only options, and the operands it reads before
 the command, so ``xargs -I {} rm {}`` and ``timeout --signal KILL 5 git push``
 both reach the program. ``uv``, ``poetry``, ``pipenv``, ``pdm``, ``hatch``, ``rye``, and
@@ -149,6 +150,8 @@ __all__ = [
     "WrapperOptionGrammar",
     "WINDOWS_EXECUTABLE_SUFFIX",
     "RUN_SUBCOMMAND_OPTION_GRAMMAR",
+    "SHELL_KEYWORD_OPTION_GRAMMAR",
+    "ALL_SHELL_KEYWORDS_BEFORE_A_COMMAND",
     "ALL_WRAPPER_OPTION_GRAMMARS_BY_NAME",
     "ALL_RUN_SUBCOMMAND_WRAPPER_COMMANDS",
     "RUN_SUBCOMMAND_NAME",
@@ -312,6 +315,14 @@ RUN_SUBCOMMAND_OPTION_GRAMMAR = WrapperOptionGrammar(
     all_flag_options=frozenset(),
     leading_operand_count=0,
 )
+SHELL_KEYWORD_OPTION_GRAMMAR = WrapperOptionGrammar(
+    all_value_taking_options=frozenset(),
+    all_flag_options=frozenset(),
+    leading_operand_count=0,
+)
+ALL_SHELL_KEYWORDS_BEFORE_A_COMMAND: frozenset[str] = frozenset(
+    {"if", "then", "elif", "else", "while", "until", "do", "!", "{"}
+)
 ALL_WRAPPER_OPTION_GRAMMARS_BY_NAME: dict[str, WrapperOptionGrammar] = {
     "sudo": WrapperOptionGrammar(
         all_value_taking_options=frozenset(
@@ -365,6 +376,20 @@ ALL_WRAPPER_OPTION_GRAMMARS_BY_NAME: dict[str, WrapperOptionGrammar] = {
         all_flag_options=frozenset({"-v", "--verbose", "--preserve-status", "--foreground"}),
         leading_operand_count=1,
     ),
+    "command": WrapperOptionGrammar(
+        all_value_taking_options=frozenset(),
+        all_flag_options=frozenset({"-p"}),
+        leading_operand_count=0,
+    ),
+    "exec": WrapperOptionGrammar(
+        all_value_taking_options=frozenset({"-a"}),
+        all_flag_options=frozenset({"-c", "-l"}),
+        leading_operand_count=0,
+    ),
+    **{
+        each_keyword: SHELL_KEYWORD_OPTION_GRAMMAR
+        for each_keyword in ALL_SHELL_KEYWORDS_BEFORE_A_COMMAND
+    },
 }
 ALL_RUN_SUBCOMMAND_WRAPPER_COMMANDS: frozenset[str] = frozenset(
     {

package/hooks/hooks_constants/pr_lifecycle_skill_gate_constants.py

@@ -25,7 +25,6 @@ COMMAND_SEPARATORS = ";|&\n()`"
 COMMAND_WHITESPACE = " \t\r"
 OPTION_AND_VALUE_WORD_COUNT = 2
 GIT_GLOBAL_OPTIONS_WITH_VALUE = frozenset({"-C", "-c", "--git-dir", "--work-tree", "--namespace", "--config-env"})
-GH_OPTIONS_WITH_VALUE = frozenset({"-R", "--repo", "--hostname", "--config", "-H", "--header", "-X", "--method", "-F", "--field", "-f", "--raw-field", "--input", "--jq", "-q", "--template", "-t", "--cache"})
 GIT_ACTIONS = frozenset({"commit", "push"})
 GH_PULL_REQUEST_COMMAND = "pr"
 GH_API_COMMAND = "api"

package/hooks/hooks_constants/pre_tool_use_dispatcher_constants.py

@@ -87,4 +87,8 @@ ALL_HOSTED_HOOK_ENTRIES: tuple[HostedHookEntry, ...] = (
         script_relative_path="blocking/context_budget_blocker.py",
         applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_APPLY_PATCH_TOOL_NAMES,
     ),
+    HostedHookEntry(
+        script_relative_path="blocking/pull_request_proof_edit_gate.py",
+        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_APPLY_PATCH_TOOL_NAMES,
+    ),
 )

package/hooks/hooks_constants/pull_request_proof_constants.py

@@ -59,9 +59,10 @@ MISSING_LOOK_REASON = (
 CHANGED_FILES_SEPARATOR = ", "
 UNREADABLE_CHANGES_REASON = (
     "Git in this directory cannot list the files this pull request changes, so the"
-    " picture check cannot tell whether people see the change. Run the create call"
-    " from a checkout of the head branch with origin fetched, or put a screenshot"
-    " link in the 'Proof in practice' section. Read " + PROOF_GUIDE_PATH + " for the full rule."
+    " picture check cannot tell whether people see the change. Put a screenshot or"
+    " Artifact link in the 'Proof in practice' section and run the create call again,"
+    " or run it from a checkout of the head branch with origin fetched. Take one of"
+    " these routes now, before any change to this gate. Read " + PROOF_GUIDE_PATH + " for the full rule."
 )
 FEATURE_TITLE_PATTERN = r"^\s*feat(\([^)]*\))?!?:"
 EVAL_HEADING_PATTERN = r"^(#{1,6})[ \t]+evals?[ \t]*#*[ \t]*$"
@@ -83,3 +84,21 @@ MISSING_BUILD_EVAL_REASON = (
     + EVAL_GUIDE_PATH
     + " for the full rule."
 )
+ALL_PROOF_GATE_DENY_MARKERS = (PROOF_GUIDE_PATH, EXISTING_WORK_GUIDE_PATH, EVAL_GUIDE_PATH)
+ALL_PROOF_GATE_FILE_NAMES = frozenset(
+    {
+        "pull_request_proof.py",
+        "pull_request_proof_constants.py",
+        "pull_request_proof_edit_gate.py",
+        "pre_tool_use_dispatcher_constants.py",
+    }
+)
+GATE_EDIT_BEFORE_ROUTE_REASON = (
+    "The pull request proof gate denied a create call in this session, and its deny"
+    " named the way through. Take that route now. Add what the deny asked for, such as"
+    " a screenshot or Artifact link in the 'Proof in practice' section, then run the"
+    " create call again. The deny text is the instruction. Edit this gate only"
+    " after a create call passes it. Read " + PROOF_GUIDE_PATH + " for the full rule."
+)
+WINDOWS_PATH_SEPARATOR = "\\"
+POSIX_PATH_SEPARATOR = "/"

package/hooks/hooks_constants/shell_command_evaluation_constants.py

@@ -0,0 +1,67 @@
+"""Names the programs that run a command held in their arguments rather than as a shell wrapper.
+
+``eval`` and PowerShell's ``Invoke-Expression`` run their joined arguments,
+``find -exec`` runs the tokens up to its terminator, and PowerShell's
+``-EncodedCommand`` runs a base64 string of UTF-16LE text. PowerShell accepts
+any prefix of ``-EncodedCommand`` from ``-e`` on, plus the ``-ec`` alias.
+``Start-Process`` runs its file path with its argument list, which may be
+comma-separated, and a parameter may carry its value after a colon, as in
+``-ArgumentList:'pr list'``; the values of its other parameters are not part
+of the command. Unwrapping stops past ``MAXIMUM_UNWRAP_DEPTH`` nested levels, so a
+deeply nested command cannot exhaust the parser.
+"""
+
+from __future__ import annotations
+
+__all__ = [
+    "ALL_STRING_EVALUATING_PROGRAM_NAMES",
+    "FIND_PROGRAM_NAME",
+    "ALL_FIND_EXEC_ACTIONS",
+    "ALL_FIND_EXEC_TERMINATORS",
+    "FIND_EXEC_COMMAND_SEPARATOR",
+    "ALL_POWERSHELL_PROGRAM_NAMES",
+    "ENCODED_COMMAND_OPTION",
+    "ENCODED_COMMAND_SHORT_ALIAS",
+    "MINIMUM_ENCODED_COMMAND_PREFIX_LENGTH",
+    "ENCODED_COMMAND_TEXT_ENCODING",
+    "ALL_START_PROCESS_PROGRAM_NAMES",
+    "ALL_START_PROCESS_NON_COMMAND_PARAMETERS",
+    "START_PROCESS_PARAMETER_PREFIX",
+    "START_PROCESS_ARGUMENT_SEPARATOR",
+    "START_PROCESS_PARAMETER_VALUE_SEPARATOR",
+    "MAXIMUM_UNWRAP_DEPTH",
+    "ALL_LINE_BREAK_CHARACTERS",
+    "QUOTED_LINE_BREAK_REPLACEMENT",
+]
+
+ALL_STRING_EVALUATING_PROGRAM_NAMES: frozenset[str] = frozenset(
+    {"eval", "invoke-expression", "iex"}
+)
+FIND_PROGRAM_NAME: str = "find"
+ALL_FIND_EXEC_ACTIONS: frozenset[str] = frozenset({"-exec", "-execdir", "-ok", "-okdir"})
+ALL_FIND_EXEC_TERMINATORS: frozenset[str] = frozenset({";", "\\;", "+"})
+FIND_EXEC_COMMAND_SEPARATOR: str = " ; "
+ALL_POWERSHELL_PROGRAM_NAMES: frozenset[str] = frozenset({"pwsh", "powershell"})
+ENCODED_COMMAND_OPTION: str = "-encodedcommand"
+ENCODED_COMMAND_SHORT_ALIAS: str = "-ec"
+MINIMUM_ENCODED_COMMAND_PREFIX_LENGTH: int = 2
+ENCODED_COMMAND_TEXT_ENCODING: str = "utf-16-le"
+ALL_START_PROCESS_PROGRAM_NAMES: frozenset[str] = frozenset({"start-process", "saps", "start"})
+ALL_START_PROCESS_NON_COMMAND_PARAMETERS: frozenset[str] = frozenset(
+    {
+        "-workingdirectory",
+        "-verb",
+        "-windowstyle",
+        "-credential",
+        "-redirectstandardinput",
+        "-redirectstandardoutput",
+        "-redirectstandarderror",
+        "-environment",
+    }
+)
+START_PROCESS_PARAMETER_PREFIX: str = "-"
+START_PROCESS_ARGUMENT_SEPARATOR: str = ","
+START_PROCESS_PARAMETER_VALUE_SEPARATOR: str = ":"
+MAXIMUM_UNWRAP_DEPTH: int = 16
+ALL_LINE_BREAK_CHARACTERS: frozenset[str] = frozenset({"\n", "\r"})
+QUOTED_LINE_BREAK_REPLACEMENT: str = " "

package/hooks/hooks_constants/shell_command_substitution_constants.py

@@ -0,0 +1,25 @@
+"""Characters the command substitution scan reads in a shell command."""
+
+from __future__ import annotations
+
+__all__ = [
+    "COMMAND_SUBSTITUTION_OPENER",
+    "BACKTICK",
+    "SINGLE_QUOTE",
+    "DOUBLE_QUOTE",
+    "SHELL_ESCAPE_CHARACTER",
+    "OPENING_PARENTHESIS",
+    "CLOSING_PARENTHESIS",
+    "ALL_PARENTHESIS_DEPTH_CHANGES",
+    "ALL_BACKTICK_ESCAPED_CHARACTERS",
+]
+
+COMMAND_SUBSTITUTION_OPENER: str = "$("
+BACKTICK: str = "`"
+SINGLE_QUOTE: str = "'"
+DOUBLE_QUOTE: str = '"'
+SHELL_ESCAPE_CHARACTER: str = "\\"
+OPENING_PARENTHESIS: str = "("
+CLOSING_PARENTHESIS: str = ")"
+ALL_PARENTHESIS_DEPTH_CHANGES: dict[str, int] = {OPENING_PARENTHESIS: 1, CLOSING_PARENTHESIS: -1}
+ALL_BACKTICK_ESCAPED_CHARACTERS: frozenset[str] = frozenset({"$", BACKTICK, SHELL_ESCAPE_CHARACTER})