claude-dev-env 8.73.1 → 8.74.0

package/scripts/repository_checks/followup_ledger_duplicates.py

@@ -0,0 +1,55 @@
+"""Committed follow-up ledger check for exact repeated lines.
+
+GitHub's server-side merge ignores ``merge=union``, so repeated lines arrive
+only through a local union merge. This check stops them at the merge queue.
+"""
+
+from __future__ import annotations
+
+from collections.abc import Sequence
+from pathlib import Path
+from types import ModuleType
+
+from policy_lint.config import constants as policy_constants
+
+from repository_checks.config import constants as repository_constants
+from repository_checks.hook_modules import load_hooks_module
+from repository_checks.models import RepositoryFinding
+
+
+def collect_followup_ledger_duplicate_findings(
+    repository_root: Path, all_tracked_paths: Sequence[str]
+) -> list[RepositoryFinding]:
+    """Return a finding when the tracked ledger repeats a line.
+
+    Args:
+        repository_root: Git repository root.
+        all_tracked_paths: Repository-relative tracked paths.
+
+    Returns:
+        One finding naming the repeated-line count, or no findings.
+    """
+    ledger = load_hooks_module(repository_constants.FOLLOWUP_LEDGER_MODULE_NAME)
+    ledger_path = ledger.followup_ledger_path(repository_root)
+    relative_path = ledger_path.relative_to(repository_root).as_posix()
+    if relative_path not in all_tracked_paths:
+        return []
+    repeated_line_count = _repeated_line_count(ledger, ledger_path)
+    if not repeated_line_count:
+        return []
+    return [
+        RepositoryFinding(
+            repository_constants.CHECK_ID_FOLLOWUP_LEDGER_DUPLICATES,
+            relative_path,
+            repository_constants.FOLLOWUP_LEDGER_DUPLICATE_MESSAGE_TEMPLATE.format(
+                repeated_line_count=repeated_line_count
+            ),
+        )
+    ]
+
+
+def _repeated_line_count(ledger: ModuleType, ledger_path: Path) -> int:
+    all_ledger_lines = ledger_path.read_text(
+        encoding=policy_constants.UTF8_ENCODING
+    ).splitlines()
+    return len(all_ledger_lines) - len(ledger.deduplicated_lines(all_ledger_lines))

package/scripts/repository_checks/runner.py

@@ -11,6 +11,9 @@ from repository_checks.config import constants as repository_constants
 from repository_checks.env_var_documentation import (
     collect_env_var_documentation_findings,
 )
+from repository_checks.followup_ledger_duplicates import (
+    collect_followup_ledger_duplicate_findings,
+)
 from repository_checks.models import RepositoryCheckReport, RepositoryFinding
 from repository_checks.package_inventory import collect_package_inventory_findings
 from repository_checks.pytest_testpaths import collect_pytest_testpath_findings
@@ -81,6 +84,10 @@ def _all_collectors() -> tuple[tuple[str, RepositoryCollector], ...]:
             repository_constants.CHECK_ID_ENV_VAR_DOCUMENTATION,
             collect_env_var_documentation_findings,
         ),
+        (
+            repository_constants.CHECK_ID_FOLLOWUP_LEDGER_DUPLICATES,
+            collect_followup_ledger_duplicate_findings,
+        ),
         (
             repository_constants.CHECK_ID_PACKAGE_INVENTORY,
             collect_package_inventory_findings,

package/scripts/test_active_capability_references.py

@@ -2,13 +2,8 @@
 
 from __future__ import annotations
 
-import sys
 from pathlib import Path
 
-_SCRIPTS = Path(__file__).resolve().parent
-if str(_SCRIPTS) not in sys.path:
-    sys.path.insert(0, str(_SCRIPTS))
-
 from active_capability_references import (
     build_capability_inventory,
     classify_capability_reference,

package/scripts/test_broker_state_isolation.py

@@ -2,6 +2,7 @@
 
 from __future__ import annotations
 
+import json
 import subprocess
 from datetime import datetime, timezone
 from pathlib import Path
@@ -43,6 +44,5 @@ def test_meter_cache_write_lands_outside_the_home_directory(
 
     home_state_path = fake_home / ".claude" / "account-broker" / "state.json"
     assert not home_state_path.exists()
-    assert f"claude:only:{account.home}" in isolated_broker_state_path.read_text(
-        encoding="utf-8"
-    )
+    state = json.loads(isolated_broker_state_path.read_text(encoding="utf-8"))
+    assert f"claude:only:{account.home}" in state["meters"]

package/scripts/test_digest_check.py

@@ -2,15 +2,10 @@
 
 from __future__ import annotations
 
-import sys
 from pathlib import Path
 
 import pytest
 
-_SCRIPTS_DIRECTORY = Path(__file__).resolve().parent
-if str(_SCRIPTS_DIRECTORY) not in sys.path:
-    sys.path.insert(0, str(_SCRIPTS_DIRECTORY))
-
 import digest_check
 from dev_env_scripts_constants.digest_check_constants import (
     CARD_WORD_BUDGET,

package/scripts/test_durable_post_lint.py

@@ -9,14 +9,10 @@ from pathlib import Path
 
 import pytest
 
-_SCRIPTS_DIRECTORY = Path(__file__).resolve().parent
-if str(_SCRIPTS_DIRECTORY) not in sys.path:
-    sys.path.insert(0, str(_SCRIPTS_DIRECTORY))
-
 import durable_post_lint
 from dev_env_scripts_constants.private_term_constants import PrivateTermDigest
 
-SCRIPT_PATH = _SCRIPTS_DIRECTORY / "durable_post_lint.py"
+SCRIPT_PATH = Path(__file__).resolve().parent / "durable_post_lint.py"
 VALID_PR_BODY = """## Why
 
 Why text.

package/scripts/test_followup_cli.py

@@ -4,24 +4,20 @@ from __future__ import annotations
 
 import io
 import json
-import sys
 from pathlib import Path
 
 from dev_env_scripts_constants.followup_constants import (
     BACKLOG_EXCEEDED_EXIT_CODE,
     BACKLOG_EXCEEDED_TEMPLATE,
     BACKLOG_WITHIN_TEMPLATE,
+    DEDUPE_RESULT_TEMPLATE,
     FOLLOWUP_BACKLOG_THRESHOLD,
 )
 from followup_cli import main
-
-_hooks_directory = str(Path(__file__).resolve().parents[1] / "hooks")
-if _hooks_directory not in sys.path:
-    sys.path.insert(0, _hooks_directory)
-
 from followup_ledger import (
     FollowupFinding,
     all_recorded_findings,
+    followup_ledger_path,
     record_followup_finding,
 )
 
@@ -309,3 +305,19 @@ def test_list_names_the_check_behind_each_finding(tmp_path: Path) -> None:
 
     assert "code-rules/constant-outside-config" in output_text
     assert "f00dcafe" in output_text
+
+
+def test_dedupe_removes_repeated_ledger_lines_and_keeps_the_order(
+    tmp_path: Path,
+) -> None:
+    ledger_path = followup_ledger_path(tmp_path)
+    ledger_path.parent.mkdir(parents=True)
+    ledger_path.write_text("first\nsecond\nfirst\n", encoding="utf-8")
+
+    exit_code, output_text = run_command(
+        ["dedupe", "--repository-root", str(tmp_path)]
+    )
+
+    assert exit_code == 0
+    assert output_text == DEDUPE_RESULT_TEMPLATE.format(removed_count=1) + "\n"
+    assert ledger_path.read_text(encoding="utf-8") == "first\nsecond\n"

package/scripts/test_resolve_worker_spawn.py

@@ -4,7 +4,6 @@ from __future__ import annotations
 
 import json
 import subprocess
-import sys
 import threading
 from dataclasses import dataclass, field
 from datetime import datetime, timezone
@@ -12,13 +11,9 @@ from pathlib import Path
 
 import pytest
 
-_SCRIPTS_DIR = Path(__file__).resolve().parent
-if str(_SCRIPTS_DIR) not in sys.path:
-    sys.path.insert(0, str(_SCRIPTS_DIR))
-
 import account_broker
 import invoke_code_review as invoker
-import resolve_worker_spawn as dispatcher  # noqa: E402
+import resolve_worker_spawn as dispatcher
 from dev_env_scripts_constants.account_broker_constants import (
     Account,
     BrokerConfigurationError,
@@ -28,7 +23,7 @@ from dev_env_scripts_constants.account_broker_constants import (
     ProductAdapter,
     WAIT_EXIT_CODE,
 )
-from dev_env_scripts_constants.grok_worker_constants import (  # noqa: E402
+from dev_env_scripts_constants.grok_worker_constants import (
     AGENT_FLAG,
     CLI_AGENT_FLAG,
     ALL_AGENT_FILENAMES_BY_ROLE,
@@ -67,12 +62,12 @@ from dev_env_scripts_constants.grok_worker_constants import (  # noqa: E402
     TIER_CLAUDE_HEADLESS,
     TIER_GROK,
 )
-import grok_headless_runner  # noqa: E402
-from grok_headless_runner import (  # noqa: E402
+import grok_headless_runner
+from grok_headless_runner import (
     GrokRunnerOutcome,
     run_headless_worker,
 )
-from grok_worker_preflight import PreflightOutcome  # noqa: E402
+from grok_worker_preflight import PreflightOutcome
 
 HOST_PROFILE_CLAUDE = "Claude"
 HOST_PROFILE_THIRD_PARTY = "ThirdParty"

package/scripts/test_setup_project_paths.py

@@ -3,23 +3,11 @@
 import inspect
 import json
 import subprocess
-import sys
 from pathlib import Path
 from unittest.mock import patch
 
 import pytest
 
-_SCRIPTS_DIR = Path(__file__).resolve().parent
-_HOOKS_DIR = _SCRIPTS_DIR.parent / "hooks"
-_SESSION_HOOKS_PACKAGE_DIR = _SCRIPTS_DIR.parent / "hooks" / "session"
-for each_sys_path_entry in (
-    str(_SCRIPTS_DIR),
-    str(_HOOKS_DIR),
-    str(_SESSION_HOOKS_PACKAGE_DIR),
-):
-    if each_sys_path_entry not in sys.path:
-        sys.path.insert(0, each_sys_path_entry)
-
 import setup_project_paths as setup
 import untracked_repo_detector as detector_module
 from hooks_constants.project_paths_reader import registry_file_path

package/scripts/test_shared_tree_paths.py

@@ -9,12 +9,8 @@ from pathlib import Path
 
 import pytest
 
-_SCRIPTS_DIR = Path(__file__).resolve().parent
-if str(_SCRIPTS_DIR) not in sys.path:
-    sys.path.insert(0, str(_SCRIPTS_DIR))
-
-import shared_tree_paths  # noqa: E402
-from dev_env_scripts_constants.grok_worker_constants import (  # noqa: E402
+import shared_tree_paths
+from dev_env_scripts_constants.grok_worker_constants import (
     CLAUDE_CONFIG_DIR_ENV_VAR,
     PROCESS_TREE_DIRECTORY_NAME,
     PROCESS_TREE_KILL_MODULE_FILENAME,

package/scripts/test_validate_instruction_pairs.py

@@ -1,8 +1,6 @@
 import subprocess
 from pathlib import Path
 
-import sys
-
 from validate_instruction_pairs import (
     GATE_FAILED_EXIT_CODE,
     GATE_PASSED_EXIT_CODE,
@@ -10,11 +8,6 @@ from validate_instruction_pairs import (
     run_gate,
     validate_repository,
 )
-
-_hooks_directory = str(Path(__file__).resolve().parents[1] / "hooks")
-if _hooks_directory not in sys.path:
-    sys.path.insert(0, _hooks_directory)
-
 from followup_ledger import all_recorded_findings, head_commit
 from hooks_constants.followup_ledger_constants import SEVERITY_SMELL
 

package/scripts/test_verify_installable_package.py

@@ -6,14 +6,9 @@ command walking without requiring a full npm pack on every case.
 
 from __future__ import annotations
 
-import sys
 import tarfile
 from pathlib import Path
 
-_SCRIPTS_DIR = Path(__file__).resolve().parent
-if str(_SCRIPTS_DIR) not in sys.path:
-    sys.path.insert(0, str(_SCRIPTS_DIR))
-
 import verify_installable_package as mod
 from dev_env_scripts_constants.verify_installable_package_constants import (
     CLASS_PACKAGED,

package/scripts/tests/test_contrast_framing.py

@@ -89,12 +89,12 @@ def test_form_named_rejects_an_unknown_name() -> None:
         form_named("no-such-form")
 
 
-def test_every_form_is_named_in_the_rule_document() -> None:
-    rule_text = (PACKAGE_ROOT / CONTRAST_FRAMING_RULE_DOCUMENT).read_text(
+def test_every_form_is_named_in_the_rule_guide() -> None:
+    guide_text = (PACKAGE_ROOT / CONTRAST_FRAMING_RULE_DOCUMENT).read_text(
         encoding="utf-8"
     )
     for each_form in ALL_CONTRAST_FRAMING_FORMS:
-        assert f"`{each_form.name}`" in rule_text
+        assert f"`{each_form.name}`" in guide_text
 
 
 def test_a_list_of_not_items_stays_quiet() -> None:

package/scripts/tests/test_followup_ledger_duplicates.py

@@ -0,0 +1,58 @@
+"""Behavior tests for the committed follow-up ledger duplicate check."""
+
+from __future__ import annotations
+
+import sys
+from pathlib import Path
+
+_TESTS_DIRECTORY = Path(__file__).resolve().parent
+if str(_TESTS_DIRECTORY) not in sys.path:
+    sys.path.insert(0, str(_TESTS_DIRECTORY))
+
+from repository_checks.config.constants import (
+    CHECK_ID_FOLLOWUP_LEDGER_DUPLICATES,
+    FINDINGS_EXIT_CODE,
+    SUCCESS_EXIT_CODE,
+)
+from repository_policy_test_support import (
+    commit_tracked_files,
+    initialize_repository,
+    run_policy,
+    write_text,
+)
+
+_LEDGER_RELATIVE_PATH = ".claude/followups/smells.jsonl"
+
+
+def test_should_flag_a_committed_ledger_with_a_repeated_line(tmp_path: Path) -> None:
+    repository_root = tmp_path / "repo"
+    initialize_repository(repository_root)
+    write_text(
+        repository_root / _LEDGER_RELATIVE_PATH,
+        '{"rule_id": "a"}\n{"rule_id": "b"}\n{"rule_id": "a"}\n',
+    )
+    commit_tracked_files(repository_root)
+
+    exit_code, stdout_text, _stderr_text = run_policy(repository_root)
+
+    assert exit_code == FINDINGS_EXIT_CODE
+    assert (
+        f"{CHECK_ID_FOLLOWUP_LEDGER_DUPLICATES}: {_LEDGER_RELATIVE_PATH}:"
+        in stdout_text
+    )
+    assert "cde followup dedupe" in stdout_text
+
+
+def test_should_pass_a_committed_ledger_without_repeats(tmp_path: Path) -> None:
+    repository_root = tmp_path / "repo"
+    initialize_repository(repository_root)
+    write_text(
+        repository_root / _LEDGER_RELATIVE_PATH,
+        '{"rule_id": "a"}\n{"rule_id": "b"}\n',
+    )
+    commit_tracked_files(repository_root)
+
+    exit_code, stdout_text, _stderr_text = run_policy(repository_root)
+
+    assert exit_code == SUCCESS_EXIT_CODE
+    assert stdout_text == ""

package/scripts/tests/test_repository_policy.py

@@ -17,6 +17,7 @@ import repository_policy
 from repository_checks.config.constants import (
     CHECK_ID_CLAUDE_MD_ORPHANS,
     CHECK_ID_ENV_VAR_DOCUMENTATION,
+    CHECK_ID_FOLLOWUP_LEDGER_DUPLICATES,
     CHECK_ID_PACKAGE_INVENTORY,
     CHECK_ID_PYTEST_TESTPATHS,
     CHECK_ID_TRACKED_PERSONAL_DATA,
@@ -50,6 +51,7 @@ def test_should_keep_stable_check_identifiers() -> None:
     assert repository_policy.ALL_CHECK_IDS == (
         CHECK_ID_CLAUDE_MD_ORPHANS,
         CHECK_ID_ENV_VAR_DOCUMENTATION,
+        CHECK_ID_FOLLOWUP_LEDGER_DUPLICATES,
         CHECK_ID_PACKAGE_INVENTORY,
         CHECK_ID_PYTEST_TESTPATHS,
         CHECK_ID_TRACKED_PERSONAL_DATA,

package/scripts/tests/test_rule_index_shape.py

@@ -1,4 +1,4 @@
-"""Each rule entry keeps the index shape, and the always-loaded entries stay inside a byte budget."""
+"""The rules index and each rule entry keep their shape, and the always-loaded rules stay inside a byte budget."""
 
 import re
 import sys
@@ -28,11 +28,16 @@ DOUBLED_WHEN_LEAD_IN_PATTERN = re.compile(
     r"^\*\*When(?: this applies)?:\*\* When\b", re.MULTILINE
 )
 
+INDEX_LINE_PATTERN = re.compile(r"^- \*\*[^*]+\*\*(?: \(\[guide\]\((\.\./docs/rule-guides/[^)#\s]+\.md)\)\))?\. \S")
+INDEX_SKILL_POINTER_PATTERN = re.compile(r"the `[a-z-]+` skill")
+
+INDEX_FILE_NAME = "index.md"
+INDEX_PATH = RULES_DIRECTORY / INDEX_FILE_NAME
 MAXIMUM_ENTRY_BYTES = 1_500
-MAXIMUM_ALWAYS_ON_BYTES = 12_000
-POINTER_ENTRY_NAMES = frozenset({"skill-pointers.md"})
+MAXIMUM_INDEX_BYTES = 4_000
+MAXIMUM_ALWAYS_ON_BYTES = 6_000
 CODEX_VERBATIM_ENTRY_NAMES = frozenset({"question-presentation.md"})
-INDEX_SHAPE_EXEMPT_ENTRY_NAMES = POINTER_ENTRY_NAMES | CODEX_VERBATIM_ENTRY_NAMES
+INDEX_SHAPE_EXEMPT_ENTRY_NAMES = CODEX_VERBATIM_ENTRY_NAMES
 CODEX_MATERIALIZED_GUIDE_NAMES = frozenset(
     Path(each_path).name for each_path in codex_instruction_rule_relative_paths
 )
@@ -43,6 +48,7 @@ def _entry_paths() -> list[Path]:
         each_path
         for each_path in RULES_DIRECTORY.glob("*.md")
         if each_path.name not in instruction_alias_filenames
+        and each_path.name != INDEX_FILE_NAME
     )
 
 
@@ -183,11 +189,59 @@ def test_each_entry_links_a_full_text_guide_that_exists() -> None:
     assert all_problems == []
 
 
+def _index_lines() -> list[str]:
+    return [
+        each_line
+        for each_line in INDEX_PATH.read_text(encoding="utf-8").splitlines()
+        if each_line.startswith("- ")
+    ]
+
+
+def _index_guide_names() -> list[str]:
+    return [
+        Path(each_match.group(1)).name
+        for each_line in _index_lines()
+        if (each_match := INDEX_LINE_PATTERN.match(each_line)) and each_match.group(1)
+    ]
+
+
+def test_each_index_line_names_a_rule_and_a_trigger() -> None:
+    malformed = [
+        each_line for each_line in _index_lines() if not INDEX_LINE_PATTERN.match(each_line)
+    ]
+    assert malformed == []
+
+
+def test_each_index_line_links_a_guide_or_names_a_skill() -> None:
+    unlinked = [
+        each_line
+        for each_line in _index_lines()
+        if not INDEX_LINE_PATTERN.match(each_line).group(1)
+        and not INDEX_SKILL_POINTER_PATTERN.search(each_line)
+    ]
+    assert unlinked == []
+
+
+def test_each_index_guide_exists() -> None:
+    missing = [
+        each_guide_name
+        for each_guide_name in _index_guide_names()
+        if not (RULE_GUIDES_DIRECTORY / each_guide_name).is_file()
+    ]
+    assert missing == []
+
+
+def test_index_stays_inside_its_byte_budget() -> None:
+    assert len(INDEX_PATH.read_bytes()) <= MAXIMUM_INDEX_BYTES
+
+
 def test_each_guide_has_exactly_one_owner() -> None:
     owners_by_guide: dict[str, list[str]] = {}
     for each_path in _entry_paths():
         for each_guide_name in _linked_guide_names(_entry_text(each_path)):
             owners_by_guide.setdefault(each_guide_name, []).append(each_path.name)
+    for each_guide_name in _index_guide_names():
+        owners_by_guide.setdefault(each_guide_name, []).append(INDEX_FILE_NAME)
     unowned = sorted(
         each_guide.name
         for each_guide in RULE_GUIDES_DIRECTORY.glob("*.md")
@@ -204,7 +258,7 @@ def test_each_guide_has_exactly_one_owner() -> None:
 
 
 def test_always_loaded_entries_stay_inside_the_total_byte_budget() -> None:
-    always_on_bytes = sum(
+    always_on_bytes = len(INDEX_PATH.read_bytes()) + sum(
         len(each_path.read_bytes())
         for each_path in _entry_paths()
         if _loads_in_every_session(_entry_text(each_path))

package/scripts/tests/test_rule_load_scopes.py

@@ -8,24 +8,9 @@ SKILLS_DIRECTORY = PACKAGE_ROOT / ".agents" / "skills"
 
 ALWAYS_ON_RULE_NAMES = frozenset(
     {
-        "asd-ste100-language.md",
-        "cleanup-temp-files.md",
         "correction-lens.md",
-        "destructive-commands.md",
-        "explore-thoroughly.md",
-        "features-start-with-an-eval.md",
-        "filesystem-search.md",
-        "memory-stores-durable-facts.md",
-        "no-contrast-framing.md",
-        "proof-before-pull-request.md",
+        "index.md",
         "question-presentation.md",
-        "research-mode.md",
-        "request-scope.md",
-        "session-title.md",
-        "skill-pointers.md",
-        "shell-invocation.md",
-        "verify-before-asking.md",
-        "verify-runtime-state.md",
     }
 )
 

package/settings.json

@@ -7,6 +7,15 @@
     ]
   },
   "advisorModel": "fable",
+  "autoCompactWindow": 350000,
+  "modelSettings": {
+    "claude-haiku-5-5": {
+      "autoCompactWindow": 100000
+    },
+    "claude-haiku-4-5": {
+      "autoCompactWindow": 100000
+    }
+  },
   "autoMode": {
     "allow": [
       "$defaults",

package/system-prompts/software-engineer.xml

@@ -7,7 +7,7 @@
 </role>
 
 <task_scope>
-  Apply rules/asd-ste100-language.md for user-facing word choice, sentence style, tone, punctuation,
+  Apply docs/rule-guides/asd-ste100-language.md for user-facing word choice, sentence style, tone, punctuation,
   and prose form. Keep the behavior contracts below within their named scope.
   Defer to the user's judgment when they indicate a task is too ambitious or complex to pursue.
   Match the scope of every action to what the user explicitly requested: a bug fix delivers the
@@ -28,7 +28,7 @@
 <output_style>
   When a user-facing response needs beginner presentation, use ELI5: beginner framing, large
   visuals, minimal text, one stable self-contained HTML artifact, update-in-place continuity,
-  and sharing. Apply rules/asd-ste100-language.md to sentence-level prose inside that artifact.
+  and sharing. Apply docs/rule-guides/asd-ste100-language.md to sentence-level prose inside that artifact.
   Lead every response with the direct answer or result. Open with the substance — the
   conclusion, the fix, the decision — before any supporting context or explanation. Expand
   depth in proportion to the complexity of the ask: a direct question earns a sentence; a
@@ -67,7 +67,7 @@
   Reserve user questions for preferences, missing context the user holds, judgment calls, and
   scope decisions.
 
-  Source every claim as rules/research-mode.md describes.
+  Source every claim as docs/rule-guides/research-mode.md describes.
 </investigation>
 
 <problem_solving>
@@ -363,7 +363,7 @@
   Visible output is concise by default. The first progress update is one sentence.
   Later updates mark only important discoveries or direction changes. The final
   response begins with the outcome.
-  Language policy: rules/asd-ste100-language.md. This section owns visible progress,
+  Language policy: docs/rule-guides/asd-ste100-language.md. This section owns visible progress,
   tool narration, and outcome-first final structure.
 </communication_contract>