claude-dev-env 8.73.1 → 8.73.2

package/hooks/visual_reply_rules.py

@@ -0,0 +1,268 @@
+"""The visual reply mode rule list and the checks the reply length gate runs from it.
+
+One JSON file, ``rules/visual-reply-rules.json``, holds the rules. The gate,
+the reminder and the evaluation read the same file, so all three name each
+rule with the same label and the same reminder text.
+
+The mode is off unless ``~/.claude/visual-reply-mode.json`` holds
+``{"enabled": true}``.
+"""
+
+from __future__ import annotations
+
+import json
+import re
+from collections.abc import Iterable
+from dataclasses import dataclass
+from pathlib import Path
+
+from json_file_reader import read_json_object
+from hooks_constants.visual_reply_rules_constants import (
+    ABBREVIATION_MESSAGE,
+    ABBREVIATIONS_RULE_KEY,
+    ALL_REPLY_TOOL_NAME_SUFFIXES,
+    ALL_VISUAL_TOOL_NAME_SUFFIXES,
+    ALLOWED_CAPITALIZED_WORDS_KEY,
+    ASSISTANT_ENTRY_TYPE,
+    BLOCK_ID_KEY,
+    BLOCK_NAME_KEY,
+    BLOCK_TYPE_KEY,
+    CAPITALIZED_ABBREVIATION_PATTERN,
+    CONTENT_KEY,
+    ENTRY_TYPE_KEY,
+    IS_ERROR_KEY,
+    IS_META_KEY,
+    LOWERCASE_ABBREVIATION_TEMPLATE,
+    LOWERCASE_ABBREVIATIONS_KEY,
+    MAXIMUM_REPLIES_PER_TURN,
+    MAXIMUM_SENTENCES_WITHOUT_VISUAL,
+    MESSAGE_KEY,
+    MODE_SWITCH_ENABLED_KEY,
+    MODE_SWITCH_FILE_NAME,
+    NO_PICTURE_RULE_KEY,
+    NO_VISUAL_MESSAGE,
+    ONE_ITEM_RULE_KEY,
+    RULE_KEY_FIELD,
+    RULE_LABEL_FIELD,
+    RULE_REMINDER_FIELD,
+    RULES_FILE_ENCODING,
+    RULES_FILE_PATH,
+    RULES_LIST_KEY,
+    SECOND_REPLY_MESSAGE,
+    TEXT_BLOCK_TYPE,
+    TOOL_RESULT_BLOCK_TYPE,
+    TOOL_USE_BLOCK_TYPE,
+    TOOL_USE_ID_KEY,
+    TRACKER_NUMBER_MESSAGE,
+    TRACKER_NUMBER_PATTERN,
+    TRANSCRIPT_ENCODING,
+    USER_ENTRY_TYPE,
+    WIDGET_ANCHOR_MESSAGE,
+    WIDGET_ANCHOR_PATTERN,
+    WIDGET_TOOL_NAME_SUFFIX,
+)
+
+
+@dataclass(frozen=True)
+class ReplyRule:
+    """One rule of the mode: its key, the label a flag shows, and the reminder text."""
+
+    key: str
+    label: str
+    reminder: str
+
+
+@dataclass(frozen=True)
+class VisualReplyRules:
+    """The parsed rule file."""
+
+    all_rules: tuple[ReplyRule, ...]
+    all_allowed_capitalized_words: frozenset[str]
+    all_lowercase_abbreviations: tuple[str, ...]
+
+    def reminder(self, rule_key: str) -> str:
+        """Return the reminder text for one rule key."""
+        return next(each.reminder for each in self.all_rules if each.key == rule_key)
+
+
+def _string_list(field_value: object) -> list[object]:
+    return field_value if isinstance(field_value, list) else []
+
+
+def load_rules(rules_path: Path = RULES_FILE_PATH) -> VisualReplyRules | None:
+    """Parse the rule file, or return None when it is missing or malformed."""
+    document = read_json_object(rules_path, RULES_FILE_ENCODING)
+    if document is None:
+        return None
+    all_rule_entries = document.get(RULES_LIST_KEY)
+    if not isinstance(all_rule_entries, list):
+        return None
+    all_rules = tuple(
+        ReplyRule(
+            key=str(each[RULE_KEY_FIELD]),
+            label=str(each[RULE_LABEL_FIELD]),
+            reminder=str(each[RULE_REMINDER_FIELD]),
+        )
+        for each in all_rule_entries
+        if isinstance(each, dict)
+        and all(field in each for field in (RULE_KEY_FIELD, RULE_LABEL_FIELD, RULE_REMINDER_FIELD))
+    )
+    all_needed_keys = {ONE_ITEM_RULE_KEY, NO_PICTURE_RULE_KEY, ABBREVIATIONS_RULE_KEY}
+    if not all_needed_keys <= {each.key for each in all_rules}:
+        return None
+    return VisualReplyRules(
+        all_rules=all_rules,
+        all_allowed_capitalized_words=frozenset(
+            str(each) for each in _string_list(document.get(ALLOWED_CAPITALIZED_WORDS_KEY))
+        ),
+        all_lowercase_abbreviations=tuple(
+            str(each) for each in _string_list(document.get(LOWERCASE_ABBREVIATIONS_KEY))
+        ),
+    )
+
+
+def mode_enabled(claude_home: Path) -> bool:
+    """Return True only when the switch file turns the mode on."""
+    switch_document = read_json_object(claude_home / MODE_SWITCH_FILE_NAME, RULES_FILE_ENCODING)
+    if switch_document is None:
+        return False
+    return switch_document.get(MODE_SWITCH_ENABLED_KEY) is True
+
+
+def abbreviation_violation(prose_text: str, rules: VisualReplyRules) -> str | None:
+    """Return the deny reason for the first abbreviation in prose with links and code removed."""
+    reminder = rules.reminder(ABBREVIATIONS_RULE_KEY)
+    for each_match in CAPITALIZED_ABBREVIATION_PATTERN.finditer(prose_text):
+        if each_match.group(0) not in rules.all_allowed_capitalized_words:
+            return ABBREVIATION_MESSAGE.format(abbreviation=each_match.group(0), reminder=reminder)
+    for each_abbreviation in rules.all_lowercase_abbreviations:
+        pattern = LOWERCASE_ABBREVIATION_TEMPLATE.format(abbreviation=re.escape(each_abbreviation))
+        if re.search(pattern, prose_text, re.IGNORECASE):
+            return ABBREVIATION_MESSAGE.format(abbreviation=each_abbreviation, reminder=reminder)
+    tracker_match = TRACKER_NUMBER_PATTERN.search(prose_text)
+    if tracker_match is not None:
+        return TRACKER_NUMBER_MESSAGE.format(reference=tracker_match.group(0), reminder=reminder)
+    return None
+
+
+def widget_anchor_violation(tool_name: str, all_tool_input: dict[str, object]) -> str | None:
+    """Return the deny reason for an anchor link inside widget code."""
+    if not tool_name.endswith(WIDGET_TOOL_NAME_SUFFIX):
+        return None
+    serialized_input = json.dumps(all_tool_input)
+    return WIDGET_ANCHOR_MESSAGE if WIDGET_ANCHOR_PATTERN.search(serialized_input) else None
+
+
+def _parsed_entries(all_transcript_lines: Iterable[str]) -> list[dict[str, object]]:
+    all_entries = []
+    for each_line in all_transcript_lines:
+        try:
+            parsed_entry = json.loads(each_line)
+        except json.JSONDecodeError:
+            continue
+        if isinstance(parsed_entry, dict):
+            all_entries.append(parsed_entry)
+    return all_entries
+
+
+def _is_prompt_entry(all_entry_fields: dict[str, object]) -> bool:
+    if all_entry_fields.get(ENTRY_TYPE_KEY) != USER_ENTRY_TYPE or all_entry_fields.get(IS_META_KEY):
+        return False
+    message = all_entry_fields.get(MESSAGE_KEY)
+    content = message.get(CONTENT_KEY) if isinstance(message, dict) else None
+    if isinstance(content, str):
+        return bool(content.strip())
+    return isinstance(content, list) and any(
+        isinstance(each_block, dict) and each_block.get(BLOCK_TYPE_KEY) == TEXT_BLOCK_TYPE
+        for each_block in content
+    )
+
+
+def _content_blocks(all_entry_fields: dict[str, object], entry_type: str) -> list[dict[str, object]]:
+    if all_entry_fields.get(ENTRY_TYPE_KEY) != entry_type:
+        return []
+    message = all_entry_fields.get(MESSAGE_KEY)
+    content = message.get(CONTENT_KEY) if isinstance(message, dict) else None
+    return [each for each in (content if isinstance(content, list) else []) if isinstance(each, dict)]
+
+
+def _tool_uses(all_entry_fields: dict[str, object]) -> list[dict[str, object]]:
+    return [
+        each_block
+        for each_block in _content_blocks(all_entry_fields, ASSISTANT_ENTRY_TYPE)
+        if each_block.get(BLOCK_TYPE_KEY) == TOOL_USE_BLOCK_TYPE
+    ]
+
+
+def _entries_this_turn(all_transcript_lines: Iterable[str]) -> list[dict[str, object]]:
+    all_entries = _parsed_entries(all_transcript_lines)
+    last_prompt_index = max(
+        (index for index, each in enumerate(all_entries) if _is_prompt_entry(each)), default=-1
+    )
+    return all_entries[last_prompt_index + 1 :]
+
+
+def _read_transcript_lines(transcript_path: object) -> list[str] | None:
+    if not isinstance(transcript_path, str):
+        return None
+    try:
+        return Path(transcript_path).read_text(encoding=TRANSCRIPT_ENCODING).splitlines()
+    except OSError:
+        return None
+
+
+def _result_ids(all_entries: list[dict[str, object]], is_error: bool) -> set[object]:
+    return {
+        each_block.get(TOOL_USE_ID_KEY)
+        for each_entry in all_entries
+        for each_block in _content_blocks(each_entry, USER_ENTRY_TYPE)
+        if each_block.get(BLOCK_TYPE_KEY) == TOOL_RESULT_BLOCK_TYPE
+        and bool(each_block.get(IS_ERROR_KEY)) is is_error
+    }
+
+
+def visual_shown_this_turn(all_transcript_lines: Iterable[str]) -> bool:
+    """Return True when a widget or page call after the last prompt did not come back with an error."""
+    all_entries = _entries_this_turn(all_transcript_lines)
+    all_errored_ids = _result_ids(all_entries, is_error=True)
+    return any(
+        str(each_use.get(BLOCK_NAME_KEY)).endswith(ALL_VISUAL_TOOL_NAME_SUFFIXES)
+        and each_use.get(BLOCK_ID_KEY) not in all_errored_ids
+        for each_entry in all_entries
+        for each_use in _tool_uses(each_entry)
+    )
+
+
+def replies_sent_this_turn(all_transcript_lines: Iterable[str]) -> int:
+    """Count the reply calls after the last prompt that came back without an error."""
+    all_entries = _entries_this_turn(all_transcript_lines)
+    all_delivered_ids = _result_ids(all_entries, is_error=False)
+    return sum(
+        1
+        for each_entry in all_entries
+        for each_use in _tool_uses(each_entry)
+        if str(each_use.get(BLOCK_NAME_KEY)).endswith(ALL_REPLY_TOOL_NAME_SUFFIXES)
+        and each_use.get(BLOCK_ID_KEY) in all_delivered_ids
+    )
+
+
+def second_reply_violation(transcript_path: object, rules: VisualReplyRules) -> str | None:
+    """Return the deny reason for a reply when this turn already delivered one."""
+    all_lines = _read_transcript_lines(transcript_path)
+    if all_lines is None or replies_sent_this_turn(all_lines) < MAXIMUM_REPLIES_PER_TURN:
+        return None
+    return SECOND_REPLY_MESSAGE.format(reminder=rules.reminder(ONE_ITEM_RULE_KEY))
+
+
+def visual_violation(
+    sentence_count: int, transcript_path: object, rules: VisualReplyRules
+) -> str | None:
+    """Return the deny reason for a reply of several sentences with no visual this turn."""
+    if sentence_count <= MAXIMUM_SENTENCES_WITHOUT_VISUAL:
+        return None
+    all_lines = _read_transcript_lines(transcript_path)
+    if all_lines is None or visual_shown_this_turn(all_lines):
+        return None
+    return NO_VISUAL_MESSAGE.format(
+        sentence_count=sentence_count, reminder=rules.reminder(NO_PICTURE_RULE_KEY)
+    )

package/hooks/workflow/test_auto_formatter.py

@@ -9,14 +9,10 @@ The sandbox is rooted under the user's home directory via ``tempfile.mkdtemp``
 rather than the OS temp directory, matching the sibling workflow-hook tests.
 """
 
-import contextlib
 import functools
 import importlib.util
-import inspect
 import json
 import os
-import shutil
-import stat
 import subprocess
 import sys
 import tempfile
@@ -26,6 +22,8 @@ from types import ModuleType
 
 import pytest
 
+from hooks_constants.windows_filesystem import force_rmtree
+
 HOOK_SCRIPT_PATH = os.path.join(os.path.dirname(__file__), "auto_formatter.py")
 HOOKS_DIRECTORY_PATH = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
 POST_TOOL_USE_DISPATCHER_PATH = os.path.join(
@@ -52,25 +50,6 @@ def build_dispatcher_payload(tool_name: str, file_path: Path) -> str:
     return json.dumps({"tool_name": tool_name, "tool_input": {"file_path": str(file_path)}})
 
 
-def _strip_read_only_and_retry(removal_function, target_path, *_exc_info):
-    try:
-        os.chmod(target_path, stat.S_IWRITE)
-        removal_function(target_path)
-    except OSError:
-        pass
-
-
-_rmtree_supports_onexc = "onexc" in inspect.signature(shutil.rmtree).parameters
-
-
-def _force_rmtree(target_path: str) -> None:
-    with contextlib.suppress(OSError):
-        if _rmtree_supports_onexc:
-            shutil.rmtree(target_path, onexc=_strip_read_only_and_retry)
-        else:
-            shutil.rmtree(target_path, onerror=_strip_read_only_and_retry)
-
-
 @functools.lru_cache(maxsize=1)
 def _get_sandbox_parent_directory() -> str:
     return tempfile.mkdtemp(prefix="pytest_auto_formatter_", dir=str(Path.home()))
@@ -80,7 +59,7 @@ def _get_sandbox_parent_directory() -> str:
 def _cleanup_sandbox_parent_directory() -> Generator[None]:
     yield
     if _get_sandbox_parent_directory.cache_info().currsize:
-        _force_rmtree(_get_sandbox_parent_directory())
+        force_rmtree(_get_sandbox_parent_directory())
         _get_sandbox_parent_directory.cache_clear()
 
 
@@ -95,7 +74,7 @@ def git_repository() -> Generator[Path]:
         env=build_fixture_git_environment(),
     )
     yield repository_path
-    _force_rmtree(str(repository_path))
+    force_rmtree(str(repository_path))
 
 
 def _run_hook(tool_name: str, file_path: Path) -> subprocess.CompletedProcess[str]:

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.73.1",
+    "version": "8.73.2",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {

package/rules/index.md

@@ -0,0 +1,30 @@
+# Rules
+Each line gives a rule in brief. When its trigger matches your task, open the guide and follow it in full. Correction lens and question presentation load as their own files.
+
+**Writing**
+- **Plain language** ([guide](../docs/rule-guides/asd-ste100-language.md)). Writing chat, narration, or repository prose. Short complete sentences on one topic, active voice, one action per step, each fact said once.
+- **No contrast framing** ([guide](../docs/rule-guides/no-contrast-framing.md)). Any sentence a person reads. State the chosen point and leave out the discarded reading. Remove the six forms: `trailing-comma-not`, `corrective-it-is-not`, `substitution-rather-than`, `additive-not-just`, `comparative-ranking`, `substitution-as-opposed-to`.
+
+**Evidence**
+- **Research mode** ([guide](../docs/rule-guides/research-mode.md)). Any claim, recommendation, or advice. Cite a source for each claim, and run the tool that settles a fact before you state it.
+- **Verify before asking** ([guide](../docs/rule-guides/verify-before-asking.md)). Before a clarifying question. Look in files, config, environment, and tools first; ask only for a judgment or a preference.
+- **Verify runtime state** ([guide](../docs/rule-guides/verify-runtime-state.md)). Before you say a component works, is healthy, or is not the cause. Get a live signal this session.
+
+**Before building**
+- **Explore thoroughly** ([guide](../docs/rule-guides/explore-thoroughly.md)). Before you log, plan, delegate, or build an ask. Search for existing work; when something exists, stop and report it in four points with the `search-before-acting` skill.
+- **Features start with an eval** ([guide](../docs/rule-guides/features-start-with-an-eval.md)). A new feature or a change in behavior. Your first action is the Skill tool with skill `claude-api` and args `build-eval`.
+- **Request scope** ([guide](../docs/rule-guides/request-scope.md)). Asked whether part of a block is still needed, or asked to change one. Propose removing every line a shipped gate already enforces.
+
+**Shell and files**
+- **Shell invocation** ([guide](../docs/rule-guides/shell-invocation.md)). Any Bash command or permission rule. Use `pwsh` on Windows; keep `$(...)`, backticks, and process substitution out of commands.
+- **Destructive commands** ([guide](../docs/rule-guides/destructive-commands.md)). Removing files. Keep `rm` literals out of commands, use absolute targets, use `git rm` for tracked files, and copy the guide's no-rm line into subagent prompts.
+- **Filesystem search** ([guide](../docs/rule-guides/filesystem-search.md)). Finding files by name, path, size, or date. Scope the search to a project, worktree, or filter, never a root.
+- **Clean up temporary files** ([guide](../docs/rule-guides/cleanup-temp-files.md)). Creating scratch files or debug dumps. Track them and remove them when the task ends.
+
+**Shipping**
+- **Pull request lifecycle**. Before a commit, push, pull request action, or merge. Invoke the `pr-lifecycle` skill; a hook denies those commands until it loads.
+- **Proof before a pull request** ([guide](../docs/rule-guides/proof-before-pull-request.md)). Before you open a pull request. Run the change with and without it, and quote both under "Proof in practice".
+- **Session title** ([guide](../docs/rule-guides/session-title.md)). The session has a tool whose name ends in `__set_session_title`. Set `<emoji> <name>` before each turn ends.
+
+**Memory**
+- **Durable facts only** ([guide](../docs/rule-guides/memory-stores-durable-facts.md)). Writing auto-memory or a `MEMORY.md` entry. Keep only a fact that helps a fresh session weeks later.

package/rules/visual-reply-rules.json

@@ -0,0 +1,41 @@
+{
+  "rules": [
+    {
+      "key": "one_item",
+      "label": "More than one item",
+      "reminder": "Show one item per turn: one visual of that item and one short reply beside it. Put progress in the status line, and send the next item after the user answers this one."
+    },
+    {
+      "key": "no_picture",
+      "label": "No picture",
+      "reminder": "Show the item as one visual first, a widget or a published page. Then send one reply of one to three short sentences that states the outcome and each fact the user needs, and links the page."
+    },
+    {
+      "key": "too_many_words",
+      "label": "Too many words",
+      "reminder": "Cut the reply to three short sentences or fewer. Keep the outcome and each fact the user needs in the reply; the visual adds detail around them."
+    },
+    {
+      "key": "abbreviations",
+      "label": "Abbreviations",
+      "reminder": "Write each name in plain descriptive words. Spell out every abbreviation and drop tracker and item numbers. A pull request number stays only inside its link."
+    },
+    {
+      "key": "wall_of_text",
+      "label": "Wall of text",
+      "reminder": "Put each point, and each step the reader takes, on its own line."
+    }
+  ],
+  "allowed_capitalized_words": [
+    "I",
+    "OK"
+  ],
+  "lowercase_abbreviations": [
+    "e.g.",
+    "i.e.",
+    "etc.",
+    "vs.",
+    "approx.",
+    "w/"
+  ]
+}

package/scripts/Migrate-ShellPolicy.ps1

@@ -9,7 +9,7 @@
     settings.local.json, and settings.local.json.template, and rewrites permission
     rule strings that invoke powershell / powershell.exe / bash -c / cmd /c
     into their pwsh equivalents per the migration mapping in
-    rules/shell-invocation.md. Defaults to dry-run; pass -Apply to write
+    docs/rule-guides/shell-invocation.md. Defaults to dry-run; pass -Apply to write
     changes. Prints exactly one summary line.
 
 .PARAMETER Roots

package/scripts/conftest.py

@@ -1,8 +1,10 @@
-"""Put the scripts directory on ``sys.path`` for every test in this folder.
+"""Put the scripts and hooks directories on ``sys.path`` for every test here.
 
 The code-review invoker and its constants package live beside these tests
 rather than on the default pytest path, so each test module can import them
-by bare name once this directory is registered.
+by bare name once this directory is registered. The hooks directory and its
+session package are registered too, so a test imports ``followup_ledger``,
+``hooks_constants``, or ``untracked_repo_detector`` by bare name.
 
 ::
 
@@ -21,9 +23,15 @@ from pathlib import Path
 
 import pytest
 
-_scripts_directory = str(Path(__file__).resolve().parent)
-if _scripts_directory not in sys.path:
-    sys.path.insert(0, _scripts_directory)
+_scripts_directory = Path(__file__).resolve().parent
+_hooks_directory = _scripts_directory.parent / "hooks"
+for each_import_directory in (
+    _hooks_directory / "session",
+    _hooks_directory,
+    _scripts_directory,
+):
+    if str(each_import_directory) not in sys.path:
+        sys.path.insert(0, str(each_import_directory))
 
 _live_broker_state_resolver = importlib.import_module("account_broker_support").broker_state_path
 

package/scripts/dev_env_scripts_constants/contrast_framing_constants.py

@@ -8,7 +8,7 @@ against a rejected reading::
     "precision matters more than coverage" -> comparative-ranking
     ok: "the function runs more than 30 lines"
 
-The rule file ``rules/no-contrast-framing.md`` names each form here in
+The rule guide ``docs/rule-guides/no-contrast-framing.md`` names each form here in
 backticks, and a test holds the two in step.
 """
 
@@ -79,4 +79,4 @@ CONTRAST_FRAMING_QUOTED_LINE_LIMIT: int = 120
 
 CONTRAST_FRAMING_FINDING_CODE: str = "contrast-framing"
 
-CONTRAST_FRAMING_RULE_DOCUMENT: str = "rules/no-contrast-framing.md"
+CONTRAST_FRAMING_RULE_DOCUMENT: str = "docs/rule-guides/no-contrast-framing.md"

package/scripts/dev_env_scripts_constants/test_contrast_framing_constants.py

@@ -2,11 +2,23 @@
 
 from __future__ import annotations
 
+from pathlib import Path
+
 from dev_env_scripts_constants.contrast_framing_constants import (
     ALL_CONTRAST_FRAMING_FORMS,
     CONTRAST_FRAMING_MESSAGE_TEMPLATE,
+    CONTRAST_FRAMING_RULE_DOCUMENT,
 )
 
+PACKAGE_ROOT = Path(__file__).resolve().parents[2]
+
+
+def test_the_rule_document_is_a_rule_guide_that_exists() -> None:
+    rule_document = PACKAGE_ROOT / CONTRAST_FRAMING_RULE_DOCUMENT
+
+    assert rule_document.parent.name == "rule-guides"
+    assert rule_document.is_file()
+
 
 def test_every_form_carries_a_distinct_name() -> None:
     all_names = [each_form.name for each_form in ALL_CONTRAST_FRAMING_FORMS]

package/scripts/policy_lint/adapter_configuration.py

@@ -136,7 +136,6 @@ def _names_exempt_registration_path(registered_string: str) -> bool:
         hooks/blocking/session_title_format_gate.py      -> exempt
         hooks/blocking/session_title_stop_gate.py        -> exempt
         hooks/blocking/artifact_dark_mode_gate.py        -> exempt
-        hooks/blocking/artifact_look_gate.py             -> exempt
         hooks/blocking/some_new_blocker.py               -> flagged
 
     The Bash PreToolUse dispatcher sits under ``blocking/`` for layout reasons
@@ -161,10 +160,6 @@ def _names_exempt_registration_path(registered_string: str) -> bool:
     The verify-before-acting hook runs after a mutating call has finished. It
     asks the model to check a hedged claim, and the call it reads stays in place.
 
-    The artifact look gate denies an Artifact publish of a page until a
-    screenshot of it was read. It decides when a page ships and no code or
-    safety policy.
-
     The session title gates keep the session title in its status format. One
     denies a malformed title, and the other asks for a title before a turn
     ends. They decide the shape of a title and no code or safety policy.

package/scripts/policy_lint/config/constants.py

@@ -73,7 +73,6 @@ ALL_ACTION_BOUNDARY_EXEMPT_REGISTRATION_PATHS = (
     "blocking/session_title_stop_gate.py",
     "blocking/image_read_size_gate.py",
     "blocking/artifact_dark_mode_gate.py",
-    "blocking/artifact_look_gate.py",
 )
 ALL_TEST_DIRECTORY_NAMES = frozenset({"tests"})
 ALL_TEST_FILE_PREFIXES = ("test_",)

package/scripts/test_active_capability_references.py

@@ -2,13 +2,8 @@
 
 from __future__ import annotations
 
-import sys
 from pathlib import Path
 
-_SCRIPTS = Path(__file__).resolve().parent
-if str(_SCRIPTS) not in sys.path:
-    sys.path.insert(0, str(_SCRIPTS))
-
 from active_capability_references import (
     build_capability_inventory,
     classify_capability_reference,

package/scripts/test_broker_state_isolation.py

@@ -2,6 +2,7 @@
 
 from __future__ import annotations
 
+import json
 import subprocess
 from datetime import datetime, timezone
 from pathlib import Path
@@ -43,6 +44,5 @@ def test_meter_cache_write_lands_outside_the_home_directory(
 
     home_state_path = fake_home / ".claude" / "account-broker" / "state.json"
     assert not home_state_path.exists()
-    assert f"claude:only:{account.home}" in isolated_broker_state_path.read_text(
-        encoding="utf-8"
-    )
+    state = json.loads(isolated_broker_state_path.read_text(encoding="utf-8"))
+    assert f"claude:only:{account.home}" in state["meters"]

package/scripts/test_digest_check.py

@@ -2,15 +2,10 @@
 
 from __future__ import annotations
 
-import sys
 from pathlib import Path
 
 import pytest
 
-_SCRIPTS_DIRECTORY = Path(__file__).resolve().parent
-if str(_SCRIPTS_DIRECTORY) not in sys.path:
-    sys.path.insert(0, str(_SCRIPTS_DIRECTORY))
-
 import digest_check
 from dev_env_scripts_constants.digest_check_constants import (
     CARD_WORD_BUDGET,

package/scripts/test_durable_post_lint.py

@@ -9,14 +9,10 @@ from pathlib import Path
 
 import pytest
 
-_SCRIPTS_DIRECTORY = Path(__file__).resolve().parent
-if str(_SCRIPTS_DIRECTORY) not in sys.path:
-    sys.path.insert(0, str(_SCRIPTS_DIRECTORY))
-
 import durable_post_lint
 from dev_env_scripts_constants.private_term_constants import PrivateTermDigest
 
-SCRIPT_PATH = _SCRIPTS_DIRECTORY / "durable_post_lint.py"
+SCRIPT_PATH = Path(__file__).resolve().parent / "durable_post_lint.py"
 VALID_PR_BODY = """## Why
 
 Why text.

package/scripts/test_followup_cli.py

@@ -4,7 +4,6 @@ from __future__ import annotations
 
 import io
 import json
-import sys
 from pathlib import Path
 
 from dev_env_scripts_constants.followup_constants import (
@@ -14,11 +13,6 @@ from dev_env_scripts_constants.followup_constants import (
     FOLLOWUP_BACKLOG_THRESHOLD,
 )
 from followup_cli import main
-
-_hooks_directory = str(Path(__file__).resolve().parents[1] / "hooks")
-if _hooks_directory not in sys.path:
-    sys.path.insert(0, _hooks_directory)
-
 from followup_ledger import (
     FollowupFinding,
     all_recorded_findings,

package/scripts/test_resolve_worker_spawn.py

@@ -4,7 +4,6 @@ from __future__ import annotations
 
 import json
 import subprocess
-import sys
 import threading
 from dataclasses import dataclass, field
 from datetime import datetime, timezone
@@ -12,13 +11,9 @@ from pathlib import Path
 
 import pytest
 
-_SCRIPTS_DIR = Path(__file__).resolve().parent
-if str(_SCRIPTS_DIR) not in sys.path:
-    sys.path.insert(0, str(_SCRIPTS_DIR))
-
 import account_broker
 import invoke_code_review as invoker
-import resolve_worker_spawn as dispatcher  # noqa: E402
+import resolve_worker_spawn as dispatcher
 from dev_env_scripts_constants.account_broker_constants import (
     Account,
     BrokerConfigurationError,
@@ -28,7 +23,7 @@ from dev_env_scripts_constants.account_broker_constants import (
     ProductAdapter,
     WAIT_EXIT_CODE,
 )
-from dev_env_scripts_constants.grok_worker_constants import (  # noqa: E402
+from dev_env_scripts_constants.grok_worker_constants import (
     AGENT_FLAG,
     CLI_AGENT_FLAG,
     ALL_AGENT_FILENAMES_BY_ROLE,
@@ -67,12 +62,12 @@ from dev_env_scripts_constants.grok_worker_constants import (  # noqa: E402
     TIER_CLAUDE_HEADLESS,
     TIER_GROK,
 )
-import grok_headless_runner  # noqa: E402
-from grok_headless_runner import (  # noqa: E402
+import grok_headless_runner
+from grok_headless_runner import (
     GrokRunnerOutcome,
     run_headless_worker,
 )
-from grok_worker_preflight import PreflightOutcome  # noqa: E402
+from grok_worker_preflight import PreflightOutcome
 
 HOST_PROFILE_CLAUDE = "Claude"
 HOST_PROFILE_THIRD_PARTY = "ThirdParty"