claude-dev-env 8.72.0 → 8.72.2

package/hooks/session/test_advisor_rules_prompt.py

@@ -35,6 +35,7 @@ def _run_main() -> str:
 @pytest.fixture
 def config_directory(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> Path:
     monkeypatch.setenv(CLAUDE_CONFIG_DIR_ENV_VAR, str(tmp_path))
+    monkeypatch.delenv("CLAUDE_CODE_REMOTE", raising=False)
     monkeypatch.delenv(ADVISOR_DISABLE_ENV_VAR, raising=False)
     return tmp_path
 
@@ -56,6 +57,16 @@ class TestAdvisorRulesPrompt:
         _write_settings(config_directory, {"permissions": {}})
         assert _run_main() == ""
 
+    def test_should_emit_nothing_while_the_session_prompts_mod_is_on(
+        self, config_directory: Path, monkeypatch: pytest.MonkeyPatch
+    ) -> None:
+        monkeypatch.setenv("CLAUDE_PROJECT_DIR", str(config_directory))
+        _write_settings(
+            config_directory,
+            {"advisorModel": "fable", "enabledPlugins": {"session-prompts@mods-marketplace": True}},
+        )
+        assert _run_main() == ""
+
     def test_should_emit_nothing_when_advisor_model_is_blank(self, config_directory: Path) -> None:
         _write_settings(config_directory, {"advisorModel": "  "})
         assert _run_main() == ""

package/hooks/session/test_orchestrator_auto_starter.py

@@ -99,3 +99,25 @@ def test_main_stdin_disabled_prints_nothing() -> None:
     )
     assert completed.returncode == 0
     assert completed.stdout.strip() == ""
+
+
+def test_main_prints_nothing_while_the_session_prompts_mod_is_on(tmp_path: Path) -> None:
+    (tmp_path / "settings.json").write_text(
+        json.dumps({"enabledPlugins": {"session-prompts@mods-marketplace": True}}), encoding="utf-8"
+    )
+    completed = subprocess.run(
+        [sys.executable, str(STARTER_SCRIPT)],
+        input=json.dumps({"source": "startup"}),
+        capture_output=True,
+        text=True,
+        check=False,
+        env={
+            **os.environ,
+            ORCHESTRATOR_AUTO_STARTER_ENABLED_ENV_VAR: "1",
+            "CLAUDE_CONFIG_DIR": str(tmp_path),
+            "CLAUDE_CODE_REMOTE": "",
+            "CLAUDE_PROJECT_DIR": str(tmp_path),
+        },
+    )
+    assert completed.returncode == 0
+    assert completed.stdout.strip() == ""

package/hooks/session/test_task_tool_prompt.py

@@ -7,6 +7,8 @@ from io import StringIO
 from pathlib import Path
 from unittest.mock import patch
 
+import pytest
+
 _SESSION_DIR = Path(__file__).resolve().parent
 _HOOKS_ROOT = _SESSION_DIR.parent
 for each_sys_path_entry in (str(_SESSION_DIR), str(_HOOKS_ROOT)):
@@ -63,3 +65,16 @@ class TestSessionDirective:
 
     def test_build_session_directive_returns_the_shared_constant(self) -> None:
         assert prompt.build_session_directive() == TASK_TOOL_DIRECTIVE
+
+
+class TestModHandoff:
+    def test_should_stay_silent_while_the_session_prompts_mod_is_on(
+        self, tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+    ) -> None:
+        (tmp_path / "settings.json").write_text(
+            json.dumps({"enabledPlugins": {"session-prompts@mods-marketplace": True}}), encoding="utf-8"
+        )
+        monkeypatch.setenv("CLAUDE_CONFIG_DIR", str(tmp_path))
+        monkeypatch.delenv("CLAUDE_CODE_REMOTE", raising=False)
+        monkeypatch.setenv("CLAUDE_PROJECT_DIR", str(tmp_path))
+        assert _run_main() == ""

package/hooks/session/test_working_style_prompt.py

@@ -6,6 +6,8 @@ from io import StringIO
 from pathlib import Path
 from unittest.mock import patch
 
+import pytest
+
 _SESSION_DIR = Path(__file__).resolve().parent
 _HOOKS_ROOT = _SESSION_DIR.parent
 for each_sys_path_entry in (str(_SESSION_DIR), str(_HOOKS_ROOT)):
@@ -60,3 +62,16 @@ class TestWorkingStylePrompt:
 
     def test_build_session_directive_returns_the_shared_constant(self) -> None:
         assert starter.build_session_directive() == WORKING_STYLE_PROMPT
+
+
+class TestModHandoff:
+    def test_should_stay_silent_while_the_session_prompts_mod_is_on(
+        self, tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+    ) -> None:
+        (tmp_path / "settings.json").write_text(
+            json.dumps({"enabledPlugins": {"session-prompts@mods-marketplace": True}}), encoding="utf-8"
+        )
+        monkeypatch.setenv("CLAUDE_CONFIG_DIR", str(tmp_path))
+        monkeypatch.delenv("CLAUDE_CODE_REMOTE", raising=False)
+        monkeypatch.setenv("CLAUDE_PROJECT_DIR", str(tmp_path))
+        assert _run_main() == ""

package/hooks/session/working_style_prompt.py

@@ -17,6 +17,8 @@ _hooks_dir = str(Path(__file__).resolve().parent.parent)
 if _hooks_dir not in sys.path:
     sys.path.insert(0, _hooks_dir)
 
+from hooks_constants.mod_handoff import is_mod_plugin_enabled
+from hooks_constants.mod_handoff_constants import SESSION_PROMPTS_PLUGIN_NAME
 from hooks_constants.working_style_prompt_constants import (  # noqa: E402
     WORKING_STYLE_PROMPT,
 )
@@ -28,7 +30,9 @@ def build_session_directive() -> str:
 
 
 def main() -> None:
-    """Emit the working-style prompt as SessionStart additionalContext."""
+    """Emit the working-style prompt as SessionStart additionalContext, unless the session-prompts mod is on."""
+    if is_mod_plugin_enabled(SESSION_PROMPTS_PLUGIN_NAME):
+        return
     print(
         json.dumps(
             {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.72.0",
+    "version": "8.72.2",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {

package/rules/asd-ste100-language.md

@@ -2,7 +2,7 @@
 
 **When:** Writing chat, tool narration, or repository prose.
 
-Use the sole general language rule. Write short, complete sentences on one topic. Use active voice; lead with conditions; give one action per step. Use plain, precise words and stable terms. Expand abbreviations and contractions first; name unclear pronouns. Be inclusive; punctuate clearly. Preserve exact labels, identifiers, formulas, titles, and interface text. Send a result, blocker, or question. Mark injury or death `WARNING`, equipment damage `CAUTION`; state condition then result. Aim for 20 words per step, 25 per description. Treat checks as aids; have a human verify accuracy, terms, safety, confidentiality, and meaning.
+Use the sole general language rule. Write short, complete sentences on one topic. Use active voice; lead with conditions; one action per step. Use plain, precise words, stable terms. Expand abbreviations and contractions; name unclear pronouns. Be inclusive; punctuate clearly. Preserve exact labels, identifiers, formulas, titles, interface text. Say each fact once. Send a result, blocker, or question. Mark injury or death `WARNING`, equipment damage `CAUTION`; state condition then result. Aim for 20 words per step, 25 per description. Treat checks as aids; have a human verify accuracy, terms, safety, confidentiality, meaning.
 
 **Enforcement:** none.
 

package/scripts/dev_env_scripts_constants/review_closure_constants.py

@@ -155,6 +155,30 @@ summary, a Graphite verdict mirror whose findings arrive as review threads, a
 Qodo description of the change, a Qodo placeholder posted while it reviews, and
 a Qodo review that found nothing."""
 
+CODEX_REVIEW_BOT_LOGIN = "chatgpt-codex-connector[bot]"
+ALL_REVIEW_REQUEST_COMMANDS = ("@codex review", "@codex security review")
+ALL_CODEX_NOTICE_DETAILS = (
+    "<details> <summary>\u2139\ufe0f About Codex in GitHub</summary>\n<br/>\n\n[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you\n- Open a pull request for review\n- Mark a draft as ready\n- Comment \"@codex review\" or \"@codex security review\".\n\nCodex reacts with \U0001f440 while any review is running, comments if it has suggestions, and reacts with \U0001f44d once all reviews finish with no findings.\n\n</details>",
+    "<details> <summary>\u2139\ufe0f About Codex in GitHub</summary>\n<br/>\n\n[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you\n- Open a pull request for review\n- Mark a draft as ready\n- Comment \"@codex review\".\n\nIf Codex has suggestions, it will comment; otherwise it will react with \U0001f44d.\n\n\n\n\nCodex can also answer questions or update the PR. Try commenting \"@codex address that feedback\".\n            \n</details>",
+)
+CODEX_SUMMARY_PREFIX = (
+    "<!-- codex-pull-request-review-summary -->\n\n"
+    "## Codex Review Summary\n\n"
+    "This comment shows the latest Codex review activity on this pull request.\n\n"
+    "| Review | Status | Commit | Review trigger |\n"
+    "| --- | --- | --- | --- |\n"
+)
+CODEX_SUMMARY_ROW_PATTERN = (
+    r"\| (?:\U0001f4dd \*\*Code Review\*\*|\U0001f6e1\ufe0f \*\*Security Review\*\*) "
+    r"\| \u2705 \*\*Completed\*\* <relative-time datetime=\"[^\"\n]+\">"
+    r"[^<\n]+</relative-time> \| `[a-f0-9]{7,40}` \| Manual request \|"
+)
+CODEX_CLEAN_REVIEW_PATTERN = (
+    r"Codex Review: Didn't find any major issues\."
+    r"(?: Nice work!| Chef's kiss\.| You're on a roll\.| Swish!)?"
+    r"\n\n\*\*Reviewed commit:\*\* `[a-f0-9]{7,40}`"
+)
+
 SHORT_SHA_LENGTH: int = 7
 """How much of a commit identifier the verdict line prints."""
 

package/scripts/review_closure_model.py

@@ -29,6 +29,7 @@ nobody.
 
 from __future__ import annotations
 
+import re
 from collections.abc import Iterable, Mapping, Sequence
 from dataclasses import dataclass
 from datetime import datetime
@@ -38,6 +39,8 @@ from dev_env_scripts_constants.review_closure_constants import (
     ALL_COMMENT_AUTHOR_KEYS,
     ALL_COMMENT_LIST_KEYS,
     ALL_NOTICE_COMMENT_MARKERS,
+    ALL_CODEX_NOTICE_DETAILS,
+    ALL_REVIEW_REQUEST_COMMANDS,
     ALL_OUTDATED_KEYS,
     ALL_RESOLVED_KEYS,
     APPROVALS_CHECK_NAME,
@@ -48,6 +51,10 @@ from dev_env_scripts_constants.review_closure_constants import (
     CHECK_RUN_NAME_KEY,
     CLOSED_DETAIL,
     CLOSED_VERDICT_LABEL,
+    CODEX_CLEAN_REVIEW_PATTERN,
+    CODEX_REVIEW_BOT_LOGIN,
+    CODEX_SUMMARY_PREFIX,
+    CODEX_SUMMARY_ROW_PATTERN,
     COMMENT_BODY_KEY,
     COMMENT_IDENTIFIER_KEY,
     COMMENT_IDS_KEY,
@@ -187,21 +194,21 @@ def latest_driver_comment_time(
     all_comments: Iterable[TopLevelComment],
     all_driver_logins: frozenset[str],
 ) -> datetime | None:
-    """Find when the driving agent last posted a top-level comment.
+    """Find when the driving agent last posted a substantive top-level comment.
 
     Args:
         all_comments: The top-level comments on the pull request.
         all_driver_logins: The logins that count as the driving agent.
 
     Returns:
-        The creation time of the driving agent's latest top-level comment, or
+        The creation time of the driving agent's latest substantive comment, or
         None when it posted none.
     """
     return max(
         (
             each_comment.created_at
             for each_comment in all_comments
-            if each_comment.author_login in all_driver_logins
+            if each_comment.author_login in all_driver_logins and not each_comment.is_notice
         ),
         default=None,
     )
@@ -241,10 +248,10 @@ def top_level_findings(
     """Decide which top-level comments still wait on the driving agent.
 
     The driving agent answers a top-level comment by posting a top-level
-    comment of its own. Its latest one answers every comment last touched
+    substantive comment of its own. Its latest one answers every comment last touched
     before it. A person's comment edited after it waits again. A bot's edit
     leaves its comment answered, since a bot posts each new finding as a
-    review thread or a new comment.
+    review thread or a new comment. Requests and notices answer no findings.
 
     Args:
         all_comments: The top-level comments on the pull request.
@@ -424,14 +431,47 @@ def comment_records_by_id(
     }
 
 
+def _is_codex_notice(body: str) -> bool:
+    """Match the verified summary or clean format, including its metadata."""
+    normalized = body.strip()
+    for each_details in ALL_CODEX_NOTICE_DETAILS:
+        if not normalized.endswith(each_details):
+            continue
+        content = normalized[:-len(each_details)].rstrip()
+        if content.startswith(CODEX_SUMMARY_PREFIX):
+            all_rows = content[len(CODEX_SUMMARY_PREFIX):].splitlines()
+            return bool(all_rows) and all(
+                re.fullmatch(CODEX_SUMMARY_ROW_PATTERN, each_row) for each_row in all_rows
+            )
+        return re.fullmatch(CODEX_CLEAN_REVIEW_PATTERN, content) is not None
+    return False
+
+
+def _is_notice_comment(
+    all_comment_fields: Mapping[str, object], body: str, all_extra_markers: Sequence[str]
+) -> bool:
+    """Separate exact review requests and trusted notices from findings."""
+    is_command = body.strip().casefold() in ALL_REVIEW_REQUEST_COMMANDS
+    if is_command:
+        return is_command
+    if not _is_bot_author(all_comment_fields):
+        return False
+    return any(
+        each_marker in body for each_marker in (*ALL_NOTICE_COMMENT_MARKERS, *all_extra_markers)
+    ) or (
+        _comment_author_login(all_comment_fields) == CODEX_REVIEW_BOT_LOGIN and _is_codex_notice(body)
+    )
+
+
 def parse_top_level_comment(
     all_comment_fields: Mapping[str, object],
     all_extra_notice_markers: Sequence[str] = (),
 ) -> TopLevelComment:
     """Read one top-level comment from the REST answer.
 
-    A bot comment whose body carries a notice marker is a notice. A person's
-    comment carrying the same text still counts, since anyone can paste it.
+    Command-only review requests and verified bot notices carry no findings.
+    A person's comment pasting bot notice text still counts. Notice metadata
+    and format must match before a Codex bot comment is exempted.
 
     Args:
         all_comment_fields: The comment as the issue comments route reports it.
@@ -450,11 +490,7 @@ def parse_top_level_comment(
         identifier=all_comment_fields.get(COMMENT_IDENTIFIER_KEY),
         author_login=_comment_author_login(all_comment_fields),
         is_bot=is_bot,
-        is_notice=is_bot
-        and any(
-            each_marker in body
-            for each_marker in (*ALL_NOTICE_COMMENT_MARKERS, *all_extra_notice_markers)
-        ),
+        is_notice=_is_notice_comment(all_comment_fields, body, all_extra_notice_markers),
         created_at=datetime.fromisoformat(str(all_comment_fields.get(CREATED_AT_KEY))),
         updated_at=datetime.fromisoformat(str(all_comment_fields.get(UPDATED_AT_KEY))),
         url=str(all_comment_fields.get(HTML_URL_KEY) or ""),