claude-dev-env 8.69.0 → 8.69.1

package/hooks/advisory/test_refactor_guard_advisory.py

@@ -1,242 +0,0 @@
-"""Tests for direct and dispatched refactor guidance."""
-
-from __future__ import annotations
-
-import json
-import os
-import subprocess
-import sys
-from pathlib import Path
-
-import pytest
-
-ADVISORY_DIRECTORY = Path(__file__).resolve().parent
-HOOK_SCRIPT_PATH = ADVISORY_DIRECTORY / "refactor_guard.py"
-DISPATCHER_SCRIPT_PATH = ADVISORY_DIRECTORY.parent / "blocking" / "pre_tool_use_dispatcher.py"
-if str(ADVISORY_DIRECTORY) not in sys.path:
-    sys.path.insert(0, str(ADVISORY_DIRECTORY))
-
-import refactor_guard  # noqa: E402
-from refactor_guard_test_support import commit_file, stage_file  # noqa: E402
-
-pytestmark = pytest.mark.usefixtures("ephemeral_exempt_off")
-
-
-def _refactor_payload(file_path: Path) -> str:
-    return json.dumps(
-        {
-            "tool_name": "Edit",
-            "tool_input": {
-                "file_path": str(file_path),
-                "old_string": "def calculate_total(amount: int) -> int:\n    return amount",
-                "new_string": "def compute_total(amount: int) -> int:\n    return amount",
-            },
-        }
-    )
-
-
-def _ordinary_edit_payload(file_path: Path) -> str:
-    return json.dumps(
-        {
-            "tool_name": "Edit",
-            "tool_input": {
-                "file_path": str(file_path),
-                "old_string": "return amount",
-                "new_string": "return amount + 1",
-            },
-        }
-    )
-
-
-def _run_hook(
-    script_path: Path, repository_path: Path, payload_text: str
-) -> subprocess.CompletedProcess[str]:
-    environment_by_key = os.environ.copy()
-    environment_by_key["HOME"] = str(repository_path)
-    environment_by_key["USERPROFILE"] = str(repository_path)
-    return subprocess.run(
-        [sys.executable, str(script_path)],
-        cwd=repository_path,
-        input=payload_text,
-        capture_output=True,
-        text=True,
-        env=environment_by_key,
-        check=False,
-    )
-
-
-def test_direct_hook_emits_edit_stage_guidance_for_eligible_refactor(
-    git_repository: Path,
-) -> None:
-    source_path = git_repository / "module.py"
-    commit_file(
-        git_repository,
-        source_path,
-        "def calculate_total(amount: int) -> int:\n    return amount\n",
-    )
-    stage_file(
-        git_repository,
-        source_path,
-        "def calculate_total(amount: int) -> int:\n    return amount + 1\n",
-    )
-
-    completed_hook = _run_hook(HOOK_SCRIPT_PATH, git_repository, _refactor_payload(source_path))
-    advisory_payload = json.loads(completed_hook.stdout)
-    hook_specific_output = advisory_payload["hookSpecificOutput"]
-
-    assert hook_specific_output["permissionDecision"] == "allow"
-    assert "Edit-stage" in advisory_payload["systemMessage"]
-    assert "current git diff" in hook_specific_output["additionalContext"]
-    assert str(source_path) in advisory_payload["systemMessage"]
-
-
-def test_direct_hook_stays_silent_for_ordinary_edit(git_repository: Path) -> None:
-    source_path = git_repository / "module.py"
-    commit_file(
-        git_repository,
-        source_path,
-        "def calculate_total(amount: int) -> int:\n    return amount\n",
-    )
-
-    completed_hook = _run_hook(
-        HOOK_SCRIPT_PATH,
-        git_repository,
-        _ordinary_edit_payload(source_path),
-    )
-
-    assert completed_hook.returncode == 0
-    assert completed_hook.stdout == ""
-
-
-def test_direct_hook_stays_silent_for_write_payload(git_repository: Path) -> None:
-    source_path = git_repository / "module.py"
-    commit_file(
-        git_repository,
-        source_path,
-        "def calculate_total(amount: int) -> int:\n    return amount\n",
-    )
-    write_payload = json.dumps(
-        {
-            "tool_name": "Write",
-            "tool_input": {"file_path": str(source_path), "content": "new content"},
-        }
-    )
-
-    completed_hook = _run_hook(HOOK_SCRIPT_PATH, git_repository, write_payload)
-
-    assert completed_hook.returncode == 0
-    assert completed_hook.stdout == ""
-
-
-def test_dispatcher_preserves_edit_stage_guidance(git_repository: Path) -> None:
-    """A red step (staged, uncommitted test) plus a staged refactor still allows."""
-    source_path = git_repository / "module.py"
-    matching_test_path = git_repository / "test_module.py"
-    commit_file(
-        git_repository,
-        source_path,
-        "def calculate_total(amount: int) -> int:\n    return amount\n",
-    )
-    stage_file(
-        git_repository,
-        matching_test_path,
-        "def calculate_total(amount: int) -> int:\n    return amount\n\n"
-        "def test_calculate_total() -> None:\n    assert calculate_total(1) == 1\n",
-    )
-    stage_file(
-        git_repository,
-        source_path,
-        "def calculate_total(amount: int) -> int:\n    return amount + 1\n",
-    )
-
-    completed_dispatch = _run_hook(
-        DISPATCHER_SCRIPT_PATH,
-        git_repository,
-        _refactor_payload(source_path),
-    )
-    dispatcher_payload = json.loads(completed_dispatch.stdout)
-    hook_specific_output = dispatcher_payload["hookSpecificOutput"]
-
-    assert hook_specific_output["permissionDecision"] == "allow", (
-        f"Dispatcher output: {completed_dispatch.stdout!r}; stderr: {completed_dispatch.stderr!r}"
-    )
-    assert "Edit-stage" in dispatcher_payload["systemMessage"]
-    assert "Refactor guard" in dispatcher_payload["systemMessage"]
-
-
-def test_bypass_token_is_consumed_once(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:
-    bypass_token_path = tmp_path / "refactor-bypass-token"
-    monkeypatch.setattr(refactor_guard, "REFACTOR_BYPASS_TOKEN_PATH", bypass_token_path)
-    bypass_token_path.write_text("approved", encoding="utf-8")
-
-    assert refactor_guard.is_bypass_approved()
-    assert not bypass_token_path.exists()
-    assert not refactor_guard.is_bypass_approved()
-
-
-def _multi_edit_payload(file_path: Path, all_edits: list[dict[str, str]]) -> str:
-    return json.dumps(
-        {
-            "tool_name": "MultiEdit",
-            "tool_input": {"file_path": str(file_path), "edits": all_edits},
-        }
-    )
-
-
-def _commit_and_stage_the_renamed_module(git_repository: Path, source_path: Path) -> None:
-    """Commit the base module, then stage an unrelated numeric change to it."""
-    commit_file(
-        git_repository,
-        source_path,
-        "def calculate_total(amount: int) -> int:\n    return amount\n",
-    )
-    stage_file(
-        git_repository,
-        source_path,
-        "def calculate_total(amount: int) -> int:\n    return amount + 1\n",
-    )
-
-
-def test_direct_hook_flags_refactor_in_second_multi_edit(git_repository: Path) -> None:
-    """A rename buried in the second edit of a MultiEdit is caught, not only the first.
-
-    The first edit is an ordinary numeric change; only the second edit renames
-    calculate_total to compute_total outside the currently staged diff.
-    """
-    source_path = git_repository / "module.py"
-    _commit_and_stage_the_renamed_module(git_repository, source_path)
-    payload_text = _multi_edit_payload(
-        source_path,
-        [
-            {"old_string": "return amount", "new_string": "return amount + 1"},
-            {
-                "old_string": "def calculate_total(amount: int) -> int:\n    return amount",
-                "new_string": "def compute_total(amount: int) -> int:\n    return amount",
-            },
-        ],
-    )
-
-    completed_hook = _run_hook(HOOK_SCRIPT_PATH, git_repository, payload_text)
-    advisory_payload = json.loads(completed_hook.stdout)
-    hook_specific_output = advisory_payload["hookSpecificOutput"]
-
-    assert hook_specific_output["permissionDecision"] == "allow"
-    assert "Edit-stage" in advisory_payload["systemMessage"]
-
-
-def test_direct_hook_stays_silent_for_ordinary_multi_edit(git_repository: Path) -> None:
-    source_path = git_repository / "module.py"
-    commit_file(
-        git_repository,
-        source_path,
-        "def calculate_total(amount: int) -> int:\n    return amount\n",
-    )
-    payload_text = _multi_edit_payload(
-        source_path,
-        [{"old_string": "return amount", "new_string": "return amount + 1"}],
-    )
-
-    completed_hook = _run_hook(HOOK_SCRIPT_PATH, git_repository, payload_text)
-
-    assert completed_hook.returncode == 0
-    assert completed_hook.stdout == ""

package/hooks/advisory/test_refactor_guard_eligibility.py

@@ -1,166 +0,0 @@
-"""Tests for refactor candidate eligibility against a temporary Git repository."""
-
-from __future__ import annotations
-
-import sys
-from pathlib import Path
-
-import pytest
-
-ADVISORY_DIRECTORY = Path(__file__).resolve().parent
-if str(ADVISORY_DIRECTORY) not in sys.path:
-    sys.path.insert(0, str(ADVISORY_DIRECTORY))
-
-import refactor_guard  # noqa: E402
-from refactor_guard_test_support import commit_file, stage_file  # noqa: E402
-
-
-def test_refactor_candidate_is_eligible_when_old_lines_are_outside_changed_surface(
-    git_repository: Path,
-) -> None:
-    source_path = git_repository / "module.py"
-    commit_file(
-        git_repository,
-        source_path,
-        "def calculate_total(amount: int) -> int:\n    return amount\n",
-    )
-    stage_file(
-        git_repository,
-        source_path,
-        "def calculate_total(amount: int) -> int:\n    return amount + 1\n",
-    )
-
-    old_function = "def calculate_total(amount: int) -> int:\n    return amount"
-    renamed_function = "def compute_total(amount: int) -> int:\n    return amount"
-
-    assert refactor_guard.is_refactor_eligible(str(source_path), old_function, renamed_function)
-
-
-def test_refactor_candidate_is_ineligible_when_old_lines_are_in_changed_surface(
-    git_repository: Path,
-) -> None:
-    source_path = git_repository / "module.py"
-    commit_file(git_repository, source_path, "pass\n")
-    old_function = "def calculate_total(amount: int) -> int:\n    return amount"
-    stage_file(git_repository, source_path, f"{old_function}\n")
-    renamed_function = "def compute_total(amount: int) -> int:\n    return amount"
-
-    assert not refactor_guard.is_refactor_eligible(str(source_path), old_function, renamed_function)
-
-
-def test_changed_surface_reads_staged_and_unstaged_lines(
-    git_repository: Path, monkeypatch: pytest.MonkeyPatch
-) -> None:
-    source_path = git_repository / "module.py"
-    commit_file(git_repository, source_path, "baseline = 1\n")
-
-    stage_file(git_repository, source_path, "staged_line = 1\n")
-    source_path.write_text("unstaged_line = 1\n", encoding="utf-8")
-
-    monkeypatch.setenv("GIT_DIR", str(git_repository / "missing-git-dir"))
-    monkeypatch.setenv("GIT_WORK_TREE", str(git_repository / "missing-work-tree"))
-    monkeypatch.setenv("GIT_INDEX_FILE", str(git_repository / "missing-index"))
-    monkeypatch.setenv("GIT_COMMON_DIR", str(git_repository / "missing-common-dir"))
-    monkeypatch.setenv("GIT_PREFIX", "adversarial-prefix")
-    scrubbed_environment = refactor_guard._git_environment()
-    assert not any(each_name.startswith("GIT_") for each_name in scrubbed_environment)
-    all_added_lines = refactor_guard.get_git_diff_added_lines(str(source_path))
-
-    assert all_added_lines == {"staged_line = 1", "unstaged_line = 1"}
-
-
-def test_duplicate_old_lines_require_duplicate_changed_occurrences(
-    git_repository: Path, monkeypatch: pytest.MonkeyPatch
-) -> None:
-    source_path = git_repository / "module.py"
-    commit_file(git_repository, source_path, "pass\n")
-    old_function = "def calculate_total(amount: int) -> int:\n    return amount\n    return amount"
-    stage_file(
-        git_repository,
-        source_path,
-        "def calculate_total(amount: int) -> int:\n    return amount\n",
-    )
-    renamed_function = old_function.replace("calculate_total", "compute_total")
-    monkeypatch.setattr(
-        refactor_guard,
-        "_get_added_line_occurrences",
-        lambda _file_path: ["def calculate_total(amount: int) -> int:", "    return amount"],
-    )
-
-    assert refactor_guard.is_refactor_edit(old_function, renamed_function)
-    assert not refactor_guard.is_edit_within_changed_surface(str(source_path), old_function)
-
-
-def test_ordinary_edit_is_not_a_refactor_candidate(git_repository: Path) -> None:
-    source_path = git_repository / "module.py"
-    commit_file(git_repository, source_path, "return_amount = 1\n")
-
-    assert not refactor_guard.is_refactor_eligible(
-        str(source_path), "return_amount = 1", "return_amount = 2"
-    )
-
-
-def test_new_file_is_not_a_refactor_candidate(git_repository: Path) -> None:
-    source_path = git_repository / "new_module.py"
-    source_path.write_text(
-        "def calculate_total(amount: int) -> int:\n    return amount\n",
-        encoding="utf-8",
-    )
-
-    assert refactor_guard.is_new_file(str(source_path))
-    assert not refactor_guard.is_refactor_eligible(
-        str(source_path),
-        "def calculate_total(amount: int) -> int:\n    return amount",
-        "def compute_total(amount: int) -> int:\n    return amount",
-    )
-
-
-def test_hook_infrastructure_is_not_a_refactor_candidate(
-    tmp_path: Path, monkeypatch: pytest.MonkeyPatch
-) -> None:
-    monkeypatch.setenv("HOME", str(tmp_path))
-    monkeypatch.setenv("USERPROFILE", str(tmp_path))
-    hook_path = str(Path.home() / ".claude" / "settings.json")
-
-    assert refactor_guard.is_hook_infrastructure(hook_path)
-    assert not refactor_guard.is_refactor_eligible(
-        hook_path,
-        "def calculate_total(amount: int) -> int:\n    return amount",
-        "def compute_total(amount: int) -> int:\n    return amount",
-    )
-
-
-def test_changed_surface_below_half_is_false(monkeypatch: pytest.MonkeyPatch) -> None:
-    monkeypatch.setattr(
-        refactor_guard,
-        "_get_added_line_occurrences",
-        lambda _file_path: ["changed line"],
-    )
-
-    assert not refactor_guard.is_edit_within_changed_surface(
-        "module.py", "changed line\noriginal line\noriginal line"
-    )
-
-
-def test_changed_surface_at_half_is_true(monkeypatch: pytest.MonkeyPatch) -> None:
-    monkeypatch.setattr(
-        refactor_guard,
-        "_get_added_line_occurrences",
-        lambda _file_path: ["changed one", "changed two"],
-    )
-
-    assert refactor_guard.is_edit_within_changed_surface(
-        "module.py", "changed one\nchanged two\noriginal one\noriginal two"
-    )
-
-
-def test_changed_surface_above_half_is_true(monkeypatch: pytest.MonkeyPatch) -> None:
-    monkeypatch.setattr(
-        refactor_guard,
-        "_get_added_line_occurrences",
-        lambda _file_path: ["changed one", "changed two", "changed three"],
-    )
-
-    assert refactor_guard.is_edit_within_changed_surface(
-        "module.py", "changed one\nchanged two\nchanged three\noriginal line"
-    )

package/hooks/hooks_constants/refactor_guard_constants.py

@@ -1,77 +0,0 @@
-"""Constants for the changed-surface refactor advisory."""
-
-from __future__ import annotations
-
-GIT_EXECUTABLE_TOKEN: str = "git"
-GIT_COMMAND_TIMEOUT_SECONDS: int = 5
-MAXIMUM_REFACTOR_LINE_DELTA: int = 3
-REFACTOR_LINE_DELTA_DIVISOR: int = 2
-CHANGED_SURFACE_MATCH_RATIO: float = 0.5
-ALL_PYTHON_KEYWORDS: frozenset[str] = frozenset(
-    {
-        "def",
-        "class",
-        "return",
-        "import",
-        "from",
-        "if",
-        "elif",
-        "else",
-        "for",
-        "while",
-        "try",
-        "except",
-        "finally",
-        "with",
-        "as",
-        "yield",
-        "raise",
-        "pass",
-        "break",
-        "continue",
-        "and",
-        "or",
-        "not",
-        "in",
-        "is",
-        "lambda",
-        "None",
-        "True",
-        "False",
-        "self",
-        "cls",
-        "async",
-        "await",
-        "global",
-        "nonlocal",
-        "assert",
-        "del",
-        "print",
-        "len",
-        "range",
-        "list",
-        "dict",
-        "set",
-        "str",
-        "int",
-        "float",
-        "bool",
-        "type",
-        "isinstance",
-        "hasattr",
-        "getattr",
-        "setattr",
-        "super",
-        "property",
-        "staticmethod",
-        "classmethod",
-        "abstractmethod",
-        "Optional",
-        "Union",
-        "List",
-        "Dict",
-        "Set",
-        "Tuple",
-        "Any",
-    }
-)

package/hooks/hooks_constants/test_refactor_guard_constants.py

@@ -1,21 +0,0 @@
-"""Tests for refactor advisory constants."""
-
-import sys
-from pathlib import Path
-
-_HOOKS_ROOT = Path(__file__).resolve().parent.parent
-if str(_HOOKS_ROOT) not in sys.path:
-    sys.path.insert(0, str(_HOOKS_ROOT))
-
-from hooks_constants.refactor_guard_constants import (
-    ALL_PYTHON_KEYWORDS,
-    CHANGED_SURFACE_MATCH_RATIO,
-    MAXIMUM_REFACTOR_LINE_DELTA,
-    REFACTOR_LINE_DELTA_DIVISOR,
-)
-
-
-def test_refactor_threshold_constants_define_a_half_boundary() -> None:
-    assert CHANGED_SURFACE_MATCH_RATIO * REFACTOR_LINE_DELTA_DIVISOR == 1
-    assert MAXIMUM_REFACTOR_LINE_DELTA > REFACTOR_LINE_DELTA_DIVISOR
-    assert "return" in ALL_PYTHON_KEYWORDS