claude-dev-env 8.68.0 → 8.68.2

package/hooks/features/conduct-gates.md

@@ -13,7 +13,6 @@ This family stops a chat reply, edited message, or tool call when its payload br
 - `blocking/verify_before_acting.py` blocks a completed mutating call when the agent's reasoning contains an unchecked claim.
 - `blocking/pr_lifecycle_skill_gate.py` denies a commit, push, pull request action, or merge until the `pr-lifecycle` skill appears in the transcript since the last compaction.
 - `blocking/artifact_look_gate.py` denies an Artifact publish of an HTML page until an image was opened with Read after the page file was last written, so the agent looks at its page before it ships.
-- `blocking/artifact_dark_mode_gate.py` denies an Artifact page publish when the page, inside the publish wrapper, keeps a light body or shows text under 4.5:1 contrast in dark mode. `blocking/artifact_dark_mode_render.cjs` renders the page in headless Chromium for it.
 
 ## When it fires
 
@@ -26,7 +25,6 @@ This family stops a chat reply, edited message, or tool call when its payload br
 - `blocking/verify_before_acting.py` runs on `PostToolUse`, matcher `Write|Edit|MultiEdit|NotebookEdit|Agent|Task|apply_patch|Bash|PowerShell|mcp__.*`, timeout `10` seconds in `hooks.json`.
 - `blocking/pr_lifecycle_skill_gate.py` runs on `PreToolUse`, matcher `Bash|PowerShell|mcp__.*__(create_pull_request|merge_pull_request|enable_pr_auto_merge|update_pull_request)`, timeout `10` seconds in `hooks.json`.
 - `blocking/artifact_look_gate.py` runs on `PreToolUse`, matcher `Artifact|Skill`, timeout `10` seconds in `hooks.json`. It speaks only on an `Artifact` publish of a `.html` or `.htm` file.
-- `blocking/artifact_dark_mode_gate.py` runs on `PreToolUse`, matcher `Artifact`, timeout `60` seconds in `hooks.json`.
 
 ## Proving it
 
@@ -42,7 +40,6 @@ Preconditions:
 - **Step note.** Input is a tool call after a transcript message without a status line while the flag is on. Run `python -m pytest packages/claude-dev-env/hooks/blocking/test_step_note_gate.py -q`. The adjacent test observes a block until a status line appears.
 - **Checked claim.** Input is a Write after hedged reasoning in the transcript. Run `python -m pytest packages/claude-dev-env/hooks/blocking/test_verify_before_acting.py -q`. The adjacent test observes a block and a logged blocked outcome.
 - **Lifecycle skill.** Input is a `git commit` or `gh pr create` command with no `pr-lifecycle` invocation in the transcript. Run `python -m pytest packages/claude-dev-env/hooks/blocking/test_pr_lifecycle_skill_gate.py -q`. The adjacent test observes a denial, then a silent allow once the skill or its slash command appears.
-- **Dark mode page.** Input is an Artifact publish of a page that themes `html` but leaves `body` to the publish wrapper. Run `python -m pytest packages/claude-dev-env/hooks/blocking/test_artifact_dark_mode_gate.py -q`. The adjacent test observes a denial that names the text and its contrast; a page that themes `body` passes. The render tests skip on a host with no Node Playwright and Chromium.
 
 ## Gotchas
 

package/hooks/features/spawn-routing.md

@@ -7,7 +7,6 @@ This family reminds the agent to gather context before a spawn, tells it that it
 - `routing/spawn_readiness_hook.py` adds context to a spawn that comes before a read step, or before an answered question or a settled-scope line. The spawn still runs.
 - `routing/spawn_oversight_hook.py` adds the orchestrator oversight directive to every spawn: watch the agent, check its output against the user's words and standards, and correct it before the output reaches the user. The spawn still runs.
 - `routing/thread_spawn_pace_hook.py` reshapes a thread request when usage is over pace or unreadable.
-- `routing/subagent_model_pin_hook.py` moves every Agent and Task subagent to Opus. A spawn that names Opus or Fable runs unchanged.
 - `routing/subagent_model_routing.mjs` allows a selected Luna model, remaps eligible requests, and denies unsupported model routing.
 
 ## When it fires
@@ -15,7 +14,6 @@ This family reminds the agent to gather context before a spawn, tells it that it
 - `routing/spawn_readiness_hook.py` runs on `PreToolUse` with matchers `Agent|Task`, `multi_agent_v1__spawn_agent`, `Workflow|mcp__github__actions_run_trigger`, and `mcp__hearthbot__start_thread_session`, each at `10` seconds in `hooks.json`. A workflow dispatch counts only when its inputs carry a `prompt`.
 - `routing/spawn_oversight_hook.py` runs on `PreToolUse` with matchers `Agent|Task`, `multi_agent_v1__spawn_agent`, `Workflow|mcp__github__actions_run_trigger`, `mcp__hearthbot__start_thread_session`, and `mcp__hearthbot__start_rc_session`, each at `10` seconds in `hooks.json`. A workflow dispatch counts only when its inputs carry a `prompt`.
 - `routing/thread_spawn_pace_hook.py` runs on `PreToolUse`, matcher `mcp__hearthbot__start_thread_session`, timeout `30` seconds in `hooks.json`.
-- `routing/subagent_model_pin_hook.py` runs on `PreToolUse`, matcher `Agent|Task`, timeout `10` seconds in `hooks.json`.
 - `routing/subagent_model_routing.mjs` runs on `PreToolUse`, matcher `multi_agent_v1__spawn_agent`, timeout `10` seconds through the quoted Node command in `hooks.json`.
 
 ## Proving it
@@ -27,7 +25,6 @@ Preconditions:
 - **Spawn readiness.** Input is a spawn after a read, a question, and its answer. Run `python -m pytest packages/claude-dev-env/hooks/routing/test_spawn_readiness_hook.py -q`. The adjacent test observes no output for a ready spawn and reminder context for each missing step.
 - **Spawn oversight.** Input is a spawn from each registered tool, a subagent's own spawn, and a non-spawn call. Run `python -m pytest packages/claude-dev-env/hooks/routing/test_spawn_oversight_hook.py -q`. The adjacent test observes the directive for every spawn and no output for the other calls.
 - **Thread pace.** Input is a thread spawn with usage over pace. Run `python -m pytest packages/claude-dev-env/hooks/routing/test_thread_spawn_pace_hook.py -q`. The adjacent test observes updated tool input with the selected model, effort, and advisor line.
-- **Model pin.** Input is an Agent spawn that names a Sonnet model. Run `python -m pytest packages/claude-dev-env/hooks/routing/test_subagent_model_pin_hook.py -q`. The adjacent test observes updated tool input with model `opus`.
 - **Model routing.** Input is a `multi_agent_v1__spawn_agent` payload with a model choice. Run `node --test packages/claude-dev-env/hooks/routing/subagent_model_routing.test.mjs`. The adjacent test observes an allow or deny decision with the routed model.
 
 ## Gotchas

package/hooks/hooks.json

@@ -15,11 +15,6 @@
             "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/routing/spawn_readiness_hook.py",
             "timeout": 10
           },
-          {
-            "type": "command",
-            "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/routing/subagent_model_pin_hook.py",
-            "timeout": 10
-          },
           {
             "type": "command",
             "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/routing/spawn_oversight_hook.py",
@@ -157,8 +152,9 @@
         "hooks": [
           {
             "type": "command",
-            "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/blocking/artifact_dark_mode_gate.py",
-            "timeout": 60
+            "command": "python3 ${CLAUDE_PLUGIN_ROOT}/hooks/lifecycle/nested_project_hooks.py",
+            "timeout": 1800,
+            "async": true
           }
         ]
       },

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.68.0",
+    "version": "8.68.2",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {

package/scripts/review_closure_github.py

@@ -19,6 +19,7 @@ a workflow runner.
 from __future__ import annotations
 
 import functools
+import http.client
 import json
 import os
 import urllib.error
@@ -126,7 +127,12 @@ def request_json(
     try:
         with urllib.request.urlopen(request, timeout=REQUEST_TIMEOUT_SECONDS) as reply:
             return _decoded_answer(url, reply.status, reply.read())
-    except (urllib.error.URLError, OSError, ValueError) as failure:
+    except (
+        urllib.error.URLError,
+        OSError,
+        ValueError,
+        http.client.HTTPException,
+    ) as failure:
         raise GitHubError(str(failure)) from failure
 
 

package/scripts/tests/test_review_closure_github.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import http.client
 import json
 import os
 import sys
@@ -379,3 +380,23 @@ def should_read_a_bot_comment_carrying_a_passed_marker_as_a_notice(
     )
 
     assert [each.is_notice for each in all_comments] == [True]
+
+
+class TruncatedReply:
+    status = 200
+
+    def read(self) -> bytes:
+        raise http.client.IncompleteRead(b"{", 39041)
+
+
+def should_report_a_reply_cut_short_as_a_github_error(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    @contextmanager
+    def fake_urlopen(request: object, timeout: int = 0) -> Iterator[TruncatedReply]:
+        yield TruncatedReply()
+
+    monkeypatch.setattr(reader.urllib.request, "urlopen", fake_urlopen)
+
+    with pytest.raises(GitHubError, match="IncompleteRead"):
+        reader.read_pull_request("jl-cmd/claude-dev-env", 4347, TOKEN)

package/hooks/hooks_constants/subagent_model_pin_hook_constants.py

@@ -1,16 +0,0 @@
-"""Constants for the subagent model pin PreToolUse hook.
-
-Groups: the model every subagent runs on, the model families the hook moves,
-and the hook input and output keys.
-"""
-
-from __future__ import annotations
-
-SUBAGENT_MODEL_ALIAS = "opus"
-ALL_MOVED_MODEL_FAMILIES = ("sonnet", "haiku")
-MODEL_INPUT_KEY = "model"
-TOOL_INPUT_KEY = "tool_input"
-CONTEXT_PREFIX = "Subagent model moved to opus (was "
-CONTEXT_OMITTED_MODEL_TEXT = "inherited from the parent"
-CONTEXT_SUFFIX = ")."
-ADDITIONAL_CONTEXT_KEY = "additionalContext"

package/hooks/routing/subagent_model_pin_hook.py

@@ -1,105 +0,0 @@
-#!/usr/bin/env python3
-"""PreToolUse hook: run every Agent and Task subagent on Opus.
-
-Registered on ``Agent|Task``. Nested spawns pass through the same hook, so the
-pin holds at every level.
-
-::
-
-    model omitted           -> updatedInput model "opus"
-    model sonnet or haiku   -> updatedInput model "opus"
-    model opus or fable     -> no output; the call runs unchanged
-
-A model id counts by its family: ``claude-sonnet-5-5`` is sonnet. A fork
-ignores the model field, so the rewrite leaves it unchanged.
-"""
-
-from __future__ import annotations
-
-import json
-import sys
-from pathlib import Path
-
-hooks_root_directory = str(Path(__file__).resolve().parent.parent)
-if hooks_root_directory not in sys.path:
-    sys.path.insert(0, hooks_root_directory)
-
-from hooks_constants.bash_pre_tool_use_dispatcher_constants import HOOK_EVENT_NAME
-from hooks_constants.hook_specific_output_keys import (
-    HOOK_EVENT_NAME_KEY,
-    HOOK_SPECIFIC_OUTPUT_KEY,
-    UPDATED_INPUT_KEY,
-)
-from hooks_constants.pre_tool_use_stdin import read_hook_input_dictionary_from_stdin
-from hooks_constants.subagent_model_pin_hook_constants import (
-    ADDITIONAL_CONTEXT_KEY,
-    ALL_MOVED_MODEL_FAMILIES,
-    CONTEXT_OMITTED_MODEL_TEXT,
-    CONTEXT_PREFIX,
-    CONTEXT_SUFFIX,
-    MODEL_INPUT_KEY,
-    SUBAGENT_MODEL_ALIAS,
-    TOOL_INPUT_KEY,
-)
-
-
-def is_moved_model(model: object) -> bool:
-    """Return True when the spawn names no model or a model family the pin moves.
-
-    ::
-
-        None -> True        "sonnet" -> True     "claude-haiku-4-5-20251001" -> True
-        "opus" -> False     "claude-fable-5-1" -> False
-
-    Args:
-        model: The ``model`` field of the spawn input.
-    """
-    if model is None or model == "":
-        return True
-    if not isinstance(model, str):
-        return False
-    lowered_model = model.lower()
-    return any(each_family in lowered_model for each_family in ALL_MOVED_MODEL_FAMILIES)
-
-
-def decide_hook_output(tool_input: object) -> dict[str, object] | None:
-    """Choose the hook's output for one subagent spawn.
-
-    Args:
-        tool_input: The ``tool_input`` of the PreToolUse payload.
-
-    Returns:
-        None to pass the call through unchanged, else the hook JSON output.
-    """
-    if not isinstance(tool_input, dict):
-        return None
-    requested_model = tool_input.get(MODEL_INPUT_KEY)
-    if not is_moved_model(requested_model):
-        return None
-    previous_model_text = requested_model or CONTEXT_OMITTED_MODEL_TEXT
-    return {
-        HOOK_SPECIFIC_OUTPUT_KEY: {
-            HOOK_EVENT_NAME_KEY: HOOK_EVENT_NAME,
-            UPDATED_INPUT_KEY: {**tool_input, MODEL_INPUT_KEY: SUBAGENT_MODEL_ALIAS},
-            ADDITIONAL_CONTEXT_KEY: f"{CONTEXT_PREFIX}{previous_model_text}{CONTEXT_SUFFIX}",
-        }
-    }
-
-
-def main() -> int:
-    """Read the PreToolUse payload and print the decision.
-
-    Returns:
-        0 in every case.
-    """
-    hook_payload = read_hook_input_dictionary_from_stdin()
-    tool_input = hook_payload.get(TOOL_INPUT_KEY) if hook_payload is not None else None
-    hook_output = decide_hook_output(tool_input)
-    if hook_output is not None:
-        sys.stdout.write(json.dumps(hook_output))
-        sys.stdout.flush()
-    return 0
-
-
-if __name__ == "__main__":
-    sys.exit(main())

package/hooks/routing/test_subagent_model_pin_hook.py

@@ -1,67 +0,0 @@
-import json
-import subprocess
-import sys
-from pathlib import Path
-
-import pytest
-
-HOOK_SCRIPT = Path(__file__).resolve().parent / "subagent_model_pin_hook.py"
-HOOKS_JSON = Path(__file__).resolve().parent.parent / "hooks.json"
-CONSTANTS_DIRECTORY = Path(__file__).resolve().parent.parent / "hooks_constants"
-SPAWN_INPUT = {"subagent_type": "pstack:poteto-agent", "prompt": "Do X.", "description": "d"}
-
-
-def _run_hook(tool_input: object) -> str:
-    completed = subprocess.run(
-        [sys.executable, str(HOOK_SCRIPT)],
-        input=json.dumps({"tool_name": "Agent", "tool_input": tool_input}),
-        capture_output=True,
-        text=True,
-        check=True,
-    )
-    return completed.stdout
-
-
-@pytest.mark.parametrize(
-    "requested_model",
-    [None, "", "sonnet", "haiku", "claude-sonnet-5-5", "claude-sonnet-5-5[1m]", "claude-haiku-4-5-20251001"],
-)
-def test_should_move_the_spawn_to_opus(requested_model: object) -> None:
-    tool_input = dict(SPAWN_INPUT)
-    if requested_model is not None:
-        tool_input["model"] = requested_model
-    decision = json.loads(_run_hook(tool_input))["hookSpecificOutput"]
-    assert decision["hookEventName"] == "PreToolUse"
-    assert "permissionDecision" not in decision
-    assert decision["updatedInput"] == {**SPAWN_INPUT, "model": "opus"}
-
-
-@pytest.mark.parametrize("requested_model", ["opus", "fable", "claude-opus-5-5", "claude-fable-5-1"])
-def test_should_leave_an_opus_or_fable_spawn_alone(requested_model: str) -> None:
-    assert _run_hook({**SPAWN_INPUT, "model": requested_model}) == ""
-
-
-def test_should_pass_a_tool_input_that_is_not_an_object() -> None:
-    assert _run_hook(["not", "an", "object"]) == ""
-
-
-def test_should_register_the_pin_on_the_agent_and_task_matcher() -> None:
-    all_agent_entries = [
-        each_entry
-        for each_entry in json.loads(HOOKS_JSON.read_text(encoding="utf-8"))["hooks"]["PreToolUse"]
-        if each_entry["matcher"] == "Agent|Task"
-    ]
-    all_commands = [
-        each_hook["command"] for each_entry in all_agent_entries for each_hook in each_entry["hooks"]
-    ]
-    assert any("subagent_model_pin_hook.py" in each_command for each_command in all_commands)
-
-
-def test_should_keep_every_constant_free_of_a_sonnet_model_id() -> None:
-    all_offending_files = [
-        each_file.name
-        for each_file in CONSTANTS_DIRECTORY.glob("*.py")
-        if not each_file.name.startswith("test_")
-        and "claude-sonnet" in each_file.read_text(encoding="utf-8")
-    ]
-    assert all_offending_files == []