claude-dev-env 8.53.1 → 8.53.3

package/hooks/blocking/reply_length_gate.py

@@ -10,6 +10,13 @@ It also denies a pull request number the reader cannot open::
     flag: It merged in #4347.
     ok:   Both land in [PR 5256](https://github.com/owner/repo/pull/5256).
 
+It denies a colon that joins two clauses on one line, and an em dash::
+
+    flag: That second reading matters: one message added 6.7k.
+    ok:   That second reading matters. One message added 6.7k.
+    ok:   Two checks failed at 9:47, then the list follows:
+          (each item on its own line below the colon)
+
 It denies a banned word or phrase, matched whole and case-insensitive::
 
     flag: The cause is likely the cache.
@@ -64,6 +71,8 @@ from hooks_constants.reply_length_gate_constants import (
     CONFIG_FILE_ENCODING,
     DECISION_CARD_OPTIONS_KEY,
     DECISION_CARD_TOOL_NAME,
+    EM_DASH_MESSAGE,
+    EM_DASH_PATTERN,
     FENCED_BLOCK_PATTERN,
     HOOK_EVENT_NAME,
     INLINE_CODE_PATTERN,
@@ -73,6 +82,8 @@ from hooks_constants.reply_length_gate_constants import (
     MARKDOWN_LINK_PATTERN,
     MAXIMUM_SENTENCE_COUNT,
     MAXIMUM_WORDS_PER_SENTENCE,
+    MID_SENTENCE_COLON_MESSAGE,
+    MID_SENTENCE_COLON_PATTERN,
     RETRY_INSTRUCTION,
     SENTENCE_END_PATTERN,
     SENTENCE_PREVIEW_SUFFIX,
@@ -126,6 +137,20 @@ def length_violation(reply_text: str) -> str | None:
     return None
 
 
+def mid_sentence_colon_violation(reply_text: str) -> str | None:
+    """Return the deny reason for a colon followed by prose on its line, or None."""
+    if MID_SENTENCE_COLON_PATTERN.search(countable_text(reply_text)) is None:
+        return None
+    return MID_SENTENCE_COLON_MESSAGE
+
+
+def em_dash_violation(reply_text: str) -> str | None:
+    """Return the deny reason for an em dash in the prose, or None."""
+    if EM_DASH_PATTERN.search(countable_text(reply_text)) is None:
+        return None
+    return EM_DASH_MESSAGE
+
+
 def unlinked_pull_request_violation(reply_text: str) -> str | None:
     """Return the deny reason for a pull request number outside a link, or None."""
     without_fences = FENCED_BLOCK_PATTERN.sub(" ", reply_text)
@@ -203,6 +228,8 @@ def tool_violation(tool_name: object, all_tool_input: dict[str, object]) -> tupl
         return None
     violation = (
         length_violation(reply_text)
+        or mid_sentence_colon_violation(reply_text)
+        or em_dash_violation(reply_text)
         or unlinked_pull_request_violation(reply_text)
         or banned_word_violation(reply_text, configured_banned_words())
     )

package/hooks/blocking/test_reply_length_gate.py

@@ -442,3 +442,48 @@ def test_should_apply_the_configured_list_to_decision_cards(
     )
     assert (probably_exit_code, synergy_exit_code) == (0, 2)
     assert 'Banned word "synergy"' in stderr_text
+
+
+QUOTED_COLON_SENTENCE = "That second reading matters: one message added 6.7k to Messages."
+
+
+def test_should_deny_the_quoted_mid_sentence_colon(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+) -> None:
+    exit_code, stderr_text = run_gate(
+        monkeypatch, capsys, POST_TOOL_NAME, {"text": QUOTED_COLON_SENTENCE}
+    )
+    assert exit_code == 2
+    assert "colon" in stderr_text
+
+
+@pytest.mark.parametrize(
+    "allowed_text",
+    [
+        "That second reading matters. One message added 6.7k to Messages.",
+        "Two checks failed:\n- lint\n- types",
+        "It fired at 9:47 today.",
+        "The call `a: int` passed.",
+        "See https://example.com/a: b for it.",
+        "Both land in [PR 5256](https://github.com/owner/repo/pull/5256).",
+        "```\nflag: x\n```",
+    ],
+)
+def test_should_allow_a_colon_that_introduces_a_list_or_sits_in_a_span(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str], allowed_text: str
+) -> None:
+    exit_code, stderr_text = run_gate(monkeypatch, capsys, REPLY_TOOL_NAME, {"text": allowed_text})
+    assert (exit_code, stderr_text) == (0, "")
+
+
+def test_should_deny_an_em_dash_and_allow_one_in_code(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+) -> None:
+    denied_code, denied_text = run_gate(
+        monkeypatch, capsys, REPLY_TOOL_NAME, {"text": "The fix \u2014 a rename \u2014 is in."}
+    )
+    allowed_code, _ = run_gate(
+        monkeypatch, capsys, REPLY_TOOL_NAME, {"text": "The fix uses `\u2014` in a label."}
+    )
+    assert (denied_code, allowed_code) == (2, 0)
+    assert "em dash" in denied_text

package/hooks/hooks_constants/reply_length_gate_constants.py

@@ -24,6 +24,8 @@ MARKDOWN_LINK_PATTERN = re.compile(r"\[[^\]\n]*\]\([^)\s]*\)")
 UNLINKED_PULL_REQUEST_PATTERN = re.compile(
     r"\b(?:PRs?|pull requests?)\s*#?\d+|(?<![\w/&])#\d+", re.IGNORECASE
 )
+MID_SENTENCE_COLON_PATTERN = re.compile(r":[ \t]+\S")
+EM_DASH_PATTERN = re.compile("\u2014")
 LINE_BREAK_PATTERN = re.compile(r"\n+")
 SENTENCE_END_PATTERN = re.compile(r"(?<=[.!?])\s+")
 WORD_PATTERN = re.compile(r"[A-Za-z0-9]+(?:['.,-][A-Za-z0-9]+)*")
@@ -33,6 +35,11 @@ SENTENCE_PREVIEW_SUFFIX = "..."
 RETRY_INSTRUCTION = " Cut the text and resend the call."
 TOO_MANY_SENTENCES_MESSAGE = "Reply too long: {sentence_count} sentences, limit {sentence_limit}."
 UNLINKED_PULL_REQUEST_MESSAGE = 'Pull request "{reference}" has no link. Write it as [PR N](https://github.com/<owner>/<repo>/pull/N).'
+MID_SENTENCE_COLON_MESSAGE = (
+    "A colon joins two clauses on one line. Write two sentences, or end the line with the colon"
+    " and put the list on the lines below."
+)
+EM_DASH_MESSAGE = "An em dash is in the text. Use a period or a comma."
 ALL_DEFAULT_BANNED_WORDS = (
     "real",
     "really",

package/hooks/hooks_constants/test_reply_length_gate_constants.py

@@ -45,3 +45,9 @@ def test_gate_reads_only_the_prose_fields_of_a_decision_card() -> None:
         constants.DECISION_CARD_OPTIONS_KEY,
         constants.ALL_DECISION_OPTION_PROSE_KEYS,
     ) == (("question", "context"), "options", ("label", "consequence"))
+
+
+def test_colon_pattern_matches_a_colon_with_prose_after_it_on_the_line() -> None:
+    assert constants.MID_SENTENCE_COLON_PATTERN.search("matters: one message")
+    assert constants.MID_SENTENCE_COLON_PATTERN.search("at 9:47") is None
+    assert constants.MID_SENTENCE_COLON_PATTERN.search("items:\n- one") is None

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.53.1",
+    "version": "8.53.3",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {

package/scripts/account_broker.py

@@ -54,6 +54,7 @@ from dev_env_scripts_constants.account_broker_constants import (
 from dev_env_scripts_constants.codex_account_constants import (
     CODEX_HOME_ENVIRONMENT_VARIABLE,
     MAIN_CODEX_HOME_DIRECTORY_NAME,
+    NO_ROSTER_ACCOUNT_NAME,
     TIER_NORMAL,
 )
 
@@ -78,7 +79,7 @@ def choose_from_readings(
     """
     if product is Product.CODEX and not all_readings:
         home = Path(os.environ.get(CODEX_HOME_ENVIRONMENT_VARIABLE) or Path.home() / MAIN_CODEX_HOME_DIRECTORY_NAME).resolve()
-        return Decision("run", Account(product, "default", home, True), None, "no roster is configured", TIER_NORMAL)
+        return Decision("run", Account(product, NO_ROSTER_ACCOUNT_NAME, home, True), None, "no roster is configured", TIER_NORMAL)
     all_available = [each_reading for each_reading in all_readings if each_reading.account not in all_spent_accounts]
     selected = (
         _choose_claude(all_available, preferred_command)
@@ -366,7 +367,8 @@ def _parse_spent_mark(all_accounts_by_name: Mapping[str, Reading], mark: str, pr
         raise BrokerConfigurationError(f"invalid reset for account {name}") from error
     reading = all_accounts_by_name.get(name)
     if reading is None:
-        print(f"warning: spent mark names {name}, an account outside the roster; choose waits until its reset", file=sys.stderr)
+        if all_accounts_by_name or name != NO_ROSTER_ACCOUNT_NAME:
+            print(f"warning: spent mark names {name}, an account outside the roster; choose waits until its reset", file=sys.stderr)
         return Reading(Account(product, name, Path(), False), None), reset
     return reading, reset
 

package/scripts/dev_env_scripts_constants/codex_account_constants.py

@@ -66,6 +66,9 @@ CODEX_PROFILES_ROOT_ENVIRONMENT_VARIABLE: str = "CODEX_PROFILES_ROOT"
 MAIN_CODEX_HOME_DIRECTORY_NAME: str = ".codex"
 """Directory under the user home that holds the shared Codex setup."""
 
+NO_ROSTER_ACCOUNT_NAME: str = "default"
+"""Account name the broker gives the shared Codex home when no roster is configured."""
+
 CODEX_HOME_ENVIRONMENT_VARIABLE: str = "CODEX_HOME"
 """Environment variable that points Codex at one account's home."""
 

package/scripts/test_account_broker.py

@@ -1026,6 +1026,38 @@ def test_should_warn_when_a_spent_mark_names_an_account_outside_the_roster(
     assert "outside the roster" in all_warning_lines[0]
 
 
+def test_should_not_warn_when_the_default_account_is_marked_without_a_roster(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+) -> None:
+    monkeypatch.setitem(account_broker.all_product_adapters, Product.CODEX, _adapter((), {}))
+    _freeze_clock(monkeypatch, NOW)
+    reset = NOW + timedelta(hours=2)
+
+    account_broker.main(("choose", "--product", "codex", "--spent", f"default:{int(reset.timestamp())}"))
+
+    assert capsys.readouterr().err == ""
+
+
+@pytest.mark.parametrize(
+    ("all_roster_names", "marked_name"),
+    [(("first",), "default"), ((), "visitor")],
+)
+def test_should_warn_when_a_spent_mark_names_an_account_the_roster_lacks(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str], all_roster_names: tuple[str, ...], marked_name: str
+) -> None:
+    all_accounts = tuple(_account(each_name) for each_name in all_roster_names)
+    monkeypatch.setitem(account_broker.all_product_adapters, Product.CODEX, _adapter(all_accounts, {each_name: _meters(80, 80) for each_name in all_roster_names}))
+    _freeze_clock(monkeypatch, NOW)
+    reset = NOW + timedelta(hours=2)
+
+    account_broker.main(("choose", "--product", "codex", "--spent", f"{marked_name}:{int(reset.timestamp())}"))
+
+    all_warning_lines = capsys.readouterr().err.splitlines()
+    assert len(all_warning_lines) == 1
+    assert marked_name in all_warning_lines[0]
+    assert "outside the roster" in all_warning_lines[0]
+
+
 @pytest.mark.parametrize("mark", ["", ":1800000000"])
 def test_should_reject_a_spent_mark_without_an_account_name(
     monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str], mark: str