claude-dev-env 8.51.0 → 8.51.2

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.51.0",
+    "version": "8.51.2",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {

package/rules/build-needs-a-user.md

@@ -5,7 +5,7 @@ paths:
   - "**/bin/**"
   - "**/ci/**"
   - "**/tools/**"
-  - "**/skills/*/scripts/**"
+  - "**/skills/**"
   - "**/commands/**"
 ---
 

package/scripts/sweep_empty_dirs.py

@@ -36,12 +36,29 @@ def _log_walk_error(os_error: OSError) -> None:
     logging.warning("cannot scan %s -- %s", os_error.filename, os_error.strerror)
 
 
+def _is_older_than(directory_path: str, now: float, min_age_seconds: int) -> bool:
+    """Report whether a directory ctime precedes *now* by more than the minimum age."""
+    try:
+        raw_ctime = os.path.getctime(directory_path)
+    except FileNotFoundError:
+        return False
+    except PermissionError:
+        logging.warning("permission denied -- %s", directory_path)
+        return False
+    except OSError:
+        return False
+    ctime = min(raw_ctime, now)
+    return now - ctime > min_age_seconds
+
+
 def sweep(root: str, min_age_seconds: int) -> list[str]:
     """Remove empty directories under *root* older than *min_age_seconds*.
 
-    Walks bottom-up so nested empty directories are cleaned from the leaves
-    inward.  Relies on os.rmdir to fail harmlessly for non-empty directories
-    instead of checking snapshotted subdirectory lists.
+    Reads the age of every directory before the first removal, because on
+    POSIX removing a child directory moves its parent's ctime to the present.
+    Then removes bottom-up so nested empty directories are cleaned from the
+    leaves inward.  os.rmdir decides emptiness and fails harmlessly for a
+    directory that still holds an entry.
 
     Args:
         root: Root directory to walk; directories below the root are
@@ -56,35 +73,28 @@ def sweep(root: str, min_age_seconds: int) -> list[str]:
     all_removed: list[str] = []
 
     now = time.time()
-    for each_directory_path, _, _ in os.walk(
-        root, onerror=_log_walk_error, topdown=False
-    ):
-        if each_directory_path == root:
-            continue
+    all_expired_directories = [
+        each_directory_path
+        for each_directory_path, _, _ in os.walk(
+            root, onerror=_log_walk_error, topdown=False
+        )
+        if each_directory_path != root
+        and _is_older_than(each_directory_path, now, min_age_seconds)
+    ]
+    for each_directory_path in all_expired_directories:
         try:
-            raw_ctime = os.path.getctime(each_directory_path)
+            os.rmdir(each_directory_path)
+            logging.info("deleted: %s", each_directory_path)
+            all_removed.append(each_directory_path)
         except FileNotFoundError:
-            continue
-        except PermissionError:
-            logging.warning("permission denied -- %s", each_directory_path)
-            continue
-        except OSError:
-            continue
-        ctime = min(raw_ctime, now)
-        if now - ctime > min_age_seconds:
-            try:
-                os.rmdir(each_directory_path)
-                logging.info("deleted: %s", each_directory_path)
-                all_removed.append(each_directory_path)
-            except FileNotFoundError:
-                pass
-            except OSError as e:
-                if e.errno not in (errno.ENOTEMPTY, errno.EEXIST):
-                    logging.warning(
-                        "could not remove %s -- %s",
-                        each_directory_path,
-                        e,
-                    )
+            pass
+        except OSError as e:
+            if e.errno not in (errno.ENOTEMPTY, errno.EEXIST):
+                logging.warning(
+                    "could not remove %s -- %s",
+                    each_directory_path,
+                    e,
+                )
 
     return all_removed
 

package/scripts/test_sweep_empty_dirs.py

@@ -107,6 +107,17 @@ def test_sweep_removes_nested_empty_dirs(tmp_path: Path) -> None:
     assert not (tmp_path / "level1").exists()
 
 
+def test_sweep_reports_a_nested_chain_removed_leaf_first_in_one_pass(tmp_path: Path) -> None:
+    """sweep reads every age before it removes, so one pass clears the whole chain."""
+    outer = tmp_path / "outer"
+    inner = outer / "inner"
+    inner.mkdir(parents=True)
+
+    removed = sweep(str(tmp_path), min_age_seconds=0)
+
+    assert removed == [str(inner), str(outer)]
+
+
 def test_sweep_removes_only_old_enough_directories(tmp_path: Path) -> None:
     """sweep does not remove directories newer than the age threshold."""
     young_dir = tmp_path / "young"