claude-dev-env 8.48.0 → 8.48.2

package/hooks/blocking/test_code_rules_enforcer_ephemeral.py

@@ -28,6 +28,8 @@ _ENFORCER_SCRIPT = Path(__file__).resolve().parent / "code_rules_enforcer.py"
 
 _VIOLATING_PRODUCTION_SOURCE = "def process_data(payload: str) -> None:\n    print(payload)\n"
 
+_DIRECTORY_OUTSIDE_TEMP_ROOTS = Path("/home/user")
+
 
 def _run_enforcer_cli(
     all_cli_arguments: list[str],
@@ -74,6 +76,7 @@ def test_should_return_false_for_os_tempfile_gettempdir_root(
     """
     monkeypatch.delenv("CLAUDE_CODE_RULES_DISABLE_EPHEMERAL_EXEMPT", raising=False)
     monkeypatch.delenv("CLAUDE_JOB_DIR", raising=False)
+    monkeypatch.setattr(tempfile, "tempdir", str(_DIRECTORY_OUTSIDE_TEMP_ROOTS / "os_temp_root"))
     system_temp_root = tempfile.gettempdir()
     scratch_path = str(Path(system_temp_root) / "scratch_work.py")
     assert is_ephemeral_script_path(scratch_path) is False
@@ -82,7 +85,6 @@ def test_should_return_false_for_os_tempfile_gettempdir_root(
 @pytest.mark.parametrize("env_name", ["TMPDIR", "TEMP", "TMP"])
 def test_should_return_false_for_tmpdir_temp_tmp_env_roots(
     env_name: str,
-    tmp_path: Path,
     monkeypatch: pytest.MonkeyPatch,
 ) -> None:
     """B3: $TMPDIR / $TEMP / $TMP are not ephemeral sources.
@@ -92,8 +94,9 @@ def test_should_return_false_for_tmpdir_temp_tmp_env_roots(
     """
     monkeypatch.delenv("CLAUDE_CODE_RULES_DISABLE_EPHEMERAL_EXEMPT", raising=False)
     monkeypatch.delenv("CLAUDE_JOB_DIR", raising=False)
-    monkeypatch.setenv(env_name, str(tmp_path / "env_root"))
-    scratch_path = str(tmp_path / "env_root" / "scratch.py")
+    env_root = _DIRECTORY_OUTSIDE_TEMP_ROOTS / "env_root"
+    monkeypatch.setenv(env_name, str(env_root))
+    scratch_path = str(env_root / "scratch.py")
     assert is_ephemeral_script_path(scratch_path) is False
 
 
@@ -111,7 +114,8 @@ def test_should_return_false_for_pytest_tmp_path_when_job_dir_elsewhere(
     """
     monkeypatch.delenv("CLAUDE_CODE_RULES_DISABLE_EPHEMERAL_EXEMPT", raising=False)
     monkeypatch.setenv("CLAUDE_JOB_DIR", str(tmp_path / "elsewhere"))
-    pytest_sandbox_target = str(tmp_path / "candidate.py")
+    monkeypatch.setattr(tempfile, "tempdir", str(_DIRECTORY_OUTSIDE_TEMP_ROOTS / "os_temp_root"))
+    pytest_sandbox_target = str(Path(tempfile.gettempdir()) / "pytest-of-user" / "candidate.py")
     assert is_ephemeral_script_path(pytest_sandbox_target) is False
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.48.0",
+    "version": "8.48.2",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {

package/scripts/account_broker_support.py

@@ -25,12 +25,14 @@ import codex_account_meters
 from claude_account_profile import default_profile_home, validate_profile_name
 from claude_chain_usage import WeeklyUtilizationProbeError, probe_account_meters
 from dev_env_scripts_constants.account_broker_constants import (
+    ALL_BATCH_FILE_EXTENSIONS,
     BROKER_STATE_DIRECTORY_NAME,
     BROKER_STATE_FILE_NAME,
     BROKER_STATE_LOCK_SUFFIX,
     BROKER_STATE_TEMP_SUFFIX,
     Account,
     BrokerConfigurationError,
+    CMD_SHELL_METACHARACTERS,
     Decision,
     JobOutcome,
     Meters,
@@ -434,7 +436,29 @@ def _resolve_command(all_argv: Sequence[str]) -> list[str]:
     resolved_command = shutil.which(command_name)
     if resolved_command is None and not os.path.dirname(command_name):
         raise FileNotFoundError(errno.ENOENT, "command not found on PATH", command_name)
-    return [resolved_command or command_name, *all_arguments]
+    launched_command = resolved_command or command_name
+    _refuse_batch_file_shell_metacharacters(launched_command, all_arguments)
+    return [launched_command, *all_arguments]
+
+
+def _refuse_batch_file_shell_metacharacters(launched_command: str, all_arguments: Sequence[str]) -> None:
+    if os.path.splitext(launched_command)[1].casefold() not in ALL_BATCH_FILE_EXTENSIONS:
+        return
+    shell_parsed_argument = next(
+        (
+            each_argument
+            for each_argument in all_arguments
+            if any(each_character in CMD_SHELL_METACHARACTERS for each_character in each_argument)
+        ),
+        None,
+    )
+    if shell_parsed_argument is None:
+        return
+    raise OSError(
+        errno.EINVAL,
+        f"cmd.exe would parse the batch file argument {shell_parsed_argument!r}; send that text on stdin",
+        launched_command,
+    )
 
 
 def _run_captured_subprocess(all_argv: Sequence[str], **options: object) -> subprocess.CompletedProcess[str]:

package/scripts/dev_env_scripts_constants/account_broker_constants.py

@@ -58,6 +58,8 @@ BROKER_STATE_FILE_NAME = "state.json"
 BROKER_STATE_TEMP_SUFFIX = ".json"
 BROKER_STATE_LOCK_SUFFIX = ".lock"
 SECONDS_PER_HOUR = 3600
+ALL_BATCH_FILE_EXTENSIONS = frozenset({".bat", ".cmd"})
+CMD_SHELL_METACHARACTERS = "&|<>^%!\"\r\n"
 ALL_PARENT_CLAUDE_SESSION_VARIABLES: frozenset[str] = frozenset({
     "CLAUDE_CODE_SESSION_ID",
     "CLAUDE_CODE_REMOTE",

package/scripts/test_account_broker_support.py

@@ -190,3 +190,62 @@ def test_should_refuse_to_launch_a_bare_command_missing_from_path(monkeypatch: p
 
     assert raised.value.errno == errno.ENOENT
     assert raised.value.filename == "claude"
+
+
+@pytest.mark.parametrize("metacharacter", ["&", "|", "<", ">", "^", "%", "!", '"', "\n", "\r"])
+def test_should_refuse_a_batch_file_argument_that_cmd_would_parse(
+    monkeypatch: pytest.MonkeyPatch, metacharacter: str
+) -> None:
+    resolved_command = r"C:\Users\someone\AppData\Roaming\npm\claude.cmd"
+    monkeypatch.setattr(shutil, "which", lambda name: resolved_command)
+    monkeypatch.setattr(support.subprocess, "run", lambda *arguments, **options: pytest.fail("a batch file ran"))
+
+    with pytest.raises(OSError) as raised:
+        support.subprocess_runner(["claude", "-p", f"fix{metacharacter}test"])
+
+    assert raised.value.errno == errno.EINVAL
+    assert raised.value.filename == resolved_command
+    assert "stdin" in raised.value.strerror
+
+
+def test_should_refuse_metacharacters_for_an_uppercase_bat_extension(monkeypatch: pytest.MonkeyPatch) -> None:
+    resolved_command = r"C:\tools\CLAUDE.BAT"
+    monkeypatch.setattr(shutil, "which", lambda name: resolved_command)
+    monkeypatch.setattr(support.subprocess, "run", lambda *arguments, **options: pytest.fail("a batch file ran"))
+
+    with pytest.raises(OSError) as raised:
+        support.subprocess_runner(["claude", "a & b"])
+
+    assert raised.value.errno == errno.EINVAL
+
+
+def test_should_launch_a_batch_file_with_flags_only(monkeypatch: pytest.MonkeyPatch) -> None:
+    resolved_command = r"C:\Users\someone\AppData\Roaming\npm\claude.cmd"
+    monkeypatch.setattr(shutil, "which", lambda name: resolved_command)
+    all_launched_argv: list[list[str]] = []
+
+    def fake_run(all_argv: list[str], **options: object) -> subprocess.CompletedProcess[bytes]:
+        all_launched_argv.append(list(all_argv))
+        return subprocess.CompletedProcess(all_argv, 0)
+
+    monkeypatch.setattr(support.subprocess, "run", fake_run)
+
+    support.subprocess_runner(["claude", "-p", "--output-format", "json", "--model", "opus"], input=b"a & b")
+
+    assert all_launched_argv == [[resolved_command, "-p", "--output-format", "json", "--model", "opus"]]
+
+
+def test_should_pass_metacharacters_to_an_executable_unchanged(monkeypatch: pytest.MonkeyPatch) -> None:
+    resolved_command = "/usr/local/bin/claude"
+    monkeypatch.setattr(shutil, "which", lambda name: resolved_command)
+    all_launched_argv: list[list[str]] = []
+
+    def fake_run(all_argv: list[str], **options: object) -> subprocess.CompletedProcess[bytes]:
+        all_launched_argv.append(list(all_argv))
+        return subprocess.CompletedProcess(all_argv, 0)
+
+    monkeypatch.setattr(support.subprocess, "run", fake_run)
+
+    support.subprocess_runner(["claude", "-p", 'say "a & b" | 100%!'])
+
+    assert all_launched_argv == [[resolved_command, "-p", 'say "a & b" | 100%!']]