claude-dev-env 8.46.27 → 8.46.29

package/docs/code-rules/core-principles-and-config.md

@@ -30,9 +30,9 @@ Search config for the exact value and a semantic match. Add timing to config/tim
 
 Run the named pytest node or command with the described input. A breach produces a rule finding; advisory checks write to stderr.
 
-- check_config_duplicate_path_anchor: two config constants pointing at the same path; `python -m pytest packages/claude-dev-env/hooks/blocking` reports a named violation.
+- check_config_duplicate_path_anchor: two config constants pointing at the same path; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_config_duplicate_path_anchor.py::test_should_flag_reanchored_base_already_built_by_sibling` reports a named violation.
 - check_constants_outside_config: UPPER_SNAKE = 3 in a production module; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_enforcer_config_path.py::test_should_produce_blocking_for_module_level_upper_snake_outside_config` reports a named violation.
-- check_constants_outside_config_advisory: a function-local UPPER_SNAKE constant; `python -m pytest packages/claude-dev-env/hooks/blocking` reports a stderr advisory.
+- check_constants_outside_config_advisory: a function-local UPPER_SNAKE constant; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_enforcer_split_constants_config.py::test_advisory_should_flag_annotated_function_body_constant` reports a stderr advisory.
 - check_fstring_structural_literals: an f-string that embeds a URL path fragment; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_enforcer_fstring_scan.py::test_should_flag_fstring_with_url_path` reports a named violation.
 - check_magic_values: a production function comparing a value with 2; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_enforcer_magic_allowlist.py::test_check_magic_values_should_flag_literal_two_in_function_body` reports a named violation.
 - check_duplicated_format_patterns: the same f-string skeleton at three call sites; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_enforcer_split_optional_params.py::test_should_advise_when_fstring_skeleton_appears_three_or_more_times` reports a stderr advisory.

package/docs/code-rules/lint-enforced-rules.md

@@ -46,15 +46,15 @@ Run the named pytest node or command with the described input. A breach produces
 - check_module_docstring_names_public_checks: a module summary omitting a public check; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_enforcer_module_docstring_roster.py::test_should_flag_module_docstring_omitting_a_public_check` reports a named violation.
 - check_module_docstring_scope_omits_data_schema_constants: a module summary listing schema constants as behavior; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_enforcer_module_docstring_data_schema_scope.py` reports a named violation.
 - check_imports_at_top: an ordinary import inside a function; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_enforcer_type_checking_scope.py::test_should_flag_runtime_import_inside_function_even_if_file_uses_type_checking` reports a named violation.
-- check_js_bare_flag_return_directive: a JavaScript return directive with an unexplained bare flag; `python -m pytest packages/claude-dev-env/hooks/blocking` reports a named violation.
-- check_js_resume_task_enumeration_coverage: a resume task branch missing an enumerated state; `python -m pytest packages/claude-dev-env/hooks/blocking` reports a named violation.
-- check_js_returns_object_schemaless_branch: sibling JavaScript return paths with an ad hoc object; `python -m pytest packages/claude-dev-env/hooks/blocking` reports a named violation.
-- check_js_sibling_return_object_key_drift: sibling return objects with different keys; `python -m pytest packages/claude-dev-env/hooks/blocking` reports a named violation.
-- check_library_print: a print call in library code; `python -m pytest packages/claude-dev-env/hooks/blocking` reports a named violation.
-- check_logging_adjacent_string_literals: adjacent string literals in a logger call; `python -m pytest packages/claude-dev-env/hooks/blocking` reports a named violation.
+- check_js_bare_flag_return_directive: a JavaScript return directive with an unexplained bare flag; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_js_bare_flag_return_directive.py::test_flags_bare_down_directive_when_the_workflow_states_the_contract` reports a named violation.
+- check_js_resume_task_enumeration_coverage: a resume task branch missing an enumerated state; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_js_resume_task_enumeration.py::should_flag_resume_branch_absent_from_spawn_enumeration` reports a named violation.
+- check_js_returns_object_schemaless_branch: sibling JavaScript return paths with an ad hoc object; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_js_returns_object_schemaless.py::test_flags_schema_less_branch_under_returns_object_claim` reports a named violation.
+- check_js_sibling_return_object_key_drift: sibling return objects with different keys; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_js_sibling_return_object_key_drift.py::test_flags_blocker_return_that_omits_one_documented_field` reports a named violation.
+- check_library_print: a print call in library code; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_enforcer_library_print.py::test_should_flag_print_call_in_library_module` reports a named violation.
+- check_logging_adjacent_string_literals: adjacent string literals in a logger call; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_logging_adjacent_literals.py::test_should_flag_adjacent_literals_in_attribute_logger_call` reports a named violation.
 - check_logging_fstrings: an f-string passed to logger.info; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_enforcer_logger_fstring.py::test_should_flag_logger_info_fstring` reports a named violation.
 - check_naive_datetime_construction: datetime.fromtimestamp without a timezone; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_enforcer_naive_datetime.py::test_flags_fromtimestamp_without_timezone` reports a named violation.
-- check_windows_api_none: a Windows API call passed None for a required argument; `python -m pytest packages/claude-dev-env/hooks/blocking` reports a named violation.
+- check_windows_api_none: a Windows API call passed None for a required argument; `python -m pytest packages/claude-dev-env/hooks/blocking/test_code_rules_enforcer_windows_api_none.py::test_should_flag_win32gui_call_passing_none` reports a named violation.
 
 ## Gotchas
 

package/hooks/blocking/test_code_rules_enforcer_library_print.py

@@ -0,0 +1,26 @@
+"""Tests for check_library_print."""
+
+from __future__ import annotations
+
+from code_rules_enforcer import check_library_print
+
+LIBRARY_FILE_PATH = "shared_utils/web_automation/sample.py"
+CLI_FILE_PATH = "shared_utils/web_automation/sample_cli.py"
+PRINTING_SOURCE = "def report_status(status_text: str) -> None:\n    print(status_text)\n"
+
+
+def test_should_flag_print_call_in_library_module() -> None:
+    issues = check_library_print(PRINTING_SOURCE, LIBRARY_FILE_PATH)
+    assert issues == [
+        "Line 2: Library print() - route through logger or accept an explicit stream parameter"
+    ]
+
+
+def test_should_flag_sys_stderr_write_in_library_module() -> None:
+    writing_source = "import sys\n\nsys.stderr.write('done')\n"
+    issues = check_library_print(writing_source, LIBRARY_FILE_PATH)
+    assert issues == ["Line 3: sys.stderr.write - route through logger"]
+
+
+def test_should_allow_print_call_in_cli_entry_point() -> None:
+    assert check_library_print(PRINTING_SOURCE, CLI_FILE_PATH) == []

package/hooks/blocking/test_code_rules_enforcer_windows_api_none.py

@@ -0,0 +1,17 @@
+"""Tests for check_windows_api_none."""
+
+from __future__ import annotations
+
+from code_rules_enforcer import check_windows_api_none
+
+
+def test_should_flag_win32gui_call_passing_none() -> None:
+    source = "win32gui.SetWindowPos(window_handle, " + "None)\n"
+    assert check_windows_api_none(source) == [
+        "Line 1: win32gui call with None - use 0 for unused int params"
+    ]
+
+
+def test_should_allow_win32gui_call_passing_zero() -> None:
+    source = "win32gui.SetWindowPos(window_handle, 0)\n"
+    assert check_windows_api_none(source) == []

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.46.27",
+    "version": "8.46.29",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {

package/scripts/dev_env_scripts_constants/account_broker_constants.py

@@ -2,9 +2,10 @@
 
 from __future__ import annotations
 
-import importlib.util
+import importlib.machinery
 import os
 import subprocess
+import types
 from dataclasses import dataclass, field
 from datetime import datetime, timedelta, timezone
 from enum import Enum
@@ -63,11 +64,12 @@ def codex_usage_limit_signatures() -> tuple[str, ...]:
         ImportError: The marker module cannot be loaded.
     """
     constants_path = Path(__file__).resolve().parents[2] / "_shared" / "pr-loop" / "scripts" / "codex_review_scripts_constants" / "classifier_constants.py"
-    specification = importlib.util.spec_from_file_location("account_broker_codex_classifier_constants", constants_path)
-    if specification is None or specification.loader is None:
-        raise ImportError(f"cannot load usage markers from {constants_path}")
-    module = importlib.util.module_from_spec(specification)
-    specification.loader.exec_module(module)
+    loader = importlib.machinery.SourceFileLoader("account_broker_codex_classifier_constants", str(constants_path))
+    module = types.ModuleType(loader.name)
+    try:
+        loader.exec_module(module)
+    except OSError as error:
+        raise ImportError(f"cannot load usage markers from {constants_path}") from error
     return module.ALL_USAGE_LIMIT_MARKERS
 
 

package/scripts/dev_env_scripts_constants/test_account_broker_constants.py

@@ -4,6 +4,7 @@ from __future__ import annotations
 
 import dataclasses
 from datetime import datetime, timedelta, timezone
+from pathlib import Path
 
 import pytest
 
@@ -58,6 +59,18 @@ def test_codex_usage_limit_signatures_loads_classifier_markers() -> None:
     assert "http 429" in signatures
 
 
+def test_codex_usage_limit_signatures_raises_import_error_when_markers_are_missing(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
+    monkeypatch.setattr(broker_constants, "__file__", str(tmp_path / "scripts" / "constants" / "module.py"))
+
+    with pytest.raises(ImportError, match="cannot load usage markers from") as raised:
+        broker_constants.codex_usage_limit_signatures()
+
+    assert str(tmp_path) in str(raised.value)
+    assert isinstance(raised.value.__cause__, FileNotFoundError)
+
+
 def test_utc_time_text_converts_an_offset_timestamp() -> None:
     moment = datetime(2026, 10, 3, 7, 30, tzinfo=timezone(timedelta(hours=-4)))
 

package/scripts/tests/test_code_rules_index.py

@@ -103,6 +103,30 @@ def test_should_assign_each_enforcer_check_to_one_family() -> None:
     assert documented_checks == imported_checks
 
 
+def _assert_proof_target_resolves(proof_label: str, proof_target: str) -> None:
+    module_text, _, test_name = proof_target.partition("::")
+    module_path = _REPOSITORY_ROOT / module_text
+    assert module_path.is_file(), proof_label
+    if test_name:
+        assert re.search(
+            rf"^def {re.escape(test_name)}\(",
+            module_path.read_text(encoding="utf-8"),
+            re.MULTILINE,
+        ), proof_label
+
+
+def test_should_name_a_test_module_in_each_proof_command() -> None:
+    for each_family_path in _FAMILY_DIRECTORY.glob("*.md"):
+        family_text = each_family_path.read_text(encoding="utf-8")
+        all_proofs = re.findall(
+            r"^- (check_\w+):.*?`python -m pytest ([^`\s]+)", family_text, re.MULTILINE
+        )
+        for each_check, each_target in all_proofs:
+            _assert_proof_target_resolves(
+                f"{each_family_path.name}: {each_check} -> {each_target}", each_target
+            )
+
+
 def _collect_citation_texts() -> list[tuple[Path, str]]:
     all_citations: list[tuple[Path, str]] = []
     for each_root in _CITATION_ROOTS: