claude-dev-env 8.46.21 → 8.46.23

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.46.21",
+    "version": "8.46.23",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {

package/scripts/dev_env_scripts_constants/claude_chain_constants.py

@@ -10,5 +10,5 @@ ALL_USAGE_LIMIT_SIGNATURES: tuple[str, ...] = (
 )
 """Case-insensitive substrings that mark a non-zero exit as a usage-limit refusal."""
 
-CHAIN_CONFIG_ERROR_EXIT_CODE: int = 3
+CHAIN_CONFIG_ERROR_EXIT_CODE: int = 5
 """CLI exit code when the chain configuration is missing or invalid."""

package/scripts/dev_env_scripts_constants/grok_worker_constants.py

@@ -493,7 +493,7 @@ SPAWN_SERVED_EXIT_CODE: int = 0
 SPAWN_EXHAUSTED_EXIT_CODE: int = 2
 """CLI exit code when no dispatcher tier served the call."""
 
-SPAWN_CONFIG_ERROR_EXIT_CODE: int = 3
+SPAWN_CONFIG_ERROR_EXIT_CODE: int = 5
 """CLI exit code when the claude chain configuration is missing or invalid."""
 
 RESULT_KEY_TIER_USED: str = "tier_used"

package/scripts/resolve_worker_spawn.py

@@ -607,7 +607,7 @@ def main(all_command_arguments: list[str]) -> int:
 
     A timeout outside the accepted bounds is a config fault: the run prints a
     structured outcome whose attempt reason is ``timeout_out_of_bounds`` and
-    exits ``3``, rather than raising out of the CLI. A broker configuration error,
+    exits ``5``, rather than raising out of the CLI. A broker configuration error,
     or an unknown host profile refused by ``detect_host_profile``, prints the
     same exit code with the refusal text as its output.
 

package/scripts/test_claude_account_worker_process.py

@@ -0,0 +1,47 @@
+from __future__ import annotations
+
+from pathlib import Path
+
+from claude_account_worker_process import invoke_worker
+from dev_env_scripts_constants.account_broker_constants import JobOutcome, Product
+
+
+def test_should_send_job_to_runner_and_return_outcome_with_elapsed_seconds(
+    tmp_path: Path,
+) -> None:
+    expected_outcome = JobOutcome(
+        0, "{}", "", "extra_2", (("extra_2", "served"),), "served", None, None
+    )
+    captured_calls: list[tuple[Product, list[str], dict[str, object]]] = []
+    clock_readings = iter([100.0, 107.5])
+
+    def recording_runner(
+        product: Product, argv: list[str], **options: object
+    ) -> JobOutcome:
+        captured_calls.append((product, argv, options))
+        return expected_outcome
+
+    outcome, elapsed_seconds = invoke_worker(
+        all_arguments=["claude", "-p"],
+        cwd=tmp_path,
+        prompt_text="standalone brief",
+        timeout_minutes=2,
+        runner=recording_runner,
+        monotonic_clock=lambda: next(clock_readings),
+    )
+
+    assert outcome is expected_outcome
+    assert elapsed_seconds == 7.5
+    assert captured_calls == [
+        (
+            Product.CLAUDE,
+            ["claude", "-p"],
+            {
+                "timeout_seconds": 120,
+                "stdin_text": "standalone brief",
+                "cwd": tmp_path,
+                "encoding": "utf-8",
+                "errors": "replace",
+            },
+        )
+    ]

package/scripts/test_claude_account_worker_report.py

@@ -0,0 +1,157 @@
+from __future__ import annotations
+
+import json
+from datetime import datetime, timezone
+from pathlib import Path
+
+import pytest
+
+from claude_account_worker_report import (
+    WorkerReport,
+    finalize_report,
+    make_report,
+    pre_launch_failure_report,
+    wait_report,
+    write_report,
+)
+from dev_env_scripts_constants.account_broker_constants import WAIT_EXIT_CODE
+from dev_env_scripts_constants.claude_account_worker_constants import (
+    STDOUT_TAIL_CHARACTER_LIMIT,
+)
+
+
+def test_should_build_wait_report_with_wait_exit_code_and_reset_time() -> None:
+    reset_at = datetime(2026, 10, 4, 12, tzinfo=timezone.utc)
+
+    report = wait_report("wait", "no account has room", reset_at)
+
+    assert report == WorkerReport(
+        account="wait",
+        reason="no account has room",
+        exit_code=WAIT_EXIT_CODE,
+        duration_seconds=0.0,
+        payload=None,
+        is_error=False,
+        wait_reset_at=reset_at,
+    )
+
+
+def test_should_build_report_from_json_result_and_round_duration() -> None:
+    report = make_report(
+        "extra_2",
+        "served",
+        exit_code=0,
+        duration_seconds=1.23456,
+        stdout_text='{"result":"ready","is_error":false}',
+    )
+
+    assert report.payload == "ready"
+    assert report.is_error is False
+    assert report.duration_seconds == 1.235
+    assert report.wait_reset_at is None
+
+
+def test_should_mark_report_as_error_when_json_flags_error() -> None:
+    report = make_report(
+        "extra_2",
+        "served",
+        exit_code=0,
+        duration_seconds=0.0,
+        stdout_text='{"result":"failed","is_error":true}',
+    )
+
+    assert report.payload == "failed"
+    assert report.is_error is True
+
+
+def test_should_mark_report_as_error_when_exit_code_is_nonzero() -> None:
+    report = make_report(
+        "extra_2",
+        "served",
+        exit_code=5,
+        duration_seconds=0.0,
+        stdout_text='{"result":"ready","is_error":false}',
+    )
+
+    assert report.exit_code == 5
+    assert report.is_error is True
+
+
+def test_should_keep_bounded_stdout_tail_when_stdout_is_not_json() -> None:
+    stdout_text = "x" * STDOUT_TAIL_CHARACTER_LIMIT + "tail"
+
+    report = make_report(
+        "extra_2", "served", exit_code=0, duration_seconds=0.0, stdout_text=stdout_text
+    )
+
+    assert report.payload == stdout_text[-STDOUT_TAIL_CHARACTER_LIMIT:]
+    assert len(report.payload) == STDOUT_TAIL_CHARACTER_LIMIT
+    assert report.is_error is True
+
+
+def test_should_drop_payload_when_json_has_no_result_key() -> None:
+    report = make_report(
+        "extra_2",
+        "served",
+        exit_code=0,
+        duration_seconds=0.0,
+        stdout_text='{"other":1}',
+    )
+
+    assert report.payload is None
+    assert report.is_error is True
+
+
+def test_should_build_pre_launch_failure_report_with_zero_duration() -> None:
+    report = pre_launch_failure_report("none", "prompt file is unreadable", 1)
+
+    assert report.account == "none"
+    assert report.reason == "prompt file is unreadable"
+    assert report.exit_code == 1
+    assert report.duration_seconds == 0.0
+    assert report.is_error is True
+    assert report.wait_reset_at is None
+
+
+def test_should_write_report_as_json_and_create_parent_directory(
+    tmp_path: Path,
+) -> None:
+    reset_at = datetime(2026, 10, 4, 12, tzinfo=timezone.utc)
+    report_file = tmp_path / "nested" / "report.json"
+
+    write_report(report_file, wait_report("wait", "no account has room", reset_at))
+
+    report_text = report_file.read_text(encoding="utf-8")
+    assert report_text.endswith("\n")
+    assert json.loads(report_text) == {
+        "account": "wait",
+        "reason": "no account has room",
+        "exit_code": WAIT_EXIT_CODE,
+        "duration_seconds": 0.0,
+        "result": None,
+        "is_error": False,
+        "wait_reset_at": reset_at.isoformat(),
+    }
+
+
+def test_should_finalize_report_by_writing_it_printing_summary_and_returning_exit_code(
+    tmp_path: Path, capsys: pytest.CaptureFixture[str]
+) -> None:
+    report_file = tmp_path / "report.json"
+    report = make_report(
+        "extra_2",
+        "served",
+        exit_code=4,
+        duration_seconds=2.0,
+        stdout_text='{"result":"done","is_error":false}',
+    )
+
+    exit_code = finalize_report(report_file, report)
+
+    assert exit_code == 4
+    written_report = json.loads(report_file.read_text(encoding="utf-8"))
+    assert written_report["result"] == "done"
+    assert written_report["wait_reset_at"] is None
+    assert (
+        capsys.readouterr().out == f"account=extra_2 exit_code=4 report={report_file}\n"
+    )

package/scripts/test_invoke_code_review_cli.py

@@ -19,7 +19,7 @@ from _code_review_test_support import (
     install_seams,
     run_review_cli,
 )
-from dev_env_scripts_constants.account_broker_constants import BrokerConfigurationError
+from dev_env_scripts_constants.account_broker_constants import BrokerConfigurationError, WAIT_EXIT_CODE
 from dev_env_scripts_constants.claude_chain_constants import (
     CHAIN_CONFIG_ERROR_EXIT_CODE,
 )
@@ -82,6 +82,7 @@ def test_cli_emits_json_on_chain_configuration_error(
     exit_code = run_review_cli(working_directory, session_model=FIXTURE_SESSION_OPUS)
 
     assert exit_code == CHAIN_CONFIG_ERROR_EXIT_CODE
+    assert exit_code != WAIT_EXIT_CODE
     captured = capsys.readouterr()
     parsed_payload = json.loads(captured.out)
     assert parsed_payload == {

package/scripts/test_resolve_worker_spawn.py

@@ -299,12 +299,12 @@ def test_grok_usage_limited_on_claude_host_requires_agent(
 def test_out_of_bounds_timeout_is_reported_as_config_not_worker_failure(
     monkeypatch: pytest.MonkeyPatch, tmp_path: Path, capsys: pytest.CaptureFixture[str]
 ) -> None:
-    """A refused timeout prints a structured outcome and exits 3, never a traceback.
+    """A refused timeout prints a structured outcome and exits 5, never a traceback.
 
     ::
 
-        --timeout-seconds 0     ok: reason timeout_out_of_bounds, exit 3
-        --timeout-seconds 5401  ok: reason timeout_out_of_bounds, exit 3
+        --timeout-seconds 0     ok: reason timeout_out_of_bounds, exit 5
+        --timeout-seconds 5401  ok: reason timeout_out_of_bounds, exit 5
     """
     prompt_file, working_directory, run_state_directory = _paths(tmp_path)
     _install_seams(monkeypatch, grok_outcome=_grok_ok())
@@ -350,7 +350,7 @@ def test_out_of_bounds_timeout_is_refused_when_the_grok_tier_is_unreachable(
     ::
 
         preflight unusable, --timeout-seconds 5401
-            ok: reason timeout_out_of_bounds, exit 3, no tier invoked
+            ok: reason timeout_out_of_bounds, exit 5, no tier invoked
     """
     prompt_file, working_directory, run_state_directory = _paths(tmp_path)
     call_log = _install_seams(
@@ -496,7 +496,7 @@ def test_tier_three_wait_reports_reset_and_stops(
     assert call_log.claude_calls == 1
 
 
-def test_config_error_returns_exit_three(
+def test_config_error_exit_code_differs_from_the_wait_exit_code(
     monkeypatch: pytest.MonkeyPatch, tmp_path: Path, capsys: pytest.CaptureFixture[str]
 ) -> None:
     prompt_file, working_directory, run_state_directory = _paths(tmp_path)
@@ -523,6 +523,7 @@ def test_config_error_returns_exit_three(
     )
 
     assert exit_code == SPAWN_CONFIG_ERROR_EXIT_CODE
+    assert exit_code != WAIT_EXIT_CODE
     captured = capsys.readouterr()
     parsed_payload = json.loads(captured.out)
     assert parsed_payload[RESULT_KEY_OK] is False