claude-dev-env 8.46.20 → 8.46.22

package/docs/rule-guides/failure-blast-radius.md

@@ -42,7 +42,7 @@ for each_member in all_members:
 
 The re-raise comes first, sending an escalation directly through the boundary.
 
-**The boundary recognizes declared types.** A runtime crash inside member work — a `TypeError`, an `AttributeError` — ends the run because its type identifies a code defect. `except Exception` triggers the rule (`CODE_RULES.md` §31).
+**The boundary recognizes declared types.** A runtime crash inside member work — a `TypeError`, an `AttributeError` — ends the run because its type identifies a code defect. `except Exception` triggers the rule (`CODE_RULES.md` §9.7).
 
 ## Repair, park, and the deliverable
 

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.46.20",
+    "version": "8.46.22",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {

package/scripts/test_claude_account_worker_process.py

@@ -0,0 +1,47 @@
+from __future__ import annotations
+
+from pathlib import Path
+
+from claude_account_worker_process import invoke_worker
+from dev_env_scripts_constants.account_broker_constants import JobOutcome, Product
+
+
+def test_should_send_job_to_runner_and_return_outcome_with_elapsed_seconds(
+    tmp_path: Path,
+) -> None:
+    expected_outcome = JobOutcome(
+        0, "{}", "", "extra_2", (("extra_2", "served"),), "served", None, None
+    )
+    captured_calls: list[tuple[Product, list[str], dict[str, object]]] = []
+    clock_readings = iter([100.0, 107.5])
+
+    def recording_runner(
+        product: Product, argv: list[str], **options: object
+    ) -> JobOutcome:
+        captured_calls.append((product, argv, options))
+        return expected_outcome
+
+    outcome, elapsed_seconds = invoke_worker(
+        all_arguments=["claude", "-p"],
+        cwd=tmp_path,
+        prompt_text="standalone brief",
+        timeout_minutes=2,
+        runner=recording_runner,
+        monotonic_clock=lambda: next(clock_readings),
+    )
+
+    assert outcome is expected_outcome
+    assert elapsed_seconds == 7.5
+    assert captured_calls == [
+        (
+            Product.CLAUDE,
+            ["claude", "-p"],
+            {
+                "timeout_seconds": 120,
+                "stdin_text": "standalone brief",
+                "cwd": tmp_path,
+                "encoding": "utf-8",
+                "errors": "replace",
+            },
+        )
+    ]

package/scripts/test_claude_account_worker_report.py

@@ -0,0 +1,157 @@
+from __future__ import annotations
+
+import json
+from datetime import datetime, timezone
+from pathlib import Path
+
+import pytest
+
+from claude_account_worker_report import (
+    WorkerReport,
+    finalize_report,
+    make_report,
+    pre_launch_failure_report,
+    wait_report,
+    write_report,
+)
+from dev_env_scripts_constants.account_broker_constants import WAIT_EXIT_CODE
+from dev_env_scripts_constants.claude_account_worker_constants import (
+    STDOUT_TAIL_CHARACTER_LIMIT,
+)
+
+
+def test_should_build_wait_report_with_wait_exit_code_and_reset_time() -> None:
+    reset_at = datetime(2026, 10, 4, 12, tzinfo=timezone.utc)
+
+    report = wait_report("wait", "no account has room", reset_at)
+
+    assert report == WorkerReport(
+        account="wait",
+        reason="no account has room",
+        exit_code=WAIT_EXIT_CODE,
+        duration_seconds=0.0,
+        payload=None,
+        is_error=False,
+        wait_reset_at=reset_at,
+    )
+
+
+def test_should_build_report_from_json_result_and_round_duration() -> None:
+    report = make_report(
+        "extra_2",
+        "served",
+        exit_code=0,
+        duration_seconds=1.23456,
+        stdout_text='{"result":"ready","is_error":false}',
+    )
+
+    assert report.payload == "ready"
+    assert report.is_error is False
+    assert report.duration_seconds == 1.235
+    assert report.wait_reset_at is None
+
+
+def test_should_mark_report_as_error_when_json_flags_error() -> None:
+    report = make_report(
+        "extra_2",
+        "served",
+        exit_code=0,
+        duration_seconds=0.0,
+        stdout_text='{"result":"failed","is_error":true}',
+    )
+
+    assert report.payload == "failed"
+    assert report.is_error is True
+
+
+def test_should_mark_report_as_error_when_exit_code_is_nonzero() -> None:
+    report = make_report(
+        "extra_2",
+        "served",
+        exit_code=5,
+        duration_seconds=0.0,
+        stdout_text='{"result":"ready","is_error":false}',
+    )
+
+    assert report.exit_code == 5
+    assert report.is_error is True
+
+
+def test_should_keep_bounded_stdout_tail_when_stdout_is_not_json() -> None:
+    stdout_text = "x" * STDOUT_TAIL_CHARACTER_LIMIT + "tail"
+
+    report = make_report(
+        "extra_2", "served", exit_code=0, duration_seconds=0.0, stdout_text=stdout_text
+    )
+
+    assert report.payload == stdout_text[-STDOUT_TAIL_CHARACTER_LIMIT:]
+    assert len(report.payload) == STDOUT_TAIL_CHARACTER_LIMIT
+    assert report.is_error is True
+
+
+def test_should_drop_payload_when_json_has_no_result_key() -> None:
+    report = make_report(
+        "extra_2",
+        "served",
+        exit_code=0,
+        duration_seconds=0.0,
+        stdout_text='{"other":1}',
+    )
+
+    assert report.payload is None
+    assert report.is_error is True
+
+
+def test_should_build_pre_launch_failure_report_with_zero_duration() -> None:
+    report = pre_launch_failure_report("none", "prompt file is unreadable", 1)
+
+    assert report.account == "none"
+    assert report.reason == "prompt file is unreadable"
+    assert report.exit_code == 1
+    assert report.duration_seconds == 0.0
+    assert report.is_error is True
+    assert report.wait_reset_at is None
+
+
+def test_should_write_report_as_json_and_create_parent_directory(
+    tmp_path: Path,
+) -> None:
+    reset_at = datetime(2026, 10, 4, 12, tzinfo=timezone.utc)
+    report_file = tmp_path / "nested" / "report.json"
+
+    write_report(report_file, wait_report("wait", "no account has room", reset_at))
+
+    report_text = report_file.read_text(encoding="utf-8")
+    assert report_text.endswith("\n")
+    assert json.loads(report_text) == {
+        "account": "wait",
+        "reason": "no account has room",
+        "exit_code": WAIT_EXIT_CODE,
+        "duration_seconds": 0.0,
+        "result": None,
+        "is_error": False,
+        "wait_reset_at": reset_at.isoformat(),
+    }
+
+
+def test_should_finalize_report_by_writing_it_printing_summary_and_returning_exit_code(
+    tmp_path: Path, capsys: pytest.CaptureFixture[str]
+) -> None:
+    report_file = tmp_path / "report.json"
+    report = make_report(
+        "extra_2",
+        "served",
+        exit_code=4,
+        duration_seconds=2.0,
+        stdout_text='{"result":"done","is_error":false}',
+    )
+
+    exit_code = finalize_report(report_file, report)
+
+    assert exit_code == 4
+    written_report = json.loads(report_file.read_text(encoding="utf-8"))
+    assert written_report["result"] == "done"
+    assert written_report["wait_reset_at"] is None
+    assert (
+        capsys.readouterr().out == f"account=extra_2 exit_code=4 report={report_file}\n"
+    )

package/scripts/tests/test_code_rules_index.py

@@ -27,7 +27,8 @@ _TEXT_SUFFIXES = frozenset({".md", ".py", ".js", ".mjs", ".ts", ".json", ".xml"}
 _MARKDOWN_LINK = re.compile(r"(?<!!)\[[^]]+\]\(([^)\s]+)(?:\s+[^)]*)?\)")
 _INDEX_ANCHOR = re.compile(r"CODE_RULES\.md#([^\s)\]<>\"`]+)", re.IGNORECASE)
 _NUMBERED_CITATION = re.compile(
-    r"(?:CODE_RULES\s*\u00a7\s*|\bsection\s+)(\d+(?:\.\d+)?)", re.IGNORECASE
+    r"CODE_RULES(?:\.md)?[`'\"]*\s*(?:\u00a7\s*|section\s+)(\d+(?:\.\d+)?)",
+    re.IGNORECASE,
 )
 
 
@@ -129,6 +130,27 @@ def test_should_report_dead_code_rules_anchor() -> None:
         _assert_citations_resolve(index_text, [dead_citation])
 
 
+def test_should_ignore_section_number_of_another_document() -> None:
+    index_text = _INDEX_PATH.read_text(encoding="utf-8")
+    foreign_citation = (_INDEX_PATH, "See the runbook section 12 appendix row.")
+    _assert_citations_resolve(index_text, [foreign_citation])
+
+
+@pytest.mark.parametrize(
+    "citation_text",
+    [
+        "CODE_RULES.md" + " section 12",
+        "``docs/CODE_RULES.md``" + " section 12",
+        "CODE_RULES" + " \u00a712",
+        "CODE_RULES.md" + " \u00a712",
+    ],
+)
+def test_should_report_dead_code_rules_section(citation_text: str) -> None:
+    index_text = _INDEX_PATH.read_text(encoding="utf-8")
+    with pytest.raises(AssertionError, match="dead CODE_RULES" + " section 12"):
+        _assert_citations_resolve(index_text, [(_INDEX_PATH, citation_text)])
+
+
 def _assert_destination_resolves(markdown_path: Path, destination: str) -> None:
     if "://" in destination or destination.startswith("#"):
         return