claude-dev-env 8.46.2 → 8.46.4

package/hooks/routing/test_subagent_model_pin_hook.py

@@ -61,7 +61,6 @@ def test_should_keep_every_constant_free_of_a_sonnet_model_id() -> None:
         each_file.name
         for each_file in CONSTANTS_DIRECTORY.glob("*.py")
         if not each_file.name.startswith("test_")
-        and each_file.name != "subagent_model_pin_hook_constants.py"
         and "claude-sonnet" in each_file.read_text(encoding="utf-8")
     ]
     assert all_offending_files == []

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "claude-dev-env",
-    "version": "8.46.2",
+    "version": "8.46.4",
     "description": "Claude Code development standards — rules, hooks, agents, commands, and skills",
     "type": "module",
     "bin": {

package/rules/flag-non-breaking-findings.md

@@ -11,7 +11,7 @@ paths:
 
 # Flag non-breaking findings
 
-**When:** When writing a local gate or changing a check's severity.
+**When:** Writing a local gate or changing a check's severity.
 
 Give every check ID a breaking or smell severity row; style and structure findings are smells. Fail the gate and stop for a bug, secret, broken test, syntax error, or instruction file that cannot load. Record a smell in `.claude/followups/smells.jsonl`, proceed, and fix it in a later pull request; ledger failure leaves the gate decision unchanged. Treat an unclassified check as breaking.
 

package/rules/retired-hook-prose.md

@@ -5,7 +5,7 @@ paths:
 
 # Rules prose names only hooks that run
 
-**When:** When describing a hook or retiring a gate.
+**When:** Describing a hook or retiring a gate.
 
 Verify the module and its hook registration or dispatcher roster before claiming it runs; describe a retired hook in past tense or name the check that carries its work now. When retiring a gate, remove the forced agent calls, tokens, extra steps, thresholds, audit rubrics, and review prompts it required across every instruction lane. Add a retired hook path to the installer roster when deleting its module.
 

package/scripts/tests/test_rule_index_shape.py

@@ -18,11 +18,15 @@ from codex_compat_materializer import (
 )
 
 FRONTMATTER_DELIMITER = "---"
+FENCE_MARKER = "```"
 FULL_TEXT_LINK_PATTERN = re.compile(
     r"^\*\*Full text:\*\*.*?\]\((\.\./docs/rule-guides/[^)#\s]+\.md)\)", re.MULTILINE
 )
 TITLE_PATTERN = re.compile(r"^# \S", re.MULTILINE)
 WHEN_LINE_PATTERN = re.compile(r"^\*\*When(?: this applies)?:\*\* \S", re.MULTILINE)
+DOUBLED_WHEN_LEAD_IN_PATTERN = re.compile(
+    r"^\*\*When(?: this applies)?:\*\* When\b", re.MULTILINE
+)
 
 MAXIMUM_ENTRY_BYTES = 1_500
 MAXIMUM_ALWAYS_ON_BYTES = 12_000
@@ -90,16 +94,74 @@ def test_each_entry_opens_with_a_title_after_its_frontmatter() -> None:
     assert untitled == []
 
 
+def _entry_body_before_full_text(entry_text: str) -> str:
+    _, entry_body = _split_frontmatter(entry_text)
+    all_kept_lines: list[str] = []
+    is_inside_fence = False
+    for each_line in entry_body.splitlines():
+        if FULL_TEXT_LINK_PATTERN.match(each_line):
+            break
+        if each_line.lstrip().startswith(FENCE_MARKER):
+            is_inside_fence = not is_inside_fence
+            continue
+        if not is_inside_fence:
+            all_kept_lines.append(each_line)
+    return "\n".join(all_kept_lines)
+
+
+def _states_when_it_applies(entry_text: str) -> bool:
+    return bool(WHEN_LINE_PATTERN.search(_entry_body_before_full_text(entry_text)))
+
+
 def test_each_entry_states_when_it_applies() -> None:
     without_when_line = [
         each_path.name
         for each_path in _entry_paths()
         if each_path.name not in INDEX_SHAPE_EXEMPT_ENTRY_NAMES
-        and not WHEN_LINE_PATTERN.search(_entry_text(each_path))
+        and not _states_when_it_applies(_entry_text(each_path))
     ]
     assert without_when_line == []
 
 
+def test_when_line_inside_a_fenced_block_does_not_count() -> None:
+    entry_text = (
+        "# Example rule\n\n"
+        "```markdown\n**When:** Writing an example.\n```\n\n"
+        "**Full text:** [`docs/rule-guides/example.md`]"
+        "(../docs/rule-guides/example.md).\n"
+    )
+    assert not _states_when_it_applies(entry_text)
+
+
+def test_when_line_below_the_full_text_link_does_not_count() -> None:
+    entry_text = (
+        "# Example rule\n\n"
+        "**Full text:** [`docs/rule-guides/example.md`]"
+        "(../docs/rule-guides/example.md).\n\n"
+        "**When:** Writing an example.\n"
+    )
+    assert not _states_when_it_applies(entry_text)
+
+
+def test_when_line_in_the_entry_body_counts() -> None:
+    entry_text = (
+        "---\npaths:\n  - \"**/*.py\"\n---\n\n# Example rule\n\n"
+        "**When:** Writing an example.\n\n"
+        "**Full text:** [`docs/rule-guides/example.md`]"
+        "(../docs/rule-guides/example.md).\n"
+    )
+    assert _states_when_it_applies(entry_text)
+
+
+def test_no_entry_repeats_when_after_its_when_label() -> None:
+    doubled_lead_in = [
+        each_path.name
+        for each_path in _entry_paths()
+        if DOUBLED_WHEN_LEAD_IN_PATTERN.search(_entry_text(each_path))
+    ]
+    assert doubled_lead_in == []
+
+
 def _full_text_link_problems(entry_path: Path) -> list[str]:
     all_guide_names = _linked_guide_names(_entry_text(entry_path))
     if not all_guide_names: